Fix codeclimate remarks

This commit is contained in:
Marcus Holl
2018-11-05 12:59:40 +01:00
parent 66332b67af
commit bb0953dab9
4 changed files with 5 additions and 5 deletions
+1 -1
View File
@@ -8,7 +8,7 @@ Executes a maven command inside a Docker container.
| parameter | mandatory | default | example values |
| -------------------------------|-----------|-------------------|----------------------------|
| `script` | yes | | |
| `script` | yes | | |
| `dockerImage` | no | 'maven:3.5-jdk-7' | |
| `globalSettingsFile` | no | | 'local_folder/settings.xml'|
| `projectSettingsFile` | no | | |
+1 -1
View File
@@ -15,7 +15,7 @@ static checkScript(def step, Map params) {
step.currentBuild.setResult('UNSTABLE')
step.echo "[WARNING][${step.STEP_NAME}] No reference to surrounding script provided with key 'script', e.g. 'script: this'. " +
"Build status has been set to 'UNSTABLE'. In future versions of piper-lib the build will fail."
"Build status has been set to 'UNSTABLE'. In future versions of piper-lib the build will fail."
}
return script
+1 -1
View File
@@ -57,7 +57,7 @@ void call(parameters = [:]) {
configuration = configHelper.use()
new Utils().pushToSWA([step: STEP_NAME,
stepParam1: parameters?.script == null], configuration)
stepParam1: parameters?.script == null], configuration)
def transportRequestId = configuration.transportRequestId
+2 -2
View File
@@ -60,8 +60,8 @@ void call(parameters = [:]) {
.withMandatoryProperty('filePath')
new Utils().pushToSWA([step: STEP_NAME,
stepParam1: configuration.changeManagement.type,
stepParam2: parameters?.script == null], configuration)
stepParam1: configuration.changeManagement.type,
stepParam2: parameters?.script == null], configuration)
def changeDocumentId = null