You've already forked sap-jenkins-library
							
							
				mirror of
				https://github.com/SAP/jenkins-library.git
				synced 2025-10-30 23:57:50 +02:00 
			
		
		
		
	(fix) nil pointer dereference in case credentials are not available (#3564)
* adds return in gcs upload in case error occurs e.g. no credentials, avoid nil pointer dereference * Adds generated files * Updates generated files Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
This commit is contained in:
		| @@ -201,6 +201,7 @@ func (p *checkmarxExecuteScanReports) persist(stepConfig checkmarxExecuteScanOpt | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -121,6 +121,7 @@ func (p *detectExecuteScanReports) persist(stepConfig detectExecuteScanOptions, | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -171,6 +171,7 @@ func (p *fortifyExecuteScanReports) persist(stepConfig fortifyExecuteScanOptions | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -81,6 +81,7 @@ func (p *gaugeExecuteTestsReports) persist(stepConfig gaugeExecuteTestsOptions, | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -95,6 +95,7 @@ func (p *golangBuildReports) persist(stepConfig golangBuildOptions, gcpJsonKeyFi | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -49,6 +49,7 @@ func (p *karmaExecuteTestsReports) persist(stepConfig karmaExecuteTestsOptions, | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -54,6 +54,7 @@ func (p *malwareExecuteScanReports) persist(stepConfig malwareExecuteScanOptions | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -89,6 +89,7 @@ func (p *mavenBuildReports) persist(stepConfig mavenBuildOptions, gcpJsonKeyFile | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -51,6 +51,7 @@ func (p *mavenExecuteIntegrationReports) persist(stepConfig mavenExecuteIntegrat | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -98,6 +98,7 @@ func (p *mtaBuildReports) persist(stepConfig mtaBuildOptions, gcpJsonKeyFilePath | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -85,6 +85,7 @@ func (p *newmanExecuteReports) persist(stepConfig newmanExecuteOptions, gcpJsonK | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -87,6 +87,7 @@ func (p *npmExecuteScriptsReports) persist(stepConfig npmExecuteScriptsOptions, | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -117,6 +117,7 @@ func (p *protecodeExecuteScanReports) persist(stepConfig protecodeExecuteScanOpt | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -70,6 +70,7 @@ func (p *sonarExecuteScanReports) persist(stepConfig sonarExecuteScanOptions, gc | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -47,6 +47,7 @@ func (p *uiVeri5ExecuteTestsReports) persist(stepConfig uiVeri5ExecuteTestsOptio | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -166,6 +166,7 @@ func (p *whitesourceExecuteScanReports) persist(stepConfig whitesourceExecuteSca | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
| 		return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -230,6 +230,7 @@ func (p *{{ .StepName }}{{ .Name | title}}) persist(stepConfig {{ .StepName }}Op | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
|         	return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -136,6 +136,7 @@ func (p *testStepReports) persist(stepConfig testStepOptions, gcpJsonKeyFilePath | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
|         	return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -49,6 +49,7 @@ func (p *testStepReports) persist(stepConfig testStepOptions, gcpJsonKeyFilePath | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
|         	return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
| @@ -48,6 +48,7 @@ func (p *testStepReports) persist(stepConfig testStepOptions, gcpJsonKeyFilePath | ||||
| 	gcsClient, err := gcs.NewClient(gcs.WithEnvVars(envVars)) | ||||
| 	if err != nil { | ||||
| 		log.Entry().Errorf("creation of GCS client failed: %v", err) | ||||
|         	return | ||||
| 	} | ||||
| 	defer gcsClient.Close() | ||||
| 	structVal := reflect.ValueOf(&stepConfig).Elem() | ||||
|   | ||||
		Reference in New Issue
	
	Block a user