Commit Graph
670 Commits
Author SHA1 Message Date
Florian WilhelmandGitHub 0a86c8534d Improve check for batch mode in mavenExecute (#226)
The old naive check fails if an argument starts with '-B'. Now we use a
regular expression, which should correctly match if batch mode was
already supplied, and add it if not.
2018-07-26 16:03:05 +02:00
rodibrinandGitHub 770657d963 Merge pull request #229 from rodibrin/pr/neoimage
Remove tool descriptor from neo deploy and config the neo docker image
2018-07-26 10:10:33 +02:00
rodibrinandGitHub 9e547cd605 Merge branch 'master' into pr/neoimage 2018-07-26 10:04:20 +02:00
Roland Stengel b7e355bca8 config neo docker image 2018-07-25 15:23:56 +02:00
Roland Stengel c3c7d8b142 remove the tool descriptor from neo deploy 2018-07-25 15:23:56 +02:00
Marcus HollandGitHub 5b8dd91510 Merge pull request #219 from marcusholl/pr/nestedConfig
nested config for changeManagment related steps
2018-07-25 12:32:26 +02:00
Marcus Holl f16d5c766b Merge remote-tracking branch 'github/master' into HEAD 2018-07-25 12:26:20 +02:00
Marcus HollandGitHub 00a2e088af Merge pull request #216 from marcusholl/pr/readNestedProperties
read nested properties
2018-07-25 09:53:32 +02:00
Christopher FennerandGitHub aa57127e84 Merge branch 'master' into pr/readNestedProperties 2018-07-25 09:49:33 +02:00
Marcus Holl 411fd7fe62 Access to nested properties
yaml configuration supports nested properties. With this change
we can read those nested properties.
2018-07-25 09:47:16 +02:00
Marcus HollandGitHub 339226f304 Merge pull request #223 from marcusholl/pr/fixDoNotFailInCaseCommitHistoryDoesNotContainChangeDocumentId
Do not fail immediatly in case commit history does not contain a chan…
2018-07-23 09:46:53 +02:00
Marcus Holl 2a851abdfd Merge remote-tracking branch 'github/master' into HEAD 2018-07-23 09:41:02 +02:00
Marcus HollandGitHub 8563df62dd Merge pull request #222 from marcusholl/pr/fixRemoveEarlyCheckForChangeDocumentId
[fix] Remove early check for mandatory param 'changeDocumentId'
2018-07-20 09:25:38 +02:00
Marcus Holl 43a9dcbcfd Do not fail immediatly in case commit history does not contain a changeDocumentId
we emit a log message and fail later at withManadotoryProperty check.
2018-07-19 10:26:34 +02:00
Marcus Holl 1e0fa0799e [fix] Remove early check for mandatory param 'changeDocumentId'
otherwise we will never try to read the change document id from commit history.
2018-07-19 10:09:24 +02:00
Marcus HollandGitHub d2a16f2ded Merge pull request #211 from marcusholl/pr/IntroduceCredentialsRule
Introduce CredentialsRule
2018-07-19 09:22:05 +02:00
Marcus Holl 46f6587a97 Merge remote-tracking branch 'github/master' into HEAD 2018-07-19 09:17:07 +02:00
Marcus HollandGitHub 101ca2dba0 Merge pull request #205 from marcusholl/pr/transportRequestUploadFileTransportRequestIdFromCommitHistory
Pr/transport request upload file transport request id from commit history
2018-07-19 09:13:02 +02:00
Marcus Holl 3effe404b0 Merge remote-tracking branch 'github/master' into HEAD 2018-07-19 08:54:57 +02:00
Marcus HollandGitHub 5609283a10 Merge pull request #212 from marcusholl/pr/decoupleTests
decouple tests
2018-07-18 12:56:43 +02:00
Marcus Holl 0678019efb Merge remote-tracking branch 'github/master' into HEAD 2018-07-18 12:49:41 +02:00
Marcus HollandGitHub 3bd07e40f7 Merge pull request #206 from marcusholl/pr/transportRequestReleaseTransportRequestIdFromCommitHistory
Pr/transport request release transport request id from commit history
2018-07-18 12:47:54 +02:00
Marcus Holl ab0a0c6882 Introduce CredentialsRule
Instead of configuring the credentials setup

  o withCredentials
  o usename

in each of our tests (for the moment change-management related)
we collect the common coding in a JUnitRule.
2018-07-18 12:45:30 +02:00
Marcus Holl f2bf406dee Merge remote-tracking branch 'github/master' into HEAD 2018-07-18 12:42:54 +02:00
Marcus HollandGitHub 3f877c237c Merge pull request #198 from marcusholl/transportRequestReleaseChangeDocumentIdFromCommitHistory
transportRequestRelease: get changeDocumentId from commit history
2018-07-18 12:31:37 +02:00
Marcus Holl 9d9c17d937 Merge remote-tracking branch 'github/master' into HEAD 2018-07-18 12:23:34 +02:00
Marcus HollandGitHub b36ece463e Merge pull request #217 from marcusholl/pr/fixExceptionMessage
[fix] Excpetion message contains config key instead of value.
2018-07-18 11:51:13 +02:00
Marcus Holl 3e3af733f2 Merge remote-tracking branch 'github/master' into pr/fixExceptionMessage 2018-07-18 11:45:48 +02:00
rodibrinandGitHub 675c14810d Merge pull request #220 from rodibrin/pr/neodropversioncheck
Remove the NEO version check
2018-07-18 09:52:00 +02:00
Roland Stengel 4851ba94bf drop NEO version verification - remove neo version check 2018-07-18 09:46:11 +02:00
Roland Stengel b7a2a84e2d drop NEO version verification - decouple verifyversion from getversion 2018-07-18 09:46:11 +02:00
Roland Stengel 38360f1d0c drop NEO version verification - introduce getVersion 2018-07-17 20:56:31 +02:00
Marcus Holl 9b4d55d0d9 switch to nested configuration for change management related steps 2018-07-17 16:41:42 +02:00
Marcus Holl 1e23a9ba3e Merge remote-tracking branch 'mholl/pr/readNestedProperties' into HEAD 2018-07-17 11:22:23 +02:00
Marcus Holl 4b2ee0d4ad [fix] Excpetion message contains config key instead of value. 2018-07-17 10:08:47 +02:00
Marcus HollandGitHub 1c4595769d Merge pull request #209 from marcusholl/pr/refactorGetMandatoryProperty
[refactor] re-use getConfigPropery inside getMandatoryProperty
2018-07-17 08:56:09 +02:00
Marcus Holl 4f8f7be6aa Access to nested properties
yaml configuration supports nested properties. With this change
we can read those nested properties.
2018-07-16 17:26:22 +02:00
Marcus Holl 83e757475a Merge remote-tracking branch 'github/master' into HEAD 2018-07-16 12:09:49 +02:00
Marcus Holl b72cb656d5 Merge remote-tracking branch 'github/master' into HEAD 2018-07-16 11:15:22 +02:00
Marcus Holl 7482b58dc2 UploadFileToTransport: Read transportRequestId from commit history 2018-07-16 10:28:59 +02:00
Marcus Holl bc13d1d969 Introduce getTransportRequestId in ChangeManagement utils 2018-07-16 10:15:27 +02:00
Marcus Holl bb0e9b92ce transport request upload file: decouple tests. 2018-07-13 16:09:51 +02:00
Marcus Holl 0337b34cef [whitespace only] increase readability 2018-07-13 14:40:54 +02:00
Marcus Holl 254a4e2017 Remove unused sh registerAllowedMethod
registerAllowedMethod for sh call not used anymore since we mock the ChangeManagement utils class.
The sh calls was triggered from the utils class. Since we mock that class, there is no sh call
anymore.
2018-07-13 13:23:10 +02:00
Marcus Holl 64291cd88f [refactor] re-use getConfigPropery inside getMandatoryProperty
... instead of accessing the config map directy.

With that we ensure that getMandatoryProperty behaves the same like
getConfigProperty. Currently we differ e.g. with trim().
2018-07-13 11:28:55 +02:00
Marcus HollandGitHub a49c17c869 Merge pull request #202 from marcusholl/pr/mandatoryPropertyCheck
Validate required parameters via config helper
2018-07-13 11:03:30 +02:00
Marcus Holl 63b0fd6f67 Merge remote-tracking branch 'github/master' into HEAD 2018-07-13 10:30:29 +02:00
Marcus HollandGitHub 1bb3cb4d1f Merge pull request #203 from marcusholl/pr/condenceParameters
Do not repeat the same parameter names for different configuration la…
2018-07-13 09:04:40 +02:00
Marcus Holl b53e1ea539 Merge remote-tracking branch 'github/master' into HEAD 2018-07-13 08:55:15 +02:00
Christopher FennerandGitHub 819f84f773 Merge pull request #207 from SAP/CCFenner-patch-2
newmanExecute: create collectionDisplayName inside of the step
2018-07-13 08:24:39 +02:00