Commit Graph
20 Commits
Author SHA1 Message Date
Linda Siebert b58bb87114 Set chartPath to general for kubernetesDeploy (#4537) 2023-09-07 11:36:59 +02:00
Linda Siebert 4e0b4824f0 cloudFoundryDeploy- support manifest.yml as true default (#4050)
* Add new default

* Revert "Add new default"

This reverts commit c9c3ae2e80.

* Change config to have default

* Revert "Change config to have default"

This reverts commit e65517457f.

* Add method

* Add space to match

* Add cf native test
2022-10-11 14:12:35 +02:00
Linda Siebert 3ba7a8dfa4 Adapt npmExecuteEndToEndTests (#4008)
* Adapt step

* Adapt comment
2022-09-16 17:30:19 +02:00
acbcc5646b [ANS] Change helper and re-generate steps (#3675)
* Add ans implementation

* Remove todo comment

* Rename test function

Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com>

* Better wording

Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com>

* Add reading of response body function

* Use http pkg ReadResponseBody

* Check read error

* Better test case description

* Fix formatting

* Create own package for read response body

* Omit empty nested resource struct

* Separate Resource struct from Event struct

* Merge and unmarshall instead of only unmarshalling

* Improve status code error message

* Remove unchangeable event fields

* Separate event parts

* Change log level setter function

* Restructure ans send test

* Revert exporting readResponseBody function

Instead the code is duplicated in the xsuaa and ans package

* Add check correct ans setup request

* Add set options function for mocking

* Review fixes

* Correct function name

* Use strict unmarshalling

* Validate event

* Move functions

* Add documentation comments

* improve test

* Validate event

* Add logrus hook for ans

* Set defaults on new hook creation

* Fix log level on error

* Don't alter entry log level

* Set severity fatal on 'fatal error' log message

* Ensure that log entries don't affect each other

* Remove unnecessary correlationID

* Use file path instead of event template string

* Improve warning messages

* Add empty log message check

* Allow configuration from file and string

* Add sourceEventId to tags

* Change resourceType to Pipeline

* Use structured config approach

* Use new log level set function

* Check correct setup and return error

* Mock http requests

* Only send log level warning or higher

* Use new function name

* One-liner ifs

* Improve test name

* Fix tests

* Prevent double firing

* Reduce Fire test size

* Add error message to test

* Reduce newANSHook test size

* Further check error

* Rename to defaultEvent in hook struct

* Reduce ifs further

* Fix set error category test

The ansHook Fire test cannot run in parallel, as it would affect the
other tests that use the error category.

* Change function name to SetServiceKey

* Validate event

* Rename to eventTemplate in hook struct

* Move copy to event.go

* Fix function mix

* Remove unnecessary cleanup

* Remove parallel test

The translation fails now and again when parallel is on.

* Remove prefix test

* Remove unused copyEvent function

* Fix ifs

* Add docu comment

* Register ans hook from pkg

* register hook and setup event template seperately

* Exclusively read eventTemplate from environment

* setupEventTemplate tests

* adjust hook levels test

* sync tests- wlill still fail

* migrate TestANSHook_registerANSHook test

* fixes

* Introduce necessary parameters

* Setup hook test

* Use file instead

* Adapt helper for ans

* Generate go files

* Add ans config to general config

* Change generator

* Regenerate steps

* Allow hook config from user config

Merges with hook config from defaults

* Remove ans flags from root command

* Get environment variables

* Generate files

* Add test when calling merge twice

* Update generator

* Regenerate steps

* Check two location for ans service key env var

* Re-generate

* Fix if

* Generate files with fix

* Duplicate config struct

* Add type casting test for ans config

* Fix helper

* Fix format

* Fix type casting of config

* Revert "Allow hook config from user config"

This reverts commit 4864499a4c497998c9ffc3e157ef491be955e68e.

* Revert "Add test when calling merge twice"

This reverts commit b82320fd07b82f5a597c5071049d918bcf62de00.

* Add ans config tests

* Improve helper code

* Re-generate commands

* Fix helper unit tests

* Change to only one argument

* Fix helper tests

* Re-generate

* Revert piper and config changes

* Re-generate missing step

* Generate new steps

* [ANS] Add servicekey credential to environment (#3684)

* Add ANS credential

* Switch to hooks and remove comments

* Add subsection for ans

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>

* Remove changes to piper.go

* Remove formatting

* Add test for ANS

* Define hook credential seperately from step credential

* Add test for retrieval from general section

* Add comment

* Get ans hook info from DefaultValueCache

* [ANS] Add documentation (#3704)

* Add ANS credential

* Switch to hooks and remove comments

* Add subsection for ans

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>

* Remove changes to piper.go

* Remove formatting

* Add test for ANS

* Define hook credential seperately from step credential

* Add test for retrieval from general section

* Add comment

* Add documentation

* Review changes

* Review comments

* Improve documentation further

* Add note of two event templates

* Add log level destinction

* Further improvements

* Improve text

* Remove unused things

* Add ANS credential

* Switch to hooks and remove comments

* Add subsection for ans

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>

* Remove changes to piper.go

* Remove formatting

* Add test for ANS

* Define hook credential seperately from step credential

* Add test for retrieval from general section

* Add comment

* Get ans hook info from DefaultValueCache

* Improvements

Co-authored-by: Linda Siebert <linda.siebert@sap.com>
Co-authored-by: Linda Siebert <39100394+LindaSieb@users.noreply.github.com>

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>

* New lines

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
Co-authored-by: Roland Stengel <r.stengel@sap.com>
Co-authored-by: Thorsten Duda <thorsten.duda@sap.com>
2022-06-22 13:31:17 +02:00
Linda SiebertandJesse Awan 8eb0c6aa48 Adjust sonarExecuteScan step (#3527)
* add check for instance parameter

* remove default from yaml

* adapt changes

* Update stashSettings.yml

* Unstash

* Add echo

* Stash changes

* Remove changes

* stash everything

* Change it up

* Change go

* Switch to new solution

* Try new stash

* Remove compliance

* Move Artifacts

* Change stashing

* Match others

* Remove space

* Test if warning goes away

Co-authored-by: Jesse Awan <jesse.awan@sap.com>
2022-02-25 13:09:50 +01:00
Linda SiebertandThorsten Duda 480d1c260f Add testing for helm during acceptance stage (#3402)
* Add kubernetesDeploy to Acceptance

* Add more kubernetesDeploy

* Add helm tests

* Change documentation

* Fix docu

* Change generated

* Add tests

* Add groovy tests

* Fix tests

* Change tests

Co-authored-by: Thorsten Duda <thorsten.duda@sap.com>
2022-01-25 10:42:42 +01:00
Linda SiebertandOliver Feldmann 6b827b0dfb kubernetesDeploy- add documentation for <image-name> (#3246)
* Add documentation for image writing

* Generate

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2021-11-04 10:42:46 +01:00
Linda SiebertandOliver Feldmann 8ca9f6115b [kubernetesDeploy] add support for containerImageName and containerImageTag (#3153)
* Add params to kubeDeploy

* Add tests for using new params

* Fix formatting

* Add failure tests

* Change test title

* Fix formatting

* Fix error message

* Change error messages

* Reorder if/else

* Change helm and helm3 tests

* Reword docs

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>

* Fix test and image swap

* Generate code

* Remove unused code

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2021-10-08 14:58:32 +02:00
Linda Siebert d321b446b5 Add additional files to deployDescriptor stash (#3152)
* Add subdirectories for yaml
2021-10-06 11:20:41 +02:00
Linda Siebert 54f55f7388 Add kubernetesDeploy to Release (#3126)
* Add kubernetesDeploy to Release

* Add dockerConfigJSON to STEPS

* Generate go

* Fix removed code

* Generated

* Add debugging

* Change for debugging

* Try this

* Debugging

* Try reading file

* Fix log

* See files

* Add debugging

* Remove debugging here

* Remove debug

* Remove some debugging

* Apply suggestions from code review

* Add tests

* Format
2021-09-29 15:01:40 +02:00
Linda SiebertandOliver Feldmann ca2a753e9c Pass in custom stash settings to Init (#3119)
* Add customStashSettings parameter

* Add test for customStashSettings

* Remove file

* Fix tests

* Remove unnecessary rule

* Remove assert

* Apply suggestions from code review

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>

* Update vars/piperPipelineStageInit.groovy

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2021-09-27 13:36:55 +02:00
Linda SiebertandOliver Feldmann fa95bcc8a9 Match documentation of buildExecute (#3095)
* Match documentation

* Move comment

* Don't pass containerImageNameAndTag

* Change kaniko tests

* Move code in

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2021-09-10 16:25:44 +02:00
Linda Siebert b93bcba2d1 Revert "Don't configure secret with config file" (#3093)
This reverts commit 151ec040f9.
2021-09-10 16:10:32 +02:00
Linda Siebert 10d0fbe6fe Update uiVeri5ExecuteTests.md (#3045)
Add an additional example and fix credential access.
2021-08-19 14:21:46 +02:00
Linda Siebert f9e052e4d1 Refactor all instances of iFlow to be integrationFlow (#2992) 2021-08-04 16:42:25 +02:00
Linda Siebert 7a8f4f06eb Remove platform from triggerIntegration step (#2957) 2021-06-30 17:00:49 +02:00
Linda Siebert b68f549923 CPI- Remove platform parameter (#2956)
* Remove platform from yaml and generated

* Remove from tests and md
2021-06-30 14:32:30 +02:00
Linda Siebert 49f4fcf43b CPI- Change resourceRef of apiServiceKey (#2950)
* Change name and param in yaml

Change name and param in resourceRef of apiServiceKey param

* Generate go code
2021-06-28 16:57:37 +02:00
Linda Siebert 6426a2f792 CPI- Refactor Credential ID (#2946)
* Change credential name in yaml

Change cpiAPIServiceKeyCredentialId to cpiApiServiceKeyCredentialsId in cpi yaml files

* Refactor groovy files

Change cpiAPIServiceKeyCredentialId to cpiApiServiceKeyCredentialsId in cpi groovy files

* Change credential name in md

Change cpiAPIServiceKeyCredentialId to cpiApiServiceKeyCredentialsId in cpi md files
2021-06-28 14:54:03 +02:00
78a29d782b CPI - Introduce service key (#2901)
* Switch to service key for CPI GetMplStatus

Introduces read method for service key files, mock utils and tests.

* Use secret text instead of file

* Change serviceKey definition

* Update cpiUpload to use Service Key

retrieved the host and uaa information from service key

* Update cpiDeploy to use service key

retrieved the host and uaa information from service key

* Update cpiServiceEndpoint to use Service Key

retrieved the host and uaa information from service key

* Update cpiDownload to use Service Key

retrieved the host and uaa information from service key

* Update cpiUpdateConfig to use Service Key

retrieved the host and uaa information from service key

* Refactor serviceKey var name

* Fixed references to service key to follow the real format

they should be accessed through oauth instead of uaa because of the format of the json

* Rename ServiceKey to APIServiceKey

To support having a different service key(and for readability), we need to change the name to API.

* Add STAGES and STEPS yaml

add in to each yaml file of cpi integration

* Revert "Add STAGES and STEPS yaml"

This reverts commit aa2665d158.

* Change comments/formatting commonUtils

Make comments more understandable and follow code climate suggestions

* Change documentation files for steps

remove OAuth and host and change credentials to be servicekey

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
Co-authored-by: Thorsten Duda <thorsten.duda@sap.com>
2021-06-28 10:50:33 +02:00