Marcus Holl
2a851abdfd
Merge remote-tracking branch 'github/master' into HEAD
2018-07-23 09:41:02 +02:00
Marcus Holl
43a9dcbcfd
Do not fail immediatly in case commit history does not contain a changeDocumentId
...
we emit a log message and fail later at withManadotoryProperty check.
2018-07-19 10:26:34 +02:00
Marcus Holl
1e0fa0799e
[fix] Remove early check for mandatory param 'changeDocumentId'
...
otherwise we will never try to read the change document id from commit history.
2018-07-19 10:09:24 +02:00
Marcus Holl
46f6587a97
Merge remote-tracking branch 'github/master' into HEAD
2018-07-19 09:17:07 +02:00
Marcus Holl
3effe404b0
Merge remote-tracking branch 'github/master' into HEAD
2018-07-19 08:54:57 +02:00
Marcus Holl
0678019efb
Merge remote-tracking branch 'github/master' into HEAD
2018-07-18 12:49:41 +02:00
Marcus Holl
ab0a0c6882
Introduce CredentialsRule
...
Instead of configuring the credentials setup
o withCredentials
o usename
in each of our tests (for the moment change-management related)
we collect the common coding in a JUnitRule.
2018-07-18 12:45:30 +02:00
Marcus Holl
f2bf406dee
Merge remote-tracking branch 'github/master' into HEAD
2018-07-18 12:42:54 +02:00
Marcus Holl
9d9c17d937
Merge remote-tracking branch 'github/master' into HEAD
2018-07-18 12:23:34 +02:00
Marcus Holl
3e3af733f2
Merge remote-tracking branch 'github/master' into pr/fixExceptionMessage
2018-07-18 11:45:48 +02:00
Roland Stengel
4851ba94bf
drop NEO version verification - remove neo version check
2018-07-18 09:46:11 +02:00
Roland Stengel
38360f1d0c
drop NEO version verification - introduce getVersion
2018-07-17 20:56:31 +02:00
Marcus Holl
4b2ee0d4ad
[fix] Excpetion message contains config key instead of value.
2018-07-17 10:08:47 +02:00
Marcus Holl
83e757475a
Merge remote-tracking branch 'github/master' into HEAD
2018-07-16 12:09:49 +02:00
Marcus Holl
b72cb656d5
Merge remote-tracking branch 'github/master' into HEAD
2018-07-16 11:15:22 +02:00
Marcus Holl
7482b58dc2
UploadFileToTransport: Read transportRequestId from commit history
2018-07-16 10:28:59 +02:00
Marcus Holl
bb0e9b92ce
transport request upload file: decouple tests.
2018-07-13 16:09:51 +02:00
Marcus Holl
0337b34cef
[whitespace only] increase readability
2018-07-13 14:40:54 +02:00
Marcus Holl
254a4e2017
Remove unused sh registerAllowedMethod
...
registerAllowedMethod for sh call not used anymore since we mock the ChangeManagement utils class.
The sh calls was triggered from the utils class. Since we mock that class, there is no sh call
anymore.
2018-07-13 13:23:10 +02:00
Marcus Holl
63b0fd6f67
Merge remote-tracking branch 'github/master' into HEAD
2018-07-13 10:30:29 +02:00
Marcus Holl
b73df0f682
ReleaseTransportRequest: Read transportRequestId from commit history
2018-07-12 16:00:27 +02:00
Marcus Holl
8d60a81ec5
Read transportId from commit history: split getChangeID method
2018-07-12 14:17:33 +02:00
Marcus Holl
c9572d187b
Merge remote-tracking branch 'github/master' into HEAD
2018-07-12 13:23:00 +02:00
Marcus Holl
52052cc99d
Merge pull request #196 from marcusholl/transportRequestCreateChangeDocumentIdFromCommitHistory
...
transportRequestCreate: retrieve changeDocumentId from commit history
2018-07-12 13:14:34 +02:00
Marcus Holl
3cb8912456
Merge pull request #180 from marcusholl/pr/supportCmClientOptsUploadFileToTransport
...
Support CM clientOpts for uploadFileToTransport
2018-07-12 10:16:07 +02:00
Marcus Holl
52bb1e842d
Validate required parameters via config helper
...
- In case a parameter is missing we do not thrown and AbortException
anmore, but an IllegalArgumentExcpetion, since that exception is
thrown by the configuration helper. The difference is: AbortExceptions
are contained in the log without stacktrace, other exceptions are
printed with stack trace.
- Exception messages are changed to the standard error message triggered
inside the configuration helper. In case the changeDocumentId is
retrieved also from the commit history we keep an exception message
pointing to that.
- Having references to the parameters is droped. Instead the parameters
are directly used from the configuration map.
- in case of long signatures line breaks are inserted in order to
simplify reading the code.
2018-07-12 09:34:06 +02:00
Christopher Fenner
1423522e2f
Merge pull request #201 from marcusholl/pr/fixQuotationMark
...
[fix] misplaced quotation mark in assertion message
2018-07-12 09:21:30 +02:00
rodibrin
4cb5ba5f3f
Merge pull request #194 from rodibrin/pr/newmanexecutetest
...
adapt the NewmanExecuteTest to windows file system
2018-07-12 08:56:28 +02:00
Marcus Holl
c1927da33f
[fix] misplaced quotation mark in assertion message
2018-07-12 08:12:32 +02:00
Marcus Holl
239e8cc054
Merge pull request #199 from marcusholl/pr/supportAssertOfLogMessageInCaseOfFailures
...
Support check for log messages in case of exceptions in code under test
2018-07-11 12:29:21 +02:00
Christopher Fenner
aa865f145f
Merge pull request #172 from SAP/CCFenner/mtaVersioning
...
add versioning for MTAs
2018-07-11 11:53:20 +02:00
Marcus Holl
111802cfd2
Support check for log messages in case of exceptions in code under test
...
With the current approach of checking log entries we are not able to
check log entries in case of a failure. But is is important to assert
log messages in case of a failure. Having reasonable log messages
simplified troubleshooting.
Hence we add JenkinsLoggingRule.expect(substring) and check after the
base of that rule has been called.
This interfears with other rules also working with an expect approach,
like e.g. ExpectedException. Which violation is presented depends on
the order or the rules around the test case.
2018-07-10 17:34:58 +02:00
Marcus Holl
cada0e7882
transportRequestCreate: retrieve changeDocumentId from commit history
2018-07-10 16:41:43 +02:00
Marcus Holl
a7ea15ac58
transportRequestUploadFile: retrieveChangeDocumentId from commit history
2018-07-10 16:40:26 +02:00
Marcus Holl
4a9c0695ca
transportRequestRelease: get changeDocumentId from commit history
2018-07-10 16:34:42 +02:00
Roland Stengel
81c0110740
adapt the NewmanExecuteTest to windows file system
2018-07-10 13:10:16 +02:00
Marcus Holl
5e09e2fb88
No forwarding of config map in to ChangeManagement class.
2018-07-10 12:30:31 +02:00
Marcus Holl
bb2ed27c10
Switch from gitLabel to gitChangeDocumentLabel
...
since we will have two labels in future. One for scanning changeDocumentIds and
another one for scanning transportRequestIds
2018-07-10 11:15:09 +02:00
Marcus Holl
71ca78e0a9
Switch from git_xxx to gitXxx like properties
2018-07-10 11:14:43 +02:00
Marcus Holl
74b6ac0c8e
Support cmclient_opts in transportRequestCreate
2018-07-09 15:41:13 +02:00
Marcus Holl
d8d2249862
Support cmclientOpts for uploadFileToTransport
2018-07-09 09:40:07 +02:00
Marcus Holl
6829319ca5
Remove wrong package declaration and stange grovvy shebang
...
o we are in the default package, hence package 'steps' is inappropriate
o there is also no grovvy shebang in other test files, why should it be here?
2018-07-06 13:37:20 +02:00
Marcus Holl
44cee0475d
Merge pull request #176 from marcusholl/pr/decoupleTests
...
Pr/decouple tests
2018-07-06 13:09:44 +02:00
Marcus Holl
cf09b45025
Merge pull request #161 from marcusholl/marcusholl/pr/landscapeConfigLayer
...
Provide configuration layer for custom configuration
2018-07-06 12:47:52 +02:00
Christopher Fenner
96b2880ea0
Merge pull request #186 from SAP/CCFenner/newmanExecute
...
add step for Newman test execution
2018-07-06 10:27:55 +02:00
Marcus Holl
20612c726f
Add tests asserting log messages
2018-07-04 11:56:53 +02:00
Marcus Holl
99c6012f4a
Merge pull request #177 from marcusholl/pr/customMessageForWithMandatoryParameter
...
withMandatoryParameter supports a error message from the caller
2018-07-04 11:42:52 +02:00
Christopher Fenner
cd891acc97
remove println
2018-07-04 11:13:41 +02:00
Marcus Holl
22b6dd63f6
Merge custom defaults with library defaults.
2018-07-03 17:01:22 +02:00
Marcus Holl
c29fb02dd9
wip
2018-07-03 17:01:22 +02:00