jenkins/sap-jenkins-library
1
0
Fork 0
mirror of https://github.com/SAP/jenkins-library.git synced 2024-12-14 11:03:09 +02:00
Code Issues Releases Activity
656 Commits 353 Branches 458 Tags 1.5 GiB
2a851abdfd
Commit Graph

656 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Marcus Holl
2a851abdfd Merge remote-tracking branch 'github/master' into HEAD 2018-07-23 09:41:02 +02:00
Marcus Holl
8563df62dd
Merge pull request #222 from marcusholl/pr/fixRemoveEarlyCheckForChangeDocumentId 
[fix] Remove early check for mandatory param 'changeDocumentId'
 2018-07-20 09:25:38 +02:00
Marcus Holl
43a9dcbcfd Do not fail immediatly in case commit history does not contain a changeDocumentId 
we emit a log message and fail later at withManadotoryProperty check.
 2018-07-19 10:26:34 +02:00
Marcus Holl
1e0fa0799e [fix] Remove early check for mandatory param 'changeDocumentId' 
otherwise we will never try to read the change document id from commit history.
 2018-07-19 10:09:24 +02:00
Marcus Holl
d2a16f2ded
Merge pull request #211 from marcusholl/pr/IntroduceCredentialsRule 
Introduce CredentialsRule
 2018-07-19 09:22:05 +02:00
Marcus Holl
46f6587a97 Merge remote-tracking branch 'github/master' into HEAD 2018-07-19 09:17:07 +02:00
Marcus Holl
101ca2dba0
Merge pull request #205 from marcusholl/pr/transportRequestUploadFileTransportRequestIdFromCommitHistory 
Pr/transport request upload file transport request id from commit history
 2018-07-19 09:13:02 +02:00
Marcus Holl
3effe404b0 Merge remote-tracking branch 'github/master' into HEAD 2018-07-19 08:54:57 +02:00
Marcus Holl
5609283a10
Merge pull request #212 from marcusholl/pr/decoupleTests 
decouple tests
 2018-07-18 12:56:43 +02:00
Marcus Holl
0678019efb Merge remote-tracking branch 'github/master' into HEAD 2018-07-18 12:49:41 +02:00
Marcus Holl
3bd07e40f7
Merge pull request #206 from marcusholl/pr/transportRequestReleaseTransportRequestIdFromCommitHistory 
Pr/transport request release transport request id from commit history
 2018-07-18 12:47:54 +02:00
Marcus Holl
ab0a0c6882 Introduce CredentialsRule 
Instead of configuring the credentials setup

  o withCredentials
  o usename

in each of our tests (for the moment change-management related)
we collect the common coding in a JUnitRule.
 2018-07-18 12:45:30 +02:00
Marcus Holl
f2bf406dee Merge remote-tracking branch 'github/master' into HEAD 2018-07-18 12:42:54 +02:00
Marcus Holl
3f877c237c
Merge pull request #198 from marcusholl/transportRequestReleaseChangeDocumentIdFromCommitHistory 
transportRequestRelease: get changeDocumentId from commit history
 2018-07-18 12:31:37 +02:00
Marcus Holl
9d9c17d937 Merge remote-tracking branch 'github/master' into HEAD 2018-07-18 12:23:34 +02:00
Marcus Holl
b36ece463e
Merge pull request #217 from marcusholl/pr/fixExceptionMessage 
[fix] Excpetion message contains config key instead of value.
 2018-07-18 11:51:13 +02:00
Marcus Holl
3e3af733f2 Merge remote-tracking branch 'github/master' into pr/fixExceptionMessage 2018-07-18 11:45:48 +02:00
rodibrin
675c14810d
Merge pull request #220 from rodibrin/pr/neodropversioncheck 
Remove the NEO version check
 2018-07-18 09:52:00 +02:00
Roland Stengel
4851ba94bf drop NEO version verification - remove neo version check 2018-07-18 09:46:11 +02:00
Roland Stengel
b7a2a84e2d drop NEO version verification - decouple verifyversion from getversion 2018-07-18 09:46:11 +02:00
Roland Stengel
38360f1d0c drop NEO version verification - introduce getVersion 2018-07-17 20:56:31 +02:00
Marcus Holl
4b2ee0d4ad [fix] Excpetion message contains config key instead of value. 2018-07-17 10:08:47 +02:00
Marcus Holl
1c4595769d
Merge pull request #209 from marcusholl/pr/refactorGetMandatoryProperty 
[refactor] re-use getConfigPropery inside getMandatoryProperty
 2018-07-17 08:56:09 +02:00
Marcus Holl
83e757475a Merge remote-tracking branch 'github/master' into HEAD 2018-07-16 12:09:49 +02:00
Marcus Holl
b72cb656d5 Merge remote-tracking branch 'github/master' into HEAD 2018-07-16 11:15:22 +02:00
Marcus Holl
7482b58dc2 UploadFileToTransport: Read transportRequestId from commit history 2018-07-16 10:28:59 +02:00
Marcus Holl
bc13d1d969 Introduce getTransportRequestId in ChangeManagement utils 2018-07-16 10:15:27 +02:00
Marcus Holl
bb0e9b92ce transport request upload file: decouple tests. 2018-07-13 16:09:51 +02:00
Marcus Holl
0337b34cef [whitespace only] increase readability 2018-07-13 14:40:54 +02:00
Marcus Holl
254a4e2017 Remove unused sh registerAllowedMethod 
registerAllowedMethod for sh call not used anymore since we mock the ChangeManagement utils class.
The sh calls was triggered from the utils class. Since we mock that class, there is no sh call
anymore.
 2018-07-13 13:23:10 +02:00
Marcus Holl
64291cd88f [refactor] re-use getConfigPropery inside getMandatoryProperty 
... instead of accessing the config map directy.

With that we ensure that getMandatoryProperty behaves the same like
getConfigProperty. Currently we differ e.g. with trim().
 2018-07-13 11:28:55 +02:00
Marcus Holl
a49c17c869
Merge pull request #202 from marcusholl/pr/mandatoryPropertyCheck 
Validate required parameters via config helper
 2018-07-13 11:03:30 +02:00
Marcus Holl
63b0fd6f67 Merge remote-tracking branch 'github/master' into HEAD 2018-07-13 10:30:29 +02:00
Marcus Holl
1bb3cb4d1f
Merge pull request #203 from marcusholl/pr/condenceParameters 
Do not repeat the same parameter names for different configuration la…
 2018-07-13 09:04:40 +02:00
Marcus Holl
b53e1ea539 Merge remote-tracking branch 'github/master' into HEAD 2018-07-13 08:55:15 +02:00
Christopher Fenner
819f84f773
Merge pull request #207 from SAP/CCFenner-patch-2 
newmanExecute: create collectionDisplayName inside of the step
 2018-07-13 08:24:39 +02:00
Christopher Fenner
a4b622e563
use collectionDisplayName 2018-07-12 23:34:35 +02:00
Christopher Fenner
153536f5d3
create collectionDisplayName inside of the step 2018-07-12 23:31:15 +02:00
Marcus Holl
3e01caf909 Merge remote-tracking branch 'github/master' into HEAD 2018-07-12 16:26:52 +02:00
Marcus Holl
b73df0f682 ReleaseTransportRequest: Read transportRequestId from commit history 2018-07-12 16:00:27 +02:00
Marcus Holl
1a32ac46d8 Prepare transportRequestRelease for layered tests 2018-07-12 16:00:26 +02:00
Marcus Holl
5c657f2253 Introduce getTransportRequestId in ChangeManagement utils 2018-07-12 14:17:41 +02:00
Marcus Holl
8d60a81ec5 Read transportId from commit history: split getChangeID method 2018-07-12 14:17:33 +02:00
Marcus Holl
75a9a76205
Merge pull request #197 from marcusholl/transportRequestUploadFileChangeDocumentIdFromCommitHistory 
transportRequestUploadFile: retrieveChangeDocumentId from commit history
 2018-07-12 13:28:03 +02:00
Marcus Holl
c9572d187b Merge remote-tracking branch 'github/master' into HEAD 2018-07-12 13:23:00 +02:00
Marcus Holl
52052cc99d
Merge pull request #196 from marcusholl/transportRequestCreateChangeDocumentIdFromCommitHistory 
transportRequestCreate: retrieve changeDocumentId from commit history
 2018-07-12 13:14:34 +02:00
Marcus Holl
2310bb4bd5 Do not repeat the same parameter names for different configuration layers 
changeId is removed from the step parameters since the changeId
is specific to the build. Hence there is no reason for providing
it from the deeper configuration layers.
 2018-07-12 12:13:36 +02:00
Marcus Holl
3cb8912456
Merge pull request #180 from marcusholl/pr/supportCmClientOptsUploadFileToTransport 
Support CM clientOpts for uploadFileToTransport
 2018-07-12 10:16:07 +02:00
Marcus Holl
52bb1e842d Validate required parameters via config helper 
- In case a parameter is missing we do not thrown and AbortException
    anmore, but an IllegalArgumentExcpetion, since that exception is
    thrown by the configuration helper. The difference is: AbortExceptions
    are contained in the log without stacktrace, other exceptions are
    printed with stack trace.
  - Exception messages are changed to the standard error message triggered
    inside the configuration helper. In case the changeDocumentId is
    retrieved also from the commit history we keep an exception message
    pointing to that.
  - Having references to the parameters is droped. Instead the parameters
    are directly used from the configuration map.
  - in case of long signatures line breaks are inserted in order to
    simplify reading the code.
 2018-07-12 09:34:06 +02:00
Christopher Fenner
1423522e2f
Merge pull request #201 from marcusholl/pr/fixQuotationMark 
[fix] misplaced quotation mark in assertion message
 2018-07-12 09:21:30 +02:00