jenkins/sap-jenkins-library
1
0
Fork 0
mirror of https://github.com/SAP/jenkins-library.git synced 2024-12-14 11:03:09 +02:00
Code Issues Releases Activity
735 Commits 353 Branches 458 Tags 1.5 GiB
4425629ee7
Commit Graph

735 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Marcus Holl
1c4595769d
Merge pull request #209 from marcusholl/pr/refactorGetMandatoryProperty 
[refactor] re-use getConfigPropery inside getMandatoryProperty
 2018-07-17 08:56:09 +02:00
Marcus Holl
4f8f7be6aa Access to nested properties 
yaml configuration supports nested properties. With this change
we can read those nested properties.
 2018-07-16 17:26:22 +02:00
Marcus Holl
83e757475a Merge remote-tracking branch 'github/master' into HEAD 2018-07-16 12:09:49 +02:00
Marcus Holl
b72cb656d5 Merge remote-tracking branch 'github/master' into HEAD 2018-07-16 11:15:22 +02:00
Marcus Holl
7482b58dc2 UploadFileToTransport: Read transportRequestId from commit history 2018-07-16 10:28:59 +02:00
Marcus Holl
bc13d1d969 Introduce getTransportRequestId in ChangeManagement utils 2018-07-16 10:15:27 +02:00
Marcus Holl
bb0e9b92ce transport request upload file: decouple tests. 2018-07-13 16:09:51 +02:00
Marcus Holl
0337b34cef [whitespace only] increase readability 2018-07-13 14:40:54 +02:00
Marcus Holl
254a4e2017 Remove unused sh registerAllowedMethod 
registerAllowedMethod for sh call not used anymore since we mock the ChangeManagement utils class.
The sh calls was triggered from the utils class. Since we mock that class, there is no sh call
anymore.
 2018-07-13 13:23:10 +02:00
Marcus Holl
64291cd88f [refactor] re-use getConfigPropery inside getMandatoryProperty 
... instead of accessing the config map directy.

With that we ensure that getMandatoryProperty behaves the same like
getConfigProperty. Currently we differ e.g. with trim().
 2018-07-13 11:28:55 +02:00
Marcus Holl
a49c17c869
Merge pull request #202 from marcusholl/pr/mandatoryPropertyCheck 
Validate required parameters via config helper
 2018-07-13 11:03:30 +02:00
Marcus Holl
63b0fd6f67 Merge remote-tracking branch 'github/master' into HEAD 2018-07-13 10:30:29 +02:00
Marcus Holl
1bb3cb4d1f
Merge pull request #203 from marcusholl/pr/condenceParameters 
Do not repeat the same parameter names for different configuration la…
 2018-07-13 09:04:40 +02:00
Marcus Holl
b53e1ea539 Merge remote-tracking branch 'github/master' into HEAD 2018-07-13 08:55:15 +02:00
Christopher Fenner
819f84f773
Merge pull request #207 from SAP/CCFenner-patch-2 
newmanExecute: create collectionDisplayName inside of the step
 2018-07-13 08:24:39 +02:00
Christopher Fenner
a4b622e563
use collectionDisplayName 2018-07-12 23:34:35 +02:00
Christopher Fenner
153536f5d3
create collectionDisplayName inside of the step 2018-07-12 23:31:15 +02:00
Marcus Holl
3e01caf909 Merge remote-tracking branch 'github/master' into HEAD 2018-07-12 16:26:52 +02:00
Marcus Holl
b73df0f682 ReleaseTransportRequest: Read transportRequestId from commit history 2018-07-12 16:00:27 +02:00
Marcus Holl
1a32ac46d8 Prepare transportRequestRelease for layered tests 2018-07-12 16:00:26 +02:00
Marcus Holl
5c657f2253 Introduce getTransportRequestId in ChangeManagement utils 2018-07-12 14:17:41 +02:00
Marcus Holl
8d60a81ec5 Read transportId from commit history: split getChangeID method 2018-07-12 14:17:33 +02:00
Marcus Holl
75a9a76205
Merge pull request #197 from marcusholl/transportRequestUploadFileChangeDocumentIdFromCommitHistory 
transportRequestUploadFile: retrieveChangeDocumentId from commit history
 2018-07-12 13:28:03 +02:00
Marcus Holl
c9572d187b Merge remote-tracking branch 'github/master' into HEAD 2018-07-12 13:23:00 +02:00
Marcus Holl
52052cc99d
Merge pull request #196 from marcusholl/transportRequestCreateChangeDocumentIdFromCommitHistory 
transportRequestCreate: retrieve changeDocumentId from commit history
 2018-07-12 13:14:34 +02:00
Marcus Holl
2310bb4bd5 Do not repeat the same parameter names for different configuration layers 
changeId is removed from the step parameters since the changeId
is specific to the build. Hence there is no reason for providing
it from the deeper configuration layers.
 2018-07-12 12:13:36 +02:00
Marcus Holl
3cb8912456
Merge pull request #180 from marcusholl/pr/supportCmClientOptsUploadFileToTransport 
Support CM clientOpts for uploadFileToTransport
 2018-07-12 10:16:07 +02:00
Marcus Holl
52bb1e842d Validate required parameters via config helper 
- In case a parameter is missing we do not thrown and AbortException
    anmore, but an IllegalArgumentExcpetion, since that exception is
    thrown by the configuration helper. The difference is: AbortExceptions
    are contained in the log without stacktrace, other exceptions are
    printed with stack trace.
  - Exception messages are changed to the standard error message triggered
    inside the configuration helper. In case the changeDocumentId is
    retrieved also from the commit history we keep an exception message
    pointing to that.
  - Having references to the parameters is droped. Instead the parameters
    are directly used from the configuration map.
  - in case of long signatures line breaks are inserted in order to
    simplify reading the code.
 2018-07-12 09:34:06 +02:00
Christopher Fenner
1423522e2f
Merge pull request #201 from marcusholl/pr/fixQuotationMark 
[fix] misplaced quotation mark in assertion message
 2018-07-12 09:21:30 +02:00
rodibrin
4cb5ba5f3f
Merge pull request #194 from rodibrin/pr/newmanexecutetest 
adapt the NewmanExecuteTest to windows file system
 2018-07-12 08:56:28 +02:00
Marcus Holl
c1927da33f [fix] misplaced quotation mark in assertion message 2018-07-12 08:12:32 +02:00
Marcus Holl
239e8cc054
Merge pull request #199 from marcusholl/pr/supportAssertOfLogMessageInCaseOfFailures 
Support check for log messages in case of exceptions in code under test
 2018-07-11 12:29:21 +02:00
Marcus Holl
d3dde491f6
Merge pull request #181 from marcusholl/pr/streamlineScript 
Streamline and fix usage of script
 2018-07-11 12:28:26 +02:00
Marcus Holl
c978d02532 Make use of decent helper function of configuration helper 2018-07-11 11:55:19 +02:00
Marcus Holl
3ddac5633d Introduce dedicated variable for script 2018-07-11 11:55:19 +02:00
Christopher Fenner
aa865f145f
Merge pull request #172 from SAP/CCFenner/mtaVersioning 
add versioning for MTAs
 2018-07-11 11:53:20 +02:00
Marcus Holl
a4f62e6f6e
Merge pull request #182 from marcusholl/pr/supportCmClientOptsForReleaseTransport 
Support cmClientOpts for releasing a transport
 2018-07-11 11:50:34 +02:00
Marcus Holl
111802cfd2 Support check for log messages in case of exceptions in code under test 
With the current approach of checking log entries we are not able to
check log entries in case of a failure. But is is important to assert
log messages in case of a failure. Having reasonable log messages
simplified troubleshooting.

Hence we add JenkinsLoggingRule.expect(substring) and check after the
base of that rule has been called.

This interfears with other rules also working with an expect approach,
like e.g. ExpectedException. Which violation is presented depends on
the order or the rules around the test case.
 2018-07-10 17:34:58 +02:00
Marcus Holl
cada0e7882 transportRequestCreate: retrieve changeDocumentId from commit history 2018-07-10 16:41:43 +02:00
Marcus Holl
a7ea15ac58 transportRequestUploadFile: retrieveChangeDocumentId from commit history 2018-07-10 16:40:26 +02:00
Marcus Holl
4a9c0695ca transportRequestRelease: get changeDocumentId from commit history 2018-07-10 16:34:42 +02:00
Marcus Holl
4a92f65e66
Merge pull request #195 from marcusholl/pr/noConfigInChangeManagmentUtils 
No forwarding of config map in to ChangeManagement class.
 2018-07-10 14:07:48 +02:00
Roland Stengel
4d726d6c5f Merge branch 'pr/newmanexecutetest' of github.com:rodibrin/jenkins-library into pr/newmanexecutetest 2018-07-10 13:13:54 +02:00
Roland Stengel
81c0110740 adapt the NewmanExecuteTest to windows file system 2018-07-10 13:10:16 +02:00
Marcus Holl
5e09e2fb88 No forwarding of config map in to ChangeManagement class. 2018-07-10 12:30:31 +02:00
Marcus Holl
87c61ae7fb
Merge pull request #193 from marcusholl/pr/gitFormat 
Add missing docu for parameter gitFormat
 2018-07-10 12:13:01 +02:00
Roland Stengel
f32c9f495d adapt the NewmanExecuteTest to windows file system 2018-07-10 12:02:58 +02:00
Marcus Holl
67b2d34b5c Add missing docu for parameter gitFormat 2018-07-10 11:27:19 +02:00
Marcus Holl
0ccabb7c40
Merge pull request #192 from marcusholl/pr/CamelCaseInsteadUnderscore 
camel case instead underscore
 2018-07-10 11:20:44 +02:00
Marcus Holl
bb2ed27c10 Switch from gitLabel to gitChangeDocumentLabel 
since we will have two labels in future. One for scanning changeDocumentIds and
another one for scanning transportRequestIds
 2018-07-10 11:15:09 +02:00