2 Commits

Author	SHA1	Message	Date
Marcus Holl	56586cae1b	Remove assert.Error right before assert.EqualError (#2344) ... Is there any benefit from having ``` assert.Error(./.) assert.EqualError(./.) ``` ? assert.Error ensures that we have an error. assert.EqualError ensures that we have an error and moreover it checks for a specific error. Hence assert.EqualError does all and more what assert.Error does. In case there is a benefit from that pattern this PR should not be merged. In case there is not benefit from that pattern we should abandong that pattern.	2020-11-11 14:14:55 +01:00
Christopher Fenner	989c47db2c	feat(sonar): extract sonar project link to report JSON (#1390) ... * add test cases for sonar pkg * add sonar pkg * read task report and write reports JSON * use alias * rename type * set read permission on created files * archive reports * handle empty report lists * use filepath * simplify report creation * improve error message * Revert "archive reports" This reverts commit ba4b56fec1. * improve test cases * Add descriptions Co-Authored-By: Stephan Aßmus <stephan.assmus@sap.com> * improve tests Co-Authored-By: Stephan Aßmus <stephan.assmus@sap.com> Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>	2020-04-21 15:45:52 +02:00