Mikalai Dzemidzenka
b82ecb0ff7
convert batsExecuteTests to go implementation ( #2737 )
...
* convert batsExecuteTests to go implementation
* added additional test cases, added container definition to batsExecuteTests.yaml
* added influx, for junit added container definition
* added parameter envVars
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2021-04-29 16:50:23 +02:00
Oliver Feldmann
d766f6befe
dockerExecuteOnKubernetes: Add capability for volume mounts ( #2784 )
...
* Remove unused container variable
* Add volume mounts functionality
* Make volume mounts optional
* Replace placeholder with {}
* Don't provide sidecar volume mounts
* Remove unnecessary parameter volumeName
* Add documentation for new parameter
* Use empty map for {}
* Update vars/dockerExecuteOnKubernetes.groovy
Co-authored-by: Srinikitha Kondreddy <srinikitha.kondreddy@sap.com>
* Improve documentation
Co-authored-by: Srinikitha Kondreddy <srinikitha.kondreddy@sap.com>
2021-04-29 11:39:34 +02:00
Mikalai Dzemidzenka
61f4c5245a
feat(karma): migrate karmaExecuteTests to go implementation ( #2695 )
...
* convert karmaExecuteTests to go implementation
* removed KarmaExecuteTestsTest.groovy
* added KarmaExecuteTests to fieldRelatedWhiteList
* Update vars/karmaExecuteTests.groovy
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update resources/metadata/karmaExecuteTests.yaml
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update resources/metadata/karmaExecuteTests.yaml
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* added reference seleniumHubCredentialsId to yaml file, fixed modules code
* karmaExecuteTests.yaml renamed to karma.yaml
Co-authored-by: lndrschlz <leander.schulz01@sap.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-04-15 13:58:23 +02:00
Oliver Nocon
d04a7c2eb3
feat(pipelineCreateScanSummary) Create groovy wrapper ( #2743 )
...
* feat(pipelineCreateScanSummary) Create groovy wrapper
* add command to binary
* stash step reports
* update stash
* fix typo
* unstash reports first
* update reporting
* update json reporting
* update tests & enhance logging
* update md report
* update md reporting
* fix rendering
* update tests
2021-04-15 07:45:06 +02:00
Kevin Stiehl
fe6ea643fa
Add terraformExecuteStep ( #2679 )
...
* Add terraformExectueStep
* Update terraformExecute.go
* fmt
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2021-03-29 16:22:23 +02:00
lndrschlz
b612a1fb3f
fix: stackoverflow error when writing cpe file ( #2729 )
...
* catch stackoverflow error
* update log
* update log
* update log
* explicit return if value null
* wip
* wip
* wip
* wip
* prevent error
* cleanup
* cleanup
* use notify
* removed import
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-03-29 13:44:55 +02:00
Kevin Stiehl
b70af2651e
Fix config rsolving in PostStage ( #2726 )
...
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-03-29 12:18:19 +02:00
Siarhei Pazdniakou
33699c7388
Convert containerExecuteStructureTests to go implementation ( #2701 )
...
* Converted containerExecuteStructureTests to go implementation
* Added tests
* Fixed issues
* Made fixes
Co-authored-by: lndrschlz <leander.schulz01@sap.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2021-03-25 08:18:30 +01:00
Roland Stengel
101e8ec784
TransportRequest: add UploadSOLMAN groovy step ( #2688 )
...
* TransportRequest: add UploadSOLMAN groovy step
- groovy to go
- use docker image in go
- map credentials in go
- generated yaml
2021-03-22 11:53:37 +01:00
lndrschlz
dea96a3ba0
feat(newmanExecute): golang implmementation for newmanExecute ( #2513 )
...
* Automates first parts of newmanExecute.groovy
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* Adds newman installation
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* Removes warning
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* makes tests robust for later shell calls
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* Adds version logging
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* Adds tests for version logging
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* Adds newman shell execution
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* Prepare cloud foundry apps with secrets handling
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* Adds further process to CF Utils
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* Fixes unit test
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* Adds error category
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* Add fix to execute step locally
Currently only tested on windows machine locally in powershell.
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* Adapt unit test to fix of runCommand
Signed-off-by: Fabian Reh <fabian.reh@sap.com>
* refactored golang step to newmanExecute
* wip
* added test config
* refactored newmanExecute groovy wrapper step
* exclude newmanExecute from common step test
* cleaups
* add credential support
* fix groovy credential providing
* add import
* add stageName
* define script
* remove unused vars
* add import
* fix iterator ref
* golang secret handling and cleanups
* wip
* wip
* wip
* update go step
* implement cf credential proposal
* testRepository functionality implemented
* register secrets to logger
* add missing dependecies
* test xsuaa credential handling
* wip
* wip
* cleanups
* add import
* remove mandatory params
* add container definition
* test runCommand
* test runCommand
* fix npm path
* fix npm path
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* added newmanEnvironment to templating
* wip
* use env and globals params in runCommand when no templating
* fix condition
* wip
* reverted config edit
* updated documentation
* install with shell
* wip
* wip
* fix tests
* refactor tests
* wip
* remove old test
* wip
* escape go tmpl
* escape go tmpl
* fix defaults
* add doc comment
* remove test case
* refactored newman commands
* add cli reporter
* refactor options
* mock os getenv and fix all tests
* refactoring and doc update
* go generate
* small refactor
* spelling
* fix newman doc
* remove MaskPasswords wrapper; fix stash bug;
* docu fix
Co-authored-by: Fabian Reh <fabian.reh@sap.com>
2021-03-17 08:08:33 +01:00
Christopher Fenner
0fcbfa8da7
feat(sonar): create report for issue count ( #2691 )
...
* create json report
* archive report
* add test case
* generate report
* correct report name
2021-03-12 15:05:07 +01:00
Christopher Fenner
be68270cb4
fix(piperExecuteBin): move CPE.readFromDisk to own finally block ( #1885 )
...
* Update piperExecuteBin.groovy
fixes #1881
* Update piperExecuteBin.groovy
2021-03-12 09:42:19 +01:00
Christopher Fenner
f999925788
fix(influx): correct data type of influx measurements ( #2171 )
...
* update data type of influx measurements
* Update checkmarx.yaml
* pick changes from #1885 for testing
* update generated code
* update to new datatype
* adjust to type changes
* change back to string type
* Update fortifyExecuteScan.go
* add typo to be backward compatible
* change type to int for files_scanned and lines_of_code_scanned
* add typo
* add measurements to whitesource
* update generated sources
* adjust test cases
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2021-03-10 16:00:53 +01:00
Sven Merk
34f2a82787
Update influxWriteData.groovy ( #2684 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2021-03-10 09:23:36 +01:00
Christian Luttenberger
c8e9e44f23
New pipeline step assembly confirm ( #2631 )
...
* Add new pipeline step
* new pipeline stage
* Cleanup Test
* Adding new step to pipeline - stage publish
* Move from Publish to Build
* Adjusting documentation for move from publish to build
* Change Release with Confirm Step in Build Stage
* codeclimate
* Code Climate
* Code Climate spaces
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
2021-02-23 11:11:52 +01:00
Daniel Mieg
43fa6634ee
Updates for ABAP Environment release 2102 ( #2621 )
2021-02-21 20:19:42 +01:00
Christopher Fenner
2d93e5d4df
fix(cpe) readToDisk failes with content from writeToDisk ( #2629 )
...
* branch for debugging
* Add json fix for booleans
* remove debug output
* handle boolean in cpe
* handle various types in json
* fix variable
Co-authored-by: OliverNocon <oliver.nocon@sap.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2021-02-19 11:34:30 +01:00
Marcus Holl
3df4542271
move additional hints into markdown file ( #2599 )
...
These hints are up to now provided as javadoc like comments
at the call method for cloudFoundryDeploy step. At that level
they are not taken into account by the go generator.
Is is not a suitable approach to include this kind of markdown
docu into the long description of the metadata file since this
long description is (also) used by the piper help command when
invoking piper cloudFoundyDeploy --help. At that point in time
markdown like text does not make sense.
2021-02-19 08:44:51 +01:00
Mayur Belur Mohan
06afce3005
IntegrationArtifactUpload Command ( #2610 )
...
* IntegrationArtifactUpload Command
2021-02-17 09:59:56 +01:00
Kevin Stiehl
ffffe8295e
(Vault) Improvements ( #2439 )
...
* vault improvements
* Update cloudFoundryDeploy.yaml
remove double PARAMETERS
* go generate
* fix type & resturcutre paragraph to a list
* remove non-existent secrets
* build trigger
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-02-15 09:48:51 +01:00
Oliver Feldmann
1b032b5c82
Skip checkout flag ( #2594 )
...
* Skip checkout flag
Defaults to null==false
We need the option to provide an scmInfo object by the user
* Check skipCheckout is Boolean
* Require scmInfo map in case checkout is skipped
2021-02-11 16:21:57 +01:00
Marcus Holl
c53d5241cb
use v6 version of ppiper/cf-cli consistently for all go steps ( #2569 )
2021-02-11 09:31:25 +01:00
Mayur Belur Mohan
f030bc9861
IntegrationArtifactDownload Command ( #2587 )
...
* IntegrationArtifactDownload Command
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-02-10 17:08:23 +01:00
Christian Luttenberger
e9a93ed384
Adding new step for abap Enviroment Assembly Confirm ( #2586 )
...
* Adding new abap Assembly Confirm
* Update abapEnvironmentAssembleConfirm.go
* Add generated objects
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
2021-02-10 11:33:10 +01:00
Mayur Belur Mohan
538256774a
IntegrationArtifactGetServiceEndpoint Command ( #2582 )
...
* GetIntegrationArtifactServiceEndpoint Command
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-02-05 10:35:55 +01:00
Mayur Belur Mohan
426c106765
IntegrationArtifactGetMplStatus Command ( #2558 )
...
* IntegrationArtifactGetMplStatus Command
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-02-04 10:50:15 +01:00
Srinikitha Kondreddy
1b16de0734
Remove handle pipeline step errors from groovy glue code ( #2573 )
2021-02-04 08:54:00 +01:00
Oliver Nocon
a104b2a06d
feat(whitesourceExecuteScan): UA for all build tools, e.g. maven & npm ( #2501 )
...
* feat(whitesource): add config helper
this helps to ease & enforce config settings
* fix accidential change of class
* add todos wrt java download
* use existing scanOptions, add option to download jre
* update generation
* fix generation
* allow running UA via go library
* correct image, improve logging
* add removal of downloaded JVM
* update java creation and deletion
* refactor and add log output
* remove obsolete ToDo
* increase test coverage
* increase test coverage
* adding aliases and tests
* make go modules as default
* maven: update behavior of projectNaming
* add Docker capabilities
* correct parameter name
* retrieve Docker coordinates
* docker coordinates only to provide artifact
* add ToDos
* add mta capability
* add aliases, mvn arguments for settings
* clean up groovy part
* update defaults
* add container for pip
* add defaults, add maven specifics, ...
* properly download settings
* maven: check existence of excluded files
* fix reporting
* Update CommonStepsTest.groovy
* update comment
* fix CodeClimate finding
* add tests for pip & fix minor issues
* fix order of pip build descriptors
* update pip container options
* fix pip virtualEnv parameter
* update report permissions
* fix test
* update container options
* add use fileUtils to load properties file
* update parameter description
* adding Docker scanning defaults
* clean up configHelper
* consider also npm tool cache
* add todos
2021-02-03 14:52:48 +01:00
Mayur Belur Mohan
0ed5cce53a
IntegrationArtifactUpdateConfiguration Command ( #2542 )
...
* IntegrationArtifactUpdateConfiguration Command
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-01-29 09:46:47 +01:00
lndrschlz
e60bdb94a6
feat(uiVeri5): golang implmementation for uiVeri5ExecuteTests ( #2394 )
...
* added uiVeri5ExecuteTests step files
* added confPath an regenerated step
* added test for uiVeri5ExecuteTests
* config modified
* added groovy wrapper
* ambiguous method fixed
* uiveri5 wrapper
* removed install command
* fixed defaults
* added testOptions as confPath arg
* test set env
* test npm install local
* changed env settings
* tests regenerated
* go generate
* fix code climate
* overwrite groovy step
* remove groovy wrapper go
* unstash piper bin
* test older node version
* test piperExecuteBin
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* refactored params
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* set testServerUrl as os env for uiveri5
* Update config.yml
* fix naming of testServerUrl param
* wip
* refactored setEnv and fixed tests
* wip
* step param for NPM_CONFIG_PREFIX
* fix runCommand
* refactored step param, regenerate, docu, fix tests
* fix groovy wrapper test
* cleanup
* add to CommonStepsTest field whitelist
* fixed default pipeline environment vars
* fix []string default
* fix metadata.go bug
* added test for docu metadata gen
* fix metadata_test.go in doc gen
* Update metadata_generated.go
* Update metadata_generated.go
* remove npm config prefix param; doc fix
* remove tab
* changed npm config prefix
* removed groovy wrapper test
* removed groovy step defaults
* modify path variable
* modified npm config prefix
* fix error wrapper and tests
* doc update
* add testRepository support
* wip
* fix testRepository param
* wip
* add utils
* init stash content
* wip
* wip
* wip
* add comment for deprecated parameters
* fixed commonStepTest
* fixed commonStepTest
* added error category for testOptions failure
* Update vars/uiVeri5ExecuteTests.groovy
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update vars/uiVeri5ExecuteTests.groovy
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* fix condition
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-01-28 11:31:24 +01:00
Srinikitha Kondreddy
efe3ab36f8
Support for secretfile type neo credential for deployment ( #2537 )
...
* Use Oauth bearer token credentials to deploy to neo
* Add test case
* Add test file
* Fix code climate issues
* Add code review changes
2021-01-26 09:29:44 +01:00
Mayur Belur Mohan
fe72b295d6
IntegrationArtifactDeploy Command ( #2526 )
...
* UpdateIntegrationArtifactConfiguration Command
* Fixes for codeclimate Check
* CommonStepsTest changes
* CodeReview Changes
* Git Patch
* Git Patch undo
* Code Review Comments
* code review fixes
* improve the error handling
* codeclimate fixes
* remove json parsing
* Error handling changes
* TestCase coverage fixes
* Refactoring Commands
* IntegrationArtifactDeploy Command
* Regenerate metadata_generated
* codereview fixes
* Code Review Fixes
* Code Review Fixes
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2021-01-22 15:55:50 +01:00
Oliver Feldmann
741b49140e
Move pull image parameters to general section ( #2478 )
...
* Move pull image parameters to general section
* Allow no nesting override
* Test dockerPullImage can be set to true
As the default is false, we need to make sure it can still be set to true.
2021-01-13 10:48:48 +01:00
Marcus Holl
84bb028ffd
fix typo for transportRequestUploadFile ( #2499 )
2021-01-12 15:15:30 +01:00
mayurmohan
f4469c3427
DeployIntegrationArtifact Command ( #2474 )
...
DeployIntegrationArtifact Command
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-01-12 12:17:42 +01:00
Christopher Fenner
6dd006f0a0
fix(cpe): fix issue in custom type determination ( #2505 )
2021-01-12 11:36:25 +01:00
Marcus Holl
93330d5ed2
Prepare credentials for forwarding as environment variables to piper go ( #2432 )
...
Prepare credentials for forwarding as environment variables to piper go
2021-01-12 09:17:34 +01:00
Christopher Fenner
834dd1a1de
fix(CPE): correct handling of complex (json) data in writeToDisk ( #2500 )
...
* correct handling of JSON data
* fix typo
* Update commonPipelineEnvironment.groovy
2021-01-11 12:58:12 +01:00
Oliver Nocon
006aaab50d
fix(handlePipelineStepError): correct handling of failed steps ( #2498 )
...
* WIP: debug incorrect error message
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update commonPipelineEnvironment.groovy
* Update piperExecuteBin.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update piperExecuteBin.groovy
* Update commonPipelineEnvironment.groovy
* Update handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Update piperExecuteBin.groovy
* Update vars/piperExecuteBin.groovy
* Update vars/handlePipelineStepErrors.groovy
* Update handlePipelineStepErrors.groovy
* Apply suggestions from code review
* correct test case
* change test case
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Christopher Fenner <Christopher.Fenner@sap.com>
2021-01-11 10:49:33 +01:00
Oliver Nocon
5f5450449e
fix(piperExecuteBin): define variable ( #2497 )
2021-01-07 12:24:48 +01:00
Hans Schulz
e9a7590c5c
Add cfTrace parameter ( #2248 )
...
* add cfTrace parameter
* make cfTrace toggle creation of log file
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-12-21 17:46:52 +01:00
Oliver Nocon
7de42230e0
add step to create a GitHub issue ( #2481 )
...
* add step to create a GirHub issue
* add groovy library step
* Update githubcreateissue.yaml
Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
2020-12-21 17:13:16 +01:00
Oliver Nocon
cf7ca8f791
add step to create a GitHub comment ( #2479 )
...
* add step to create a GitHub comment
* add docs
* mandatory parameters
* add command
* Update githubCommentIssue.go
* add groovy library step
Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
2020-12-21 16:21:07 +01:00
Srinikitha Kondreddy
d9a1355220
Fix typo ( #2436 )
2020-12-14 15:02:49 +01:00
Christopher Fenner
9cd3ee5758
fix(checks+tests): fail pipeline if plugins fail the build ( #2463 )
...
* fix false negative
* add comment
* add default
2020-12-11 14:49:36 +01:00
Oliver Feldmann
96ebaa1a20
chore(docs): Fix switheroo of deployType and deployTool typo ( #2464 )
...
* Fix switcheroo
* Add commas
2020-12-11 13:11:36 +01:00
Daniel Mieg
44e7766e8f
Add stage docu ( #2460 )
...
* Add stage docu
* Add table to configuration.md
* Add comment to clone repo stage
* Fix indentation errors
* Docu: commitID
* fix links
2020-12-10 14:28:03 +01:00
Christopher Fenner
6970b57468
fix(cfDeploy): correct stash for go step ( #2456 )
2020-12-09 14:31:07 +01:00
Marcus Holl
17bdbe2ef4
piperExecuteBin: provide credentials directly without indirection into config ( #2437 )
...
`piperExecuteBin` is called with a credentials list. Each list entry is a map consisting of
* the type of the credential (e.g. usernamePassword, token)
* the identifier which is used for resolving the credential.
* a list of environment variables which holds the resolved credentials.
Inside `piperExecuteBin` the id was resolved against the config and the result was used for resolving the credentials against the jenkins-credentials-plugin.
With this change here we introduce another key for the map mentioned above:
* resolveCredentialsId
When this key is provided with value `false` we do not resolve the credentials-id from the config. In that case the id is directly used for resolving the credential again the jenkins-credentials-plugin.
2020-12-07 08:54:49 +01:00
Christopher Fenner
fac4af231f
fix(cfDeploy): correct stashing ( #2448 )
...
* remove stash from step yaml
* add stash to groovy code
2020-12-05 13:35:16 +01:00
Daniel Mieg
b001474edd
Remove input statement ( #2419 )
...
* Remove input statement
* adaptDocu
2020-12-04 10:03:41 +01:00
Christopher Fenner
e1d140e513
fix(checksPublishResults): typo in tool it key ( #2443 )
2020-12-03 14:16:04 +01:00
Stephan Aßmus
e48b5c588e
Include configFile in pipelineConfigAndTests stash ( #2424 )
2020-12-01 12:04:27 +01:00
Thilaknath
104435c8dd
Show user friendly error messages for pipeline restart step. ( #2409 )
...
* Add message parameter to pipelineRestart to make error messages user friendly
* Update the parameter to the correct name
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-26 08:03:22 +01:00
Christopher Fenner
eff1933a61
refactor(checks): use warnings-ng plugin ( #2398 )
...
* use recordIssues
* fix c&p issue
* simplify code
* fix
* add quality gates
* change qgates to TOTAL_HIGH
* remove pattern for tasks
* use TOTAL_ERROR for checkstyle
* fix indent
* use deprecated threshold parameters
* debug messages
* transform legacy qgates
* fix
* adjust test cases
* correct qgates
* correct legacy thresholds
* fix typo
* remove deprecated defaults
* add test case
* log use tool
* add notification
* remove deprecated defaults
* remove deprecated parameter
* adjust legacy threshold message
* add q gates on error and high for all check tools
* Apply suggestions from code review
* adjust test cases
* remove duplicate assert
* Fail if aggregation is still defined
* update docs
* fix indent
* Update documentation/docs/steps/checksPublishResults.md
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-11-25 15:39:33 +01:00
Florian Wilhelm
9d5bd8b09b
Remove references to cloud sdk ( #2418 )
...
Not required anymore as Cloud SDK was merged into General Purpose Pipeline
2020-11-23 17:48:53 +01:00
Stephan Aßmus
c74500545c
dockerExecute: Add compatibility aliasing for renamed params ( #2391 )
2020-11-17 17:44:19 +01:00
Stephan Aßmus
cbd932a5eb
dockerExecute: Wrap all code in docker.withRegistry() ( #2384 )
...
* wrap all in docker.withRegistry()
* Renamed parameter
No backwards alias, since it never worked before.
* Fix code and tests
* Rename parameter as per review
* Rename parameter as per review
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
2020-11-17 14:53:09 +01:00
Kevin Stiehl
dfab156427
Feature/approle secret id rotation ( #2311 )
...
* add new step vault secret
* add debug log
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-17 13:49:31 +01:00
Stephan Aßmus
0491bf3712
Always use artifactPrepareVersion ( #2360 )
...
artifactSetVersion was documented as being "deprecated" since a while, but was still used.
2020-11-16 16:38:17 +01:00
Christopher Fenner
81c8553d6a
refactor(hadolint): implement step in GO ( #1169 )
...
* initial commit of yaml file
* initial commit for HaDoLint in GO
* add helper function to load file from url
* load config file
* write report information to disk
* comment the code
* refactor groovy code
* remove download function from FileUtils
* use http.Downloader
* rename step files
* update generated files
* update generated files
* remove duplicate commands
* add credentials for config url
* add generated test file
* reuse piperExecuteBin functions
* correct step name
* update go step
* deactivate test
* fix import
* use differing go step name
* rename step
* correct result publishing
* correct command name
* expose tls insecure flag
* hand through error
* disable tls verification
* fix tls disabling
* use credentials
* mow
* reformat
* add qgate only if set
* correct report name
* remove old defaults
* add qgate to defaults
* handle report name
* restore default
* remove unused step config
* use piperExecuteBin
* remove obsolete type
* add test cases
* remove groovy tests
* move client parameter handling to run function
* use custom interfaces and mockery
* remove commented code
* correct struct names
* rename parameter dockerfile
* add further asserts
* cleanup
* change file permission to read/write
* remove tokenize
* add further comments
* init http client only if necessary
* add todo
* Revert "rename parameter dockerfile"
This reverts commit 2a570685b8
2020-11-16 15:14:54 +01:00
Florian Wilhelm
647e1ef0bd
Add deployment to performance tests stage and enable stage ( #2370 )
...
Co-authored-by: Kevin Hudemann <kevin.hudemann@sap.com>
2020-11-13 16:31:45 +01:00
Srinikitha Kondreddy
6c26a791a3
Add an option to clone from specific repository ( #2322 )
2020-11-12 20:35:59 +01:00
Kevin Hudemann
8fd6927854
Add mavenExecuteIntegration, mavenExecuteStaticCodeChecks, npmExecuteLint and npmExecuteScripts to piperPipelineStagePRVoting ( #2352 )
...
This change adds the steps mavenExecuteIntegration, mavenExecuteStaticCodeChecks,
npmExecuteLint and npmExecuteScripts to the stage piperPipelineStagePRVoting.
2020-11-12 09:25:44 +01:00
Daniel Mieg
712c568087
Create groovy step for abapEnvironmentCreateSystem ( #2303 )
...
* Create groovy step
* add to pipeline
* add includeAddon
* Adapt docu
* Adapt groovy test
* adapt stage addonBuild
* add comma
* Add to docu
* Upper case spelling
* Update docu
* adapt docu
2020-11-11 17:08:24 +01:00
Stephan Aßmus
115cfb5bae
Run nexusUpload in stage Promote ( #2349 )
2020-11-11 16:32:23 +01:00
Florian Wilhelm
0356f13853
Improve error message for legacy cloud sdk config ( #2348 )
2020-11-11 14:47:55 +01:00
Marcus Holl
d327c2e061
Revert "Avoid CPS serialization issue in setupCPE ( #2261 )" ( #2305 )
...
This reverts commit c9b50d7f10
2020-11-11 10:44:49 +01:00
Daniel Mieg
2c432124fc
Unify strategy spelling ( #2345 )
...
* Update abapEnvironmentPipelineStageCloneRepositories.groovy
* Adapt test
2020-11-10 16:45:16 +01:00
Stephan Aßmus
87e8d5d160
Extend the legacy config check for "required" config keys ( #2332 )
2020-11-10 14:18:37 +01:00
Christopher Fenner
b71825fac9
feat(pipeline): add sonar step to PR and Build stage ( #1651 )
...
* add sonar scan to build stage
* add sonar scan to PR stage
* add step activation condition
* adjust whitespaces
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-10 09:18:14 +01:00
Srinikitha Kondreddy
0234e4908c
Invalidate cache for neo deployments ( #2209 )
...
* Add additional parameters for invalidating cache
* Fetch bearer token
* Fetch x-csrf token
* Add echo for testing
* Add echo
* Add another echo
* Check status
* Debug
* Clean up
* Throw exception
* Code review changes
* Review changes
* Add test
* Fix tests
* Fetch bearer token
* Fetch x-csrf token
* Add echo for testing
* Add echo
* Add another echo
* Check status
* Debug
* Resolve conflicts
* Resolve conflicts
* Code review changes
* Review changes
* fix conflicts
* Fix indent
* Add new parameter to define portal landscape region
* Add default value for new param
* Fix test
* Remove example
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
* Check cache invalidation for html5 apps
* Add nesting
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
* Add docu for invalidating cache for html5 apps (#2306 )
* Add docu for invalidating cache for html5 apps
* Improve content
* Docu review changes
* Remove heading
Co-authored-by: Sarah Lendle <44202907+SarahLendle@users.noreply.github.com>
* Update documentation/docs/steps/neoDeploy.md
Co-authored-by: Sarah Lendle <44202907+SarahLendle@users.noreply.github.com>
Co-authored-by: Sarah Lendle <44202907+SarahLendle@users.noreply.github.com>
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
Co-authored-by: Sarah Lendle <44202907+SarahLendle@users.noreply.github.com>
2020-11-09 12:15:00 +01:00
Florian Wilhelm
73a2c256cc
Move legacy config check to step so it can be reused in other pipelines ( #2325 )
2020-11-09 10:15:43 +01:00
Stephan Aßmus
8007a1a6c6
New step gatlingExecuteTests, used in Performance stage ( #2298 )
...
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
2020-11-03 17:42:02 +01:00
Kevin Hudemann
f13ccabe1e
Add preDeploymentHook to multicloudDeploy step ( #2308 )
2020-11-03 16:46:33 +01:00
Oliver Feldmann
5b5f1fe873
Remove closure in switch case ( #2302 )
...
Before this commit, if the closure of the switch case is executed a
CpsCallableInvocation exception is thrown.
2020-11-03 12:50:00 +01:00
Dominik Lendle
c6afd7696b
Abap pipeline extension for cloneGitRepo & checkoutBranch to be used ( #2004 )
...
* Added CFDeleteServiceKeys
* Added ServiceKey deletion tests
* added cfServiceKeys flag explanation to documentation
* removed trailing spaces from documentation
* resolving conflicts
* Changed deletion message an variable naming
* Changed tests
* Changed tests
* Changed tests
* Changed tests
* Changed CloudFoundryDeleteServiceOptions to options
* Changed CloudFoundryDeleteServiceOptions to options
* Minor changes
* Minor changes
* Changed variable naming
* Changed error handling
* Changed error handling and logging
* Changed documentation
* Simplified code
* Fixed CodeClimate issues
* Changed from returning err to nil where no errur returned needed
* Add cloudFoundryCreateServiceKey Go Step
* Changed Groovy File
* Changed aliases
* Removed unneccessary parts
* Minor changes
* Minor changes
* Adapted documentation
* Adapted tests
* Adapted Groovy File
* Changed Groovy file
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Removed Groovy Tests for cfCreateServiceKey
* Minor changes
* Added ATC Check YAML
* Added ATC Check generated files
* Added test class
* Added abapEnvironmentRunATCCheck
* Minor changes
* Minor changes
* Changed groovy
* Minor changes
* Changed groovy
* Changed groovy
* Minor changes
* Adapted Groovy imports
* Adapted Groovy imports
* Adapted Groovy imports
* Adapted Groovy
* Getting ATC results
* Changed error message
* changed groovy
* removed trailing spaces
* Added login check
* Minor changes
* Added step to whitelistScriptReference
* Added ATC error message handling
* Added groovy file
* Added step to groovy tests
* corrected metadata file
* Debugging
* Debugging
* Added yaml config parameter for ATC run
* Adapted file location of ATC run config to jenkins specific location
* Implementing universal pipeline logic for finding yaml config regardless of pipeline
* Changed error handling for reading config yaml file
* Changed atcrunconfig alias
* minor changes
* Minor changes
* Minor changes
* Changed back to dynamic file reading
* Minor changes
* filepath changes
* Removing CF Login
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Minor changes
* Removed whitespaces
* Added CF functions unit tests
* Added invalid parameter handling
* Removed package and SC flag
* Minor changes
* Changed tests
* Changed tests
* Changed tests
* Minor changes
* Changed tests
* removed unnecessary logout
* Added documentation
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Changed docu
* Removed trailing spaces
* Added newline at end of file
* code climate fixes
* code climate fixes
* code climate fixes
* Minor changes
* Minor changes
* Minor changes
* Changed tests
* Test changes
* Splitted Cloud Foundry functions into two classes
* Removed two steps from whtielistScriptReference
* removed atcrunConfig alias
* issue fixes
* Changed docu
* Changed docu
* Changed docu
* Removed trailing spaced from docu
* Changed docu
* Go generator run
* Issue fixes
* Remove unnecessary imports
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Update whitelistScript
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Adding piperutils for writing xml file
* Persisting ATC Results with piperutils
* Set failonMissingReports to true
* Refactoring for CodeClimate
* Changed result file name
* Changed credentials aliases
* changing secret name
* Removing trailing spaces
* Added secret name and alias to docu
* Add cloneGitRepo & checkoutBranch steps
* Tests added
* Docu added
* docu changes
* remark changes
* Class name changed
* minor changes
* Test added for prepare system stage
* Review changes
* Tests
* Step order tests
* Step order tests
* Step order tests
* Step order tests
* strategy parameter tests
* configHelper import added
* Default value for strategy added and remove pull config check
* corrected stage default
* Tests added
* changes in TestConfig
* Tests adapted for no prepare system stage
* tests changed
* changed tests
* input added
* changed tests
* changed tests
* changed tests
* commonPipeline removed
* add input register
* remove step key
* remove return
* remove comment
* correct method usage
* CodeClimate Fixes
* PR fixes
* addonBuild rename
* removed trailing spaces
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-11-03 10:16:57 +01:00
Marcus Holl
c9b50d7f10
Avoid CPS serialization issue in setupCPE ( #2261 )
...
* Avoid CPS serialization issue in setupCPE
When handing over an instance of SCMInfo we got a
CPS serialization issue. Hence we don't hand over
that instance any more
o git commit id is resolved with exising git tooling
o git branch is handed over as parameter to setupCPE
2020-11-02 11:23:34 +01:00
Oliver Nocon
26cfbf7357
fix(whitesourceExecuteScan) properly handle output resources ( #2266 )
...
* fix(whitesourceExecuteScan) properly handle output resources
* fix merge issues
* add required aliases
* update generation
* fix reading custom and container environment parameters from cpe
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-11-02 08:51:58 +01:00
Florian Wilhelm
efa85a0f0e
Allow npm install in e2e tests ( #2281 )
...
Remove hard-coded install: false in npmExecuteScripts call to allow the pipeline to configure the step according to how it is right for that pipeline.
2020-10-30 11:56:29 +01:00
Daniel Mieg
c2bd05fb3d
Add option to include a deletion prompt for Steampunk systems ( #2198 )
...
* Test out delete confirmation
* Second try
* Add confirmation for Integration Tests system
* Fix defaults
* Change default
* Adapt text
* Change default handling
* Adapt addIfEmpty
* Add pipeline test
* Add tests
2020-10-29 10:30:50 +01:00
Stephan Aßmus
d1fedd9ba8
Remove "onlyInProductiveBranch" check ( #2253 )
2020-10-28 17:08:38 +01:00
Fabian Reh
9c870b2514
Gitops update deployment fixes ( #2234 )
...
* makes containerImage not mandatory
* Adds kubectl container
* Adds log statement to debug
* adds general to container image
* removes GENERAL again
Removes condition from Kubectl container
* removes workDir
* marks logs as debug
* adds workingdir again
* Adds author to commits
* Adds commit time now
* remove deprecated and reorder
* adds deprecated again to containerRegistryUrl
Adds GENERAL scope to containerImage
* updates generated file
* Renames containerImageNameTag
* adds else case
* adds debug log
* code cleanup
* adds debug log
* revert
* adds debug logs
* revert
* makes root path not hidden
* revert
* Read container properties
* Removes debug message
* Removes debug message
* Removes general scope again
* Fixes unit test
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-10-27 13:45:34 +01:00
Daniel Kurzynski
63756dc81c
Fix cloudFoundryDeploy documentation ( #2236 )
...
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-10-26 16:59:51 +01:00
Christopher Fenner
bdfe90ed49
feat(hadolint): enable authentication when fetching config file ( #2225 )
...
* use httpRequest to fetch config file
* set default
* provide authentication for config url
* adjust test case
2020-10-23 13:57:22 +02:00
Marcus Holl
4f9bc698f9
ABAP deploy to front end server via existing fiori upload facilities ( #1939 )
...
The approach used up to now did not (... never) work since the uploaded content was always assigned to the `$TMP` package. In the meanwhile there is some fiori tooling available for managing such uploads.
Now we re-use this fiori tooling.
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2020-10-21 12:04:11 +02:00
Fabian Reh
586044192c
feat(Gitops): new step to update deployment ( #2178 )
...
* kanikoExecute: improve user experience
* ensure proper tags
* update permissions
in case a container runs with a different user
we need to make sure that the orchestrator user
can work on the file
* update permissions
* ensure availablility of directories on Jenkins
* (fix) clean up tmp dir in test
* add resilience for incorrect step yaml
* incorporate PR feedback
* Adds piper step to update deployment configuration in external git repository.
https://github.wdf.sap.corp/ContinuousDelivery/piper-ita/issues/21
* Adds handling of branchName as an optional parameter
* Update resources/metadata/gitopsUpdateDeployment.yaml
Feedback about description
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
* Adapt to interface guide
* Refactors to GitopsExecRunner
* Refactors to GitopsExecRunner in test
* Removes unnecessary mocked methods
* Adds tests for git utils
* Adds new step to CommonStepsTest.groovy
* Updates description from yaml
* Restricts visibility of methods and interfaces
Adds comments where necessary
* Updates comments
* Fixes URL name
* updates description
* updates generated file
* Fixes compile issue in CommonStepsTest.groovy
* Updates long description
* Updates test to run green on all kind of OS
* Removes global variables from tests
* Default branch: master
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
* Typo in Hierarchy
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
* Refactors test to allow parallel execution
* Renames utility variable in gitopsUpdateDeployment.go
* Renames error variables in gitopsUpdateDeployment.go
* simplified parameters for kubectl
* Refactors util classes to use parameters rather than global variables
* makes username and password mandatory
* remove unnecessary mandatory flag
* remove new methods from mock that are not necessary
* replaces with EqualError
* replaces with NoError
* update generated file
* refactor tests
* refactor tests
* make tests parallel executable
* parallel execution of tests
* Refactors interfaces to stop exposing interfaces
* Feedback from PR
* Simplifies failing mocks
* Renames variables and interfaces
* Fixes error messages
* shorten variable names
* Renames unused parameters in tests
* Cleanup nil parameters
* Typo
* Wrap errors and remove unnecessary logs
* Remove containername and filePath from GENERAL scope
* correct generated file
* corrects expected error messages
Co-authored-by: OliverNocon <oliver.nocon@sap.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-10-20 09:05:17 +02:00
Oliver Feldmann
2a0e044e20
fix(docs): add description of buildTool for cfDeploy ( #2187 )
...
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-10-15 19:03:16 +02:00
Oliver Feldmann
57816e0275
fix(docs): correct notes text box ( #2189 )
2020-10-15 18:53:45 +02:00
Roland Stengel
1488c4d355
Fiori Scenario from Neo to CF ( #2164 )
...
* Fiori Scenario from Neo to CF
* Fiori Scenario from Neo to CF - Review
- error on unknown deploy target
- codeclimate
- remove obsolete sample files
* Minor language changes
2020-10-15 13:29:52 +02:00
Kevin Stiehl
3eae0c5f68
feat(vault): fetch secrets from vault ( #2032 )
...
* cloud-foundry & sonar from vault
* add vault development hint
* don't abort on vault errors
* cloudfoundry make credentialsId only mandatory when vault is not configured
* add vault ref to step ymls
* rename vaultAddress to vaultServerUrl
* rename PIPER_vaultRole* to PIPER_vaultAppRole*
* add resourceRef for detect step
* fix error when no namespace is set
* added debug logs
* added debug logs
* fix vault resolving
* add vaultCustomBasePath
* rename vault_test.go to client_test.go
* refactored vault logging
* refactored config param lookup for vault
* added tüddelchen
* rename vaultCustomBasePath to vaultPath
* fix tests
* change lookup path for group secrets
* fix interpolation tests
* added vault resource ref to versioning
* execute go generate
* rename Approle to AppRole
* change verbose back to false
Co-authored-by: Leander Schulz <leander.schulz01@sap.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-10-13 14:14:47 +02:00
Marcus Holl
5f5372aa6f
Revert "allow multicloud deployment to run in current workspace ( #2031 )" ( #2137 )
...
This reverts commit 32fd89c6640a17ed56
2020-10-09 14:52:07 +02:00
Tom Kiemes
9ffe52d1f4
Add a milestone for Confirm stage ( #2087 )
...
This commit will prevent abortion of older builds which are waiting in the Confirm stage,
if a newer build fails in the last stage before the Confirm stage.
Example: If the 'Compliance' stage of the general purpose pipeline (piperPipeline.groovy) fails,
it will abort all former builds which are waiting in the 'Confirm' stage.
The milestone function is called without an explicit ordinal since people might use the stage
on different positions within their pipeline. When no ordinal is given, the last milestone ordinal
value will be increased by 1.
Note: Confirming a build will still abort all older builds waiting at the Confirm stage.
2020-10-07 10:56:25 +02:00
Daniel Kurzynski
f5b19a79e4
Infer project name ( #2119 )
...
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-10-05 19:34:43 +02:00
Christopher Fenner
be90876b7c
feat(output): handle non-string output values ( #2113 )
...
* handle non-string values as JSON
* change value type to interface in resources
* regenerate code
* add test cases
* handle reading of json files
* write json data to json files
* fix assignment
* use GetResourceParameter
* add test case
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-10-05 15:33:28 +02:00
Oliver Feldmann
19f45aa687
Move setting git info in cpe from stage init to setupCPE step ( #2083 )
...
* Move setting git info in cpe
Everything cpe related should be done in setupCommonPipelineEnvironment.
Thus a new parameter was introduced to accept the scmInfo object
returned by a checkout.
* Improve documentation
2020-10-05 12:50:03 +02:00
Stephan Aßmus
6379c25409
Forward config-related params to setupCommonPipelineEnvironment ( #2117 )
2020-10-05 12:12:06 +02:00
Daniel Mieg
ae213a013e
Add stages for build process to ABAP Environment Pipeline ( #2052 )
...
* Add stages for build process
* fix typo
* Add createServiceKey to Build stage
* Fix typo
* Inital Checks is required when Build stage is exec
* Switch Order
* Fix Typo
* Add parameter for confirmation
* add "addIfEmpty"
* Add import
* revert
* revert2
* Remove import
* revert3
* Add stages to docu
* Update image
2020-10-02 17:03:43 +02:00
Marcus Holl
b2b4278b34
Provide Additional pod properties for dockerExecuteOnKubernetes ( #2051 )
...
Provide additional pod properties for dockerExecuteOnKubernetes
Co-authored-by: Kay Wegner <kay.wegner@sap.com>
2020-10-02 12:56:16 +02:00
Marcus Holl
75a35fb35a
Improve logging wrt the docker image used for launching piper-go ( #1578 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-10-01 16:27:50 +02:00
