Commit Graph
196 Commits
Author SHA1 Message Date
Alejandra Ferreiro Vidal 724cf64832 create test files before class 2018-02-13 14:32:54 +01:00
Alejandra Ferreiro VidalandGitHub 763777849d Merge pull request #76 from alejandraferreirovidal/cleanUpToolValidate
Clean up tool validate
2018-02-13 10:01:43 +01:00
Alejandra Ferreiro Vidal 874dddfe33 String as String not GString 2018-02-12 16:00:05 +01:00
Alejandra Ferreiro Vidal 72f65a90bc make script private 2018-02-12 15:59:04 +01:00
Alejandra Ferreiro Vidal 56fe9488ff create test files before class 2018-02-12 15:56:48 +01:00
Alejandra Ferreiro Vidal df9a3b3c14 improve log 2018-02-12 10:03:35 +01:00
Alejandra Ferreiro Vidal 9210583bd5 remove unused checks 2018-02-12 10:03:35 +01:00
Alejandra Ferreiro Vidal 39f982c598 refactor home to make it more readable 2018-02-12 10:03:35 +01:00
Alejandra Ferreiro Vidal 3ef6f2de80 remove duplicate code 2018-02-12 10:03:21 +01:00
Christopher FennerandGitHub 2d51e0f8a4 Merge pull request #77 from alejandraferreirovidal/moveUtilsTestClasses
move utils test classes to com.sap.piper folder
2018-02-12 08:41:34 +01:00
Alejandra Ferreiro Vidal 5bfb68d24a move utils test classes to com.sap.piper folder
The folder com.sap.piper was created and the corresponding test classes
were not moved. Furthermore, a new UtilsTest class was created when this
test class did already exist, and the same tests were already
implemented, also this new test class uses the lesfurets testing
framework when it is not needed, so this new test class is removed and
the test class that there was before is kept.
2018-02-09 18:08:11 +01:00
Alejandra Ferreiro VidalandGitHub 68c666fab7 Merge pull request #69 from alejandraferreirovidal/mtaBuildNewConfig
mtaBuild with new config framework
2018-02-09 16:48:35 +01:00
Alejandra Ferreiro Vidal 9dafdd1cc0 mtaBuild with new config framework 2018-02-08 13:26:48 +01:00
Christopher FennerandGitHub 157c9cacfe Merge pull request #66 from CCFenner/deepConfigMerge
extend config merger to handle deep config structures
2018-02-08 08:50:20 +01:00
Christopher FennerandGitHub 3bf3a2a9f5 Update ConfigurationMergerTest.groovy 2018-02-07 22:53:47 +01:00
Oliver NoconandGitHub fbd03a88da Step for automatic versioning (#65)
It contains:

* versioning step artifactSetVersion
* versioning implementation for Maven & Docker
* enhancements to commonPipelineEnvironment
* extended default configuration
* new utils object for git-related tasks
* automated tests incl. new Rules and resources
* incorporated PR feedback
* step documentation
2018-02-07 13:17:33 +01:00
Christopher Fenner f6d1303317 remove obsolete method 2018-02-07 12:08:01 +01:00
Christopher Fenner 87a3a77f44 rework config merge 2018-02-07 12:07:52 +01:00
Christopher Fenner 6300008fe2 adopt tests 2018-02-07 12:01:46 +01:00
Alejandra Ferreiro VidalandGitHub 832a55f817 Merge pull request #71 from alejandraferreirovidal/cleanUpMtaBuilTest
Clean up MTABuildTest
2018-02-06 16:05:38 +01:00
Alejandra Ferreiro Vidal 42db55d5a5 remove public when not needed
See: https://github.com/SAP/jenkins-library/blob/master/CONTRIBUTING.md#do-not-use-a-visibility-modifier-for-public-classes-and-methods
2018-02-06 15:57:26 +01:00
Alejandra Ferreiro Vidal 334251ec82 remove curly braces when not needed
See: https://github.com/SAP/jenkins-library/blob/master/CONTRIBUTING.md#do-not-use-curly-braces--for-variables-or-variableproperty
2018-02-06 15:57:26 +01:00
Alejandra Ferreiro Vidal 615f8deb1d add blanks to keep format 2018-02-06 15:57:26 +01:00
Alejandra Ferreiro Vidal ae66a5cbca add new lines to keep format 2018-02-06 15:57:26 +01:00
Alejandra Ferreiro Vidal 4360636609 add sed test
Removes straightForwardTest that has not a clear scope since it test all
that it is tested in the other tests.
Adds sed test.
Removes duplicated sed assertions.
2018-02-06 15:57:25 +01:00
Alejandra Ferreiro Vidal 69d0050e0c remove blanks 2018-02-06 15:57:25 +01:00
Alejandra Ferreiro Vidal cafa0a703b format String as String not GString
See: https://github.com/SAP/jenkins-library/blob/master/CONTRIBUTING.md#use-single-quotes-for-strings-and-constants
2018-02-06 15:57:25 +01:00
Alejandra Ferreiro Vidal 8075157ea2 rename mtaHome with mtaJarLocation 2018-02-06 15:57:25 +01:00
Alejandra Ferreiro Vidal 868d13749c add mtaJarLocation from environment test
Adds a test to check if the mtaJarLocation is read from the environment
and removes all duplicate assertions.
2018-02-06 15:57:25 +01:00
Alejandra Ferreiro Vidal 5d60bc8199 add environment PATH test
Adds an unit test to test that the environment PATH is set and removes
duplicate PATH assertions.
2018-02-06 15:57:25 +01:00
Alejandra Ferreiro Vidal 7f3f76a8ad remove duplicated mtarFilePath assertions
mtarFile Path must be checked only when it is in the scope of the unit
test.
2018-02-06 15:57:24 +01:00
Alejandra Ferreiro Vidal 4aa4a1d2f5 remove unused cpe 2018-02-06 15:57:24 +01:00
Alejandra Ferreiro Vidal 9cb6f53678 remove unused code 2018-02-06 15:56:57 +01:00
Christopher FennerandGitHub 158392fc73 Merge pull request #70 from CCFenner/jacocoCodeCoverage
add code coverage measuring (jacoco/coveralls.io)
2018-02-06 14:08:00 +01:00
Christopher Fenner 2a6c0d5f34 use key map to iterate over parameters, not defaults key map 2018-02-06 13:44:03 +01:00
Christopher Fenner 82ba8f89a1 Merge commit '829b5ac490e4ee14bfe64b3093854a66dcce212f' into jacocoCodeCoverage2 2018-02-06 13:10:55 +01:00
Christopher FennerandGitHub 829b5ac490 Merge pull request #72 from CCFenner/mkdocs
correct mkdocs command
2018-02-06 10:43:23 +01:00
Christopher FennerandGitHub 6cd4a9076a correct docs command
return to workspace
2018-02-06 09:57:52 +01:00
Christopher Fenner 6e3bfac5c8 consolidate marge methods 2018-02-06 08:41:28 +01:00
Christopher Fenner 0566cab5db extend map helper 2018-02-06 08:37:56 +01:00
Christopher Fenner edf3deaa9c rename method 2018-02-05 20:31:30 +01:00
Christopher Fenner 88d09eee63 filter by keyset 2018-02-05 19:54:04 +01:00
Christopher Fenner 20cbbfc26c filter by keyset and null 2018-02-05 19:39:13 +01:00
Christopher Fenner eab6716797 use default map as base for merge (iteration) 2018-02-05 19:32:50 +01:00
Christopher FennerandGitHub adc77a66ab use full qualified plugin names 2018-02-05 12:59:35 +01:00
Alejandra Ferreiro VidalandGitHub ea5481d971 Merge pull request #63 from alejandraferreirovidal/errorRule
add error rule as common rule
2018-02-05 11:33:48 +01:00
Christopher FennerandGitHub c712925e86 Merge branch 'master' into jacocoCodeCoverage 2018-02-05 10:00:49 +01:00
Christopher FennerandGitHub b1abad89b8 Merge pull request #64 from CCFenner/slack-notification
add Slack notification for Travis
2018-02-05 09:40:15 +01:00
Christopher FennerandGitHub 308b566607 correct env variable name 2018-02-05 08:32:07 +01:00
Christopher Fenner fc2cb4e722 add coverage badge 2018-02-04 09:27:59 +01:00