Sven Merk
fae01c9cd7
Avoid nil reference access ( #2138 )
...
* Avoid nil reference access
* Fix code
2020-10-07 22:02:02 +02:00
Tom Kiemes
9ffe52d1f4
Add a milestone for Confirm stage ( #2087 )
...
This commit will prevent abortion of older builds which are waiting in the Confirm stage,
if a newer build fails in the last stage before the Confirm stage.
Example: If the 'Compliance' stage of the general purpose pipeline (piperPipeline.groovy) fails,
it will abort all former builds which are waiting in the 'Confirm' stage.
The milestone function is called without an explicit ordinal since people might use the stage
on different positions within their pipeline. When no ordinal is given, the last milestone ordinal
value will be increased by 1.
Note: Confirming a build will still abort all older builds waiting at the Confirm stage.
2020-10-07 10:56:25 +02:00
Daniel Mieg
fe1fc7bd69
Fix EOF http issue ( #2134 )
2020-10-07 08:46:12 +02:00
Christopher Fenner
f07f7a34b8
chore(detect): add error category for config issues ( #2130 )
2020-10-06 14:22:35 +02:00
Anil Keshav
627769f9c1
modifying detect.maven.excluded.scopes from TEST to test ( #2129 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-10-06 13:32:52 +02:00
Christopher Fenner
5e2e303342
chore(sonar): add error category ( #2127 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-10-06 12:24:34 +02:00
Christopher Fenner
6aa3e514e1
chore(detect): add error category for policy violations ( #2125 )
...
* chore(detect): add error category for policy violations
* Update detectExecuteScan.go
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-10-06 11:55:05 +02:00
Daniel Mieg
1e0e230be8
Adapt pipeline docu ( #2096 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-10-06 11:00:19 +02:00
Christopher Fenner
17a5b477a0
fix(cfDeploy): mark dockerUsername as secret ( #2102 )
...
* make dockerUsername secret
* regenerate sources
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-10-06 08:59:20 +02:00
Daniel Kurzynski
f5b19a79e4
Infer project name ( #2119 )
...
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-10-05 19:34:43 +02:00
Dominik Finkbeiner
ecbc2d4b0f
remove travis badge ( #2109 )
...
Travis seems to be not used anymore
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-10-05 18:09:13 +02:00
Oliver Nocon
e497b0050a
improve error categorization ( #2118 )
2020-10-05 17:46:44 +02:00
Christopher Fenner
be90876b7c
feat(output): handle non-string output values ( #2113 )
...
* handle non-string values as JSON
* change value type to interface in resources
* regenerate code
* add test cases
* handle reading of json files
* write json data to json files
* fix assignment
* use GetResourceParameter
* add test case
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-10-05 15:33:28 +02:00
Dominik Lendle
703f8e921e
Mass enabling for pullGitRepo & checkoutBranch steps ( #2005 )
2020-10-05 14:38:35 +02:00
Oliver Feldmann
19f45aa687
Move setting git info in cpe from stage init to setupCPE step ( #2083 )
...
* Move setting git info in cpe
Everything cpe related should be done in setupCommonPipelineEnvironment.
Thus a new parameter was introduced to accept the scmInfo object
returned by a checkout.
* Improve documentation
2020-10-05 12:50:03 +02:00
Stephan Aßmus
6379c25409
Forward config-related params to setupCommonPipelineEnvironment ( #2117 )
2020-10-05 12:12:06 +02:00
Florian Wilhelm
f34d515a88
Automated go dependency update ( #2115 )
...
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2020-10-05 10:14:50 +02:00
Oliver Nocon
0fb7ee5488
fix: Checkmarx project creation ( #2112 )
...
* fix : allow creation of Checkmarx projects
* checkmarx: fix project creation
* do not swallow error
* fix preset error handling
2020-10-05 08:16:18 +02:00
Daniel Mieg
ae213a013e
Add stages for build process to ABAP Environment Pipeline ( #2052 )
...
* Add stages for build process
* fix typo
* Add createServiceKey to Build stage
* Fix typo
* Inital Checks is required when Build stage is exec
* Switch Order
* Fix Typo
* Add parameter for confirmation
* add "addIfEmpty"
* Add import
* revert
* revert2
* Remove import
* revert3
* Add stages to docu
* Update image
2020-10-02 17:03:43 +02:00
Kevin Hudemann
91067d219a
Fix Cloud SDK Pipeline stash settings for security stage ( #2114 )
...
This change fixes the stash settings for the security stage in Cloud
SDK Pipeline. Previously, the SOURCES stash was not unstashed, thus
potentially existing extensions could not be found.
2020-10-02 15:52:16 +02:00
Christopher Fenner
9341ae4934
chore(sonar): assign error categories to know error cases ( #2111 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-10-02 15:08:08 +02:00
Marcus Holl
b2b4278b34
Provide Additional pod properties for dockerExecuteOnKubernetes ( #2051 )
...
Provide additional pod properties for dockerExecuteOnKubernetes
Co-authored-by: Kay Wegner <kay.wegner@sap.com>
2020-10-02 12:56:16 +02:00
Christopher Fenner
9992881c37
chore(git): add binary file to ignore list ( #2110 )
2020-10-02 11:15:36 +02:00
Christian Luttenberger
d2c420bfe7
Fix call issue to abap build framework ( #2108 )
...
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-10-02 10:06:33 +02:00
Kevin Hudemann
08a5189f39
Update Cloud SDK stash settings and stage defaults ( #2105 )
...
This change updates and cleans up the Cloud SDK specific stash settings
and stage defaults.
2020-10-02 09:05:42 +02:00
Oliver Nocon
9354697525
fix : allow creation of Checkmarx projects ( #2106 )
2020-10-01 17:08:07 +02:00
Marcus Holl
75a35fb35a
Improve logging wrt the docker image used for launching piper-go ( #1578 )
...
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-10-01 16:27:50 +02:00
Oliver Nocon
911a88bd49
fortify: fix semver for pip ( #2104 )
2020-10-01 14:47:08 +02:00
Oliver Nocon
b506235398
detect: add parameter aliases ( #2099 )
...
* align parameters for Detect
* include feedback
* update generation and formatting
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
2020-10-01 13:34:51 +02:00
Christopher Fenner
5eb4c9de29
refactor(sonar): align serverUrl with other steps ( #2090 )
...
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
2020-10-01 11:45:14 +02:00
Daniel Kurzynski
265541354d
Archive debug report in piper post action stage ( #2101 )
2020-10-01 10:14:14 +02:00
Christian Luttenberger
7a028c4149
Refactor build framework steps ( #2068 )
...
* adding my steps
* messy step
* Update abapEnvironmentAssembly.go
* clean up
* change yaml
* corrections
* Update cloudFoundryDeploy.go
* update
* delete simulation step
* remove simulate
* Update PiperGoUtils.groovy
* Update PiperGoUtils.groovy
* Update CommonStepsTest.groovy
* add docu
* Update abapEnvironmentAssembly.md
* changes due to PR
* Update .gitignore
* b
* CV list
* Update abapEnvironmentAssembly.go
* testing with simulation
* Update abapEnvironmentAssembly.go
* remove simulation
* renaming
* Update mkdocs.yml
* moving service key to yaml and fixing code climate
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* change input
* Update abapEnvironmentAssemblePackages.go
* change json tag
* fixed error handling
* documentation
* Update abapEnvironmentAssemblePackages.md
* Update abapEnvironmentAssemblePackages.md
* fixing code climate issues
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* adding unittests
* adding unittests and improved logging
* yaml -> json
* change scope of cfServiceKeyName
* correct indentation
* Update CommonStepsTest.groovy
* maintain correct step order
* Move Connector to connector.go
* Refactor bfw with unit tests
* remove spaces
* CodeClimate Fix for unexported type
* ABAP BF - Adding Error Handling Unmarshal
* Revert Unmarshal
Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Koerner <tilo.koerner@sap.com>
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
2020-09-30 16:40:36 +02:00
Christopher Fenner
b16f0428e1
docs: make used library and binary name in samples exchangeable for custom steps ( #2092 )
...
* add code block type
* add parameters to hand in library and binary name
* use library and binary name parameters
* add test cases
* use yaml file to distintuish custom from regular steps
* add test case
2020-09-30 15:02:00 +02:00
Marcus Holl
93cac1a2f4
Clarify: transportRequestId can only be provided via signature ( #1378 )
...
Clarify: transportRequestId can only be provided via signature
2020-09-30 14:29:46 +02:00
Marcus Holl
bed3ec1e28
[refactoring] Avoid having simiar dockerExecuteOnKubernetes call twice. ( #2067 )
...
Having that like this increases maintainability.
2020-09-30 13:44:40 +02:00
Marcus Holl
0a17ed561e
make unstash work for parallel executions ( #2095 )
...
without 'int' in a 'for (i = 0; ...)' loop 'i' is
a global variable and the value gets inside some parallel
execution randomly incremented from the parallel threads.
Defining it with the keyword 'int' makes it a method local
variable which does not change its value 'randomly'.
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-09-30 13:10:40 +02:00
Stephan Aßmus
fc55d02230
Fix conditions for whitesourceExecuteScan ( #2097 )
2020-09-30 12:37:01 +02:00
tiloKo
61dfa9d3d9
AAKaaS check steps to run without prior PV input ( #2091 )
...
* adding my steps
* messy step
* Update abapEnvironmentAssembly.go
* clean up
* change yaml
* corrections
* Update cloudFoundryDeploy.go
* update
* delete simulation step
* remove simulate
* Update PiperGoUtils.groovy
* Update PiperGoUtils.groovy
* Update CommonStepsTest.groovy
* add docu
* Update abapEnvironmentAssembly.md
* changes due to PR
* Update .gitignore
* b
* CV list
* Update abapEnvironmentAssembly.go
* testing with simulation
* Update abapEnvironmentAssembly.go
* remove simulation
* renaming
* Update mkdocs.yml
* moving service key to yaml and fixing code climate
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* Update abapEnvironmentAssemblePackages.go
* change input
* Update abapEnvironmentAssemblePackages.go
* change json tag
* fixed error handling
* documentation
* Update abapEnvironmentAssemblePackages.md
* Update abapEnvironmentAssemblePackages.md
* fixing code climate issues
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* fixing code climate issues
* Update abapEnvironmentAssemblePackages.yaml
* adding unittests
* adding unittests and improved logging
* yaml -> json
* change scope of cfServiceKeyName
* correct indentation
* Update CommonStepsTest.groovy
* maintain correct step order
* AAKaaS Checks as First Step
* remove old coding
Co-authored-by: rosemarieB <45030247+rosemarieB@users.noreply.github.com>
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Chris <42861202+bluesbrother84@users.noreply.github.com>
2020-09-30 10:30:53 +02:00
Srinikitha Kondreddy
4fec440030
Fix typo ( #2086 )
2020-09-30 09:35:36 +02:00
Florian Wilhelm
e8f49df6a3
Optionally use new go-based Whitesource step ( #2079 )
2020-09-30 08:56:16 +02:00
Sven Merk
58b6c04cd2
Update fortifyExecuteScan.go ( #2093 )
...
* Update fortifyExecuteScan.go
* Update fortifyExecuteScan.go
* Docs are lying
Checked the API which returns a status similar to that of artifact
* Update fortifyExecuteScan_test.go
2020-09-29 18:26:16 +02:00
Kevin Hudemann
b47e08781c
Remove absolute links from Cloud SDK docs section ( #2089 )
2020-09-29 14:23:46 +02:00
Oliver Nocon
19c1732826
Telemetry: report error category ( #2085 )
2020-09-29 13:49:40 +02:00
Stephan Aßmus
54ea3ed51a
whitesourceExecuteScan: bypass UA for mta, maven, npm and yarn ( #1879 )
...
Co-authored-by: Florian Wilhelm <florian.wilhelm02@sap.com>
2020-09-29 12:44:31 +02:00
Kevin Hudemann
e2aea73022
Preparation to switch to piperPipelineStageSecurity for Cloud SDK pipeline ( #2082 )
...
Updates containersMap, stash settings, stage defaults and legacy config settings.
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-09-29 12:25:57 +02:00
Kevin Hudemann
b3a5d1e55e
Update Cloud SDK documentation ( #2081 )
...
This change updates the Cloud SDK documentation with the changes of migrating to
the piperPipelineStageInit and update the legacy configuration settings accordingly.
In addition, it fixes the documentation of the step debugReportArchive and includes
it in the list of library steps.
2020-09-29 11:26:55 +02:00
Oliver Nocon
15b3957137
checkmarxExecuteScan: update error handling ( #2084 )
...
* checkmarxExecuteScan: update error handling
* Update cmd/checkmarxExecuteScan.go
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
* include PR feedback
Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-09-29 09:23:31 +02:00
Christopher Fenner
b2e345f4dc
docs: add note about Jenkins credentials ( #2078 )
...
* add note about Jenkins credentials
* remove copy&paste issue
* Update parameters.go
2020-09-28 11:45:21 +02:00
Kevin Hudemann
80250ab2b9
Extend piperPipelineStageInit to support init of Cloud SDK ( #2062 )
...
This change adds necessary functionality to support initialization of
Cloud SDK pipelines. In addition, it adds the support to check the
pipeline configuration for legacy configuration parameters.
2020-09-28 10:44:56 +02:00
Kevin Hudemann
a075526d15
Extend piperPipelineStageSecurity to run detectExecuteScan step ( #2069 )
...
This change adds the detectExecuteScan step to the
piperPipelineStageSecurity.
2020-09-28 09:56:57 +02:00