1
0
mirror of https://github.com/SAP/jenkins-library.git synced 2025-02-05 13:25:19 +02:00

4976 Commits

Author SHA1 Message Date
Valentin
93c4ea61aa
Revert "Fix deployment failure with CF if password contains special char (#5197)" (#5215)
This reverts commit 8205624a22920f2ebe1e7999bf1b384aeae04e5d.

Co-authored-by: Valentin Uchkunev <valentin.uchkunev@sap.com>
v1.415.0
2024-12-23 12:33:12 +01:00
Jordi van Liempt
aa1e67547a
chore(trustengine): Rename Trust Engine to System Trust in logs and docs (#5210)
* rename Trust Engine to System Trust

* Revert "rename Trust Engine to System Trust"

This reverts commit 66d4680324310790d41b70eed7421d121aac0e03.

* rename Trust Engine to System Trust in logs and docs
v1.414.0
2024-12-19 13:31:42 +00:00
Manjunath
8205624a22
Fix deployment failure with CF if password contains special char (#5197)
* Fix deployment failure with CF if password contains special char
* cf service test

* combined darwin and linux test, remove duplicate test

* escape username special characters

* fix build errors

* added missing build tags

* refactor abaputils
2024-12-18 11:21:56 +02:00
Valentin
dfd947b7e1
Update go version to 1.23 and removed some helper methods in favor of STD library (#5200)
* update go version

* fix go vet errors

* replaces stringutils with slices std package

* added slices package

* 1.22.4 to 1.23.4

---------

Co-authored-by: Valentin <valentin.uchkunev@sap.com>
v1.412.0 v1.413.0
2024-12-12 17:32:12 +02:00
Akramdzhon Azamov
e927605254
Added validation for buildTool and buildDescriptorFile (#5193)
* Added validation for buildTool and buildDescriptorFile on whitesourceExecuteScan step

* fix pull request's comment

---------

Co-authored-by: Dmitrii Pavlukhin <dmitrii.pavlukhin@sap.com>
2024-12-12 16:24:03 +03:00
Marcus Holl
055a413d21
Unstash class files for Compliance stage (#5192) (#5204) 2024-12-11 14:29:41 +01:00
Ivan Nikiforov
a206df2fdf
fix(documentation): check param for jenkinsParams before appending Jenkins-specific text (#5203)
* Check for jenkinsParams before appending Jenkins-specific text

* go fmt

---------

Co-authored-by: Ivan Nikiforov <ivan.nikiforov@sap.com>
2024-12-11 13:04:58 +05:00
Ashly Mathew
ec77db1aa8
Align description of ADO and GHA (#5202)
* Align description of ADO and GHA

* Update description.go

---------

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2024-12-09 10:36:58 +01:00
Marcus Holl
a70422c93d
Revert "Unstash class files for Compliance stage (#5192)" (#5201)
This reverts commit 28fb2b77bf7ba6af5000955e1664b8d3ec12195d.
v1.411.0
2024-12-09 08:31:36 +01:00
maxcask
97049db02f
fix passing default params to Central Build stage steps (#5199)
* duplicate config for Build name leave go changes only
2024-12-09 10:44:44 +04:00
Ashly Mathew
e8d745052a
Modify document generator to include GHA (#5190)
* include GHA in documentation

* add some missing GHA places

* add some missing GHA places

* Correct step description
2024-12-03 11:01:48 +01:00
Marcus Holl
28fb2b77bf
Unstash class files for Compliance stage (#5192) v1.410.0 2024-12-03 08:31:22 +01:00
Googlom
53838c0ecc
disable trust engine lookup on missing token (#5196) 2024-12-02 17:38:53 +05:00
Ivan Nikiforov
6d22b09ab3
Use mavenBuild.projectSettingsFile from config (#5194)
Co-authored-by: Ivan Nikiforov <ivan.nikiforov@sap.com>
Co-authored-by: phgermanov <phgermanov@gmail.com>
2024-12-02 13:20:41 +02:00
Christopher Fenner
57e4f1130a
fix(docs): correct anchor (#5191)
* Update cnbBuild.yaml

* Update cnbBuild_generated.go
v1.409.0
2024-12-02 09:06:17 +01:00
Simon Dold
eeaeb1e40b
Adding general scope to logOutput (#5189)
* adding general scope

* change generated files

---------

Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2024-11-28 09:38:25 +00:00
thtri
cd20114ca4
CxONE: search project name by exact match (#5187)
* Initial in progress

* compiling but not yet functional

* Missed file

* updated checkmarxone step

* Working up to fetching a project then breaks

* Missed file

* Breaks when retrieving projects+proxy set

* Create project & run scan working, now polling

* Fixed polling

* added back the zipfile remove command

* Fixed polling again

* Generates and downloads PDF report

* Updated and working, prep for refactor

* Added compliance steps

* Cleanup, reporting, added groovy connector

* fixed groovy file

* checkmarxone to checkmarxOne

* checkmarxone to checkmarxOne

* split credentials (id+secret, apikey), renamed pullrequestname to branch, groovy fix

* Fixed filenames & yaml

* missed the metadata_generated.go

* added json to sarif conversion

* fix:type in new checkmarxone package

* fix:type in new checkmarxone package

* removed test logs, added temp error log for creds

* extra debugging to fix crash

* improved auth logging, fixed query parse issue

* fixed bug with group fetch when using oauth user

* CWE can be -1 if not defined, can't be uint

* Query also had CweID

* Disabled predicates-fetch in sarif generation

* Removing leftover info log message

* Better error handling

* fixed default preset configuration

* removing .bat files - sorry

* Cleanup per initial review

* refactoring per Gist, fixed project find, add apps

* small fix - sorry for commit noise while testing

* Fixing issues with incremental scans.

* removing maxretries

* Updated per PR feedback, further changes todo toda

* JSON Report changes and reporting cleanup

* removing .bat (again?)

* adding docs, groovy unit test, linter fixes

* Started adding tests maybe 15% covered

* fix(checkmarxOne): test cases for pkg and reporting

* fix(checkmarxOne):fix formatting

* feat(checkmarxone): update interface with missing method

* feat(checkmarxone):change runStep signature to be able to inject dependency

* feat(checkmarxone): add tests for step (wip)

* Adding a bit more coverage

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix integration test PR

* adding scan-summary bug workaround, reportgen fail

* enforceThresholds fix when no results passed in

* fixed gap when preset empty in yaml & project conf

* fixed another gap in preset selection

* fix 0-result panic

* fail when no preset is set anywhere

* removed comment

* initial project-under-app support

* fixing sarif reportgen

* some cleanup of error messages

* post-merge test fixes

* revert previous upstream merge

* adding "incremental" to "full" triggers

* wrong boolean

* project-in-application api change prep

* Fixing SARIF report without preset access

* fix sarif deeplink

* removing comments

* fix(cxone):formatting

* fix(cxone):formatting

* small sarif fixes

* fixed merge

* attempt at pulling git source repo branch

* fix(cxone):new endpoint for project creation

* fix(cxOne): taxa is an array

* fix(cxOne): get Git branch from commonPipelineEnvironment

* fix(cxOne): add params to tag a scan and a project

* fix(cxOne): unit test - update project

* fix(cxOne): unit test - update project tags

* fix(cxOne): improve logs

* fix(cxOne): improve logs

* adding RequestNewPDFReport function using v2 api

* added version check

* fix(cxone): JSON report using v2 API

* update to set reportType in v2 reportgen

* fix(checkmarxOneExecuteScan): remove absolute patch for code preview

* fix(checkmarxOneExecuteScan): remove SCA confusion from driver name

* fix(checkmarxOneExecuteScan): search project name by exact match

* fix(checkmarxOneExecuteScan): escape branch name in deeplink

* fix(checkmarxOneExecuteScan): fix format

---------

Co-authored-by: michael kubiaczyk <michael.kubiaczyk@checkmarx.com>
Co-authored-by: michaelkubiaczyk <48311127+michaelkubiaczyk@users.noreply.github.com>
Co-authored-by: sumeet patil <sumeet.patil@sap.com>
Co-authored-by: Adrien <99400874+hubadr@users.noreply.github.com>
v1.408.0
2024-11-27 15:54:19 +01:00
Manjunath
62a5eda322
Updated help from 3.14.2 to 3.14.4 (#5188) 2024-11-27 13:57:54 +01:00
Manjunath
2493687e16
Updated all instances of circl to 1.3.7 (#5186) 2024-11-27 13:13:53 +01:00
maxcask
91823b9e08
fix(config): move Central Build stage config to Build stage for custom defaults (#5182)
* rename stage on ApplyAliasConfig func rename stage after applying alias

---------

Co-authored-by: maxcask <maxcask@gmail.com>
Co-authored-by: Googlom <alimovgb@gmail.com>
2024-11-27 11:48:54 +04:00
Christopher Fenner
e462d324e4
fix(docs): fix doc anchor (#5177)
* Update fortifyExecuteScan.yaml

* Update whitesourceExecuteScan.yaml

* Update protecodeExecuteScan.yaml

* Update sonarExecuteScan.yaml

* Update detectExecuteScan.yaml

* Update fortifyExecuteScan_generated.go
2024-11-27 08:16:27 +01:00
Manjunath
9bcf8ee50c
Update circl from 1.3.3 to 1.5.0 (#5185) 2024-11-26 15:15:10 +01:00
Manjunath
cd548193a0
Renamed maven simple bom to skip uploading to cumulus (#5180) v1.407.0 2024-11-22 14:04:12 +01:00
Googlom
f044ef106d
fix(curl): Remove --insecure flag from curl when downlaoding Piper binary (#5179)
* remove --insecure flag from binary download

* remove --insecure flag from binary download

* adjust unit tests
2024-11-21 13:30:03 +05:00
maxcask
10f535c8fa
fix handle new naming strategy for Central Build stage name if extension is used (#5178)
* handle extension filename

---------

Co-authored-by: maxcask <maxcask@gmail.com>
Co-authored-by: Googlom <alimovgb@gmail.com>
2024-11-19 11:58:55 +04:00
Ralf Pannemans
f54dbfd433
Remove commit message from project-metadata.toml (#5176) v1.406.0 2024-11-18 09:51:35 +01:00
maxcask
758d10b06e
handle new naming strategy for Central Build stage name (#5171)
* config helper rename

* rename in name provider 
---------

Co-authored-by: maxcask <maxcask@gmail.com>
2024-11-12 15:33:38 +04:00
christian
1edf8299f3
Update URL to current SapMachine (#5126)
* Update URL to recent SapMachine

11.0.2 in from Jan2019 := 5 years old
use the recent version => 11.0.24

* 11.0.24 to 25

meanwhile 11.0.25 is the latest version

* update from 11.0.25 to stable 21 link

now to use https://sap.github.io/SapMachine/latest/21/linux-x64/jre/

* applied generated go code

* Update whitesourceExecuteScan.yaml

* from 21-latest to 17.0.13

to speed this up

* revert description

* generate for new url

---------

Co-authored-by: Harald Aamot <harald.aamot@sap.com>
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
v1.405.0
2024-11-08 09:40:51 +01:00
Adrien
9626bfca0d
checkmarxOneExecuteScan - Fix report generation in CxOne 3.20 (#5170)
* Initial in progress

* compiling but not yet functional

* Missed file

* updated checkmarxone step

* Working up to fetching a project then breaks

* Missed file

* Breaks when retrieving projects+proxy set

* Create project & run scan working, now polling

* Fixed polling

* added back the zipfile remove command

* Fixed polling again

* Generates and downloads PDF report

* Updated and working, prep for refactor

* Added compliance steps

* Cleanup, reporting, added groovy connector

* fixed groovy file

* checkmarxone to checkmarxOne

* checkmarxone to checkmarxOne

* split credentials (id+secret, apikey), renamed pullrequestname to branch, groovy fix

* Fixed filenames & yaml

* missed the metadata_generated.go

* added json to sarif conversion

* fix:type in new checkmarxone package

* fix:type in new checkmarxone package

* removed test logs, added temp error log for creds

* extra debugging to fix crash

* improved auth logging, fixed query parse issue

* fixed bug with group fetch when using oauth user

* CWE can be -1 if not defined, can't be uint

* Query also had CweID

* Disabled predicates-fetch in sarif generation

* Removing leftover info log message

* Better error handling

* fixed default preset configuration

* removing .bat files - sorry

* Cleanup per initial review

* refactoring per Gist, fixed project find, add apps

* small fix - sorry for commit noise while testing

* Fixing issues with incremental scans.

* removing maxretries

* Updated per PR feedback, further changes todo toda

* JSON Report changes and reporting cleanup

* removing .bat (again?)

* adding docs, groovy unit test, linter fixes

* Started adding tests maybe 15% covered

* fix(checkmarxOne): test cases for pkg and reporting

* fix(checkmarxOne):fix formatting

* feat(checkmarxone): update interface with missing method

* feat(checkmarxone):change runStep signature to be able to inject dependency

* feat(checkmarxone): add tests for step (wip)

* Adding a bit more coverage

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix integration test PR

* adding scan-summary bug workaround, reportgen fail

* enforceThresholds fix when no results passed in

* fixed gap when preset empty in yaml & project conf

* fixed another gap in preset selection

* fix 0-result panic

* fail when no preset is set anywhere

* removed comment

* initial project-under-app support

* fixing sarif reportgen

* some cleanup of error messages

* post-merge test fixes

* revert previous upstream merge

* adding "incremental" to "full" triggers

* wrong boolean

* project-in-application api change prep

* Fixing SARIF report without preset access

* fix sarif deeplink

* removing comments

* fix(cxone):formatting

* fix(cxone):formatting

* small sarif fixes

* fixed merge

* attempt at pulling git source repo branch

* fix(cxone):new endpoint for project creation

* fix(cxOne): taxa is an array

* fix(cxOne): get Git branch from commonPipelineEnvironment

* fix(cxOne): add params to tag a scan and a project

* fix(cxOne): unit test - update project

* fix(cxOne): unit test - update project tags

* fix(cxOne): improve logs

* fix(cxOne): improve logs

* adding RequestNewPDFReport function using v2 api

* added version check

* fix(cxone): JSON report using v2 API

* update to set reportType in v2 reportgen

---------

Co-authored-by: michael kubiaczyk <michael.kubiaczyk@checkmarx.com>
Co-authored-by: thtri <trinhthanhhai@gmail.com>
Co-authored-by: Thanh-Hai Trinh <thanh.hai.trinh@sap.com>
Co-authored-by: michaelkubiaczyk <48311127+michaelkubiaczyk@users.noreply.github.com>
Co-authored-by: sumeet patil <sumeet.patil@sap.com>
2024-11-07 15:14:04 +01:00
phgermanov
c1e800a770
docs: update pr template to include inner source update reminder (#5169) 2024-11-06 12:51:14 +02:00
Manjunath
364238f154
handle error while fetching working directory (#5168) v1.403.0 v1.404.0 2024-11-04 14:20:37 +01:00
Holger Partsch
d4e298464e
Final round of adding quoting to prevent command injection (#5167)
* refactor: use import alias

* fix: add quoting to further shell steps
2024-11-04 14:05:47 +01:00
phgermanov
6988f43f7f
feat: add build artifacts metadata for mtaBuild (#5166) 2024-11-04 12:30:39 +02:00
Holger Partsch
da609e1536
Fix more potential command injection via quoting (#5164)
* fix: make quoting null safe

* fix: apply quoting in artifact set version

* fix: add quoting to more shell step

* refactor: use import alias

* fix: further quoting

---------

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
v1.402.0
2024-10-30 11:59:47 +01:00
Manjunath
183004a80d
Add identifier data to create uuid in events (#5165) v1.401.0 2024-10-29 08:39:34 +01:00
Vyacheslav Starostin
d6aaf43fae
Update version of org.cyclonedx:cyclonedx-maven-plugin (#5156)
* Update version of org.cyclonedx:cyclonedx-maven-plugin

* Update version of org.cyclonedx:cyclonedx-maven-plugin

---------

Co-authored-by: Googlom <36107508+Googlom@users.noreply.github.com>
v1.399.0 v1.400.0
2024-10-25 14:07:28 +05:00
Srinikitha Kondreddy
f9dc47e47e
Fix: validate app name (#5155) 2024-10-25 09:53:55 +02:00
Holger Partsch
8b4109bf85
fix: command injection vulnerability (#5161)
due to missing quoting, command injection was possible via
pipeline configuration.

This is now fixed using a quoting and escaping utility.

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2024-10-24 17:29:40 +02:00
Googlom
0c41f9c141
fix deadlock and add more logging (#5160) 2024-10-24 14:08:09 +05:00
Googlom
4990b2d0ba
fix(sonar): allign groovy part of Sonar step with common piperExecuteBin (#5157)
* add some logging to Vault login

* allign groovy part of the sonar step

* Revert "add some logging to Vault login"

This reverts commit d1738c124d2c1fbfb5becaad2a28dafcef4574fc.
2024-10-24 09:47:32 +02:00
Googlom
7b7ba77436
modify logging (#5158) 2024-10-23 17:32:37 +05:00
Akramdzhon Azamov
7b08d47bcb
Detect script version 9 (#5154)
* detect script v9 as default and detect script v8 as optional for blackduck

* unit test fix

---------

Co-authored-by: Dmitrii Pavlukhin <dmitrii.pavlukhin@sap.com>
2024-10-23 12:09:15 +03:00
Anil Keshav
3ad2628095
feat(vault): not allowing batch token revoke (#4918)
* not allowing batch token revoke

* chaging values to hold variable name

* error message when identifying service token

* refactor

---------

Co-authored-by: Googlom <alimovgb@gmail.com>
v1.398.0
2024-10-22 13:50:32 +05:00
Googlom
5c47be3f8f
refactor(vault): Refactor vault package (#5148)
* move to old package

* go mod

* remove old

* refactor done

* Update pkg/vault/oidc.go

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>

* commit suggestions

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>

* commit suggestions

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>

* commit suggestions

---------

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2024-10-22 13:29:34 +05:00
maxcask
4eb1756b54
fix(Central Build): Fix handling legacy stage name for Jenkins pipelines (#5151)
* add handle stageName

* some improvements

---------

Co-authored-by: maxcask <maxcask@gmail.com>
Co-authored-by: Googlom <alimovgb@gmail.com>
Co-authored-by: Googlom <36107508+Googlom@users.noreply.github.com>
v1.397.0
2024-10-21 12:23:50 +04:00
Dmitrii Pavlukhin
769067e996
added-option-to-use-global-config-file (#5145) 2024-10-18 17:06:41 +03:00
Adrien
b317b1d1eb
Add debug log for zip file content (#5152)
Co-authored-by: thtri <thanh.hai.trinh@sap.com>
2024-10-17 17:16:14 +02:00
Ivan Nikiforov
34a60daad1
Update documentation for scriptArguments param (#5128)
* Update documentation for scriptArguments param

* Update resources/metadata/shellExecute.yaml

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>

* Update doc with new examples

* Fix typo

---------

Co-authored-by: Ivan Nikiforov <ivan.nikiforov@sap.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2024-10-16 16:09:51 +02:00
Manjunath
e1563e0237
Add additional info to coordinates (#5149) v1.396.0 2024-10-16 14:10:52 +02:00
Ivan Nikiforov
36c555ea61
fix: too long string written to cpe git.commitMessage (#5147)
* fix too long CPE string written to git/commitMessage

* Add debug log

* Fix debug log

* Truncate long git commit message title

* Add tests for truncateString

* Fix test

* Fix tests

* Fix tests

---------

Co-authored-by: Ivan Nikiforov <ivan.nikiforov@sap.com>
2024-10-16 13:45:23 +02:00