Marcus Holl
aa900d7dcf
withMandatoryParameter supports a error message from the caller
2018-06-29 11:15:37 +02:00
Alejandra Ferreiro Vidal
cc9332ae79
Merge pull request #175 from alejandraferreirovidal/changeParameters
...
change credentialsId and endpoint
2018-06-29 10:12:58 +02:00
Marcus Holl
3766bf4794
Merge pull request #166 from marcusholl/cm
...
isChangeInDevelopment
2018-06-29 08:25:15 +02:00
Marcus Holl
1a815c32cd
Merge pull request #165 from marcusholl/pr/scriptCallRuleWithRegex
...
Return a return value based on a regex comparism
2018-06-29 08:24:37 +02:00
Alejandra Ferreiro Vidal
ab8a1bb837
change credentialsId and endpoint
2018-06-28 16:24:14 +02:00
Marcus Holl
cb5a98bf11
Merge pull request #174 from marcusholl/pr/changeDocumentId
...
Change parameter name 'changeId' to 'changeDocumentId'
2018-06-28 16:00:19 +02:00
Marcus Holl
1493393805
Improve log message in case a call to cmclient for getting change status fails.
2018-06-28 15:37:14 +02:00
Marcus Holl
bdef708522
Assert logging
2018-06-28 15:37:14 +02:00
Marcus Holl
7eba5b6915
Provide method for retrieving changeDocumentId from config or via git commits.
2018-06-28 15:37:13 +02:00
Marcus Holl
6d943d2005
Support CMCLIENT_OPTS
...
needed e.g. for providing a trust store.
2018-06-28 15:37:13 +02:00
Marcus Holl
5d0ffa3e69
Make use of unified cmCommandLine
2018-06-28 15:37:13 +02:00
Marcus Holl
38c6d35adb
Introde getCMCommandLine
2018-06-28 15:37:13 +02:00
Marcus Holl
fd945b40e7
Provide docu for checkChangeInDevelopment
2018-06-28 15:37:13 +02:00
Marcus Holl
9d0eb79d94
filter null values from changeId array.
2018-06-28 15:37:13 +02:00
Marcus Holl
c494e33c1d
Tests for isChangeInDevelopment
2018-06-28 15:37:13 +02:00
Marcus Holl
37ba20d060
more tests
2018-06-28 15:37:13 +02:00
Marcus Holl
00304d67db
[refactoring] getting the gitUtils mock
2018-06-28 15:37:12 +02:00
Marcus Holl
cdb26e6b91
Introduce test for pipeline step checkChangeInDevelopment
2018-06-28 15:37:12 +02:00
Alejandra Ferreiro Vidal
8eb8f23069
Create new instance of GitUtils in case there is no provided from outside
2018-06-28 15:37:12 +02:00
Marcus Holl
9adad5ba37
Get changeDocumentId from git commits.
2018-06-28 15:37:12 +02:00
Marcus Holl
2465fcb3dd
introduce step isChangeInDevelopment
2018-06-28 15:37:11 +02:00
Marcus Holl
d8dca885bb
Change parameter name 'changeId' to 'changeDocumentId'
...
the official term in SAP-SolutionManager is 'change document'.
The term 'change' as reflected in 'changeId' is ambigous and could also be understand in the
sense of a change in a revision control system.
Choosing appropriate terms for parameters here deceases the amount of documentation
required for explaining what is really denoted by the parameter.
2018-06-28 13:46:00 +02:00
Marcus Holl
dd456f0d00
Return a return value based on a regex comparism
...
Comparism on plain string level gets complicated for complex commands and means
an implict check for an exact version of a command line. There are cases where
such an exact check is not desired, e.g. there is nothing wrong with having the
order of arguments variable.
2018-06-28 13:38:48 +02:00
Marcus Holl
415c0c4396
add isChangeInDevelopment
2018-06-28 13:38:48 +02:00
Christopher Fenner
04d8ebdbd8
correct coverage badge
2018-06-27 15:06:52 +02:00
Christopher Fenner
cd10eed0c3
fix test issue on Windows
2018-06-27 14:56:50 +02:00
Christopher Fenner
44ff690a77
fix test issue on Windows
2018-06-27 14:38:57 +02:00
Christopher Fenner
70f7e5a6fa
fix test issue on Windows
2018-06-27 14:28:16 +02:00
Christopher Fenner
251f731ca8
fix test issue on Windows
2018-06-27 14:19:40 +02:00
Marcus Holl
95520331e1
Merge pull request #168 from SAP/CCFenner/snykExecute
...
add step for snyk open source vulnerability scan
2018-06-27 10:11:34 +02:00
Christopher Fenner
7058661f9f
remove obsolete parameter
2018-06-27 10:02:02 +02:00
Alejandra Ferreiro Vidal
8fad2eb339
Merge pull request #171 from marcusholl/pr/addTransportRelatedStepsToDocuIndex
...
Add new transport related steps to documentation index
2018-06-27 09:59:45 +02:00
Christopher Fenner
bc84497b24
remove obsolete parameter
2018-06-27 09:59:44 +02:00
Christopher Fenner
d0552cfbfd
remove obsolete parameter
2018-06-27 09:59:14 +02:00
Christopher Fenner
267f5f6936
use default image / workspace
2018-06-27 09:52:32 +02:00
Christopher Fenner
6cb7adac59
add node as default docker image
2018-06-27 09:51:27 +02:00
Marcus Holl
d9cdc9af42
Merge pull request #169 from marcusholl/pr/gitUtilsParameterSanityCheck
...
GitUtils: sanity check for parameters handed over via signature
2018-06-27 09:35:06 +02:00
Marcus Holl
23e5c9de6e
Add new transport related steps to documentation index
2018-06-26 16:32:01 +02:00
Christopher Fenner
dbcf87ffcc
rename exclude parameter
2018-06-26 16:08:03 +02:00
Christopher Fenner
6bcf17c70a
add snyk html report
2018-06-26 16:05:43 +02:00
Christopher Fenner
b44ebf99d1
add snyk html report
2018-06-26 16:00:26 +02:00
Christopher Fenner
957ca11d7b
add snyk html report
2018-06-26 15:47:46 +02:00
Christopher Fenner
f9d4fbda53
correct step name
2018-06-26 15:34:32 +02:00
Christopher Fenner
426f23b232
add step tests
2018-06-26 15:08:46 +02:00
Marcus Holl
6a97c3bb3e
GitUtils: sanity check for parameters handed over via signature
2018-06-26 14:51:26 +02:00
Marcus Holl
eb5461a8f1
Merge pull request #162 from alejandraferreirovidal/addCmClient
...
Add cm client
2018-06-26 14:15:21 +02:00
Christopher Fenner
a448698427
fix method name
2018-06-26 13:18:21 +02:00
Christopher Fenner
89d6e13d00
fix method name
2018-06-26 13:17:12 +02:00
Alejandra Ferreiro Vidal
4464c9427b
add step transportRequestRelease
2018-06-26 10:40:08 +02:00
Alejandra Ferreiro Vidal
12652be421
add step transportRequestUploadFile
2018-06-26 10:40:07 +02:00