1
0
mirror of https://github.com/SAP/jenkins-library.git synced 2024-12-14 11:03:09 +02:00
Commit Graph

1811 Commits

Author SHA1 Message Date
Marcus Holl
abdfa7b201 [refactoring] Increase readabiliy: inline rules without references 2019-05-15 17:03:41 +02:00
Marcus Holl
ed328b75af
Merge pull request #701 from marcusholl/pr/defensiveCopy
Provide a deep config copy from ConfigHelper.use()
2019-05-15 15:06:09 +02:00
Marcus Holl
f38729c5eb Merge remote-tracking branch 'github/master' into HEAD 2019-05-15 14:23:38 +02:00
Marcus Holl
a0649aa63f Explain what 'deepCopy' means 2019-05-15 14:21:19 +02:00
Marcus Holl
331c4bfd1a
Merge pull request #698 from marcusholl/pr/DoNotReturnWrongValueIfOnlyAPartOfAPathCanBeResolved
[fix] do not return a wrong config value if only a part of the path c…
2019-05-15 10:26:43 +02:00
Christopher Fenner
2fed3f231f
Merge branch 'master' into pr/DoNotReturnWrongValueIfOnlyAPartOfAPathCanBeResolved 2019-05-15 10:16:09 +02:00
Marcus Holl
9d43f7abb3 [fix] do not return a wrong config value if only a part of the path could be resolved. 2019-05-15 09:30:21 +02:00
Marcus Holl
0431c29063 Fix exception list for step neoDeploy (#697)
due to wrong indentation in the md file the excpetions are not rendered as expected. The reasons
why an exception occures is on the same level like the exception, but should have only level more.
2019-05-14 12:56:47 +02:00
Marcus Holl
7a7fd3ebab Provide a deep config copy from ConfigHelper.use()
The config map prepared by ConfigHelper is a mix from several configuration levels. The lowest config level
(DefaultValueCache) is shared between several ConfigHelper invocations. In case a Map or Collection which is
inherited from the DefaultValueCache level gets modified, this is also visible for all subsequent steps. This
causes trouble and situation which are hard to debug.

With this change here each invocation of ConfigHelper.use() provides a deep defensive copy. With that we can
ensure that there is no configuration update from one step to another.
2019-05-14 12:43:18 +02:00
Christopher Fenner
c52d1ceb0d
add Sonar docs link (#704) 2019-05-14 10:59:52 +02:00
Christopher Fenner
c8f9db71eb
add step for Sonar scan (#183)
* add new step sonarExecute

* simplify list

* add general credentials for SonarQube

* Update default_pipeline_environment.yml

* Update sonarExecute.groovy

* correct worker invocation

* switch step/stage config order

* add tests

* add webhook handling

* Update default_pipeline_environment.yml

* use withMandatoryProperty with condition

* Update ConfigurationHelper.groovy

* Update sonarExecute.groovy

* Update ConfigurationHelper.groovy

* rename step to sonarExecuteScan

* rename step to sonarExecuteScan

* rename step to sonarExecuteScan

* Update sonarExecuteScan.groovy

* change return type

* Update sonarExecuteScan.groovy

* stash

* update defaults

* update install path

* use quiet unzip

* use long option names

* optimize filename retrival

* rework PR voting

* fix path

* remove accitentially checked-in file

* add documentation, optimise coding

* correct test case

* add documentation

* remove option prefix

* rename config variable

* update docs

* update docs

* rename download url

* fix typo

* adjust test cases

* add test cases

* update docs
2019-05-13 12:29:07 +02:00
Marcus Holl
f9047bc37a
Merge pull request #616 from marcusholl/pr/neoLogInAnyFailureCase
provide the log in case of a failure always, not only in docker context
2019-05-10 09:26:37 +02:00
Marcus Holl
cdc9e2c266 Merge remote-tracking branch 'github/master' into HEAD 2019-05-10 08:44:51 +02:00
Oliver Nocon
729cd0ab30
detectExecuteScan - add doc to docs structure (#699) 2019-05-10 08:06:38 +02:00
Christopher Fenner
8a55e25f72
add Slack notification to Init and Post stage (#691)
* add Slack notification to post stage

* add Slack notification to init stage

* add trigger condition for Slack notification

* fix whitespaces

* use capital stage name

* add tests for init stage

* remove unused import

* add tests for post stage

* minor changes

* fix typo
2019-05-10 06:47:44 +02:00
Marcus Holl
46367263b6 Merge remote-tracking branch 'github/master' into HEAD 2019-05-09 15:49:26 +02:00
Marcus Holl
0e3f498761
Merge pull request #683 from alejandraferreirovidal/cleanNeoDeployTest
remove parameters not related to deployMode='warPropertiesFile'
2019-05-09 15:43:49 +02:00
Marcus Holl
fb22711c2a Merge remote-tracking branch 'github/master' into HEAD 2019-05-09 15:29:45 +02:00
Alejandra Ferreiro Vidal
81088df504
Merge pull request #682 from alejandraferreirovidal/fixMessage
fix wrong message
2019-05-09 14:17:17 +02:00
Alejandra Ferreiro Vidal
7724469f58 add unit tests for withPropertyInValues 2019-05-09 13:35:36 +02:00
Alejandra Ferreiro Vidal
043c228115 fix wrong message 2019-05-09 13:35:36 +02:00
Oliver Feldmann
a4af238c95
fix groovy consumer test bugs (#696)
* Fix order so hash is set before notify

* Always run tests on master branch
2019-05-09 12:10:12 +02:00
Oliver Feldmann
aca60b3ee6
groovy integration tests (#671) 2019-05-09 10:28:54 +02:00
Florian Geckeler
79b55cc064
Enable configuration of npm registry for mtaBuild 2019-05-09 08:51:11 +02:00
Oliver Nocon
e20eb3c320
pipeline initialization - support nested keys (#695)
* pipeline initialization - support nested keys

support a nested structure for config keys for initialization conditions, like

```
Acceptance:
    stepConditions:
      cloudFoundryDeploy:
        configKeys:
          - 'cfSpace'
          - 'cloudFoundry/space'
```

* optimize code
2019-05-08 12:04:47 +02:00
Oliver Nocon
a67f850fdb
add step for Synopsis Detect Scans (#690)
* add step for Synopsis Detect Scans

tool was formerly calles Blackduck Hub Detect.
Details about the tool can be found here: https://synopsys.atlassian.net/wiki/spaces/INTDOCS/pages/62423113/Synopsys+Detect
2019-05-08 11:36:01 +02:00
Christopher Fenner
b66d95fb1c improve Slack setup documentation (#687) 2019-05-08 10:17:44 +02:00
Sven Merk
94e72898b1 whitesourceExecuteScan: Fix suffix collision for MTA scenario (#689)
* Apply fix for stash name collision
* Adapt tests
2019-05-03 17:33:52 +02:00
Oliver Nocon
14efc51d24
whitesourceExecuteScan - fix stashing behavior for golang (#688)
* whitesourceExecuteScan - fix stashing behavior for golang
**changes:**

golang scan requires sources to be present. They are already part of the `checkmarx` stash which can be used here.

* fix tests
2019-05-03 16:21:36 +02:00
Oliver Nocon
46a6525c4e
Pipeline resilience - be more verbose (#677)
* Pipeline resilience - be more verbose

Be more verbose about when a pipeline gets into 'UNSTABLE' state.

Collect step name centrally to be able to inform end-users at a later point inside a pipeline (e.g. during an approval step).

* address PR feedback
2019-05-03 14:06:49 +02:00
Marcus Holl
9b7b46132f
Merge pull request #657 from marcusholl/pr/changeNamingForCreatingDocu
More fuzzy name for creating documentation
2019-05-03 13:05:28 +02:00
Marcus Holl
350ec78c9b Merge remote-tracking branch 'github/master' into HEAD 2019-05-03 11:22:05 +02:00
Marcus Holl
9a468568c8
Merge pull request #685 from marcusholl/pr/collectDependingOn
Collect depending on configurations and provide it in docu as some ki…
2019-05-03 10:09:23 +02:00
Marcus Holl
6a58277967 Merge remote-tracking branch 'github/master' into docuReadDefaultFromElswhere 2019-05-03 09:52:47 +02:00
Marcus Holl
5653484ddb Replace several replaceAll command by one. 2019-05-03 09:50:52 +02:00
Oliver Nocon
6c5d9f2f61
Pipelines - extend init conditions (#676)
extends init condition with condition `configKeys`
This condition allows to specify a list of configuration keys which if any key is set will activate the respective step & stage
2019-05-02 22:09:15 +02:00
Oliver Nocon
d207aeadd4
Merge branch 'master' into pr/collectDependingOn 2019-05-02 19:48:41 +02:00
Oliver Nocon
700a6e2e4e
Add step kanikoExecute for Docker builds using Kaniko (#684)
* Add step kanikoExecute for Docker builds using Kaniko
* Update kanikoExecute.md
* address PR feedback
2019-05-02 17:29:11 +02:00
Marcus Holl
0ce09f3578 Collect depending on configurations and provide it in docu as some kind of complex default 2019-05-02 15:29:12 +02:00
Christopher Fenner
e8f206b1a1
piperPipeline: add extensible post stage (#661)
* add post stage

* use post stage in template

* adjust test cases

* add docs skeleton

* add documentation

* Update piperPipelineStagePost.md
2019-05-02 12:26:28 +02:00
Alejandra Ferreiro Vidal
15cfed66a4 remove parameters not related to warPropertiesFile 2019-04-30 13:36:07 +02:00
Oliver Nocon
99821afab8
Doc - Add missing possible values (#679) 2019-04-29 11:43:26 +02:00
Oliver Feldmann
9b6919f473
Merge pull request #674 from SAP/docFix
Add note admonition
2019-04-25 12:12:34 +02:00
Oliver Feldmann
2fc10d6d9f
Merge branch 'master' into docFix 2019-04-25 09:59:04 +02:00
Florian Wilhelm
e51737d2ca
Fix typo and apply code formatter (#675) 2019-04-24 16:34:04 +02:00
Oliver Feldmann
e566c2bb13 Use admonition for note 2019-04-24 13:50:30 +02:00
Florian Wilhelm
49c704c9aa
Allow setting global maven config in MTA builder (#667) 2019-04-24 12:47:37 +02:00
Florian Wilhelm
82cf1d43bd
Fix relative link to editorconfig (#672) 2019-04-23 15:00:23 +02:00
Florian Wilhelm
cc5ba30127
Delete JenkinsController.groovy (#648)
This file is moved to the dedicated testing repo and thus not required here anymore.
2019-04-18 10:00:29 +02:00
Alejandra Ferreiro Vidal
79b7710515
Merge pull request #666 from alejandraferreirovidal/addNewStepDocuToIndex
add new step docu to index
2019-04-17 19:24:57 +02:00