1
0
mirror of https://github.com/SAP/jenkins-library.git synced 2024-12-12 10:55:20 +02:00
Commit Graph

4831 Commits

Author SHA1 Message Date
Tilo Körner
ac55ddf525
support trustedCerts for cloneGitRepo (#4909)
* support trustedCerts for cloneGitRepo

* some more steps

* Update sap_com_0948.go

* remove warning for config value type

* updated description for certificateNames

* go generate artifacts

* variable order and space in "[]interface {}"
2024-05-10 08:58:46 +02:00
Simon Dold
ff9b3d4296
[ABAP] update ConvertTime (#4919)
* update ConvertTime

* clean up

* fix typo

---------

Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2024-05-08 14:25:13 +02:00
Christoph Szymanski
6456f61612
Rem cx-server references from infrastructure documentation (#4886)
* Rem cx-server references from infrastructure documentation

* Rem reference to cx server in plugin doc

* Rem cx-server reference from abap doc

* Rem cx-server reference from gcts cod

* Rem cx-server ref from guided tour

* Rem unused links

* Rem unused refs

* remove cx-server from development.md

---------

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
2024-05-08 12:51:22 +02:00
Jordi van Liempt
1f4010a97e
feat(events): Retrieve OIDC token in gcpPublishEvent (#4917)
Co-authored-by: jliempt <>
2024-05-07 15:43:07 +02:00
Jordi van Liempt
f5fbb7e9d9
feat(vault): Facilitate Vault OIDC token (#4916)
* add functionality to retrieve Vault OIDC token

* fix tests for now

* update error

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>

* implement commented tests

* run mockery for config pkg

---------

Co-authored-by: jliempt <>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2024-05-07 12:19:39 +00:00
Johannes Eschrig
6c4a860bd5
OSS report for PRs: fix detect documentation url and quiet down formatting (#4895)
* fix detect docs url and quiet down formatting

* remove markdown header from unit test

* whitespace missing for test

---------

Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
2024-05-07 13:33:17 +02:00
tiloKo
dd5106ab5d
Update http.go (#4922)
typo
2024-05-07 13:26:58 +02:00
tiloKo
40693d30cd
config.go, more space in warning (#4921) 2024-05-07 13:20:22 +02:00
tiloKo
d6f3ba1b02
update semantic version too (#4924) 2024-05-07 09:33:32 +00:00
tiloKo
daf559a8ca
increase http timeout (#4923) 2024-05-07 10:03:11 +02:00
thtri
9a8b146945
fix(cxOne): set taxa in SARIF as array (#4911) 2024-05-06 13:32:31 +05:30
Christopher Fenner
0f83941765
feat(events): add step to emit events to GCP (#4901)
* feat(gcp): add step to send events to GCP (#4896)

* add gcp token handling

* add initial step

* publish events

* add test cases

* fix test case

---------

Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com>

* feat(gcp): Generate and validate the GCP OIDC token (#4899)

* test setup for generation of jwt token

* oidc token generator

* push new step files

* formatted code

* removed toolchain and jose

* removed toolchain:go 1.22.2

---------

Co-authored-by: jliempt <>
Co-authored-by: D071696 <sachin.baral.ramesh@sap.com>
Co-authored-by: d071696 <153099976+d071696@users.noreply.github.com>

* feat(events): add pipeline start and end event (#4900)

* add gcp token handling

* add initial step

* publish events

* add test cases

* fix test case

* move files

* add possible values

* handle start and end event

* add sap events

* dependencies

---------

Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com>

* log successful event publish

* remove dummy step

* prevent step from failing

* improve event creation

* improve event creation

* simplify eventing

* remove detailed events

* update parameter scope

* update go.sum

* fix test case

* add missing method

* refactor OIDC part

* add oidc.go to vault pkg

* mock OIDC token retrieval

* mock GCP functions

* update OIDC function name in Vault mocks

* get event data from CPE

* don't encode data payload in b64

* remove vault related changes

* remove vault changes from step code

* remove commented out code

* documentation/steps/gcpPublishEvent.md

* documentation/steps/gcpPublishEvent.md

* remove hardcoded eventData

* update roleID

* go generate

* add ordering key for pubsub event

---------

Co-authored-by: Jordi van Liempt <35920075+jliempt@users.noreply.github.com>
Co-authored-by: D071696 <sachin.baral.ramesh@sap.com>
Co-authored-by: d071696 <153099976+d071696@users.noreply.github.com>
Co-authored-by: jliempt <>
2024-05-06 09:28:28 +02:00
Akramdzhon Azamov
fb809a2b03
added detect9 (#4920) 2024-05-03 17:28:29 +03:00
tiloKo
0aac69625e
Provide addonDescriptor to build System (#4914) 2024-05-02 13:22:35 +02:00
Oliver Nocon
7d9fc6aee4
fix(versioning): ensure that version is not empty (#4173)
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
2024-04-29 08:19:52 +02:00
Andrei Kireev
b18f8578d0
fix(detectExecuteScan) Hide repositoryPassword from logs (#4908) 2024-04-26 09:43:23 +02:00
Daniel Mieg
9bb306adad
[ABAP] Add execution log (#4902)
* [ABAP] Add output for execution log

* Add buil comments

* Rename to avoid build issue

---------

Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
2024-04-24 16:01:34 +02:00
Andrei Kireev
af28a72ef9
fix(detectExecuteScan) Generate reports for project with no components (#4905)
* fix(detectExecuteScan) Generate reports for project with no components

* Resolved merge conflicts
2024-04-24 13:26:18 +02:00
michaelkubiaczyk
7a3024c697
fix(cxOne): fix SARIF duplicated entries and branch name (#4904)
* Initial in progress

* compiling but not yet functional

* Missed file

* updated checkmarxone step

* Working up to fetching a project then breaks

* Missed file

* Breaks when retrieving projects+proxy set

* Create project & run scan working, now polling

* Fixed polling

* added back the zipfile remove command

* Fixed polling again

* Generates and downloads PDF report

* Updated and working, prep for refactor

* Added compliance steps

* Cleanup, reporting, added groovy connector

* fixed groovy file

* checkmarxone to checkmarxOne

* checkmarxone to checkmarxOne

* split credentials (id+secret, apikey), renamed pullrequestname to branch, groovy fix

* Fixed filenames & yaml

* missed the metadata_generated.go

* added json to sarif conversion

* fix:type in new checkmarxone package

* fix:type in new checkmarxone package

* removed test logs, added temp error log for creds

* extra debugging to fix crash

* improved auth logging, fixed query parse issue

* fixed bug with group fetch when using oauth user

* CWE can be -1 if not defined, can't be uint

* Query also had CweID

* Disabled predicates-fetch in sarif generation

* Removing leftover info log message

* Better error handling

* fixed default preset configuration

* removing .bat files - sorry

* Cleanup per initial review

* refactoring per Gist, fixed project find, add apps

* small fix - sorry for commit noise while testing

* Fixing issues with incremental scans.

* removing maxretries

* Updated per PR feedback, further changes todo toda

* JSON Report changes and reporting cleanup

* removing .bat (again?)

* adding docs, groovy unit test, linter fixes

* Started adding tests maybe 15% covered

* fix(checkmarxOne): test cases for pkg and reporting

* fix(checkmarxOne):fix formatting

* feat(checkmarxone): update interface with missing method

* feat(checkmarxone):change runStep signature to be able to inject dependency

* feat(checkmarxone): add tests for step (wip)

* Adding a bit more coverage

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix integration test PR

* adding scan-summary bug workaround, reportgen fail

* enforceThresholds fix when no results passed in

* fixed gap when preset empty in yaml & project conf

* fixed another gap in preset selection

* fix 0-result panic

* fail when no preset is set anywhere

* removed comment

* initial project-under-app support

* fixing sarif reportgen

* some cleanup of error messages

* post-merge test fixes

* revert previous upstream merge

* adding "incremental" to "full" triggers

* wrong boolean

* project-in-application api change prep

* Fixing SARIF report without preset access

* fix sarif deeplink

* removing comments

* fix(cxone):formatting

* fix(cxone):formatting

* small sarif fixes

* fixed merge

* attempt at pulling git source repo branch

* fix(cxone):new endpoint for project creation

---------

Co-authored-by: thtri <trinhthanhhai@gmail.com>
Co-authored-by: Thanh-Hai Trinh <thanh.hai.trinh@sap.com>
2024-04-22 18:21:02 +02:00
tiloKo
265105efa1
AAKaaS holistic pv check (#4893)
* new step abapAddonAssemblyKitCheck
2024-04-22 13:12:38 +02:00
tiloKo
787176b6da
Update helper.go (#4874)
go generate fix parameter type for new steps
2024-04-22 13:02:08 +02:00
Egor Balakin
077ecfe342
feat: bump go to 1.21 (#4846)
* bump go to 1.21, add toolchain go1.21.7

* bump go to 1.21

* fix test

---------

Co-authored-by: Egor Balakin <egor.balakin@sap.com>
2024-04-19 03:17:39 +04:00
Daria Kuznetsova
df0b288ecb
refactor codeqlExecuteScan (#4888)
* refactored codeql step

* fixed tests

* fixed reports output dir

* refactored

* fixed returning error

* fixed tests

---------

Co-authored-by: sumeet patil <sumeet.patil@sap.com>
2024-04-16 11:35:56 +03:00
Dmitrii Pavlukhin
94a33844a0
detectExecuteScan - Removed option to change min-scan-interval for Signature Scan to enforce global interval value (#4875)
* removed option to change min-scan-interval to enforce global interval value

* returned-param-to-avoid-pipeline-breaks

* fix-for-tests
2024-04-15 16:12:13 +03:00
Vyacheslav Starostin
8241580163
Run artifactPrepareVersion inside a docker container for CAP apps (#4891)
* Run artifactPrepareVersion inside a docker container when build tool is CAP

* Run artifactPrepareVersion inside a docker container for CAP apps

* Run artifactPrepareVersion inside a docker container for CAP apps

* Update yaml
2024-04-12 13:55:59 +05:00
Vyacheslav Starostin
b0ecbf68ad
feat(artifactPrepareVersion): Introduce build tool CAP (#4890)
* feat(artifactPrepareVersion): Introduce build tool CAP

* feat(artifactPrepareVersion): Introduce build tool CAP

* Add CAPVersioningPreference to versioning.Options

* Include CAP to allowed build tool list

* Update go.mod

* Include CAP to allowed build tool list

* Delete CAP from additionalTargetTools

* Delete CAP from additionalTargetTools

* Fix test

* Update comment

* Update comment

* Add param description

* Add param description
2024-04-10 13:45:21 +05:00
thtri
3ae51e2661
fix(cxone): new endpoint for project creation (#4889)
* Initial in progress

* compiling but not yet functional

* Missed file

* updated checkmarxone step

* Working up to fetching a project then breaks

* Missed file

* Breaks when retrieving projects+proxy set

* Create project & run scan working, now polling

* Fixed polling

* added back the zipfile remove command

* Fixed polling again

* Generates and downloads PDF report

* Updated and working, prep for refactor

* Added compliance steps

* Cleanup, reporting, added groovy connector

* fixed groovy file

* checkmarxone to checkmarxOne

* checkmarxone to checkmarxOne

* split credentials (id+secret, apikey), renamed pullrequestname to branch, groovy fix

* Fixed filenames & yaml

* missed the metadata_generated.go

* added json to sarif conversion

* fix:type in new checkmarxone package

* fix:type in new checkmarxone package

* removed test logs, added temp error log for creds

* extra debugging to fix crash

* improved auth logging, fixed query parse issue

* fixed bug with group fetch when using oauth user

* CWE can be -1 if not defined, can't be uint

* Query also had CweID

* Disabled predicates-fetch in sarif generation

* Removing leftover info log message

* Better error handling

* fixed default preset configuration

* removing .bat files - sorry

* Cleanup per initial review

* refactoring per Gist, fixed project find, add apps

* small fix - sorry for commit noise while testing

* Fixing issues with incremental scans.

* removing maxretries

* Updated per PR feedback, further changes todo toda

* JSON Report changes and reporting cleanup

* removing .bat (again?)

* adding docs, groovy unit test, linter fixes

* Started adding tests maybe 15% covered

* fix(checkmarxOne): test cases for pkg and reporting

* fix(checkmarxOne):fix formatting

* feat(checkmarxone): update interface with missing method

* feat(checkmarxone):change runStep signature to be able to inject dependency

* feat(checkmarxone): add tests for step (wip)

* Adding a bit more coverage

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix code review

* feat(checkmarxOne): fix integration test PR

* adding scan-summary bug workaround, reportgen fail

* enforceThresholds fix when no results passed in

* fixed gap when preset empty in yaml & project conf

* fixed another gap in preset selection

* fix 0-result panic

* fail when no preset is set anywhere

* removed comment

* initial project-under-app support

* fixing sarif reportgen

* some cleanup of error messages

* post-merge test fixes

* revert previous upstream merge

* adding "incremental" to "full" triggers

* wrong boolean

* project-in-application api change prep

* Fixing SARIF report without preset access

* fix sarif deeplink

* removing comments

* fix(cxone):formatting

* fix(cxone):formatting

* fix(cxone):new endpoint for project creation

---------

Co-authored-by: michael kubiaczyk <michael.kubiaczyk@checkmarx.com>
Co-authored-by: michaelkubiaczyk <48311127+michaelkubiaczyk@users.noreply.github.com>
2024-04-05 14:08:43 +02:00
Jordi van Liempt
a129cc4dde
fix(maven): Add proper error handling for invalid settings.xml when publishing (#4884)
Co-authored-by: jliempt <>
2024-04-04 09:45:33 +02:00
Jordi van Liempt
38fe2ea84b
chore(sonar): Update Sonar default image to 5.0 (#4881)
* update Sonar default image

* go generate

---------

Co-authored-by: jliempt <>
2024-04-03 10:46:28 +02:00
sumeet patil
93283e55f9
contrastExecuteScan: added docs (#4879) 2024-04-02 12:24:09 +05:30
Vijayan T
8627ad6ee4
Updated the description of installArtifacts in mend (#4877) 2024-04-02 11:15:30 +05:30
Daria Kuznetsova
bf59a28aba
feat(codeqlExecuteScan): added open configs for codeql database creation and analysis (#4869)
Co-authored-by: sumeet patil <sumeet.patil@sap.com>
2024-04-02 10:18:17 +05:30
An Rav
a1184a7f98
Updated documentation for gctsdeploy step (#4856)
* updated text of scope parameter

* go generate all yaml files

---------

Co-authored-by: Sarat Krishnan <78093145+sarat-krk@users.noreply.github.com>
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2024-03-27 13:55:04 +01:00
Tomáš Hartmann
fc67751d7b
exclude .git on stashBack (#4854)
This change allows usage of `stashNoDefaultExcludes` parameter,
as otherwise I think it it impossible to stash back the .git repository.

It should not affect anything if `stashNoDefaultExcludes` is not used.
2024-03-26 12:18:15 +04:00
Oliver Feldmann
f6a3bbe655
Fail on error also in case of no lint config present (#4658)
* Fail on error also in case of no lint config present

* Fix errors

* test: add unit test
2024-03-25 15:13:29 +01:00
Srinikitha Kondreddy
6e8fdb7979
Bug: fix typo (#4870)
Co-authored-by: tiloKo <70266685+tiloKo@users.noreply.github.com>
2024-03-25 13:41:31 +00:00
Hilmar Falkenberg
2d3c666d3a
[docs] fix some typos and markdown issues on helm documentation (#4867)
* fixes `go build` on windows

cmd\cnbBuild.go:589:3: unknown field Credential in struct literal of
type "syscall".SysProcAttr
cmd\cnbBuild.go:589:24: undefined: syscall.Credential

* Update cnbBuildAttr.go

* Update cnbBuildAttr_windows.go

* go fmt

* fix some typos and markdown issues
2024-03-25 14:00:01 +01:00
Ralf Pannemans
70dac23c73
Revert "feat(cnbBuild): validate docker credentials (#4840)" (#4872)
Apparently this pr caused some regression.

This reverts commit df2e976eaa.
2024-03-25 10:43:23 +01:00
Daria Kuznetsova
2d2d357599
feat(contrastExecuteScan): new step contrastExecuteScan (#4818) 2024-03-21 10:13:59 +05:30
Akramdzhon Azamov
18bc753233
Removed the enforcement for gradle.aggregateModules parameter whitesource step (#4747)
Co-authored-by: sumeet patil <sumeet.patil@sap.com>
2024-03-20 14:57:14 +05:30
Jordi van Liempt
8bf6298250
feat(imagePushToRegistry): Support imageNameTags (#4853)
* add imageNameTags related parameters to step

* fix registry+imageNameTags

* add debug logging

* remove debug logging

* update parameter docs

---------

Co-authored-by: jliempt <>
2024-03-18 13:46:35 +01:00
Johannes Dillmann
df2e976eaa
feat(cnbBuild): validate docker credentials (#4840) 2024-03-15 10:44:14 +01:00
Srinikitha Kondreddy
d54df69de4
Extend deprecation time for cf native blue green plugin (#4861)
* Extend deprecation time for cf native blue green plugin
2024-03-15 10:32:28 +01:00
Daniel Mieg
6e9f52e274
Adapt request body for SAP_COM_0948 (#4865)
* Adapt request body for SAP_COM_0948

* Adapt tests

* Readd tags
2024-03-14 16:30:19 +01:00
Pavel Busko
4d86308433
chore(cnbBuild): simplify telemetry data (#4864)
Co-authored-by: Johannes Dillmann <j.dillmann@sap.com>
2024-03-14 15:39:30 +01:00
tiloKo
1259a32de1
Enable logon to AAKaaS via Certificate (mTLS) (#4860)
* originHash

* analysis output

* first shot

* add cert logon to piper http client

* allow initial user/pw for certificate logon

* credentials -> parameters

* encode user cert in pem

* key as well

* fix unit tests after merge

* other aakaas steps

* 2nd conn in register packages
2024-03-12 14:27:00 +01:00
tiloKo
2330993615
login via certificates (#4857)
* login via certificates
2024-03-11 15:12:32 +01:00
tiloKo
2c69c4c669
shorten commits to common length prior compare (#4859)
* shorten commits to common length prior compare

* remove obsolete unit tests

* some test

* 2nd try

* fix old wrong unit test
2024-03-08 10:46:30 +01:00
Hilmar Falkenberg
09cd271415
fixes go build on windows (#4858)
* fixes `go build` on windows
2024-03-07 13:37:49 +01:00
tiloKo
c0e56d26e0
AAKaaS originHash (#4843)
* originHash

* analysis output

* unit tests
2024-03-05 15:21:34 +01:00