1
0
mirror of https://github.com/SAP/jenkins-library.git synced 2024-12-14 11:03:09 +02:00
Commit Graph

3056 Commits

Author SHA1 Message Date
Florian Wilhelm
ec52a70e0b
Reflect recent changes in docs (#1859) 2020-07-29 12:21:21 +02:00
Oliver Nocon
bcd450f06e
kubernetesDeploy: add step configuration alias (#1857)
This is used for backward compatibility

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-07-29 11:21:32 +02:00
Stephan Aßmus
40440f8f01
Bugfix: Convert int/float parameters (2nd try) (#1851)
* If a step declares a parameter of type string, depending on how the config is written, it is no longer ignored, if it is interpreted by the yaml parser as integer or float value.
* If an expected parameter is present in the configuration, step execution will consistently fail if the parameter has the wrong type, no sensible conversion can take place, and it is known that the parameter will be ignored.
* For all type-mismatches that have no implemented conversion, a warning is logged. (It isn't known whether the conversion actually works, since it depends on both the yaml and json packages and future changes there.)
* Entries in the evaluated config with a value of nil are ignored.
2020-07-29 09:22:10 +02:00
Oliver Nocon
d691750931
Fix reading of hook configuration (#1854)
* Update piper.go

* Update piper_test.go

* Update config.go

* Update sentryHook.go

* Update piper.go

* go fmt

Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-07-28 17:19:33 +02:00
Daniel Kurzynski
bcab73d332
Support m2path for mtaBuild (#1850)
Co-authored-by: Florian Wilhelm <florian.wilhelm02@sap.com>
2020-07-28 17:06:17 +02:00
Giridhar Shenoy
0fc131adec
detectExecuteScan : Changes to include user group and handle build fails (#1775)
* changes to detectExec before master merge

* changes for detectExecuteScan

* self generated code added

* fix syntax errors and update docu

* added unit tests for fail and Group

* fix failOn bug

* add Groups as string array

* add Groups as string array

* tests and validation for groups, failOn

* Updated docs and added more tests

* documentation md files should not be changed

* Handle merge conflicts from PR 1845

* fix merge errors

Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-07-28 10:48:19 +02:00
Florian Wilhelm
60796cdc59
Update maven spotbugs plugin to support Java 14 (#1852) 2020-07-28 09:58:56 +02:00
Christopher Fenner
e4113242aa
fix(sonar): correct type for custom TLS certificates (#1847)
* correct type

* correct certificate handling

* adapt test cases

* Update resources/metadata/sonar.yaml

* update
2020-07-27 15:01:30 +02:00
Oliver Nocon
d8553ab53d
detectExecuteScan: update versioning (#1845)
* detectExecuteScan: update versioning

align with Fortify to also use the same versioning model by default.

* fix CodeClimate findings
2020-07-27 12:01:59 +02:00
Stephan Aßmus
0134332a6e
Revert "Bugfix: Convert int/float parameters (#1837)" (#1849)
This reverts commit 7f4fab762d.
2020-07-27 11:13:13 +02:00
Marcus Holl
5589abbd0f
Avoid NPEs when not having JOB_URL, BUILD_URL (#1836)
When running inside a jenkins file runner scenario these parameters might
not be available.
2020-07-27 09:29:22 +02:00
Stephan Aßmus
7f4fab762d
Bugfix: Convert int/float parameters (#1837) 2020-07-27 08:30:02 +02:00
Oliver Nocon
97737a2d8d
detectExecuteScan: fix docs (#1835)
The step is golang based thus has no dependency to a Jenkins plugin.
2020-07-24 13:45:52 +02:00
MuellerHenrik
af4d871f3c
Create fix for ABAP ATC step (#1834) 2020-07-24 10:39:40 +02:00
Chris Bo
25decaa256
Introducing new step 'gctsRollback' (#1526)
* added new step gctsDeployCommit

* suggested PR fixes applied

* fixed test

* Remove unused imports

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>

* added URL encoding for 'request' parameter

* regenerate after change

* add new step gctsRollbackCommit

* fixed typo in docu

* enhanced error messages

* minor changes

* renamed step to 'gctsDeploy'

* changed name

* remove space

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>

* changed step name to gctsRollback

* changed function name

* fix conflict

* fixed gctsDeploy step name

* fix typo

* fixed error handling

* added Jenkins credentials for github token

* regenerated

* newly generated

* removed calling piper binary with go function call

* removed unused execRunner parameter

* cleaned up

* fixed merge conflict

* added docu page

* cleaned up

* provide Jenkins creds also in config.yaml

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-07-23 20:20:07 +02:00
Florian Wilhelm
f5df533c68
Allow trigger IT via github UI (#1830)
cf https://docs.github.com/en/actions/configuring-and-managing-workflows/configuring-a-workflow\#manually-running-a-workflow
2020-07-23 11:43:59 +02:00
MuellerHenrik
e3f914e09d
Add abap utils pkg - ABAP Environment Steps (#1757)
* Add abaputils pkg and go files

* Add ReadServiceKeyAbapEnvironment function

* Fixes

* Add structs for SC, Pull and Branch

* Minor Improvements

* Adapt unit tests to new abaputils pkg

* Fixes

* Add adapted tests

* Fixes

* Fix cloudfoundry test

* Add check for host prefix (HTTPS)

* Fix tests + cleanup

* Fixes

* Fixes

* Fix

* Add mock for abaputils pkg unit tests

* Adapt abaputils comments

* Add unit test for missing params case

* Fix for missing mapping of CfSpace

* Fix host schema

* Remove LogoutOption param of unit tests and steps

* Fix unit test

* Fix unit test CF ReadServiceKey

Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-07-23 10:26:50 +02:00
Florian Wilhelm
4fd81eb7f5
Maven Integration test for TomEE-based Cloud SDK Project (#1828) 2020-07-23 09:20:11 +02:00
Florian Wilhelm
ba7f2c2b96
Refactoring, sanity check for unit-under-test binary (#1827)
- Extracted some methods to structure the code better
- Explicitly run the binary with a trivial command first to avoid simple failure reasons (like having a non-linux binary)
2020-07-22 15:48:46 +02:00
Christopher Fenner
987eeefa81
chore(pipeline): add Code Climate coverage reporting for GO (#1148)
* add Code Climate coverage reporting

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml

* Update verify-go.yml
2020-07-22 12:30:15 +02:00
Christopher Fenner
7afc4cb60e
chore(actions): cache Golang packages (#1824)
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-07-22 12:01:05 +02:00
Kevin Stiehl
116a91ce28
Fetch config parameters from vault (#1782)
* added secret fetching from vault

* added rootPath and vault namespaces

* write tests for vault config loading
	* fix smaller bugs

* rename rootPath to basePath

* fix integration test

* make basePath optional

* write more tests

* remove unnecessary code

* make basePath configurable

* remove mixin for vault

* rewrite tests
* fix tests for searching over multiple paths

Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-07-22 11:15:48 +02:00
Chris Bo
6b6d1bc087
gCTS docu fixes (#1823)
* docu fixes

* regenerated

* convert double to single quotes

* outline placeholders

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>

* outline placeholders

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>

* outline placeholders

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>

* outline placeholders

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>

* regenerated

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-07-22 10:56:20 +02:00
Oliver Nocon
e09b05b22e
DocGenerator: fix links to secrets (#1825)
* DocGenerator: fix links to secrets
* Update docuHelper.go
2020-07-22 10:33:36 +02:00
Florian Wilhelm
f77d995b95
Remove files not longer required from integration tests (#1822) 2020-07-21 12:21:02 +02:00
Florian Wilhelm
6367b88af6
Maven Build Integration Test (#1820)
Follow up for #1819, adding a new IT for `mavenBuild` which had none so far.
2020-07-21 11:15:46 +02:00
Florian Wilhelm
219327a427
Rewrite mta IT using docker cli (#1819)
This change addresses some issues of the testcontainer based testing approach (much repeated code, API not on the right abstraction level). It introduces new methods that make use of the docker cli, and rewrites the mta tests using this method.


Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-07-20 18:07:08 +02:00
lndrschlz
94dba13fef
fix(checkmarxExecuteScan): whitespace in filePatterns; log output; (#1784)
* removed whitespaces in filePatterns and add zip file count log

* safer string-replace for whitespaces

Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
2020-07-20 16:50:48 +02:00
lndrschlz
42f91f6ff1
checkmarxExecuteScan: added resourceRef for secrets in step yaml (#1767)
* checkmarxExecuteScan: added resourceRef for secrets in step yaml

* regenerate stepmeta

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-07-20 15:44:24 +02:00
Stephan Aßmus
61fed83475
Improve self-consistency of file system mock (#1815) 2020-07-20 14:23:33 +02:00
Christoph Schubert
9027c4ccda
fix(newman+cf): Change query parameter delimiter to '&' (#1814)
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-07-20 13:20:36 +02:00
Daniel Mieg
a287afdd35
Fix error in documentation (#1817)
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-07-20 10:27:38 +02:00
Daniel Kurzynski
4814bea547
Fix npmExecuteEndToEndTests (#1818) 2020-07-17 17:54:28 +02:00
Daniel Kurzynski
26e817ca29
Make stage locking more flexible (#1811) 2020-07-17 14:27:21 +02:00
Kevin Hudemann
eea0c1f35e
Use npmExecuteEndToEndTests step in Release/Acceptance stage if it is configured (#1813)
This change enables the use of the new npmExecuteEndToEndTests in the
stages release and acceptance if it is configured. If it is not
configured, nothing should change.
2020-07-17 13:59:14 +02:00
Daniel Kurzynski
f933788d86
Pass stageName through to steps (#1796) 2020-07-17 13:32:49 +02:00
Chris Bo
5e67c9c014
added steps to docu page (#1812) 2020-07-17 10:59:47 +02:00
Oliver Nocon
220748d150
Step generation: allow usage of go generate (#1793)
* Step generation: allow usage of go generate

* Update DEVELOPMENT.md

* move generate command to main.go (#1809)

* Update main.go

* Update DEVELOPMENT.md

* Update piper.go

* align path usage

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-07-17 08:06:11 +02:00
Kevin Hudemann
58e7e4be44
Add buildDescriptorExcludeList parameter to npmExecuteScripts step (#1800)
This change adds a buildDescriptorExcludeList parameter to
npmExecuteScripts, to enable the exclusion of certain directories when
executing npm scripts. Previously, npmExecuteScripts could only execute
scripts in all packages.

Now it is possible to provide paths or patterns as elements of the
buildDescriptorExcludeList to exclude packages when executing npm scripts.
2020-07-16 17:16:55 +02:00
Marcus Holl
8af0540de2
Introduce chmod in file utils (#1808) 2020-07-16 14:25:01 +02:00
Pierre Fritsch
fef38cec0a
fix(docs): typo: articale -> article (#1810) 2020-07-16 13:11:48 +02:00
Oliver Nocon
c622b3dfac
Documentation: fix parameter links & some spelling (#1807)
* Documentation: fix parameter links & some spelling
* Fix new line character
* update checkboxes
2020-07-16 11:34:02 +02:00
Daniel Mieg
90571754bf
Add test cases for stepmeta.go (#1801)
* Add tests

* Remove obsolete comment
2020-07-16 11:09:49 +02:00
Christoph Schubert
1c49326103
Improve newman blue-green app identification (#1805)
* Improve newman blue-green app identification

* Change order to be backwards compatible
2020-07-16 10:26:33 +02:00
Oliver Nocon
43f51ba90a
Revamp documentation generation for golang steps (#1781)
* Revamp documentation generation for golang steps

* Add and update tests

* Add tests, add step outputs

* Add tests, add step outputs

* Update rendering

* fix merge conflict

* update generated files

* Update pkg/config/stepmeta.go

* Update pkg/config/stepmeta.go

* Update pkg/generator/helper/docuHelper.go

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>

* Include PR feedback

* update tests

* Fix Jenkins dependecy indication

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-07-16 09:10:15 +02:00
Daniel Kurzynski
61a669778a
Apply alias to secrets (#1802) 2020-07-15 21:05:22 +02:00
Daniel Mieg
5dbb7be6b6
Fix commonPipelineEnvironment issue (#1798)
* Fix write to disk

* Change condition

* Test log output

* Fix

* Remove test log
2020-07-15 15:45:36 +02:00
Marcus Holl
37ccebeb77
No cf api for checking login state (#1785)
* Dont work upon a global command.Command instance inside cloudfoundry package

o Up to now we work on a private and shared instance of command.Command inside
  the cloudfounrdy package. We need to be able either configure this instance
  (environment variables) according to the use case. One option is to hand over
  an already configured instance which is used elsewhere. This is what we do with
  this commit.

o With this commit we remove the instance which is shared within the cloudfounrdy
  package and to provide an instance with a receiver which gets handed over to the
  functions. Hence we are thread save: parallel invoctation of e.g. Login will not
  affect each other.
2020-07-15 15:12:28 +02:00
Marcus Holl
49d4f6269a
Introduce stat command into Files utils and correspoding mock (#1721)
Introduce stat command into Files utils and correspoding mock
2020-07-15 10:31:36 +02:00
Daniel Mieg
7f69f4eb16
Support lists in commonPipelineEnvironment (#1797)
* Enable write Lists

* Enable read

* Add tests

* Fix unit test

* CodeClimate Refactor

* Add comment
2020-07-15 10:09:42 +02:00