1
0
mirror of https://github.com/SAP/jenkins-library.git synced 2024-12-14 11:03:09 +02:00
Commit Graph

1165 Commits

Author SHA1 Message Date
Marcus Holl
1663cee93a
Merge pull request #298 from marcusholl/pr/transportRequestIDAlsoViaCPE
transport request id also via cpe
2018-11-12 10:19:41 +01:00
Marcus Holl
06aacffb56 Merge remote-tracking branch 'github/master' into HEAD 2018-11-12 09:39:12 +01:00
Marcus Holl
7446b1e93d Remove return value from step documentation
In the meantime the steps do not have a return value anymore.
2018-11-09 16:09:29 +01:00
Marcus Holl
79fc8b1b85 Improve naming step -> script
We cannot say if it is a step, but it is a script, this is essential.
2018-11-09 15:45:31 +01:00
Marcus Holl
6252b18e49 Remove cps annotation
since otherwise we get executed not all the code. It returns too early.
2018-11-09 15:45:31 +01:00
Marcus Holl
0bbbb56002 Do not hand over reference to step itself
needs to be the reference as it is available by script
2018-11-09 15:45:23 +01:00
Christopher Fenner
3c86a3c54d
add missing script (#377)
fixes #376
2018-11-09 07:42:33 +01:00
Marcus Holl
8e7352cdb4 Adjust docu
there is no return value anymore.
2018-11-08 16:05:35 +01:00
Marcus Holl
f48c8a038e Merge remote-tracking branch 'github/master' into HEAD 2018-11-08 15:58:26 +01:00
Marcus Holl
d1e33d6b2f Disable check for Boolean.getBoolean()
Is it IMO completly normal to use Boolean.getBoolean(./.).

What is stated in the rule description

  | It is often mistakenly used to attempt to read user input or parse

is not a cool reason for having that rule. With such an approach we
can knock out a lot of APIs which can be misunderstood. It is the
duty of the developer to understand the API s?he is using.

The alternate way would be

'Boolean.parseBoolean(System.getProperty('xxx'))'

which is not that convenient like Boolean.getBoolean('xxx').
2018-11-08 13:57:49 +01:00
Christopher Fenner
48e58f04d1
deactivate MD013 - line length (#367) 2018-11-08 13:47:32 +01:00
Christopher Fenner
9acc28f10f
add missing script (#373) 2018-11-08 13:25:11 +01:00
Marcus Holl
7063aa1249 set build to unstable in case old config framework is used.
protected by feature flag (so we can test it manually already).
2018-11-08 13:11:24 +01:00
Marcus Holl
1b8e9d0e30 Emit more explicit warning in case old config framework is is use 2018-11-08 13:10:43 +01:00
Marcus Holl
b3c5cba707 Notify about old config framework from neo deploy. 2018-11-08 12:18:49 +01:00
Christopher Fenner
9a1ab37c0b
add new step karmaExecuteTests (#351)
* add new step for karma execution

* add defaults

* Update karmaExecuteTests.groovy

* add key comments

* add test case

* docs

* add step docs

* add step docs

* Update karmaExecuteTests.md

* complete docs

* Update karmaExecuteTests.md

* init `script` the "new way"

* Update karmaExecuteTests.groovy

* Update karmaExecuteTests.groovy
2018-11-08 12:15:15 +01:00
Thorsten Duda
9895b76bb1
Merge pull request #221 from marcusholl/pr/changeDocumentIdInCommonPipelineEnv
Cache document id in common pipeline env
2018-11-08 11:14:35 +01:00
Thorsten Duda
3896177b3e
Merge branch 'master' into pr/changeDocumentIdInCommonPipelineEnv 2018-11-08 11:00:28 +01:00
Christopher Fenner
e487ad5055
disable download logs in maven (#370) 2018-11-07 13:08:24 +01:00
Christopher Fenner
87bc3e9b96
run docs build for PRs in parallel to unit tests (#371) 2018-11-07 12:05:28 +01:00
Marcus Holl
e45e7ffd9b
Merge pull request #283 from marcusholl/pr/cleanWorktreeCheck
clean worktree check
2018-11-07 11:54:43 +01:00
Christopher Fenner
33758e0e81
Merge branch 'master' into pr/cleanWorktreeCheck 2018-11-07 11:47:56 +01:00
Christopher Fenner
10ec0473c1
correct step invokation in tests (#368)
* correct step invokation in tests

* correct step invokation in tests

* correct step invokation in tests
2018-11-07 11:45:38 +01:00
Marcus Holl
e354da8a05 Merge remote-tracking branch 'github/master' into HEAD 2018-11-07 11:44:15 +01:00
Christopher Fenner
ce362f4ae9
correct usage of commonPipelineEnvironment (#369) 2018-11-07 11:37:18 +01:00
Oliver Nocon
5ec37170fc
cloudFoundryDeploy - blue-green plugin extensions (#355)
* cloudFoundryDeploy - blue-green plugin extensions

* support blue-green application cleanup with new plugin flag
* enhance error reporting in case no app name is available

* include PR feedback
2018-11-07 10:39:30 +01:00
Christopher Fenner
0326dd5f8c
add config for CodeClimate code coverage reporting (#363)
* add config for CodeClimate code coverage reporting

* Update .travis.yml

* Update .travis.yml

* generate coverage report

* Update .travis.yml

* Update .travis.yml
2018-11-07 10:25:00 +01:00
Marcus Holl
85c4a1c933 Merge remote-tracking branch 'github/master' into HEAD 2018-11-06 15:46:50 +01:00
Marcus Holl
c035119718 Merge remote-tracking branch 'github/master' into HEAD 2018-11-06 15:41:19 +01:00
Marcus Holl
420746463e Remove return value from transportRequestCreate
it is contained in the common pipeline environment.
2018-11-06 15:37:11 +01:00
Marcus Holl
b8c0c8e6b3 Cache transport request Id in common pipeline environment 2018-11-06 15:36:39 +01:00
Marcus Holl
91f84389de The cases removed with the tests here are checked by corresponding step helper tests. 2018-11-06 14:42:03 +01:00
Marcus Holl
76be6f0b24 Cache change document id in common pipeline environment 2018-11-06 14:36:40 +01:00
Christopher Fenner
cf334f5af2
add badges for code climate (#364) 2018-11-06 14:23:52 +01:00
Christopher Fenner
a13e6d5632
exclude images and key file from Code Climate editorConfig scan (#366)
* Update .codeclimate.yml
2018-11-06 14:04:53 +01:00
Christopher Fenner
f757a0e1d4
fix Markdown issues (#365)
* fix Markdown issue 'Headers should be surrounded by blank lines'

* fix MD012

* fix MD022

* fix MD026

* fix MD007

* fix MD032

* fix MD038

* fix MD040

* fix MD031

* fix MD034

* fix MD004

* fix new findings

* fix MD036

* fix MD038

* fix MD032

* fix MD006
2018-11-06 13:50:09 +01:00
Marcus Holl
a405e7e82c
Merge pull request #317 from marcusholl/pr/condenceCMCoding
condence cm coding
2018-11-05 14:51:52 +01:00
Marcus Holl
48e76b6330 fix format retrieved in an invalid way from configuration 2018-11-05 14:42:51 +01:00
Marcus Holl
3640ab63a4 fix codeclimat issues 2018-11-05 14:05:09 +01:00
Marcus Holl
3e75a8337d fix codeclimat issues 2018-11-05 14:03:36 +01:00
Marcus Holl
cfc7c5ecdc fix codeclimat issues 2018-11-05 14:00:09 +01:00
Marcus Holl
88c4b3e967 Merge remote-tracking branch 'github/master' into HEAD 2018-11-05 13:54:10 +01:00
Marcus Holl
1835f4d7bd
Merge pull request #305 from marcusholl/pr/scriptAsMandatoryParameter
Ensure script is mandatory parameter
2018-11-05 13:45:08 +01:00
Marcus Holl
bbfc973aaa Fix codeclimate remarks 2018-11-05 13:33:25 +01:00
Marcus Holl
3cb958b740 Merge remote-tracking branch 'github/master' into HEAD 2018-11-05 13:30:43 +01:00
Marcus Holl
e4633c50ee Fix codeclimate remarks 2018-11-05 13:25:22 +01:00
Marcus Holl
f91d9aa1d0 Fix codeclimate remarks 2018-11-05 13:22:47 +01:00
Marcus Holl
74f28a19ef Fix codeclimate remarks 2018-11-05 13:20:41 +01:00
Marcus Holl
bb0953dab9 Fix codeclimate remarks 2018-11-05 12:59:40 +01:00
Marcus Holl
66332b67af fix codeclimate issues 2018-11-05 12:51:33 +01:00