1
0
mirror of https://github.com/SAP/jenkins-library.git synced 2025-02-11 13:53:53 +02:00

926 Commits

Author SHA1 Message Date
Mayur Belur Mohan
fe72b295d6
IntegrationArtifactDeploy Command (#2526)
* UpdateIntegrationArtifactConfiguration Command

* Fixes for codeclimate Check

* CommonStepsTest changes

* CodeReview Changes

* Git Patch

* Git Patch undo

* Code Review Comments

* code review fixes

* improve the error handling

* codeclimate fixes

* remove json parsing

* Error handling changes

* TestCase coverage fixes

* Refactoring Commands

* IntegrationArtifactDeploy Command

* Regenerate metadata_generated

* codereview fixes

* Code Review Fixes

* Code Review Fixes

Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
2021-01-22 15:55:50 +01:00
Giridhar Shenoy
205bbc1bed
fix(detect): scan paths to better handle signature scan and dependency scan paths (#2508)
* changes to detectExec before master merge

* changes for detectExecuteScan

* self generated code added

* fix syntax errors and update docu

* added unit tests for fail and Group

* fix failOn bug

* add Groups as string array

* add Groups as string array

* tests and validation for groups, failOn

* Updated docs and added more tests

* documentation md files should not be changed

* Handle merge conflicts from PR 1845

* fix merge errors

* remove duplicate groups, merge error

* adding buildCode and buildTool as params

* switching build options

* building maven modules

* parameter correction

* parameter correction

* gnerate with new build parameter

* adding comments

* removing piper lib master and modifying goUtils to download 1.5.7 release

* first cleaning then installing

* multi module maven built

* multi module maven built removing unwanted code

* multi module maven built moving inside switch

* testing

* modifying the default use case to also call maven build

* modifying the default use case to also call maven build wih --

* corrected maven build command

* corrected maven build command with %v

* skipping test runs

* testing for MTA project with single pom

* adding absolute path to m2 path

* clean up

* adding switch for mta and maven and removing env from containers

* commiting changes for new detect step

* correting log message

* code clean up

* unit tests changes to detectExecute

* basic tests for new change

* restoring piperGoUtils to download correct piper binary

* code clean up

* code clean up

* revert to clean version

* add unmap parameter to detect

* Added Additional parameters for BlackDuck scan

* Added detect tools paramater

* fix detect.yaml to accept correct data type

* fix codeclimate issue in detect.yaml

Co-authored-by: Keshav <anil.keshav@sap.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2021-01-21 14:57:00 +01:00
Marcus Holl
c8c1315d0c
transport request upload cts / the step (#2416)
fiori cts upload piper-go step
2021-01-13 16:14:56 +01:00
Oliver Feldmann
741b49140e
Move pull image parameters to general section (#2478)
* Move pull image parameters to general section

* Allow no nesting override

* Test dockerPullImage can be set to true

As the default is false, we need to make sure it can still be set to true.
2021-01-13 10:48:48 +01:00
mayurmohan
f4469c3427
DeployIntegrationArtifact Command (#2474)
DeployIntegrationArtifact Command

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
Co-authored-by: Marcus Holl <marcus.holl@sap.com>
2021-01-12 12:17:42 +01:00
Marcus Holl
65d22eb42a
Mta extension credentials handling (#2430)
Mta extension credentials handling

Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2021-01-12 09:39:04 +01:00
Oliver Nocon
ab3362849a
feat(kubernetesDeploy): allow disabling --force (#2495)
fixes #1731
2021-01-07 16:52:16 +01:00
Oliver Nocon
59f32cf042
feature(vault) retrieve github token from Vault (#2484) 2020-12-22 17:57:11 +01:00
Oliver Nocon
4bd155d1ed
feature(protecodeExecuteScan) proper Vault support (#2483) 2020-12-22 17:43:57 +01:00
Oliver Nocon
7de42230e0
add step to create a GitHub issue (#2481)
* add step to create a GirHub issue

* add groovy library step

* Update githubcreateissue.yaml

Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
2020-12-21 17:13:16 +01:00
Oliver Nocon
cf7ca8f791
add step to create a GitHub comment (#2479)
* add step to create a GitHub comment

* add docs

* mandatory parameters

* add command

* Update githubCommentIssue.go

* add groovy library step

Co-authored-by: Sven Merk <33895725+nevskrem@users.noreply.github.com>
2020-12-21 16:21:07 +01:00
Stephan Aßmus
cb069148d2
WS: Provide missing aliases (#2485) 2020-12-21 13:16:38 +01:00
Christopher Fenner
9cd3ee5758
fix(checks+tests): fail pipeline if plugins fail the build (#2463)
* fix false negative

* add comment

* add default
2020-12-11 14:49:36 +01:00
Christopher Fenner
fac4af231f
fix(cfDeploy): correct stashing (#2448)
* remove stash from step yaml

* add stash to groovy code
2020-12-05 13:35:16 +01:00
Kevin Stiehl
7d275b3ec3
fix(cloudfoundry): fetch credentials from vault (#2444) 2020-12-03 18:30:32 +01:00
Daniel Kurzynski
c09c5e1ef0
Fix workingDir for mta whitesource scan (#2431)
* Update whitesource.yaml

* Generate and format
2020-11-27 11:39:21 +01:00
Daniel Kurzynski
d952cb89d6
Add docker image for whitesource and mta (#2374) 2020-11-26 10:45:47 +01:00
Thilaknath
104435c8dd
Show user friendly error messages for pipeline restart step. (#2409)
* Add message parameter to pipelineRestart to make error messages user friendly

* Update the parameter to the correct name

Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-26 08:03:22 +01:00
Christopher Fenner
eff1933a61
refactor(checks): use warnings-ng plugin (#2398)
* use recordIssues

* fix c&p issue

* simplify code

* fix

* add quality gates

* change qgates to TOTAL_HIGH

* remove pattern for tasks

* use TOTAL_ERROR for checkstyle

* fix indent

* use deprecated threshold parameters

* debug messages

* transform legacy qgates

* fix

* adjust test cases

* correct qgates

* correct legacy thresholds

* fix typo

* remove deprecated defaults

* add test case

* log use tool

* add notification

* remove deprecated defaults

* remove deprecated parameter

* adjust legacy threshold message

* add q gates on error and high for all check tools

* Apply suggestions from code review

* adjust test cases

* remove duplicate assert

* Fail if aggregation is still defined

* update docs

* fix indent

* Update documentation/docs/steps/checksPublishResults.md

Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>

Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-11-25 15:39:33 +01:00
Sven Merk
5d1782aa01
checkmarxExecuteScan: adapt to 9.2 api (#2363)
* Update checkmarxExecuteScan.go

* api mods

* Switch default

* Fix decode

* mod marshalling

* Fix unmarshalling

* Code fmt and small fix

* Optimize preset handling

* Integer handling

* Fix test

* cleanup

* go fmt

* Improve test
2020-11-25 13:47:26 +01:00
Michael
fd0e8d4c9f
[typo] relese -> release (#2420) 2020-11-25 13:35:37 +01:00
Florian Wilhelm
55f25ace49
npmExecuteScripts: install dependencies by default (#2376) 2020-11-24 18:15:30 +01:00
Florian Wilhelm
9d5bd8b09b
Remove references to cloud sdk (#2418)
Not required anymore as Cloud SDK was merged into General Purpose Pipeline
2020-11-23 17:48:53 +01:00
lndrschlz
b9bab27833
feat: expose complete step metadata through generated function (#2329)
* exposing step metadata through generator

* add metadata_generated.go

* fix step go test generation

* metadata fields added to generated files

* added generated files

* removed image placeholder from fortify step

* refactored step meta generation

* go generate

* fixed metadata generator and tests

* added output resource fields/tags to metadata generator

* fix string in metadata_generated

* go generate

* fixed generator

* go generate

Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-20 08:13:59 +01:00
Stephan Aßmus
cb6b34f042
Unstash buildDescriptor where neoDeploy may need it (#2408) 2020-11-19 19:18:00 +01:00
Daniel Kurzynski
d91fb9053f
Use devxci/mbtci:1.0.16.1 (#2389)
* Use docker.pkg.github.com/sap/cloud-mta-build-tool/mbtci:1.0.16

* Revert and use devxci/mbtci:1.0.16.1

* Fix typo
2020-11-17 14:24:36 +01:00
Kevin Stiehl
dfab156427
Feature/approle secret id rotation (#2311)
* add new step vault secret

* add debug log

Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-17 13:49:31 +01:00
Daniel Kurzynski
8653780cf6
Stash also original jar (#2387) 2020-11-17 12:04:25 +01:00
Christopher Fenner
81c8553d6a
refactor(hadolint): implement step in GO (#1169)
* initial commit of yaml file

* initial commit for HaDoLint in GO

* add helper function to load file from url

* load config file

* write report information to disk

* comment the code

* refactor groovy code

* remove download function from FileUtils

* use http.Downloader

* rename step files

* update generated files

* update generated files

* remove duplicate commands

* add credentials for config url

* add generated test file

* reuse piperExecuteBin functions

* correct step name

* update go step

* deactivate test

* fix import

* use differing go step name

* rename step

* correct result publishing

* correct command name

* expose tls insecure flag

* hand through error

* disable tls verification

* fix tls disabling

* use credentials

* mow

* reformat

* add qgate only if set

* correct report name

* remove old defaults

* add qgate to defaults

* handle report name

* restore default

* remove unused step config

* use piperExecuteBin

* remove obsolete type

* add test cases

* remove groovy tests

* move client parameter handling to run function

* use custom interfaces and mockery

* remove commented code

* correct struct names

* rename parameter dockerfile

* add further asserts

* cleanup

* change file permission to read/write

* remove tokenize

* add further comments

* init http client only if necessary

* add todo

* Revert "rename parameter dockerfile"

This reverts commit 2a570685b89317d20217217894d68242d4620031.

* add alias for dockerfile parameter

* correct test case

* Apply suggestions from code review

Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>

* add comment about mock assertions

Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
2020-11-16 15:14:54 +01:00
tiloKo
2a5514c116
AAK endpoint default (#2356)
Co-authored-by: Daniel Mieg <56156797+DanielMieg@users.noreply.github.com>
2020-11-16 13:40:57 +01:00
Kevin Stiehl
9cb605ba60
[Documentation ]fix checkmarx docs (#2372)
* fix checkmarx docs

* go generate

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-16 13:03:31 +01:00
shellmann
61c190bb2b
Install artifacts before Fortify scan (#2351)
Co-authored-by: Daniel Kurzynski <daniel.kurzynski@sap.com>
2020-11-16 10:29:21 +01:00
Florian Wilhelm
647e1ef0bd
Add deployment to performance tests stage and enable stage (#2370)
Co-authored-by: Kevin Hudemann <kevin.hudemann@sap.com>
2020-11-13 16:31:45 +01:00
Kevin Hudemann
83daa33e65
Update defaults for npmExecuteScripts and mavenExecuteIntegration to run install (#2369)
This change updates the defaults for npmExecuteScripts to run npm install and mavenExecuteIntegration to install all artifacts by default.
2020-11-13 13:01:02 +01:00
Kevin Hudemann
7a04bb9749
Add runStep conditions for mavenExecuteIntegration and npmExecuteScripts in Integration stage (#2361)
This change adds runStep conditions for the steps mavenExecuteIntegration and
npmExecuteScripts for the stage Integration.
2020-11-12 16:50:57 +01:00
Florian Wilhelm
5fa2985d31
Unstash sources in integration tests (#2362)
* Unstash sources in integration tests

* Use stashSettings.yml instead
2020-11-12 16:23:55 +01:00
Stephan Aßmus
23d378d4ce
Conditions for npmExecuteScripts in Additional Unit Tests (#2357) 2020-11-12 12:41:11 +01:00
Kevin Hudemann
8fd6927854
Add mavenExecuteIntegration, mavenExecuteStaticCodeChecks, npmExecuteLint and npmExecuteScripts to piperPipelineStagePRVoting (#2352)
This change adds the steps mavenExecuteIntegration, mavenExecuteStaticCodeChecks,
npmExecuteLint and npmExecuteScripts to the stage piperPipelineStagePRVoting.
2020-11-12 09:25:44 +01:00
Daniel Mieg
712c568087
Create groovy step for abapEnvironmentCreateSystem (#2303)
* Create groovy step

* add to pipeline

* add includeAddon

* Adapt docu

* Adapt groovy test

* adapt stage addonBuild

* add comma

* Add to docu

* Upper case spelling

* Update docu

* adapt docu
2020-11-11 17:08:24 +01:00
Stephan Aßmus
115cfb5bae
Run nexusUpload in stage Promote (#2349) 2020-11-11 16:32:23 +01:00
Sven Merk
3c7712f2ee
Retry capabilities for HTTP requests + enablement for Checkmarx step (#2346) 2020-11-11 13:35:53 +01:00
Kevin Stiehl
9df9ec8ca4
(kubernetesDeploy) allow to keep a failed deployment (#2338)
* new 'keepFailedDeployments' parameter which removes the --atomic flag

* Update resources/metadata/kubernetesdeploy.yaml

Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>

* go generate

Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-10 15:43:19 +01:00
Stephan Aßmus
87e8d5d160
Extend the legacy config check for "required" config keys (#2332) 2020-11-10 14:18:37 +01:00
Marcus Holl
76fddec4c0
introduce tmsUpload to stageDefaults (#2321)
Without that the release stage does not perform tms uploads
2020-11-10 10:00:44 +01:00
Christopher Fenner
b71825fac9
feat(pipeline): add sonar step to PR and Build stage (#1651)
* add sonar scan to build stage

* add sonar scan to PR stage

* add step activation condition

* adjust whitespaces

Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-10 09:18:14 +01:00
Stephan Aßmus
eff38f6c9d
whitesourcExecuteScan-go: Additional fixes (#2315)
* Make sure the UA scan is known to the scan object. Fixes downloading reports later on.
* Move polling into pkg/whitesource, add test for e2e scan
* Remove conditions from stash config resource
* Don't use version stored in CPE. This will prevent the versioningModel from being applied.
2020-11-10 09:09:51 +01:00
Srinikitha Kondreddy
0234e4908c
Invalidate cache for neo deployments (#2209)
* Add additional parameters for invalidating cache

* Fetch bearer token

* Fetch x-csrf token

* Add echo for testing

* Add echo

* Add another echo

* Check status

* Debug

* Clean up

* Throw exception

* Code review changes

* Review changes

* Add test

* Fix tests

* Fetch bearer token

* Fetch x-csrf token

* Add echo for testing

* Add echo

* Add another echo

* Check status

* Debug

* Resolve conflicts

* Resolve conflicts

* Code review changes

* Review changes

* fix conflicts

* Fix indent

* Add new parameter to define portal landscape region

* Add default value for new param

* Fix test

* Remove example

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>

* Check cache invalidation for html5 apps

* Add nesting

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>

* Add docu for invalidating cache for html5 apps (#2306)

* Add docu for invalidating cache for html5 apps

* Improve content

* Docu review changes

* Remove heading

Co-authored-by: Sarah Lendle <44202907+SarahLendle@users.noreply.github.com>

* Update documentation/docs/steps/neoDeploy.md

Co-authored-by: Sarah Lendle <44202907+SarahLendle@users.noreply.github.com>

Co-authored-by: Sarah Lendle <44202907+SarahLendle@users.noreply.github.com>

Co-authored-by: Oliver Feldmann <oliver.feldmann@sap.com>
Co-authored-by: Sarah Lendle <44202907+SarahLendle@users.noreply.github.com>
2020-11-09 12:15:00 +01:00
Kevin Stiehl
0f48a229d2
(Vault) add vaultSecretFile References (#2314)
* add vaultSecretFile References

* add vaultRef to protecode

Co-authored-by: Oliver Nocon <33484802+OliverNocon@users.noreply.github.com>
2020-11-06 18:06:19 +01:00
Stephan Aßmus
14d7196495
Accumulate config validation errors (#2323)
* Instead of letting the pipeline fail for the first config validation error, accumulate all errors and output them to the log, then fail.
* Beginnings of a resource for validating a config.yml migrated to the GPP. Can be configured in the general section:
```yaml
general:
  legacyConfigSettings: 'com.sap.piper/pipeline/cloudSdkToGppConfigSettings.yml'
```
2020-11-06 10:17:26 +01:00
Gordon Franke
a19cbd63ee
change slack color to reflect all states (#2320)
I have used the colors from blue ocean.

Co-authored-by: Christopher Fenner <26137398+CCFenner@users.noreply.github.com>
2020-11-05 14:16:00 +01:00