mirror of
https://github.com/SAP/jenkins-library.git
synced 2025-01-30 05:59:39 +02:00
4f6b99cead
First a bug fix is addressed in which the pull policy could not be configured to false by configuring the general configuration. It could neither be configured via dockerExecute or dockerExecuteOnKubernetes, even though this parameter is docker specific. Only by configuring the specific step where one wants to set the pull policy to false can it be configured. As the bug stems from zero values being in the context config map, which is also addressed with this PR. That is the second part: Context config parameters are only set if they have a value. * Don't set pull image if not configured Otherwise, if the pull policy is not set explicitly for a step, dockerPullImage is set to true. Thus, before this change, it cannot be set in the general, or in dockerExecute or in dockerExecuteOnKubernetes configuration. * Fix unit tests * Add pullImage parameter test * Do not place empty default values in context config * Use putIfNotEmpty for sidecar container options * Export common configuration Keys that are set by both main and sidecar container can be exported Co-authored-by: Stephan Aßmus <stephan.assmus@sap.com>
Project Piper Repository
The Project "Piper" offers default pipelines to easily implement CI/CD processes integrating SAP systems. The corresponding "Shared Library" provides a set of "steps" to build your own scenarios beyond defaults.
User Documentation
If you want to view the User Documentation of Project Piper please follow this Piper Pages Link.
Known Issues
A list of known issues is available on the GitHub issues page of this project.
How to obtain support
Feel free to open new issues for feature requests, bugs or general feedback on the GitHub issues page of this project.
Register to our google group in order to get updates or for asking questions.
Contributing
Read and understand our contribution guidelines before opening a pull request.