1
0
mirror of https://github.com/google/comprehensive-rust.git synced 2025-06-16 14:17:34 +02:00

726 Commits

Author SHA1 Message Date
71c68a6996 Adds speaker notes for 6.4.1. String vs str
Adds speaker notes including:
-Brief explanation of &str, String type
-String::from and String::new
-push_str method
2023-01-16 11:06:40 +01:00
d1dc1f466a Merge pull request from sahennenkamp/patch-1
Hint towards making library mut
2023-01-14 08:07:10 +01:00
61163d019c Merge pull request from baltuky/rust_memory_management_typo
Fix a typo on the Memory Management in Rust page
2023-01-14 08:06:33 +01:00
f118a78ef2 Fix typo in rust.md 2023-01-14 01:45:36 +01:00
fdf26a776f Hint towards making library mut
Follow up to https://github.com/google/comprehensive-rust/pull/137
Gives the student a hint that it's okay to edit variables within main.
2023-01-13 14:45:47 -08:00
74e2ba6acd Merge pull request from rastringer/patch-1
Adds speaker notes for 6.4.1. String vs str
2023-01-13 14:05:19 +00:00
47435cbf41 Adds speaker notes for 6.4.1. String vs str
Adds speaker notes including:
-Brief explanation of &str, String type
-String::from and String::new
-push_str method
2023-01-13 13:14:19 +00:00
35893e2bc6 Update src/ownership/lifetimes-data-structures.md
Co-authored-by: Martin Geisler <martin@geisler.net>
2023-01-13 12:47:15 +01:00
53706056e3 Update src/ownership/lifetimes-data-structures.md
Co-authored-by: Martin Geisler <martin@geisler.net>
2023-01-13 12:47:01 +01:00
77f24ffab7 Add speaker notes for lifetimes-data-structures.md 2023-01-12 19:36:40 +01:00
9c652d06aa Add speaker notes for moves-function-calls.md 2023-01-12 18:23:57 +01:00
ddd68c5b0f Merge pull request from rastringer/patch-1
Speaker notes to 6.4 Slices
2023-01-12 17:16:57 +01:00
67b65c5ee8 Simplify language in speaker notes 2023-01-12 17:13:46 +01:00
d85643d5ac Update src/basic-syntax/slices.md
Co-authored-by: Martin Geisler <martin@geisler.net>
2023-01-12 16:11:46 +00:00
f4b651456c Speaker notes to 6.4 Slices
Brief digest of the slice type, including mentions of borrowing, range syntax and lifetimes.
2023-01-12 15:53:16 +00:00
39693b929b Merge pull request from fbornhofen/speaker-notes-2
Re-add link that is still in use
2023-01-12 14:31:20 +01:00
81ba5b6a06 Merge pull request from google/defunct-speaker-notes
Simplify state transitions for speaker notes
2023-01-12 12:45:28 +01:00
3dd03bbd65 Re-add link that is still in use 2023-01-12 12:33:03 +01:00
b7de49e1b8 Simplify state transitions for speaker notes
Before, we attempted to change state from “popup” to “inline-open”
when the speaker note window was closed.

We did this by listening to “pagehide” and change the state there. The
event fires every time you navigate away from the page, so we had a
complex setup where we would reset the state to “popup” when the next
page was loaded into the speaker note window.

The problem with this is that it’s racy: we could end up in a
situation where we set the state to “inline-open” right after the
speaker note window was updated. When that happened, we would mark the
window as “defunct”, meaning that it was supposed to be closed.

With this change, we no longer try to change the state from the
speaker note window. If the window is lost (closed), the user will
have to click the “Close speaker notes” button in the top-right to
reset the state. This should be much more reliable.

Long-term, a better solution would be to let the speaker notes fetch
the current URL using JavaScript instead of doing it via an actual
page navigation. That should allow us to react to “pagehide” events
again (since they won’t fire on every page transition).
2023-01-12 12:31:26 +01:00
92dafcb676 Merge pull request from brandonpollack23/stackheap
Add speaker notes to stack and heap pages
2023-01-12 11:53:54 +01:00
45e57e9359 Capitalization in stack.md 2023-01-12 11:51:37 +01:00
7203bb8a65 Capitalization in src/memory-management/rust.md 2023-01-12 11:50:28 +01:00
bd1c8edc3c Merge pull request from fbornhofen/speaker-notes
Speaker notes: cosmetic fixes for compund-types.md, borrowing.md
2023-01-12 11:38:43 +01:00
e8ed8cb5de Clean up playground link in borrowing.md 2023-01-12 11:32:11 +01:00
83cd7ab67b Fix typo in borrowing.md 2023-01-12 11:27:57 +01:00
a3ec024fba Fix formatting in compound-types.md 2023-01-12 11:26:48 +01:00
ff86e67fb1 Merge pull request from ilyagr/speaker-notes
Add speaker notes about error examples
2023-01-12 07:31:29 +01:00
acdf00ae6e Add speaker notes about error examples 2023-01-11 18:14:58 -08:00
f750f75db6 stackheap notes 2023-01-12 11:12:53 +09:00
a8fb8ad2b6 Merge pull request from google/running-the-course
Add instructions about how to run the course
2023-01-11 18:28:22 +01:00
4ca2469274 Merge pull request from google/show-speaker-notes-on-print
Show expanded speaker notes on print page
2023-01-11 18:25:04 +01:00
0b7b69df10 Merge pull request from google/solution-speaker-notes
Add speaker notes to exercise pages
2023-01-11 16:46:55 +01:00
d037d7b5c7 Merge pull request from rastringer/patch-1
Adds speaker notes to Compound Types section
2023-01-11 15:51:53 +01:00
b6bec18875 Clarify that "fixed" means "compile-time constant" 2023-01-11 15:49:10 +01:00
41bb8acf3f Removes out of bounds checks for simplicity
Removes the out of bounds checks to keep the notes simple.
2023-01-11 14:35:20 +00:00
6019a946d9 Merge pull request from fbornhofen/speaker-notes
Speaker notes for box.md, rc.md, option-result.md
2023-01-11 14:49:03 +01:00
6b8ee3c979 Fix typo 2023-01-11 14:47:34 +01:00
3bb3634c7a Merge pull request from fcasal/patch-1
Fix typo on Luhn exercise
2023-01-11 13:33:31 +00:00
02e1f4b879 Add speaker notes for option-result.md 2023-01-11 14:19:21 +01:00
dd194f07c9 Add speaker notes for rc.md 2023-01-11 14:04:30 +01:00
5256d9c3fd Add speaker notes for box.md 2023-01-11 13:29:43 +01:00
de9d67205e Fix typo on Luhn exercise 2023-01-11 12:11:06 +00:00
1085e9c20b Add speaker notes to exercise pages
The notes link to the corresponding solutions.
2023-01-11 12:49:59 +01:00
587645db6c Clarify default vs debug output. 2023-01-11 10:49:21 +01:00
d1422e93c2 Merge pull request from fbornhofen/speaker-notes-string
Add speaker notes for string.md
2023-01-10 19:55:59 +01:00
da81dfa07f Simplify char count 2023-01-10 19:54:48 +01:00
08af7574bb Add instructions about how to run the course
I think we need a chapter “before the course” which gives people some
background information about how to run the course. This is the start
of this chapter, we might expand it in the future as we find more
things to communicate here.
2023-01-10 19:12:57 +01:00
b2b11257f5 Add speaker notes for string.md 2023-01-10 19:06:06 +01:00
4e746482f2 Merge pull request from fbornhofen/speaker-notes-if-let
Add speaker notes for if-let-expressions.md
2023-01-10 18:58:53 +01:00
1b3eaec5e7 Merge pull request from brandonpollack23/static_const
Added notes, runtime constant eval, and footnoes to static-and-const.md
2023-01-10 18:53:46 +01:00