Martin Geisler
b29dd1ae09
Merge pull request #31 from google/mdbook-test
...
Add a build workflow to test PRs
2022-12-22 19:56:54 +01:00
Laurent Lyaudet
1315481e69
Corrected 1 or 2 typos
...
missing verb :
"The goal of the course to teach you Rust." -> "The goal of the course is to teach you Rust."
missing of ? :
"to cover all it" -> "to cover all of it"
for this one, I'm not a native english speaker but it seems more correct to me. I'll let you check :)
2022-12-22 18:33:02 +01:00
Martin Geisler
11789caee2
Add a build workflow to test PRs
...
We will expand this to build/test other things in the future.
2022-12-22 15:22:41 +01:00
Martin Geisler
85c1684fe3
Include version numbers when installing mdbook
2022-12-22 15:01:55 +01:00
Tom Niget
5dd366d7db
Remove part about Rc
2022-12-22 14:24:47 +01:00
Tom Niget
7b7b56398e
Add footnote about memory leaks
2022-12-22 14:03:18 +01:00
Taufik Rama
b9eed2a072
Minor sidenote for rustup installation as an alternative to distro package manager
2022-12-22 19:49:58 +07:00
Martin Geisler
15b8ca8a05
Merge pull request #22 from Arthur-Milchior/patch-1
...
Clarify from/into
2022-12-22 13:23:55 +01:00
Max Schumacher
adc64c020b
fix typo
2022-12-22 11:52:44 +01:00
Martin Geisler
121a7d33f3
Merge pull request #7 from andrewpollack/patch-5
...
Minor punctuation update
2022-12-22 10:08:16 +01:00
Martin Geisler
0e74800885
Merge pull request #9 from andrewpollack/patch-7
...
Minor punctuation addition
2022-12-22 10:07:58 +01:00
Andrew Pollack
7a215992b4
Minor typo, punctuation update ( #5 )
...
* Minor typo
2022-12-22 10:07:26 +01:00
Martin Geisler
d66506fe35
Merge pull request #3 from andrewpollack/patch-1
...
Adding colon punctuation to lists
2022-12-22 10:06:15 +01:00
Martin Geisler
1a7df6cfb1
Merge pull request #6 from andrewpollack/patch-4
...
Minor punctuation update
2022-12-22 10:05:53 +01:00
Martin Geisler
ed0a11a86b
Merge pull request #10 from andrewpollack/patch-8
...
Minor punctuation update
2022-12-22 10:05:08 +01:00
Martin Geisler
d80b91b3fd
Merge pull request #20 from lonesometraveler/typo
...
typo: assigment -> assignment
2022-12-22 10:03:35 +01:00
Martin Geisler
b424abf704
Merge pull request #14 from google/gh-action-cache
...
Cache the artifacts built by the publish workflow
2022-12-22 09:45:16 +01:00
Arthur Milchior
638dde7704
Clarify from/into
...
I found the phrasing confusing. Mentionning that a class implements From and then using `into()` seems confusing. It looks like that you meant that it implements `Into`.
So I believe that a little more details may help show why this exercise is valid.
I would have considered clarifying that `into` does not need to specify that we use the implementation for `i16` thanks to type analysis, but I assume this would add too much text, and this can either be ignored by the reader for the time being, or guessed
2022-12-21 16:46:23 -08:00
Kentaro Okuda
62f530d5ac
typo: assigment -> assignment
2022-12-21 19:45:02 -05:00
Tom Niget
b411aa688a
typo: hygenic -> hygienic
2022-12-21 21:43:53 +00:00
sharnoff
a6b5c7171d
grammar/typo: it's -> its
2022-12-21 21:42:58 +00:00
Martin Geisler
a96f48456d
Merge pull request #15 from jrvanwhy/unsafe-skip-details
...
`welcome.md`: indicate we skip the subtle details of unsafe Rust
2022-12-21 19:19:20 +01:00
Martin Geisler
24283c9806
Merge pull request #4 from andrewpollack/patch-2
...
Suggestion: link to Cargo book on introduction
2022-12-21 19:03:43 +01:00
Martin Geisler
d4655aae9d
Merge pull request #13 from andrewpollack/patch-10
...
Minor punctuation update
2022-12-21 19:03:19 +01:00
Johnathan Van Why
8f60685165
welcome.md: indicate we skip the subtle details of unsafe Rust
...
This sentence was missing a negation: it was supposed to say this course does not cover unsafe Rust in depth, but actually said "we go into the subtle details". This PR adds the missing negation.
2022-12-21 10:01:11 -08:00
Martin Geisler
653a818b8b
Cache the artifacts built by the publish workflow
...
This should speed up the publication: right now we spend around 4
minutes to build `mdbook` and `mdbook-svgbob`.
With this change, we will only pay that cost once a week (caches
created by GitHub Actions last 7 days[1]).
[1]: https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#usage-limits-and-eviction-policy
2022-12-21 18:49:41 +01:00
Andrew Pollack
d752b11694
Minor punctuation update ( #11 )
...
* Minor punctuation update
* Update sync.md
2022-12-21 17:41:58 +00:00
Martin Geisler
19ec43b8ec
Merge pull request #12 from google/link-to-material
...
Add link to course material
2022-12-21 18:40:02 +01:00
Martin Geisler
ebd33a5b5f
Merge pull request #8 from andrewpollack/patch-6
...
Add link to FizzBuzz definition
2022-12-21 18:39:49 +01:00
Andrew Pollack
e203586182
Minor punctuation update
2022-12-21 09:38:05 -08:00
Martin Geisler
68b9d6c0e2
Add link to course material
2022-12-21 18:37:55 +01:00
Andrew Pollack
6809d4ef78
Minor punctuation update
2022-12-21 09:33:44 -08:00
Andrew Pollack
6d622a8d58
Minor punctuation addition
2022-12-21 09:31:53 -08:00
Andrew Pollack
9c1a1a6d90
Add link to FizzBuzz definition
...
For those who are lucky enough to not know what FizzBuzz intends to accomplish 😹
2022-12-21 09:30:55 -08:00
Andrew Pollack
62c856f1d7
Minor punctuation update
2022-12-21 09:29:04 -08:00
Andrew Pollack
4648bd1f8e
Minor punctuation update
...
Bringing list punctuation in line with rest of course
2022-12-21 09:27:46 -08:00
Andrew Pollack
f155d68a8d
Suggestion: link to Cargo book on introduction
2022-12-21 09:22:30 -08:00
Andrew Pollack
90e23ab4c6
Adding colon punctuation to lists
...
Minor addition to make punctuation consistent on Welcome page
2022-12-21 09:20:30 -08:00
Martin Geisler
c274f86cfd
Merge pull request #2 from google/github-links
...
GitHub links
2022-12-21 17:55:30 +01:00
Martin Geisler
ced70fce79
Add links to edit every page on GitHub
...
This makes it super easy to edit a page: just click the icon in the
top-right and you’ll be taken directly to an editor on GitHub.
2022-12-21 17:29:56 +01:00
Martin Geisler
53f0674756
Link back to repository in top-right corner
2022-12-21 17:28:02 +01:00
Martin Geisler
c129ed2453
Merge pull request #1 from qwandor/patch-1
...
Fix typo
2022-12-21 17:12:54 +01:00
Andrew Walbran
f3ff5b994b
Fix typo
2022-12-21 16:02:37 +00:00
Martin Geisler
0e6c7e30d7
Create publish.yml
...
This is for publishing the course on GitHub Pages.
2022-12-21 16:50:05 +01:00
Martin Geisler
c212a473ba
Publish Comprehensive Rust 🦀
2022-12-21 16:38:28 +01:00
