Seamus Connor
6cb3254cf1
Correct compilation error in unit-tests.md
2023-01-01 13:57:19 -08:00
Martin Geisler
51cbf29d92
Merge pull request #79 from riking/patch-1
...
comparison: copyedit 'delays' to 'delayed'
2022-12-31 12:35:24 +01:00
Martin Geisler
150e78a3f9
Rephrase destructor delays
...
After a discussion, it seems singular works well.
2022-12-31 12:33:57 +01:00
Martin Geisler
8a8f44b568
Merge pull request #89 from jswalden/patch-3
...
Typo in "Fearless Concurrency" intro
2022-12-31 12:27:00 +01:00
Jeff Walden
1ae03443d5
"a classic problem", not "...problems"
2022-12-30 21:54:35 -08:00
Jeff Walden
9def3e371d
Typo in "Fearless Concurrency" intro
...
"referred to a _fearless concurrency_" -> "referred to a*s* _fearless concurrency_"
2022-12-30 20:53:38 -08:00
Martin Geisler
d8fd38b88a
Merge pull request #81 from google/utf-8-encoding
...
Mention that strings are UTF-8 encoded
2022-12-28 20:38:46 +01:00
Martin Geisler
d7a33f24a6
Merge pull request #83 from google/mention-arc
...
Mention `Arc` on `Rc` slide
2022-12-28 20:38:22 +01:00
Martin Geisler
4a0455f5bd
Merge pull request #85 from der3318/update-test-cases-for-polygons
...
Better Test Case for Day 2 Polygon Exercise
2022-12-28 15:46:15 +01:00
Martin Geisler
6851a6b533
Show different tuple sizes
2022-12-28 15:41:08 +01:00
Der Chien
0b77fc6bf3
20221228 revert the points length check
2022-12-28 22:39:52 +08:00
Der Chien
42494f95ab
20221228 add one more point to the polygon
2022-12-28 21:49:01 +08:00
Arman Yessenamanov
8470be86d0
Fix a typo
2022-12-28 18:58:23 +06:00
Martin Geisler
7ee63aced6
Mention Arc
on Rc
slide
...
Fixes #67 .
2022-12-28 10:15:17 +01:00
Martin Geisler
cac0641a54
Mention that strings are UTF-8 encoded
...
Technically, it's the Rust source file that is UTF-8 encoded, but in practical terms, this means that the string literals are UTF-8 encoded. It's only if you start using non-ASCII identifiers that you end up with UTF-8 encoded text outside of a string literal.
Fixes #35 .
2022-12-28 09:32:28 +01:00
Martin Geisler
dcf29d4653
Merge pull request #74 from google/try-operator
...
More precise phrasing of what ? expands to
2022-12-28 09:26:18 +01:00
Martin Geisler
94cd8bb592
Link to reference on method receiver types
2022-12-28 09:19:19 +01:00
Kane York
de7d91752f
comparison: copyedit 'delays' to 'delayed'
...
This is the correct grammatical form for the bullet point, it expands into "Destructors [of objects are] delayed."
2022-12-27 14:13:10 -08:00
Martin Geisler
82a2f4c423
Mention that there are other receiver types
2022-12-27 18:16:21 +01:00
Martin Geisler
c15e84f63e
More precise phrasing of what ? expands to
...
As per the suggestion from @QuineDot in #65 .
2022-12-27 18:09:54 +01:00
Martin Geisler
c7eff6b85e
Merge pull request #55 from Arthur-Milchior/patch-5
...
Fix typo on Send+Sync page
2022-12-27 17:19:07 +01:00
Martin Geisler
4295b8da5c
Further refine language as per @QuineDot's idea
2022-12-27 17:17:38 +01:00
Martin Geisler
f217cd12a2
Merge pull request #54 from Arthur-Milchior/patch-4
...
Typos
2022-12-27 17:16:13 +01:00
Martin Geisler
cc0c02aa14
Copy-editing on the shared state page
...
The access is to the specific `T` value found in the `Mutex<T>`.
2022-12-27 17:14:45 +01:00
Martin Geisler
d052db8874
Merge pull request #73 from janosh/fix-casing-types-bit-width
...
Fix casing in type bit widths
2022-12-27 16:46:57 +01:00
Martin Geisler
bc37d48cb0
Merge pull request #61 from pdecat/patch-1
...
Remove misplaced "calls"
2022-12-27 16:40:08 +01:00
Janosh Riebesell
cf695a99e3
fix casing in type bit widths
2022-12-26 19:35:09 -08:00
Patrick Decat
b5cbe4896b
Remove misplaced "calls"
2022-12-26 11:22:00 +01:00
Mathias M
fe3651df02
Fixes typo
2022-12-26 09:12:00 +01:00
Tom Niget
f82867b2bb
Precise what the Android parts are about ( fixes #56 )
2022-12-25 17:12:42 +01:00
Arthur Milchior
2b2e006417
Typo
...
Not sure of the intended meaning. At least the sentence is true and gramattically correct here
2022-12-24 20:39:48 -08:00
Arthur Milchior
94933b43f1
Typos
2022-12-24 20:23:43 -08:00
Jeff Walden
75f6d0b5bd
Insert "a" in a sentence that's missing it
2022-12-23 23:05:21 -08:00
Ilya Grigoriev
5ce7a08f0e
anyhow
: say this example has fewer custom types
2022-12-23 13:35:40 -08:00
Ilya Grigoriev
894e694cdb
anyhow
: Remove ReadUsernameError::IoError
...
As far as I understand, the example with the `anyhow` example
does not use its special `IoError` anymore, unlike the previous
example with just `thiserror`.
I think this should be made clear. I considered just adding a
`// Now unused` comment, but I think ti's clearer to just remove
the unused code.
2022-12-23 13:32:03 -08:00
Martin Geisler
0218fdb1f0
Merge pull request #46 from matm/patch-1
...
Fixes typo in comment
2022-12-23 14:26:30 +01:00
Martin Geisler
80edc895db
Merge pull request #42 from reillyeon/patch-2
...
Change "semantics is" to "semantics are"
2022-12-23 12:57:32 +01:00
Martin Geisler
2b91c8c818
Merge pull request #44 from drgnchan/patch-1
...
Fix grammer in references-dangling.md
2022-12-23 12:41:59 +01:00
Mathias M
69cd18f12a
Fixes typo in comment
2022-12-23 12:03:03 +01:00
Martin Geisler
61aa12e3f3
Merge pull request #27 from taufik-rama/docs/rustup-installation
...
Mention rustup.rs on the installation page
Fixes #19 .
2022-12-23 11:41:30 +01:00
Martin Geisler
1b59aa5d71
Merge pull request #45 from Arthur-Milchior/patch-3
...
Makes ownership of `self` more accurate
2022-12-23 11:39:08 +01:00
Martin Geisler
952e778527
Merge pull request #43 from reillyeon/patch-3
...
Grammar fix in ownership/lifetimes-function-calls.md
2022-12-23 11:34:51 +01:00
Martin Geisler
21a2bb235f
Merge pull request #41 from reillyeon/patch-1
...
Fix C array syntax in memory-management/manual.md
2022-12-23 11:27:15 +01:00
Taufik Rama
b9085905f1
Simplifies rustup
2022-12-23 17:11:24 +07:00
Arthur Milchior
3631117446
Makes ownership of self
more accurate
...
It’s entirely possible that a method gives ownership of self to another object, or return `self`.
For example
```
fn id(self) -> Self {
return self;
}
```
or more realistically
```
fn or(self, other) -> Self {
if (self.isValid()) { return self;}
return other;
}
```
2022-12-23 00:16:42 -08:00
drgnchan
73e9a0b854
Update references-dangling.md
2022-12-23 15:41:41 +08:00
Reilly Grant
9464def62e
Grammar fix in ownership/lifetimes-function-calls.md
2022-12-22 22:09:17 -08:00
Reilly Grant
5223ef8f25
Change "semantics is" to "semantics are"
...
Subject-verb agreement.
2022-12-22 22:05:38 -08:00
Reilly Grant
16d4d2c92f
Fix C array syntax in memory-management/manual.md
...
Heap-allocated arrays in C use `int*` instead of `int[]`.
2022-12-22 21:58:08 -08:00
Kian-Meng Ang
54adbe7f55
Misc doc fixes
...
List of changes:
- fix typos found via `codespell -S target -L crate`
- ignore Cargo.lock
2022-12-23 11:24:51 +08:00
Martin Geisler
264047445f
Merge pull request #28 from zdimension/patch-2
...
Add footnote about memory leaks
2022-12-22 20:29:10 +01:00
Danny Milosavljevic
4126cbd519
Tuples with "..." make no sense, so don't use them
2022-12-22 20:25:15 +01:00
Martin Geisler
06b594b47a
Merge pull request #26 from mxschumacher/patch-1
...
Fix typo
2022-12-22 20:18:54 +01:00
Tom Niget
3bed28a9d9
Add "mostly"
2022-12-22 20:18:36 +01:00
Laurent Lyaudet
1315481e69
Corrected 1 or 2 typos
...
missing verb :
"The goal of the course to teach you Rust." -> "The goal of the course is to teach you Rust."
missing of ? :
"to cover all it" -> "to cover all of it"
for this one, I'm not a native english speaker but it seems more correct to me. I'll let you check :)
2022-12-22 18:33:02 +01:00
Tom Niget
5dd366d7db
Remove part about Rc
2022-12-22 14:24:47 +01:00
Tom Niget
7b7b56398e
Add footnote about memory leaks
2022-12-22 14:03:18 +01:00
Taufik Rama
b9eed2a072
Minor sidenote for rustup
installation as an alternative to distro package manager
2022-12-22 19:49:58 +07:00
Martin Geisler
15b8ca8a05
Merge pull request #22 from Arthur-Milchior/patch-1
...
Clarify from/into
2022-12-22 13:23:55 +01:00
Max Schumacher
adc64c020b
fix typo
2022-12-22 11:52:44 +01:00
Martin Geisler
121a7d33f3
Merge pull request #7 from andrewpollack/patch-5
...
Minor punctuation update
2022-12-22 10:08:16 +01:00
Martin Geisler
0e74800885
Merge pull request #9 from andrewpollack/patch-7
...
Minor punctuation addition
2022-12-22 10:07:58 +01:00
Andrew Pollack
7a215992b4
Minor typo, punctuation update ( #5 )
...
* Minor typo
2022-12-22 10:07:26 +01:00
Martin Geisler
d66506fe35
Merge pull request #3 from andrewpollack/patch-1
...
Adding colon punctuation to lists
2022-12-22 10:06:15 +01:00
Martin Geisler
1a7df6cfb1
Merge pull request #6 from andrewpollack/patch-4
...
Minor punctuation update
2022-12-22 10:05:53 +01:00
Martin Geisler
ed0a11a86b
Merge pull request #10 from andrewpollack/patch-8
...
Minor punctuation update
2022-12-22 10:05:08 +01:00
Arthur Milchior
638dde7704
Clarify from/into
...
I found the phrasing confusing. Mentionning that a class implements From and then using `into()` seems confusing. It looks like that you meant that it implements `Into`.
So I believe that a little more details may help show why this exercise is valid.
I would have considered clarifying that `into` does not need to specify that we use the implementation for `i16` thanks to type analysis, but I assume this would add too much text, and this can either be ignored by the reader for the time being, or guessed
2022-12-21 16:46:23 -08:00
Kentaro Okuda
62f530d5ac
typo: assigment -> assignment
2022-12-21 19:45:02 -05:00
Tom Niget
b411aa688a
typo: hygenic -> hygienic
2022-12-21 21:43:53 +00:00
sharnoff
a6b5c7171d
grammar/typo: it's -> its
2022-12-21 21:42:58 +00:00
Martin Geisler
a96f48456d
Merge pull request #15 from jrvanwhy/unsafe-skip-details
...
`welcome.md`: indicate we skip the subtle details of unsafe Rust
2022-12-21 19:19:20 +01:00
Martin Geisler
24283c9806
Merge pull request #4 from andrewpollack/patch-2
...
Suggestion: link to Cargo book on introduction
2022-12-21 19:03:43 +01:00
Martin Geisler
d4655aae9d
Merge pull request #13 from andrewpollack/patch-10
...
Minor punctuation update
2022-12-21 19:03:19 +01:00
Johnathan Van Why
8f60685165
welcome.md
: indicate we skip the subtle details of unsafe Rust
...
This sentence was missing a negation: it was supposed to say this course does not cover unsafe Rust in depth, but actually said "we go into the subtle details". This PR adds the missing negation.
2022-12-21 10:01:11 -08:00
Andrew Pollack
d752b11694
Minor punctuation update ( #11 )
...
* Minor punctuation update
* Update sync.md
2022-12-21 17:41:58 +00:00
Andrew Pollack
e203586182
Minor punctuation update
2022-12-21 09:38:05 -08:00
Andrew Pollack
6809d4ef78
Minor punctuation update
2022-12-21 09:33:44 -08:00
Andrew Pollack
6d622a8d58
Minor punctuation addition
2022-12-21 09:31:53 -08:00
Andrew Pollack
9c1a1a6d90
Add link to FizzBuzz definition
...
For those who are lucky enough to not know what FizzBuzz intends to accomplish 😹
2022-12-21 09:30:55 -08:00
Andrew Pollack
62c856f1d7
Minor punctuation update
2022-12-21 09:29:04 -08:00
Andrew Pollack
4648bd1f8e
Minor punctuation update
...
Bringing list punctuation in line with rest of course
2022-12-21 09:27:46 -08:00
Andrew Pollack
f155d68a8d
Suggestion: link to Cargo book on introduction
2022-12-21 09:22:30 -08:00
Andrew Pollack
90e23ab4c6
Adding colon punctuation to lists
...
Minor addition to make punctuation consistent on Welcome page
2022-12-21 09:20:30 -08:00
Andrew Walbran
f3ff5b994b
Fix typo
2022-12-21 16:02:37 +00:00
Martin Geisler
c212a473ba
Publish Comprehensive Rust 🦀
2022-12-21 16:38:28 +01:00