rust/comprehensive-rust
1
0
Fork 0
mirror of https://github.com/google/comprehensive-rust.git synced 2025-01-26 06:55:40 +02:00
Code Issues Releases Activity
1,948 Commits 18 Branches 0 Tags
Commit Graph

199 Commits

Author SHA1 Message Date
dependabot[bot]
b3bbf6ceda
Bump crate-ci/typos from 1.23.2 to 1.23.5 (#2255) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.23.2 to
1.23.5.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-07-29 09:41:10 +00:00
Jonathan Daniel
4c28a9253b
Set Rust caching key per language group (#2250) 
Fixes #2247 (a follow-up from #2195).

* Add a workflow dispatch manual trigger to the tests workflow.
* Move the link-checked languages JSON list to the build job's env.
* Set a caching key per language group to avoid extra `mdbook-linkcheck`
installation on non-link-checked translations.
  For the meaning of this key, see:
https://github.com/Swatinem/rust-cache?tab=readme-ov-file#example-usage
* Fix newly broken web link in 8a3ed21 ✅ 

I tested it on my fork, and it looks good:
https://github.com/jond01/comprehensive-rust/actions/workflows/build.yml
https://github.com/jond01/comprehensive-rust/actions/caches
 2024-07-29 10:28:12 +01:00
Jonathan Daniel
1c964f6fe3
Fix a broken link and check internal links (#2195) 
In #2153 I aimed to fix a link but broke it.
In this PR, I fix it and add
[`mdbook-linkcheck`](https://github.com/Michael-F-Bryan/mdbook-linkcheck)
to avoid future cases.

Some past fixes that could have been prevented, in addition to mine in
this PR:
* #811
* #2064
* #2146

Note:  
`mdbook-linkcheck` may also check external links with a configuration
change.
It can be beneficial to check also external links from time to time. I
ran it here and found 3 broken links.

Maintainers - sorry for the lack of a preceding issue. We can discuss it
here.
Some remaining work is to fix the outdated internal links in the
translations, not done here.
Let me know what you think about the proposed contribution.

This PR completes #1502.
 2024-07-22 11:37:19 +00:00
Andrew Walbran
92de96f066
Fix direction of translation diff. (#2235) 
It was showing the diff from new to old, rather than old to new.
 2024-07-19 15:28:34 +00:00
Max Heller
df2076b111
Upgrade mdbook-pandoc and disable it except during CI workflows (#2212) 
Implements the approach summarized in
https://github.com/google/mdbook-i18n-helpers/issues/200#issuecomment-2220035461
to disable running `mdbook-pandoc` even if it is available to avoid
dependency-related issues during local rendering.

Should address https://github.com/google/comprehensive-rust/issues/1911
since `mdbook-pandoc` will no longer run locally.
 2024-07-18 13:01:25 +02:00
dependabot[bot]
054169992e
build(deps): bump crate-ci/typos from 1.23.1 to 1.23.2 (#2230) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.23.1 to
1.23.2.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-07-15 10:33:11 +01:00
Andrew Walbran
d1b82a8e5c
Diff translations on every PR (#2214) 
This uses a new mode of `i18n-report` to summarise the differences in
translations as an action on each PR.
 2024-07-13 12:26:16 +01:00
Henri F
538f6eb680
Prune CODEOWNERS file (#2210) 
Removed users without access to the repository.
#2050
 2024-07-10 08:59:49 +02:00
Andrew Walbran
b68f563e45
Martin prefers hyphens to underscores (#2207) 2024-07-09 09:19:16 -04:00
Andrew Walbran
82b9f6950b
Fix publish workflow for synced translation report (#2203) 
Building the synced translation report requires gettext for `msgmerge.`
 2024-07-08 15:31:20 +00:00
Andrew Walbran
c39b6b01d7
Publish report of translation status. (#2190) 2024-07-08 10:51:14 -04:00
dependabot[bot]
da7d40a553
build(deps): bump crate-ci/typos from 1.22.9 to 1.23.1 (#2202) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.9 to
1.23.1.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-07-08 08:56:52 +01:00
Henri F
5899752873
Add workflow support for Arabic translation (#2194) 
Part of : #445, #2193
 2024-07-08 08:51:52 +01:00
Younies Mahmoud
a976603da5
First step in Arabic Translation (#2193) 
Part of : #445
 2024-07-05 22:40:03 -07:00
Andrew Walbran
5db15cccb6
Publish all languages. (#2189) 2024-07-05 11:11:12 -07:00
Andrew Walbran
2de95fa2de
Fix publish workflow (#2171) 
Need to `apt-get update` before `apt-get install`.
 2024-06-25 09:42:16 -04:00
dependabot[bot]
c7425f91c4
build(deps): bump crate-ci/typos from 1.22.7 to 1.22.9 (#2162) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.7 to
1.22.9.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-06-25 10:48:20 +01:00
dependabot[bot]
a89a4d70ca
build(deps): bump crate-ci/typos from 1.22.3 to 1.22.7 (#2149) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.22.3 to
1.22.7.
 2024-06-17 09:10:02 -04:00
dependabot[bot]
53daee6993
build(deps): bump crate-ci/typos from 1.21.0 to 1.22.3 (#2134) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.21.0 to
1.22.3.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-06-10 09:38:06 +01:00
Darkhan Kubigenov
f337c0f70d
Upgrade dependencies in github actions (#2101) 2024-05-28 10:49:12 +02:00
Alexandra Imbrisca
3d999663ac
Add @AlexandraImbrisca to CODEOWNERS (#2091) 
Co-authored-by: Martin Geisler <martin@geisler.net>
 2024-05-22 11:17:25 +02:00
Razvan Musaloiu-E
23c5f66758
Add razvanm CODEOWNERS for ro.po (#2090) 2024-05-22 11:15:40 +02:00
Henri F
6b1b024a47
Update CODEOWNERS with new vi.po reviewer (#2051) 
Ignored unrelated failing tests.
 2024-05-21 20:30:17 -07:00
Martin Geisler
3d99e1badf
Retire @suetfei as zh-CN reviewer (#2059) 
I talked with Suet-fei and she told me that she does not have time to
review the translation.

Thanks for the help!
 2024-05-06 09:13:30 -07:00
dependabot[bot]
43f910aa41
build(deps): bump crate-ci/typos from 1.20.10 to 1.21.0 (#2055) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.20.10
to 1.21.0.
 2024-05-06 09:34:29 -04:00
dependabot[bot]
6f4f29e603
Bump crate-ci/typos from 1.20.9 to 1.20.10 (#2034) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.20.9 to
1.20.10.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-04-29 11:30:19 +01:00
dependabot[bot]
4259b63c44
Bump crate-ci/typos from 1.20.8 to 1.20.9 (#2018) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.20.8 to
1.20.9.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-04-22 09:14:00 +02:00
Caleb Maclennan
487d1710c9
Add @alerque as a reviewer for the Turkish translation (#1999) 
See invitation here:
https://github.com/google/comprehensive-rust/pull/1971#issuecomment-2061199545

Also note that @enes1313 is marked as a code owner, but they are *not* a
collaborator on the repository so the code owner features are
non-functional and this is considered an error by the GH parser.
Obviously there are two possible resolutions to that...
 2024-04-18 12:48:18 +02:00
Keiichi Watanabe
f103971cf4
Add @HidenoriKobayashi to CODEOWNERS for Japanese translation (#1997) 
@HidenoriKobayashi has been working on Japanese translation very well so
it'd be nice to have him as a CODEOWNER
 2024-04-16 14:11:34 +09:00
dependabot[bot]
956a1361f1
Bump crate-ci/typos from 1.20.4 to 1.20.8 (#1990) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.20.4 to
1.20.8.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-04-15 10:25:43 +01:00
Martin Geisler
8ed4d48aa5
Only save CI cache on main branch (#1962) 
When a PR restores the cache, it will find the most recent cache from
the `main` branch. This cache should be mostly up to date.

We are constantly at the 10 GB limit for our CI caches, so removing the
extra caches from the many PR branches should ensure that we always have
space for the `main` branch caches.
 2024-04-08 18:04:42 +02:00
dependabot[bot]
13336fc428
Bump crate-ci/typos from 1.19.0 to 1.20.4 (#1968) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.19.0 to
1.20.4.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-04-08 15:48:59 +01:00
Martin Geisler
620b8a3b72
Run mdbook test on translated code (#1961) 
I made a small mistake during the refactor in #1492: I removed the
`MDBOOK_BOOK__LANGUAGE` environment variable, which means that we ended
up testing the original Rust code snippets again and again.

This commit also fixes the few typos that have sneaked into the
translations due to the lack of testing.
 2024-04-07 19:38:18 +09:00
dependabot[bot]
6e8000e35d
Bump actions/configure-pages from 4 to 5 (#1953) 
Bumps
[actions/configure-pages](https://github.com/actions/configure-pages)
from 4 to 5.
 2024-04-01 11:26:15 -04:00
Henri F
6064631f50
Adding Vietnamese to the publish workflow. (#1933) 2024-03-26 10:47:13 -07:00
Henri F
eff410cd1a
Update CODEOWNERS with Vietnamese (#1932) 
Add @daivinhtran as Vietnamese codeowner.
 2024-03-24 22:57:35 +01:00
Henri F
6fc747aa05
Update labeler.yml with Vietnamese (#1931) 2024-03-22 16:55:06 +00:00
Max Heller
97ac0e7caf
set fallback fonts for PDF rendering (#1728) 
Once a new version of Pandoc is released that includes
https://github.com/jgm/pandoc/pull/9204 and
https://github.com/jgm/pandoc/pull/9353 (both merged), this will fix the
emoji and symbol rendering issues in #1708.

It doesn't seem to be possible to set fallback fonts with
`luatexja-fontspec` (used to configure CJK fonts), which results in some
missing symbols in the translations but at least renders the emoji
properly.

Closes #1708
 2024-03-07 14:37:52 +01:00
Martin Geisler
c866c13b68
Retire @duyguisler as a Turkish reviewer (#1880) 
Thanks for the work so far, feel free to come back if you have more
time!
 2024-03-06 17:04:53 +00:00
Manichand Kondapaka
0761f936ca
Add a dev theme to help with slide aspect ratio (#1842) 
Added a dev theme to help with slide aspect ratio while updating content
or for reviewing PRs.

Fixes #1796.

---------

Co-authored-by: Dustin J. Mitchell <djmitche@google.com>
Co-authored-by: Martin Geisler <martin@geisler.net>
 2024-03-05 10:33:42 +00:00
Martin Geisler
c509dbd9e4
Always install and run mdbook-pandoc (#1713) 
Before, we only installed and ran `mdbook-pandoc` when publishing the
course — which means that a PR change could accidentally break the
publish workflow. We now test that it works on every PR.

From a discussion in #1704.
 2024-03-04 16:25:58 +01:00
Gergely Risko
e74a8b77bd
URGENT: Fix course schedule watcher github action (#1867) 
@djmitche Currently all PRs are marked as schedule change PRs.

This is my try to propose a fix for this, but please review diligently,
I'm no github actions expert, and I don't have an environment to test.
 2024-03-04 09:39:30 -05:00
dependabot[bot]
2bed943920
build(deps): bump crate-ci/typos from 1.18.2 to 1.19.0 (#1872) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.18.2 to
1.19.0.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-03-04 10:54:38 +00:00
Dustin J. Mitchell
adff70d025
Update course-schedule PR comments in-place (#1856) 
Instead of always adding a new comment, just update the existing comment
if one exists.

This fixes #1834.
 2024-02-29 10:51:37 -05:00
Dustin J. Mitchell
152354e9c9
Put a header on schedule comments (#1814) 
This will add a little more context. See the current result in
https://github.com/google/comprehensive-rust/pull/1813.
 2024-02-20 09:19:14 -05:00
Max Heller
8080e2add6
Rendered PDF improvements (#1805) 
Updates `mdbook-pandoc` to
[0.5.0](https://github.com/max-heller/mdbook-pandoc/releases/tag/v0.5.0)
to use some new features:
- Table wrapping (closes #1709)
  
The wrapping logic mirror's
[Pandoc's](https://pandoc.org/MANUAL.html#extension-pipe_tables) (i.e.,
compare the relative widths of the `---` columns to determine column
widths) so tables in the source may need tweaking to get the proportions
right
- Replace broken links in PDF with corresponding links to
https://google.github.io/comprehensive-rust/
 2024-02-20 11:04:30 +01:00
Dustin J. Mitchell
33b19848ef
Improved support for commenting when course timings change. (#1797) 
This
* Works with the GitHub permissions model (at least in local testing on
another temporary repo)
 * Only comments when the timings actually change
 2024-02-12 11:03:24 +00:00
dependabot[bot]
4f719ddc72
build(deps): bump crate-ci/typos from 1.18.0 to 1.18.2 (#1811) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.18.0 to
1.18.2.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-02-12 10:11:15 +00:00
dependabot[bot]
73a6ab6ded
build(deps): bump crate-ci/typos from 1.17.2 to 1.18.0 (#1785) 
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.17.2 to
1.18.0.

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2024-02-05 10:31:16 +00:00
azevedoalice
55604ddbeb
Add myself to pt-BR reviewers (#1770) 2024-01-31 10:16:19 -08:00