mokou
347f30bd86
fix(main): Let find_exercise work with borrows
2021-04-21 16:21:56 +02:00
mokou
6177b6e126
chore: Fix integration tests
2021-04-21 14:47:53 +02:00
mokou
7928122fce
feat: Replace clap with argh
...
I’ve been wanting to do this for a while, but always procrastinated on it. We’ve been using Clap since the 2.0 rewrite, but Clap is known to be a fairly heavy library. Since Rustlings is usually peoples’ first contact with a Rust compilation, I think it’s in our best interests that this complation is as fast as possible. In effect, replacing Clap with the smaller, structopt-style `argh` reduces the amount of crates needing to be compiled from 82 to 60.
I also think this makes the code way easier to read, we don’t need to use Clap’s methods anymore, but can switch over to using pure Rust methods, e.g., switches are booleans, options are Option<String>s or the like, and subcommands are just structs.
2021-04-21 10:08:26 +02:00
marisa
aa0db8379c
Merge pull request #714 from rust-lang/all-contributors/add-hongshaoyang
...
docs: add hongshaoyang as a contributor
2021-04-20 11:19:49 +02:00
allcontributors[bot]
eadd41a9ec
docs: update .all-contributorsrc [skip ci]
2021-04-20 09:19:39 +00:00
allcontributors[bot]
fab2eb9833
docs: update README.md [skip ci]
2021-04-20 09:19:38 +00:00
Shao Yang Hong
6bd791f2f4
fix(structs): Add 5.3 to structs/README ( #652 )
...
Co-authored-by: Shao Yang Hong <shaoyang.hong@ninjavan.co>
2021-04-20 11:19:24 +02:00
marisa
ec5f80dce1
Merge pull request #713 from rust-lang/all-contributors/add-k12ish
...
docs: add k12ish as a contributor
2021-04-20 11:18:32 +02:00
allcontributors[bot]
65cdc856ae
docs: update .all-contributorsrc [skip ci]
2021-04-20 09:18:23 +00:00
allcontributors[bot]
472f61485e
docs: update README.md [skip ci]
2021-04-20 09:18:22 +00:00
k12ish
b4de659438
fix(option2): Rename uninformative variables ( #675 )
...
Renaming uninformative names like `optional_value`, `value`, `optional_values_vec` and `value` helps users distinguish between the two parts of the task.
2021-04-20 11:18:05 +02:00
marisa
a37a8818c8
Merge pull request #712 from rust-lang/all-contributors/add-arthas168
...
docs: add arthas168 as a contributor
2021-04-20 11:16:25 +02:00
allcontributors[bot]
bdf01aa174
docs: update .all-contributorsrc [skip ci]
2021-04-20 09:16:16 +00:00
allcontributors[bot]
a941c69f09
docs: update README.md [skip ci]
2021-04-20 09:16:15 +00:00
Pete Pavlovski
72aaa15e6a
fix(hashmap2): Update incorrect assertion ( #660 )
...
The test description says "at least five types of fruit", but the test itself is checking for exactly five types of fruit, which was a bit misleading for newcomers like me :)
A simple change from "==" to ">=" should do the trick and successfully check for the "at least" condition.
2021-04-20 11:15:49 +02:00
marisa
3a06de71a8
Merge pull request #708 from Zerotask/list-command-added-to-readme
...
docs: added hint for rustlings list command
2021-04-20 11:10:38 +02:00
marisa
5e2b39a5c1
Merge pull request #711 from rust-lang/all-contributors/add-Zerotask
...
docs: add Zerotask as a contributor
2021-04-20 11:09:41 +02:00
allcontributors[bot]
63c942233e
docs: update .all-contributorsrc [skip ci]
2021-04-20 09:09:31 +00:00
allcontributors[bot]
2612edc133
docs: update README.md [skip ci]
2021-04-20 09:09:30 +00:00
marisa
e2ce9f42b5
Merge pull request #707 from Zerotask/list-command-progress-info
...
feat(list): added progress info
2021-04-20 11:09:14 +02:00
Patrick Hintermayer
1c6f7e4b7b
feat(list): updated progress percentage
2021-04-19 09:39:05 +02:00
Zerotask
e2c41903ad
docs: added hint for rustlings list command
...
Added hint for `rustlings list` to the "Doing exercises" section.
2021-04-18 16:07:30 +02:00
Zerotask
bd48544e25
style: formatted files with rustfmt
2021-04-18 15:40:47 +02:00
Zerotask
c0e3daacaf
feat(list): added progress info
...
Added a progress info at the bottom of the list for command: rustlings list
closes #705
2021-04-18 15:37:41 +02:00
Abdou Seck
f2ad3a6a0b
Merge pull request #697 from WowSuchRicky/main
...
Rename 'Lichi' to 'Lychee' in the fruit example
2021-04-13 10:40:07 -04:00
Abdou Seck
caf921a01f
Merge pull request #674 from Morsicus/fix/collections-exercises-naming
...
Update collections exercises naming
2021-04-13 10:39:18 -04:00
WowSuchRicky
b790bafc02
Rename lichi to lychee in the fruit example
2021-04-09 14:08:02 -07:00
Abdou Seck
ad3cd54cce
Merge pull request #694 from rust-lang/all-contributors/add-tlyu
...
docs: add tlyu as a contributor
2021-04-05 07:27:42 -04:00
allcontributors[bot]
1a6a725f88
docs: update .all-contributorsrc [skip ci]
2021-04-05 11:27:17 +00:00
allcontributors[bot]
1ad20d94ff
docs: update README.md [skip ci]
2021-04-05 11:27:16 +00:00
Abdou Seck
995c6f0fb1
Merge pull request #693 from tlyu/trait-obj-tryfrom
...
fix: use trait objects for try_from_into and from_str
2021-04-05 07:26:19 -04:00
Taylor Yu
c3e7b83178
fix: use trait objects for from_str
...
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate
errors.
2021-04-04 18:56:10 -05:00
Taylor Yu
2e93a588e0
fix: use trait objects for try_from_into
...
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate
errors. In the tests, explicitly check `is_ok()` instead of trying to
force the error type to `String` (or other `PartialEq` type) using
`assert_eq!()`.
2021-04-04 12:41:32 -05:00
marisa
9aeca3f97e
Merge pull request #692 from rust-lang/all-contributors/add-flakolefluk
...
docs: add flakolefluk as a contributor
2021-04-04 09:44:02 +02:00
allcontributors[bot]
2193fff4bb
docs: update .all-contributorsrc [skip ci]
2021-04-04 07:43:51 +00:00
allcontributors[bot]
aec2c65c63
docs: update README.md [skip ci]
2021-04-04 07:43:50 +00:00
Ignacio Le Fluk
a6509cc4d5
fix(functions3): improve function argument type ( #687 )
2021-04-04 09:43:25 +02:00
marisa
a02b279750
chore: Provide a working Windows installation link
2021-03-23 09:10:40 +01:00
marisa
ece841f5ce
Merge pull request #680 from rust-lang/all-contributors/add-blerchy
...
docs: add blerchy as a contributor
2021-03-22 13:37:10 +01:00
allcontributors[bot]
2a6e4dc8a6
docs: update .all-contributorsrc [skip ci]
2021-03-22 12:37:02 +00:00
allcontributors[bot]
c163011cc0
docs: update README.md [skip ci]
2021-03-22 12:37:01 +00:00
marisa
b350945a16
Merge pull request #676 from blerchy/feat/no-emoji
...
Replace emojis when NO_EMOJI env variable present
2021-03-22 13:36:26 +01:00
marisa
1ef368a69d
Merge pull request #679 from rust-lang/new-install-urls
...
chore: Update install URLs
2021-03-21 16:35:44 +01:00
marisa
8dc587b01a
chore: Update install URLs
2021-03-21 16:34:21 +01:00
allcontributors[bot]
550c4293ed
docs: add chapeupreto as a contributor ( #678 )
...
* docs: update README.md [skip ci]
* docs: update .all-contributorsrc [skip ci]
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
2021-03-20 21:13:35 +01:00
Rod Elias
3df094713f
chore: capitalize c letter
...
By capitalizing the `c` letter it makes clear that we're talking about the C programming language.
2021-03-20 21:12:49 +01:00
Matt Lebl
01e7f27aa6
refactor: change from match to if for NO_EMOJI
2021-03-20 11:53:40 -07:00
Matt Lebl
8d62a99637
feat: Replace emojis when NO_EMOJI env variable present
2021-03-19 02:16:07 -07:00
Mickael Fortunato
ab9995e76e
doc: Update collections exercises instruction to match the standard naming
2021-03-18 19:11:15 +01:00
Mickael Fortunato
bef39b1259
fix(collections): Naming exercises for vectors and hashmap
2021-03-18 19:11:04 +01:00
