self-hosted/Mailu
1
0
Fork 0
mirror of https://github.com/Mailu/Mailu.git synced 2025-07-17 01:32:29 +02:00
Code Issues Releases Activity

Don't raise rate limit exception on hit(), only on check()

Browse Source
This commit is contained in:
Michael Wyraz
2019-12-16 18:47:21 +01:00
parent a7f787f914
commit 70f797dbd9
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/admin/mailu/limiter.py
View File

@ -33,5 +33,4 @@ class Limiter:
# disable limits for internal requests (e.g. from webmail)? # disable limits for internal requests (e.g. from webmail)?
if rate_limit_subnet==False and ipaddress.ip_address(clientip) in self.subnet: if rate_limit_subnet==False and ipaddress.ip_address(clientip) in self.subnet:
return return
if not self.limiter.hit(self.rate,"client-ip",clientip): self.limiter.hit(self.rate,"client-ip",clientip)
raise RateLimitExceeded()

10
docs/configuration.rst
View File

@ -38,8 +38,14 @@ recommended to setup a generic value and later configure a mail alias for that
address. address.
The ``AUTH_RATELIMIT`` holds a security setting for fighting attackers that The ``AUTH_RATELIMIT`` holds a security setting for fighting attackers that
try to guess user passwords. The value is the limit of requests that a single try to guess user passwords. The value is the limit of failed authentication attempts
IP address can perform against IMAP, POP and SMTP authentication endpoints. that a single IP address can perform against IMAP, POP and SMTP authentication endpoints.
If ``AUTH_RATELIMIT_SUBNET`` is ``True`` (which is the default), the ``AUTH_RATELIMIT``
rules does also apply to auth requests coming from ``SUBNET``, especially for the webmail.
If you disable this, ensure that the rate limit on the webmail is enforced in a different
way (e.g. roundcube plug-in), otherwise an attacker can simply bypass the limit using webmail.
The ``TLS_FLAVOR`` sets how Mailu handles TLS connections. Setting this value to The ``TLS_FLAVOR`` sets how Mailu handles TLS connections. Setting this value to
``notls`` will cause Mailu not to server any web content! More on :ref:`tls_flavor`. ``notls`` will cause Mailu not to server any web content! More on :ref:`tls_flavor`.