Passing an initial golangci-lint pass

server/main/main.go

@@ -22,11 +22,7 @@ func isProcessRunning(pid int) bool {
 	}
 
 	err = process.Signal(syscall.Signal(0))
-	if err != nil {
-		return false
-	}
-
-	return true
+	return err == nil
 }
 
 func monitorPid(pid int) {

server/server/server.go

@@ -64,10 +64,11 @@ func New(config *config.Configuration) (*Server, error) {
 	}()
 
 	return &Server{
-		config:    config,
-		wsServer:  wsServer,
-		webServer: webServer,
-		store:     store,
+		config:       config,
+		wsServer:     wsServer,
+		webServer:    webServer,
+		store:        store,
+		filesBackend: filesBackend,
 	}, nil
 }
 

server/services/store/sqlstore/migrate.go

@@ -21,7 +21,9 @@ func (s *SQLStore) Migrate() error {
 	var bresource *bindata.AssetSource
 	if s.dbType == "sqlite3" {
 		driver, err = sqlite3.WithInstance(s.db, &sqlite3.Config{})
-		fmt.Println(pgmigrations.AssetNames())
+		if err != nil {
+			return err
+		}
 		bresource = bindata.Resource(sqlite.AssetNames(),
 			func(name string) ([]byte, error) {
 				return sqlite.Asset(name)
@@ -29,6 +31,9 @@ func (s *SQLStore) Migrate() error {
 	}
 	if s.dbType == "postgres" {
 		driver, err = postgres.WithInstance(s.db, &postgres.Config{})
+		if err != nil {
+			return err
+		}
 		bresource = bindata.Resource(pgmigrations.AssetNames(),
 			func(name string) ([]byte, error) {
 				return pgmigrations.Asset(name)

server/services/store/sqlstore/sqlstore_test.go

@@ -21,7 +21,8 @@ func SetupTests(t *testing.T) (*SQLStore, func()) {
 	require.Nil(t, err)
 
 	tearDown := func() {
-		store.Shutdown()
+		err = store.Shutdown()
+		require.Nil(t, err)
 	}
 	return store, tearDown
 }