self-hosted/focalboard
1
0
Fork 0
mirror of https://github.com/mattermost/focalboard.git synced 2025-01-08 15:06:08 +02:00
Code Issues Releases Activity

fix a placeholder message when sharing template (#3868)

Browse Source
This commit is contained in:
Yusuke Nemoto 2022-09-28 07:06:04 +09:00 committed by GitHub
parent a522f7f92d
commit 9b3be29af5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
webapp/i18n/en.json
View File

@ -221,6 +221,7 @@
"ShareBoard.userPermissionsRemoveMemberText": "Remove member", "ShareBoard.userPermissionsRemoveMemberText": "Remove member",
"ShareBoard.userPermissionsYouText": "(You)", "ShareBoard.userPermissionsYouText": "(You)",
"ShareTemplate.Title": "Share Template", "ShareTemplate.Title": "Share Template",
"ShareTemplate.searchPlaceholder": "Search for people",
"Sidebar.about": "About Focalboard", "Sidebar.about": "About Focalboard",
"Sidebar.add-board": "+ Add board", "Sidebar.add-board": "+ Add board",
"Sidebar.changePassword": "Change password", "Sidebar.changePassword": "Change password",

6
webapp/src/components/shareBoard/__snapshots__/shareBoard.test.tsx.snap
View File

@ -2379,7 +2379,7 @@ exports[`src/components/shareBoard/shareBoard return shareBoard template and cli
class=" css-14el2xx-placeholder" class=" css-14el2xx-placeholder"
id="react-select-14-placeholder" id="react-select-14-placeholder"
> >
Search for people and channels Search for people
</div> </div>
<div <div
class=" css-ox1y69-Input" class=" css-ox1y69-Input"
@ -2573,7 +2573,7 @@ exports[`src/components/shareBoard/shareBoard return shareBoard template and cli
class=" css-14el2xx-placeholder" class=" css-14el2xx-placeholder"
id="react-select-14-placeholder" id="react-select-14-placeholder"
> >
Search for people and channels Search for people
</div> </div>
<div <div
class=" css-ox1y69-Input" class=" css-ox1y69-Input"
@ -4185,7 +4185,7 @@ exports[`src/components/shareBoard/shareBoard should match snapshot, with templa
class=" css-14el2xx-placeholder" class=" css-14el2xx-placeholder"
id="react-select-13-placeholder" id="react-select-13-placeholder"
> >
Search for people and channels Search for people
</div> </div>
<div <div
class=" css-ox1y69-Input" class=" css-ox1y69-Input"

2
webapp/src/components/shareBoard/shareBoard.test.tsx
View File

@ -709,7 +709,7 @@ describe('src/components/shareBoard/shareBoard', () => {
}) })
expect(container).toMatchSnapshot() expect(container).toMatchSnapshot()
const selectElement = screen.getByText('Search for people and channels') const selectElement = screen.getByText('Search for people')
expect(selectElement).toBeDefined() expect(selectElement).toBeDefined()
await act(async () => { await act(async () => {

5
webapp/src/components/shareBoard/shareBoard.tsx
View File

@ -389,7 +389,10 @@ export default function ShareBoardDialog(props: Props): JSX.Element {
getOptionValue={(u) => u.id} getOptionValue={(u) => u.id}
getOptionLabel={(u: IUser|Channel) => (u as IUser).username || (u as Channel).display_name} getOptionLabel={(u: IUser|Channel) => (u as IUser).username || (u as Channel).display_name}
isMulti={false} isMulti={false}
placeholder={intl.formatMessage({id: 'ShareBoard.searchPlaceholder', defaultMessage: 'Search for people and channels'})} placeholder={board.isTemplate ?
intl.formatMessage({id: 'ShareTemplate.searchPlaceholder', defaultMessage: 'Search for people'}) :
intl.formatMessage({id: 'ShareBoard.searchPlaceholder', defaultMessage: 'Search for people and channels'})
}
onChange={(newValue) => { onChange={(newValue) => {
if (newValue && (newValue as IUser).username) { if (newValue && (newValue as IUser).username) {
mutator.createBoardMember(boardId, newValue.id) mutator.createBoardMember(boardId, newValue.id)