self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-07-13 00:10:37 +02:00
Code Issues Releases Activity

Mobile: Fixes #10270: Fix dropdowns invisble when opening settings by clicking "synchronize" (#10271)

Browse Source
This commit is contained in:
Henry Heino
2024-04-07 06:38:51 -07:00
committed by GitHub
parent b678e2fb5d
commit 04c6863d7f
1 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/app-mobile/components/Dropdown.tsx
View File

@ -1,5 +1,5 @@
import * as React from 'react'; import * as React from 'react';
import { TouchableOpacity, TouchableWithoutFeedback, Dimensions, Text, Modal, View, LayoutRectangle, ViewStyle, TextStyle, FlatList, LayoutChangeEvent } from 'react-native'; import { TouchableOpacity, TouchableWithoutFeedback, Dimensions, Text, Modal, View, LayoutRectangle, ViewStyle, TextStyle, FlatList } from 'react-native';
import { Component, ReactElement } from 'react'; import { Component, ReactElement } from 'react';
import { _ } from '@joplin/lib/locale'; import { _ } from '@joplin/lib/locale';
@ -54,18 +54,9 @@ class Dropdown extends Component<DropdownProps, DropdownState> {
}; };
} }
private updateHeaderCoordinates = (event: LayoutChangeEvent) => { private updateHeaderCoordinates = () => {
if (!this.headerRef) return; if (!this.headerRef) return;
const { width, height } = event.nativeEvent.layout;
const lastLayout = this.state.headerSize;
if (width !== lastLayout.width || height !== lastLayout.height) {
this.setState({
headerSize: { x: lastLayout.x, y: lastLayout.y, width, height },
});
}
// https://stackoverflow.com/questions/30096038/react-native-getting-the-position-of-an-element // https://stackoverflow.com/questions/30096038/react-native-getting-the-position-of-an-element
this.headerRef.measure((_fx, _fy, width, height, px, py) => { this.headerRef.measure((_fx, _fy, width, height, px, py) => {
const lastLayout = this.state.headerSize; const lastLayout = this.state.headerSize;
@ -78,6 +69,10 @@ class Dropdown extends Component<DropdownProps, DropdownState> {
}; };
private onOpenList = () => { private onOpenList = () => {
// On iOS, we need to re-measure just before opening the list. Measurements from just after
// onLayout can be inaccurate in some cases (in the past, this had caused the menu to be
// drawn far offscreen).
this.updateHeaderCoordinates();
this.setState({ listVisible: true }); this.setState({ listVisible: true });
}; };
private onCloseList = () => { private onCloseList = () => {