self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2024-12-30 10:36:35 +02:00
Code Issues Releases Activity

Desktop: Fixes #9944: GotoAnything does not return all the results in some cases

Browse Source
This commit is contained in:
Laurent Cozic 2024-02-16 17:40:51 +00:00
parent 7f50cb9787
commit 1cfbf000d6
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/app-desktop/plugins/GotoAnything.tsx
View File

@ -356,6 +356,14 @@ class Dialog extends React.PureComponent<Props, State> {
} else {
const limit = 20;
const searchKeywords = await this.keywords(searchQuery);
// Note: any filtering must be done **before** fetching the notes, because we're
// going to apply a limit to the number of fetched notes.
// https://github.com/laurent22/joplin/issues/9944
if (!this.props.showCompletedTodos) {
results = results.filter((row: any) => !row.is_todo || !row.todo_completed);
}
const notes = await Note.byIds(results.map((result: any) => result.id).slice(0, limit), { fields: ['id', 'body', 'markup_language', 'is_todo', 'todo_completed'] });
// Can't make any sense of this code so...
const notesById = notes.reduce((obj, { id, body, markup_language }) => ((obj[[id] as any] = { id, body, markup_language }), obj), {});
@ -407,10 +415,6 @@ class Dialog extends React.PureComponent<Props, State> {
results[i] = { ...row, path: path, fragments: '' };
}
}
if (!this.props.showCompletedTodos) {
results = results.filter((row: any) => !row.is_todo || !row.todo_completed);
}
}
}