self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2026-06-18 20:16:34 +02:00
Code Issues Releases Activity

Desktop: Fixes #15575: Crash on deleting ca. 4000 notes (#15640)

Browse Source
This commit is contained in:
Aissa Benfodda
2026-06-11 13:36:09 +01:00
committed by GitHub
parent 17ff5974f8
commit 4cab09fdaa
1 changed files with 15 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/app-desktop/gui/NoteList/utils/useActiveDescendantId.ts
+15 -22
View File
@@ -5,34 +5,27 @@ const useActiveDescendantId = (selectedFolderId: string, selectedNoteIds: string
const selectedNoteIdsRef = useRef(selectedNoteIds);
selectedNoteIdsRef.current = selectedNoteIds;
const [activeNoteId, setActiveNoteId] = useState('');
const [focusedNoteId, setFocusedNoteId] = useState('');
useEffect(() => {
setActiveNoteId(selectedNoteIdsRef.current?.[0] ?? '');
setFocusedNoteId(selectedNoteIdsRef.current?.[0] ?? '');
}, [selectedFolderId]);
const previousNoteIdsRef = useRef<string[]>(null);
previousNoteIdsRef.current = usePrevious(selectedNoteIds);
const previousSelectedNoteIds = usePrevious(selectedNoteIds, []);
let activeNoteId = focusedNoteId;
if (!selectedNoteIds.includes(activeNoteId)) {
// Prefer added items
activeNoteId = selectedNoteIds.find(id => !previousSelectedNoteIds.includes(id)) ?? selectedNoteIds[0] ?? '';
}
useEffect(() => {
const previousNoteIds = previousNoteIdsRef.current ?? [];
if (focusedNoteId !== activeNoteId) {
setFocusedNoteId(activeNoteId);
}
}, [focusedNoteId, activeNoteId]);
setActiveNoteId(current => {
if (selectedNoteIds.includes(current)) {
return current;
} else {
// Prefer added items
for (const id of selectedNoteIds) {
if (!previousNoteIds.includes(id)) {
return id;
}
}
return selectedNoteIds[0] ?? '';
}
});
}, [selectedNoteIds]);
return { activeNoteId, setActiveNoteId };
return { activeNoteId, setActiveNoteId: setFocusedNoteId };
};
export default useActiveDescendantId;