self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2024-11-30 08:26:59 +02:00
Code Issues Releases Activity

Electron: Fixes #355: Set undo state properly when loading new note

Browse Source
This commit is contained in:
Laurent Cozic 2018-05-01 10:48:15 +01:00
parent 62e91c44d7
commit 4cf5525e20
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ElectronClient/app/gui/NoteText.jsx
View File

@ -210,10 +210,13 @@ class NoteTextComponent extends React.Component {
}
if (this.editor_) {
const session = this.editor_.editor.getSession();
const undoManager = session.getUndoManager();
undoManager.reset();
session.setUndoManager(undoManager);
// Calling setValue here does two things:
// 1. It sets the initial value as recorded by the undo manager. If we were to set it instead to "" and wait for the render
// phase to set the value, the initial value would still be "", which means pressing "undo" on a note that has just loaded
// would clear it.
// 2. It resets the undo manager - fixes https://github.com/laurent22/joplin/issues/355
// Note: calling undoManager.reset() doesn't work
this.editor_.editor.session.setValue(note ? note.body : '');
this.editor_.editor.clearSelection();
this.editor_.editor.moveCursorTo(0,0);
}