self-hosted/joplin
1
0
Fork 0
mirror of https://github.com/laurent22/joplin.git synced 2025-07-16 00:14:34 +02:00
Code Issues Releases Activity

Desktop: Fixes #9855: Allow using editor commands in the command palette (#9861)

Browse Source
This commit is contained in:
Henry Heino
2024-02-06 08:20:15 -08:00
committed by GitHub
parent e462881502
commit 8b9ce9ec72
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/app-desktop/gui/NoteEditor/editorCommandDeclarations.test.ts
View File

@ -54,6 +54,16 @@ describe('editorCommandDeclarations', () => {
}, },
true, true,
], ],
[
// In the Markdown editor, and the command palette is visible
{
markdownEditorPaneVisible: true,
richTextEditorVisible: false,
gotoAnythingVisible: true,
modalDialogVisible: true,
},
true,
],
])('should create the enabledCondition', (context: Record<string, any>, expected: boolean) => { ])('should create the enabledCondition', (context: Record<string, any>, expected: boolean) => {
const condition = enabledCondition('textBold'); const condition = enabledCondition('textBold');
const wc = new WhenClause(condition); const wc = new WhenClause(condition);

5
packages/app-desktop/gui/NoteEditor/editorCommandDeclarations.ts
View File

@ -11,8 +11,9 @@ export const enabledCondition = (commandName: string) => {
const noteMustBeMarkdown = !workWithHtmlNotes.includes(commandName); const noteMustBeMarkdown = !workWithHtmlNotes.includes(commandName);
const output = [ const output = [
'!modalDialogVisible', // gotoAnythingVisible: Enable if the command palette (which is a modal dialog) is visible
'!gotoAnythingVisible', '(!modalDialogVisible || gotoAnythingVisible)',
markdownEditorOnly ? 'markdownEditorPaneVisible' : '(markdownEditorPaneVisible || richTextEditorVisible)', markdownEditorOnly ? 'markdownEditorPaneVisible' : '(markdownEditorPaneVisible || richTextEditorVisible)',
'oneNoteSelected', 'oneNoteSelected',
noteMustBeMarkdown ? 'noteIsMarkdown' : '', noteMustBeMarkdown ? 'noteIsMarkdown' : '',