Desktop: Fixes #12451: Fix incorrect line numbers/files in debug output (#12664)

.eslintignore

@@ -604,6 +604,7 @@ packages/app-desktop/utils/isSafeToOpen.test.js
 packages/app-desktop/utils/isSafeToOpen.js
 packages/app-desktop/utils/restartInSafeModeFromMain.test.js
 packages/app-desktop/utils/restartInSafeModeFromMain.js
+packages/app-desktop/utils/sourceMapSetup.js
 packages/app-desktop/utils/window/types.js
 packages/app-mobile/PluginAssetsLoader.js
 packages/app-mobile/commands/dismissPluginPanels.js

.gitignore

@@ -579,6 +579,7 @@ packages/app-desktop/utils/isSafeToOpen.test.js
 packages/app-desktop/utils/isSafeToOpen.js
 packages/app-desktop/utils/restartInSafeModeFromMain.test.js
 packages/app-desktop/utils/restartInSafeModeFromMain.js
+packages/app-desktop/utils/sourceMapSetup.js
 packages/app-desktop/utils/window/types.js
 packages/app-mobile/PluginAssetsLoader.js
 packages/app-mobile/commands/dismissPluginPanels.js

packages/app-desktop/main-html.js

@@ -10,6 +10,7 @@ window.__REACT_DEVTOOLS_GLOBAL_HOOK__ = {
 	onCommitFiberUnmount: function() {},
 };
 
+require('./utils/sourceMapSetup');
 const app = require('./app').default;
 const Folder = require('@joplin/lib/models/Folder').default;
 const Resource = require('@joplin/lib/models/Resource').default;

packages/app-desktop/main.js

@@ -1,5 +1,6 @@
 // This is the basic initialization for the Electron MAIN process
 
+require('./utils/sourceMapSetup');
 const electronApp = require('electron').app;
 require('@electron/remote/main').initialize();
 const ElectronAppWrapper = require('./ElectronAppWrapper').default;

packages/app-desktop/package.json

@@ -12,7 +12,7 @@
     "electronRebuild": "gulp electronRebuild",
     "tsc": "tsc --project tsconfig.json",
     "watch": "tsc --watch --preserveWatchOutput --project tsconfig.json",
-    "start": "gulp before-start && electron . --env dev --log-level debug --open-dev-tools --no-welcome",
+    "start": "gulp before-start && JOPLIN_SOURCE_MAP_ENABLED=1 electron . --env dev --log-level debug --open-dev-tools --no-welcome",
     "test": "jest",
     "test-ui": "gulp before-start && playwright test",
     "test-ci": "yarn test",
@@ -196,6 +196,7 @@
     "reselect": "4.1.8",
     "roboto-fontface": "0.10.0",
     "smalltalk": "2.5.1",
+    "source-map-support": "0.5.21",
     "styled-components": "5.3.11",
     "styled-system": "5.1.5",
     "taboverride": "4.0.3",

packages/app-desktop/tools/bundleJs.ts

@@ -12,9 +12,10 @@ const makeBuildContext = (entryPoint: string, renderer: boolean, computeFileSize
 		outfile: `${filename(entryPoint)}.bundle.js`,
 		bundle: true,
 		minify: true,
-		keepNames: true,
+		keepNames: true, // Preserve original function names -- useful for debugging
 		format: 'iife', // Immediately invoked function expression
 		sourcemap: true,
+		sourcesContent: false, // Do not embed full source file content in the .map file
 		metafile: computeFileSizeStats,
 		platform: 'node',
 		target: ['node20.0'],

packages/app-desktop/utils/sourceMapSetup.ts

@@ -0,0 +1,6 @@
+
+// source-map-support can add 1-3 seconds to the application startup
+// time -- disable it unless requested:
+if (process.env.JOPLIN_SOURCE_MAP_ENABLED) {
+	require('source-map-support').install();
+}

packages/tools/cspell/dictionary4.txt

@@ -183,3 +183,4 @@ topagency
 esbuild
 mapbox
 outfile
+

yarn.lock

@@ -9002,6 +9002,7 @@ __metadata:
     reselect: "npm:4.1.8"
     roboto-fontface: "npm:0.10.0"
     smalltalk: "npm:2.5.1"
+    source-map-support: "npm:0.5.21"
     sqlite3: "npm:5.1.6"
     styled-components: "npm:5.3.11"
     styled-system: "npm:5.1.5"