Android 3.5.1

.eslintignore

@@ -115,7 +115,6 @@ packages/app-cli/app/command-export.js
 packages/app-cli/app/command-geoloc.js
 packages/app-cli/app/command-help.js
 packages/app-cli/app/command-import.js
-packages/app-cli/app/command-keymap.js
 packages/app-cli/app/command-ls.js
 packages/app-cli/app/command-mkbook.test.js
 packages/app-cli/app/command-mkbook.js
@@ -166,6 +165,8 @@ packages/app-desktop/app.reducer.js
 packages/app-desktop/app.js
 packages/app-desktop/bridge.js
 packages/app-desktop/checkForUpdates.js
+packages/app-desktop/commands/convertNoteToMarkdown.test.js
+packages/app-desktop/commands/convertNoteToMarkdown.js
 packages/app-desktop/commands/copyDevCommand.js
 packages/app-desktop/commands/copyToClipboard.js
 packages/app-desktop/commands/editProfileConfig.js
@@ -182,7 +183,6 @@ packages/app-desktop/commands/openProfileDirectory.js
 packages/app-desktop/commands/openSecondaryAppInstance.js
 packages/app-desktop/commands/replaceMisspelling.js
 packages/app-desktop/commands/restoreNoteRevision.js
-packages/app-desktop/commands/showProfileEditor.js
 packages/app-desktop/commands/startExternalEditing.js
 packages/app-desktop/commands/stopExternalEditing.js
 packages/app-desktop/commands/switchProfile.js
@@ -207,6 +207,7 @@ packages/app-desktop/gui/ConfigScreen/controls/ToggleAdvancedSettingsButton.js
 packages/app-desktop/gui/ConfigScreen/controls/plugins/PluginBox.js
 packages/app-desktop/gui/ConfigScreen/controls/plugins/PluginsStates.js
 packages/app-desktop/gui/ConfigScreen/controls/plugins/SearchPlugins.js
+packages/app-desktop/gui/ConversionNotification/ConversionNotification.js
 packages/app-desktop/gui/Dialog.js
 packages/app-desktop/gui/DialogButtonRow.js
 packages/app-desktop/gui/DialogButtonRow/useKeyboardHandler.js
@@ -392,7 +393,6 @@ packages/app-desktop/gui/PopupNotification/NotificationItem.js
 packages/app-desktop/gui/PopupNotification/PopupNotificationList.js
 packages/app-desktop/gui/PopupNotification/PopupNotificationProvider.js
 packages/app-desktop/gui/PopupNotification/types.js
-packages/app-desktop/gui/ProfileEditor.js
 packages/app-desktop/gui/PromptDialog.js
 packages/app-desktop/gui/ResizableLayout/LayoutItemContainer.js
 packages/app-desktop/gui/ResizableLayout/MoveButtons.js
@@ -960,7 +960,6 @@ packages/app-mobile/utils/fs-driver/testUtil/verifyDirectoryMatches.js
 packages/app-mobile/utils/getPackageInfo.js
 packages/app-mobile/utils/getVersionInfoText.js
 packages/app-mobile/utils/hooks/useBackHandler.js
-packages/app-mobile/utils/hooks/useDebounced.js
 packages/app-mobile/utils/hooks/useIsScreenReaderEnabled.js
 packages/app-mobile/utils/hooks/useKeyboardState.js
 packages/app-mobile/utils/hooks/useOnLongPressProps.js
@@ -1032,7 +1031,6 @@ packages/editor/CodeMirror/editorCommands/supportsCommand.js
 packages/editor/CodeMirror/extensions/biDirectionalTextExtension.js
 packages/editor/CodeMirror/extensions/ctrlClickActionExtension.js
 packages/editor/CodeMirror/extensions/ctrlClickCheckboxExtension.js
-packages/editor/CodeMirror/extensions/editorSettingsExtension.js
 packages/editor/CodeMirror/extensions/highlightActiveLineExtension.js
 packages/editor/CodeMirror/extensions/keyUpHandlerExtension.js
 packages/editor/CodeMirror/extensions/links/ctrlClickLinksExtension.js
@@ -1061,8 +1059,6 @@ packages/editor/CodeMirror/extensions/rendering/replaceBulletLists.js
 packages/editor/CodeMirror/extensions/rendering/replaceCheckboxes.js
 packages/editor/CodeMirror/extensions/rendering/replaceDividers.js
 packages/editor/CodeMirror/extensions/rendering/replaceFormatCharacters.js
-packages/editor/CodeMirror/extensions/rendering/replaceInlineHtml.test.js
-packages/editor/CodeMirror/extensions/rendering/replaceInlineHtml.js
 packages/editor/CodeMirror/extensions/rendering/types.js
 packages/editor/CodeMirror/extensions/rendering/utils/makeBlockReplaceExtension.js
 packages/editor/CodeMirror/extensions/rendering/utils/makeInlineReplaceExtension.js
@@ -1103,7 +1099,6 @@ packages/editor/CodeMirror/utils/getSearchState.js
 packages/editor/CodeMirror/utils/growSelectionToNode.js
 packages/editor/CodeMirror/utils/handleLinkEditRequests.js
 packages/editor/CodeMirror/utils/handlePasteEvent.js
-packages/editor/CodeMirror/utils/htmlNodeInfo.js
 packages/editor/CodeMirror/utils/isCursorAtBeginning.js
 packages/editor/CodeMirror/utils/isInSyntaxNode.js
 packages/editor/CodeMirror/utils/markdown/codeBlockLanguages/allLanguages.js
@@ -1119,7 +1114,6 @@ packages/editor/CodeMirror/vendor/announceSearchMatch.js
 packages/editor/ProseMirror/commands/commands.test.js
 packages/editor/ProseMirror/commands/commands.js
 packages/editor/ProseMirror/commands/focusEditor.js
-packages/editor/ProseMirror/commands/selectDocumentEnd.js
 packages/editor/ProseMirror/createEditor.js
 packages/editor/ProseMirror/index.js
 packages/editor/ProseMirror/plugins/detailsPlugin.test.js
@@ -1152,7 +1146,6 @@ packages/editor/ProseMirror/types.js
 packages/editor/ProseMirror/utils/SelectableNodeView.js
 packages/editor/ProseMirror/utils/UndoStackSynchronizer.js
 packages/editor/ProseMirror/utils/canReplaceSelectionWith.js
-packages/editor/ProseMirror/utils/clampPointToDocument.js
 packages/editor/ProseMirror/utils/computeSelectionFormatting.js
 packages/editor/ProseMirror/utils/dom/createButton.js
 packages/editor/ProseMirror/utils/dom/createTextArea.js
@@ -1162,7 +1155,6 @@ packages/editor/ProseMirror/utils/dom/showModal.js
 packages/editor/ProseMirror/utils/extractSelectedLinesTo.test.js
 packages/editor/ProseMirror/utils/extractSelectedLinesTo.js
 packages/editor/ProseMirror/utils/forEachHeading.js
-packages/editor/ProseMirror/utils/getTextBetween.js
 packages/editor/ProseMirror/utils/insertRenderedMarkdown.js
 packages/editor/ProseMirror/utils/jumpToHash.js
 packages/editor/ProseMirror/utils/makeLinksClickableInElement.js
@@ -1231,7 +1223,6 @@ packages/lib/InMemoryCache.js
 packages/lib/JoplinDatabase.js
 packages/lib/JoplinError.js
 packages/lib/JoplinServerApi.js
-packages/lib/ObjectUtils.test.js
 packages/lib/ObjectUtils.js
 packages/lib/PerformanceLogger.test.js
 packages/lib/PerformanceLogger.js
@@ -1254,8 +1245,6 @@ packages/lib/callbackUrlUtils.js
 packages/lib/clipperUtils.js
 packages/lib/commands/convertHtmlToMarkdown.test.js
 packages/lib/commands/convertHtmlToMarkdown.js
-packages/lib/commands/convertNoteToMarkdown.test.js
-packages/lib/commands/convertNoteToMarkdown.js
 packages/lib/commands/deleteNote.js
 packages/lib/commands/historyBackward.js
 packages/lib/commands/historyForward.js
@@ -1808,7 +1797,6 @@ packages/renderer/MdToHtml/renderMedia.js
 packages/renderer/MdToHtml/rules/abc.js
 packages/renderer/MdToHtml/rules/checkbox.js
 packages/renderer/MdToHtml/rules/code_inline.js
-packages/renderer/MdToHtml/rules/externalEmbed.js
 packages/renderer/MdToHtml/rules/fence.js
 packages/renderer/MdToHtml/rules/fountain.js
 packages/renderer/MdToHtml/rules/highlight_keywords.js
@@ -1844,36 +1832,28 @@ packages/tools/checkIgnoredFiles.js
 packages/tools/checkLibPaths.test.js
 packages/tools/checkLibPaths.js
 packages/tools/convertThemesToCss.js
-packages/tools/fuzzer/ActionRunner.js
 packages/tools/fuzzer/ActionTracker.js
 packages/tools/fuzzer/Client.js
 packages/tools/fuzzer/ClientPool.js
 packages/tools/fuzzer/Server.js
 packages/tools/fuzzer/constants.js
+packages/tools/fuzzer/doRandomAction.js
 packages/tools/fuzzer/model/FolderRecord.js
-packages/tools/fuzzer/model/ResourceRecord.js
 packages/tools/fuzzer/sync-fuzzer.js
 packages/tools/fuzzer/types.js
 packages/tools/fuzzer/utils/ProgressBar.js
 packages/tools/fuzzer/utils/SeededRandom.js
-packages/tools/fuzzer/utils/diffSortedStringArrays.test.js
-packages/tools/fuzzer/utils/diffSortedStringArrays.js
-packages/tools/fuzzer/utils/extractResourceIds.js
 packages/tools/fuzzer/utils/getNumberProperty.js
 packages/tools/fuzzer/utils/getProperty.js
 packages/tools/fuzzer/utils/getStringProperty.js
-packages/tools/fuzzer/utils/hangingIndent.js
 packages/tools/fuzzer/utils/logDiffDebug.js
 packages/tools/fuzzer/utils/openDebugSession.js
-packages/tools/fuzzer/utils/randomId.test.js
-packages/tools/fuzzer/utils/randomId.js
 packages/tools/fuzzer/utils/randomString.js
 packages/tools/fuzzer/utils/retryWithCount.js
 packages/tools/generate-database-types.js
 packages/tools/generate-images.js
 packages/tools/git-changelog.test.js
 packages/tools/git-changelog.js
-packages/tools/licenses/buildReport.js
 packages/tools/licenses/getLicenses.js
 packages/tools/licenses/licenseChecker.js
 packages/tools/licenses/licenseOverrides/fontAwesomeOverride/index.js

.github/workflows/build-macos-m1.yml

@@ -48,7 +48,6 @@ jobs:
           CSC_LINK: ${{ secrets.APPLE_CSC_LINK }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           GH_REPO: ${{ github.repository }}
-          GITHUB_EVENT_NAME: ${{ github.event_name }}
           IS_CONTINUOUS_INTEGRATION: 1
           BUILD_SEQUENCIAL: 1
           PUBLISH_ENABLED: ${{ env.PUBLISH_ENABLED }}
@@ -58,38 +57,25 @@ jobs:
           yarn install
           cd packages/app-desktop
           npm pkg set 'build.mac.artifactName'='${productName}-${version}-${arch}.${ext}'
-
-          npm pkg delete 'build.mac.target'
           npm pkg set 'build.mac.target[0].target'='dmg'
           npm pkg set 'build.mac.target[0].arch[0]'='arm64'
           npm pkg set 'build.mac.target[1].target'='zip'
           npm pkg set 'build.mac.target[1].arch[0]'='arm64'
 
-          # Only enable pkg build in the main repository CI. As of 01/15/2026, pkg
-          # build fails when running on external pull requests.
-          if [[ "$GITHUB_EVENT_NAME" != "pull_request" ]]; then
-            npm pkg set 'build.mac.target[2].target'='pkg'
-            npm pkg set 'build.mac.target[2].arch[0]'='arm64'
-          fi
+          if [[ "$PUBLISH_ENABLED" == "true" ]]; then
+            echo "Building and publishing desktop application..."
+            PYTHON_PATH=$(which python) USE_HARD_LINKS=false yarn dist --mac --arm64
 
-          build_dist() {
-            if [[ "$PUBLISH_ENABLED" == "true" ]]; then
-              echo "Building and publishing desktop application..."
-              PYTHON_PATH=$(which python) USE_HARD_LINKS=false yarn dist --mac --arm64
+            yarn modifyReleaseAssets --repo="$GH_REPO" --tag="$GIT_TAG_NAME" --token="$GITHUB_TOKEN"
+          else
+            echo "Building but *not* publishing desktop application..."
 
-              yarn modifyReleaseAssets --repo="$GH_REPO" --tag="$GIT_TAG_NAME" --token="$GITHUB_TOKEN"
-            else
-              echo "Building but *not* publishing desktop application..."
+            # We also want to disable signing the app in this case, because
+            # it doesn't work and we don't need it.
+            # https://www.electron.build/code-signing#how-to-disable-code-signing-during-the-build-process-on-macos
 
-              # We also want to disable signing the app in this case, because
-              # it doesn't work and we don't need it.
-              # https://www.electron.build/code-signing#how-to-disable-code-signing-during-the-build-process-on-macos
+            export CSC_IDENTITY_AUTO_DISCOVERY=false
+            npm pkg set 'build.mac.identity'=null --json
 
-              export CSC_IDENTITY_AUTO_DISCOVERY=false
-              npm pkg set 'build.mac.identity'=null --json
-
-              PYTHON_PATH=$(which python) USE_HARD_LINKS=false yarn dist  --mac --arm64 --publish=never
-            fi
-          }
-
-          build_dist || build_dist
+            PYTHON_PATH=$(which python) USE_HARD_LINKS=false yarn dist  --mac --arm64 --publish=never
+          fi

.gitignore

@@ -1,7 +1,6 @@
 _mydocs
 _releases
 _vieux/
-.claude
 !/var/cache
 !/var/logs
 !/var/sessions
@@ -53,7 +52,6 @@ lerna-debug.log
 docs/**/*.mustache
 .idea
 /readme/i18n
-.watchman-cookie-*
 
 # Yarn stuff
 # https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
@@ -89,7 +87,6 @@ packages/app-cli/app/command-export.js
 packages/app-cli/app/command-geoloc.js
 packages/app-cli/app/command-help.js
 packages/app-cli/app/command-import.js
-packages/app-cli/app/command-keymap.js
 packages/app-cli/app/command-ls.js
 packages/app-cli/app/command-mkbook.test.js
 packages/app-cli/app/command-mkbook.js
@@ -140,6 +137,8 @@ packages/app-desktop/app.reducer.js
 packages/app-desktop/app.js
 packages/app-desktop/bridge.js
 packages/app-desktop/checkForUpdates.js
+packages/app-desktop/commands/convertNoteToMarkdown.test.js
+packages/app-desktop/commands/convertNoteToMarkdown.js
 packages/app-desktop/commands/copyDevCommand.js
 packages/app-desktop/commands/copyToClipboard.js
 packages/app-desktop/commands/editProfileConfig.js
@@ -156,7 +155,6 @@ packages/app-desktop/commands/openProfileDirectory.js
 packages/app-desktop/commands/openSecondaryAppInstance.js
 packages/app-desktop/commands/replaceMisspelling.js
 packages/app-desktop/commands/restoreNoteRevision.js
-packages/app-desktop/commands/showProfileEditor.js
 packages/app-desktop/commands/startExternalEditing.js
 packages/app-desktop/commands/stopExternalEditing.js
 packages/app-desktop/commands/switchProfile.js
@@ -181,6 +179,7 @@ packages/app-desktop/gui/ConfigScreen/controls/ToggleAdvancedSettingsButton.js
 packages/app-desktop/gui/ConfigScreen/controls/plugins/PluginBox.js
 packages/app-desktop/gui/ConfigScreen/controls/plugins/PluginsStates.js
 packages/app-desktop/gui/ConfigScreen/controls/plugins/SearchPlugins.js
+packages/app-desktop/gui/ConversionNotification/ConversionNotification.js
 packages/app-desktop/gui/Dialog.js
 packages/app-desktop/gui/DialogButtonRow.js
 packages/app-desktop/gui/DialogButtonRow/useKeyboardHandler.js
@@ -366,7 +365,6 @@ packages/app-desktop/gui/PopupNotification/NotificationItem.js
 packages/app-desktop/gui/PopupNotification/PopupNotificationList.js
 packages/app-desktop/gui/PopupNotification/PopupNotificationProvider.js
 packages/app-desktop/gui/PopupNotification/types.js
-packages/app-desktop/gui/ProfileEditor.js
 packages/app-desktop/gui/PromptDialog.js
 packages/app-desktop/gui/ResizableLayout/LayoutItemContainer.js
 packages/app-desktop/gui/ResizableLayout/MoveButtons.js
@@ -934,7 +932,6 @@ packages/app-mobile/utils/fs-driver/testUtil/verifyDirectoryMatches.js
 packages/app-mobile/utils/getPackageInfo.js
 packages/app-mobile/utils/getVersionInfoText.js
 packages/app-mobile/utils/hooks/useBackHandler.js
-packages/app-mobile/utils/hooks/useDebounced.js
 packages/app-mobile/utils/hooks/useIsScreenReaderEnabled.js
 packages/app-mobile/utils/hooks/useKeyboardState.js
 packages/app-mobile/utils/hooks/useOnLongPressProps.js
@@ -1006,7 +1003,6 @@ packages/editor/CodeMirror/editorCommands/supportsCommand.js
 packages/editor/CodeMirror/extensions/biDirectionalTextExtension.js
 packages/editor/CodeMirror/extensions/ctrlClickActionExtension.js
 packages/editor/CodeMirror/extensions/ctrlClickCheckboxExtension.js
-packages/editor/CodeMirror/extensions/editorSettingsExtension.js
 packages/editor/CodeMirror/extensions/highlightActiveLineExtension.js
 packages/editor/CodeMirror/extensions/keyUpHandlerExtension.js
 packages/editor/CodeMirror/extensions/links/ctrlClickLinksExtension.js
@@ -1035,8 +1031,6 @@ packages/editor/CodeMirror/extensions/rendering/replaceBulletLists.js
 packages/editor/CodeMirror/extensions/rendering/replaceCheckboxes.js
 packages/editor/CodeMirror/extensions/rendering/replaceDividers.js
 packages/editor/CodeMirror/extensions/rendering/replaceFormatCharacters.js
-packages/editor/CodeMirror/extensions/rendering/replaceInlineHtml.test.js
-packages/editor/CodeMirror/extensions/rendering/replaceInlineHtml.js
 packages/editor/CodeMirror/extensions/rendering/types.js
 packages/editor/CodeMirror/extensions/rendering/utils/makeBlockReplaceExtension.js
 packages/editor/CodeMirror/extensions/rendering/utils/makeInlineReplaceExtension.js
@@ -1077,7 +1071,6 @@ packages/editor/CodeMirror/utils/getSearchState.js
 packages/editor/CodeMirror/utils/growSelectionToNode.js
 packages/editor/CodeMirror/utils/handleLinkEditRequests.js
 packages/editor/CodeMirror/utils/handlePasteEvent.js
-packages/editor/CodeMirror/utils/htmlNodeInfo.js
 packages/editor/CodeMirror/utils/isCursorAtBeginning.js
 packages/editor/CodeMirror/utils/isInSyntaxNode.js
 packages/editor/CodeMirror/utils/markdown/codeBlockLanguages/allLanguages.js
@@ -1093,7 +1086,6 @@ packages/editor/CodeMirror/vendor/announceSearchMatch.js
 packages/editor/ProseMirror/commands/commands.test.js
 packages/editor/ProseMirror/commands/commands.js
 packages/editor/ProseMirror/commands/focusEditor.js
-packages/editor/ProseMirror/commands/selectDocumentEnd.js
 packages/editor/ProseMirror/createEditor.js
 packages/editor/ProseMirror/index.js
 packages/editor/ProseMirror/plugins/detailsPlugin.test.js
@@ -1126,7 +1118,6 @@ packages/editor/ProseMirror/types.js
 packages/editor/ProseMirror/utils/SelectableNodeView.js
 packages/editor/ProseMirror/utils/UndoStackSynchronizer.js
 packages/editor/ProseMirror/utils/canReplaceSelectionWith.js
-packages/editor/ProseMirror/utils/clampPointToDocument.js
 packages/editor/ProseMirror/utils/computeSelectionFormatting.js
 packages/editor/ProseMirror/utils/dom/createButton.js
 packages/editor/ProseMirror/utils/dom/createTextArea.js
@@ -1136,7 +1127,6 @@ packages/editor/ProseMirror/utils/dom/showModal.js
 packages/editor/ProseMirror/utils/extractSelectedLinesTo.test.js
 packages/editor/ProseMirror/utils/extractSelectedLinesTo.js
 packages/editor/ProseMirror/utils/forEachHeading.js
-packages/editor/ProseMirror/utils/getTextBetween.js
 packages/editor/ProseMirror/utils/insertRenderedMarkdown.js
 packages/editor/ProseMirror/utils/jumpToHash.js
 packages/editor/ProseMirror/utils/makeLinksClickableInElement.js
@@ -1205,7 +1195,6 @@ packages/lib/InMemoryCache.js
 packages/lib/JoplinDatabase.js
 packages/lib/JoplinError.js
 packages/lib/JoplinServerApi.js
-packages/lib/ObjectUtils.test.js
 packages/lib/ObjectUtils.js
 packages/lib/PerformanceLogger.test.js
 packages/lib/PerformanceLogger.js
@@ -1228,8 +1217,6 @@ packages/lib/callbackUrlUtils.js
 packages/lib/clipperUtils.js
 packages/lib/commands/convertHtmlToMarkdown.test.js
 packages/lib/commands/convertHtmlToMarkdown.js
-packages/lib/commands/convertNoteToMarkdown.test.js
-packages/lib/commands/convertNoteToMarkdown.js
 packages/lib/commands/deleteNote.js
 packages/lib/commands/historyBackward.js
 packages/lib/commands/historyForward.js
@@ -1782,7 +1769,6 @@ packages/renderer/MdToHtml/renderMedia.js
 packages/renderer/MdToHtml/rules/abc.js
 packages/renderer/MdToHtml/rules/checkbox.js
 packages/renderer/MdToHtml/rules/code_inline.js
-packages/renderer/MdToHtml/rules/externalEmbed.js
 packages/renderer/MdToHtml/rules/fence.js
 packages/renderer/MdToHtml/rules/fountain.js
 packages/renderer/MdToHtml/rules/highlight_keywords.js
@@ -1818,36 +1804,28 @@ packages/tools/checkIgnoredFiles.js
 packages/tools/checkLibPaths.test.js
 packages/tools/checkLibPaths.js
 packages/tools/convertThemesToCss.js
-packages/tools/fuzzer/ActionRunner.js
 packages/tools/fuzzer/ActionTracker.js
 packages/tools/fuzzer/Client.js
 packages/tools/fuzzer/ClientPool.js
 packages/tools/fuzzer/Server.js
 packages/tools/fuzzer/constants.js
+packages/tools/fuzzer/doRandomAction.js
 packages/tools/fuzzer/model/FolderRecord.js
-packages/tools/fuzzer/model/ResourceRecord.js
 packages/tools/fuzzer/sync-fuzzer.js
 packages/tools/fuzzer/types.js
 packages/tools/fuzzer/utils/ProgressBar.js
 packages/tools/fuzzer/utils/SeededRandom.js
-packages/tools/fuzzer/utils/diffSortedStringArrays.test.js
-packages/tools/fuzzer/utils/diffSortedStringArrays.js
-packages/tools/fuzzer/utils/extractResourceIds.js
 packages/tools/fuzzer/utils/getNumberProperty.js
 packages/tools/fuzzer/utils/getProperty.js
 packages/tools/fuzzer/utils/getStringProperty.js
-packages/tools/fuzzer/utils/hangingIndent.js
 packages/tools/fuzzer/utils/logDiffDebug.js
 packages/tools/fuzzer/utils/openDebugSession.js
-packages/tools/fuzzer/utils/randomId.test.js
-packages/tools/fuzzer/utils/randomId.js
 packages/tools/fuzzer/utils/randomString.js
 packages/tools/fuzzer/utils/retryWithCount.js
 packages/tools/generate-database-types.js
 packages/tools/generate-images.js
 packages/tools/git-changelog.test.js
 packages/tools/git-changelog.js
-packages/tools/licenses/buildReport.js
 packages/tools/licenses/getLicenses.js
 packages/tools/licenses/licenseChecker.js
 packages/tools/licenses/licenseOverrides/fontAwesomeOverride/index.js

.yarn/patches/@react-native-vector-icons-fontawesome5-npm-12.3.0-a1ca46610f.patch

@@ -1,21 +0,0 @@
-# Add a minSdkVersion to prevent the dangerous READ_PHONE_STATE
-# permission from being added.
-# See:
-# - Upstream issue report: https://github.com/oblador/react-native-vector-icons/issues/1861
-# - About the permission: https://developer.android.com/reference/android/Manifest.permission#READ_PHONE_STATE
-# - StackOverflow post with discussion and alternate workarounds: https://stackoverflow.com/questions/39668549/why-has-the-read-phone-state-permission-been-added
-diff --git a/android/build.gradle b/android/build.gradle
-index a16b4ad6d1871cf5cf73ef7ebeaf8bd4d662b134..9871afb5fbf8e687370e08f54d884ecd7dde7e7c 100644
---- a/android/build.gradle
-+++ b/android/build.gradle
-@@ -37,6 +37,10 @@ android {
-   }
- 
-   compileSdkVersion safeExtGet('compileSdkVersion', 31)
-+
-+  defaultConfig {
-+    minSdkVersion safeExtGet('minSdkVersion', 24)
-+  }
- }
- 
- dependencies {

.yarn/patches/@react-native-vector-icons-ionicons-npm-12.3.0-9bd4746f3f.patch

@@ -1,21 +0,0 @@
-# Add a minSdkVersion to prevent the dangerous READ_PHONE_STATE
-# permission from being added.
-# See:
-# - Upstream issue report: https://github.com/oblador/react-native-vector-icons/issues/1861
-# - About the permission: https://developer.android.com/reference/android/Manifest.permission#READ_PHONE_STATE
-# - StackOverflow post with discussion and alternate workarounds: https://stackoverflow.com/questions/39668549/why-has-the-read-phone-state-permission-been-added
-diff --git a/android/build.gradle b/android/build.gradle
-index d42bd23123644cc324051e9c7ec4635de286315a..640996df60fe7769f69b30b35f771eb9cf0b75d4 100644
---- a/android/build.gradle
-+++ b/android/build.gradle
-@@ -37,6 +37,10 @@ android {
-   }
- 
-   compileSdkVersion safeExtGet('compileSdkVersion', 31)
-+  
-+  defaultConfig {
-+    minSdkVersion safeExtGet('minSdkVersion', 24)
-+  }
- }
- 
- dependencies {

.yarn/patches/@react-native-vector-icons-material-design-icons-npm-12.4.0-890f7f618b.patch

@@ -1,21 +0,0 @@
-# Add a minSdkVersion to prevent the dangerous READ_PHONE_STATE
-# permission from being added.
-# See:
-# - Upstream issue report: https://github.com/oblador/react-native-vector-icons/issues/1861
-# - About the permission: https://developer.android.com/reference/android/Manifest.permission#READ_PHONE_STATE
-# - StackOverflow post with discussion and alternate workarounds: https://stackoverflow.com/questions/39668549/why-has-the-read-phone-state-permission-been-added
-diff --git a/android/build.gradle b/android/build.gradle
-index 170ec0ff9befe0f9155aaf5e1b84133cfd87be99..e6a0ab4a019ee67c5af7761ae8bb35f18b05c590 100644
---- a/android/build.gradle
-+++ b/android/build.gradle
-@@ -37,6 +37,10 @@ android {
-   }
- 
-   compileSdkVersion safeExtGet('compileSdkVersion', 31)
-+
-+  defaultConfig {
-+    minSdkVersion safeExtGet('minSdkVersion', 24)
-+  }
- }
- 
- dependencies {

.yarn/patches/@react-native-vector-icons-material-icons-npm-12.4.0-94138e627b.patch

@@ -1,21 +0,0 @@
-# Add a minSdkVersion to prevent the dangerous READ_PHONE_STATE
-# permission from being added.
-# See:
-# - Upstream issue report: https://github.com/oblador/react-native-vector-icons/issues/1861
-# - About the permission: https://developer.android.com/reference/android/Manifest.permission#READ_PHONE_STATE
-# - StackOverflow post with discussion and alternate workarounds: https://stackoverflow.com/questions/39668549/why-has-the-read-phone-state-permission-been-added
-diff --git a/android/build.gradle b/android/build.gradle
-index 3b22f9de66795ee01dbaa29655727ee7ddba3cc8..325daa88d33f066b3826e5031ce281793710af2d 100644
---- a/android/build.gradle
-+++ b/android/build.gradle
-@@ -37,6 +37,10 @@ android {
-   }
- 
-   compileSdkVersion safeExtGet('compileSdkVersion', 31)
-+
-+  defaultConfig {
-+    minSdkVersion safeExtGet('minSdkVersion', 24)
-+  }
- }
- 
- dependencies {

Assets/WebsiteAssets/rss.xml

@@ -1,47 +1,4 @@
-<?xml version="1.0" encoding="UTF-8"?><rss xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:content="http://purl.org/rss/1.0/modules/content/" xmlns:atom="http://www.w3.org/2005/Atom" version="2.0"><channel><title><![CDATA[Joplin]]></title><description><![CDATA[Joplin, the open source note-taking application]]></description><link>https://joplinapp.org</link><generator>RSS for Node</generator><lastBuildDate>Sun, 11 Jan 2026 00:00:00 GMT</lastBuildDate><atom:link href="https://joplinapp.org/rss.xml" rel="self" type="application/rss+xml"/><pubDate>Sun, 11 Jan 2026 00:00:00 GMT</pubDate><item><title><![CDATA[What's new in Joplin 3.5]]></title><description><![CDATA[<h2>Improvements across desktop and mobile<a name="improvements-across-desktop-and-mobile" href="#improvements-across-desktop-and-mobile" class="heading-anchor">🔗</a></h2>
-<h3>More stable and consistent Markdown editing<a name="more-stable-and-consistent-markdown-editing" href="#more-stable-and-consistent-markdown-editing" class="heading-anchor">🔗</a></h3>
-<p>The Markdown editor has been refined to feel more stable and closer to the final rendered view. Headings in the editor now more closely match how they appear when viewing a note, reducing the visual jump between editing and reading. Layout issues have also been addressed so elements like rendered checkboxes and images no longer cause the editor to shift unexpectedly while typing.</p>
-<p>The ABC music notation plugin appeared to be popular but had some limitations. With this new version, ABC is now part of the app, which means it can now work from published notes, and from the Rich Text editor!</p>
-<p><img src="https://raw.githubusercontent.com/laurent22/joplin/dev/Assets/WebsiteAssets/images/news/20260111-abc.png" alt="ABC music notation rendered directly in Joplin, showing a short musical phrase displayed from plain-text ABC syntax"></p>
-<h3>Smoother switching between notes<a name="smoother-switching-between-notes" href="#smoother-switching-between-notes" class="heading-anchor">🔗</a></h3>
-<p>Switching between notes is now less disruptive. Joplin restores cursor position and scroll location more reliably, making it easier to move back and forth between notes—especially when working with longer documents or comparing content—without losing your place.</p>
-<h3>Case insensitive tags<a name="case-insensitive-tags" href="#case-insensitive-tags" class="heading-anchor">🔗</a></h3>
-<p>Tags are now treated in a case-insensitive way, which helps prevent duplicate tags caused by differences in capitalisation, while still allowing mixed-case tag names. All this time we were hoping that @dpoulton <a href="https://discourse.joplinapp.org/t/tags-lower-case-only/4220/106">would just get used to lowercase tags</a>, but 5 years later it looks like it's not happening ;) So thank you @mrjo118 for implementing it!</p>
-<p><img src="https://raw.githubusercontent.com/laurent22/joplin/dev/Assets/WebsiteAssets/images/news/20260111-lowercase-tags.png" alt="Joplin tag list demonstrating case-insensitive tags, with mixed-case tag names merged into a single tag."></p>
-<h3>More reliable syncing and sharing<a name="more-reliable-syncing-and-sharing" href="#more-reliable-syncing-and-sharing" class="heading-anchor">🔗</a></h3>
-<p>Syncing and sharing have been made more robust in everyday use. Joplin now handles repeated syncs more efficiently, avoids unnecessary data usage, and is better at detecting and syncing all changes, particularly when using WebDAV and S3 sync targets.</p>
-<p>Moreover filesystem synchronisation is now more reliable, in particular when used alongside tools like SyncThing on both mobile and desktop.</p>
-<h3>Accessibility and readability improvements<a name="accessibility-and-readability-improvements" href="#accessibility-and-readability-improvements" class="heading-anchor">🔗</a></h3>
-<p>Accessibility has seen further refinements in this release. Dark mode readability has been improved, common editor elements are clearer, and animations are reduced or disabled when system “reduce motion” settings are enabled, making the app more comfortable to use for a wider range of users. Keyboard navigation has also been improved on the desktop application.</p>
-<h2>Desktop-specific improvements<a name="desktop-specific-improvements" href="#desktop-specific-improvements" class="heading-anchor">🔗</a></h2>
-<h3>Easier profile management<a name="easier-profile-management" href="#easier-profile-management" class="heading-anchor">🔗</a></h3>
-<p>Managing multiple profiles on desktop is now simpler thanks to a new, more user-friendly profile management interface. This removes the need to manually edit configuration files and makes switching between different setups easier and safer.</p>
-<p><img src="https://raw.githubusercontent.com/laurent22/joplin/dev/Assets/WebsiteAssets/images/news/20260111-profiles.png" alt="Desktop profile management screen in Joplin showing multiple profiles with options to rename or delete them."></p>
-<h3>Significantly improved OneNote import<a name="significantly-improved-onenote-import" href="#significantly-improved-onenote-import" class="heading-anchor">🔗</a></h3>
-<p>Importing content from OneNote is now more reliable and accurate. Support has been expanded to cover more OneNote file formats, and many edge cases have been addressed so imported notes more closely match their original structure and content. This makes migrating from OneNote to Joplin smoother and more trustworthy.</p>
-<h3>Better tools for organising large note collections<a name="better-tools-for-organising-large-note-collections" href="#better-tools-for-organising-large-note-collections" class="heading-anchor">🔗</a></h3>
-<p>Desktop users can now select multiple notebooks at once, making it easier to reorganise notebook structures, move groups of notes, or clean up larger collections without working notebook by notebook.</p>
-<p><img src="https://raw.githubusercontent.com/laurent22/joplin/dev/Assets/WebsiteAssets/images/news/20260111-multi-select.png" alt="Joplin desktop sidebar with several notebooks selected at the same time for bulk organisation."></p>
-<h3>Polished editing experience on desktop<a name="polished-editing-experience-on-desktop" href="#polished-editing-experience-on-desktop" class="heading-anchor">🔗</a></h3>
-<p>Both the Markdown and Rich Text editors have been further refined. Cursor behaviour is more predictable, visual consistency between editing and viewing has improved, and several layout and rendering issues have been fixed to reduce interruptions while writing.</p>
-<h3>More reliable search and navigation<a name="more-reliable-search-and-navigation" href="#more-reliable-search-and-navigation" class="heading-anchor">🔗</a></h3>
-<p>Search and navigation on desktop have been improved with fixes that ensure search results behave consistently and remain visible when moving between windows or views.</p>
-<h3>Improved math support in WebClipper<a name="improved-math-support-in-webclipper" href="#improved-math-support-in-webclipper" class="heading-anchor">🔗</a></h3>
-<p>The WebClipper is not forgotten in this release - clipping certain math formulas, in particular from Wikipedia but also other websites, has been improved. Additionally, certain scientific articles are now also better handled by the WebClipper.</p>
-<h2>Mobile-specific improvements<a name="mobile-specific-improvements" href="#mobile-specific-improvements" class="heading-anchor">🔗</a></h2>
-<h3>A more powerful Rich Text Editor on mobile<a name="a-more-powerful-rich-text-editor-on-mobile" href="#a-more-powerful-rich-text-editor-on-mobile" class="heading-anchor">🔗</a></h3>
-<p>The mobile Rich Text Editor continues to improve, with new and expanded support for tables, code blocks, and other structured content. These changes make it easier to create and edit more complex notes directly on mobile devices.</p>
-<p><img src="https://raw.githubusercontent.com/laurent22/joplin/dev/Assets/WebsiteAssets/images/news/20260111-rte1.png" alt="Joplin mobile Rich Text Editor showing table editing controls and an embedded code block inside a note."></p>
-<p><img src="https://raw.githubusercontent.com/laurent22/joplin/dev/Assets/WebsiteAssets/images/news/20260111-rte2.png" alt="Mobile code block editor in Joplin with a Python code snippet displayed in an editable dialog."></p>
-<h3>Easier tag management on mobile<a name="easier-tag-management-on-mobile" href="#easier-tag-management-on-mobile" class="heading-anchor">🔗</a></h3>
-<p>Managing tags on mobile is now more practical. You can rename and delete tags directly from the app, and searching through tags is easier, helping keep large tag lists organised over time.</p>
-<p><img src="https://raw.githubusercontent.com/laurent22/joplin/dev/Assets/WebsiteAssets/images/news/20260111-mobile-tags.png" alt="Joplin mobile tag management screen showing a tag options menu with rename and delete actions."></p>
-<h3>Improved stability and usability on mobile devices<a name="improved-stability-and-usability-on-mobile-devices" href="#improved-stability-and-usability-on-mobile-devices" class="heading-anchor">🔗</a></h3>
-<p>Several fixes improve overall stability and usability on mobile, particularly on smaller screens. Issues causing UI elements to appear off-screen have been addressed, and the app behaves more consistently in situations that previously caused hangs or visual glitches.</p>
-<h2>Bug fixes and security fixes across platforms<a name="bug-fixes-and-security-fixes-across-platforms" href="#bug-fixes-and-security-fixes-across-platforms" class="heading-anchor">🔗</a></h2>
-<h3>A large number of stability, correctness and security fixes<a name="a-large-number-of-stability-correctness-and-security-fixes" href="#a-large-number-of-stability-correctness-and-security-fixes" class="heading-anchor">🔗</a></h3>
-<p>Joplin 3.5 includes about 114 bug fixes across desktop and mobile, addressing issues in editing, syncing, importing, rendering, and general stability. Many fixes target edge cases that could lead to crashes, inconsistent behaviour, or rare data loss scenarios. Moreover, this version includes several vulnerability fixes to make the applications more secure.</p>
-]]></description><link>https://joplinapp.org/news/20260111-release-3-5</link><guid isPermaLink="false">20260111-release-3-5</guid><pubDate>Sun, 11 Jan 2026 00:00:00 GMT</pubDate><twitter-text></twitter-text></item><item><title><![CDATA[What's new in Joplin 3.4]]></title><description><![CDATA[<p>Joplin 3.4 includes many bug fixes and improvements, with a focus on the mobile app.</p>
+<?xml version="1.0" encoding="UTF-8"?><rss xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:content="http://purl.org/rss/1.0/modules/content/" xmlns:atom="http://www.w3.org/2005/Atom" version="2.0"><channel><title><![CDATA[Joplin]]></title><description><![CDATA[Joplin, the open source note-taking application]]></description><link>https://joplinapp.org</link><generator>RSS for Node</generator><lastBuildDate>Mon, 22 Sep 2025 00:00:00 GMT</lastBuildDate><atom:link href="https://joplinapp.org/rss.xml" rel="self" type="application/rss+xml"/><pubDate>Mon, 22 Sep 2025 00:00:00 GMT</pubDate><item><title><![CDATA[What's new in Joplin 3.4]]></title><description><![CDATA[<p>Joplin 3.4 includes many bug fixes and improvements, with a focus on the mobile app.</p>
 <h2>Mobile<a name="mobile" href="#mobile" class="heading-anchor">🔗</a></h2>
 <h3>Rich Text Editor<a name="rich-text-editor" href="#rich-text-editor" class="heading-anchor">🔗</a></h3>
 <p>The mobile app now includes a beta <a href="https://joplinapp.org/help/apps/rich_text_editor">Rich Text Editor</a>! The new editor renders formatting/math/images within the editor:</p>
@@ -524,4 +481,42 @@ sys 0m38.013s</p>
 <p>This is a bit of an extra constraint but it is hard to avoid. Contributor License Agreements are very common for GPL or AGPL projects. For example Apache, Canonical or Python all require their contributors to sign a CLA.</p>
 <h2>Questions?<a name="questions" href="#questions" class="heading-anchor">🔗</a></h2>
 <p>If you have any questions please let us know. Overall we believe this is a positive improvements for Joplin as it means any work derives from it will also benefit the project.</p>
-]]></description><link>https://joplinapp.org/news/20221221-agpl</link><guid isPermaLink="false">20221221-agpl</guid><pubDate>Wed, 21 Dec 2022 00:00:00 GMT</pubDate><twitter-text>Joplin is switching to the GNU Affero General Public License v3 (AGPL-3.0)</twitter-text></item></channel></rss>
+]]></description><link>https://joplinapp.org/news/20221221-agpl</link><guid isPermaLink="false">20221221-agpl</guid><pubDate>Wed, 21 Dec 2022 00:00:00 GMT</pubDate><twitter-text>Joplin is switching to the GNU Affero General Public License v3 (AGPL-3.0)</twitter-text></item><item><title><![CDATA[What's new in Joplin 2.9]]></title><description><![CDATA[<h2>Proxy support<a name="proxy-support" href="#proxy-support" class="heading-anchor">🔗</a></h2>
+<p>Both the desktop and mobile application now support proxies thanks to the work of Jason Williams. This will allow you to use the apps in particular when you are behind a company proxy.</p>
+<p><img src="https://raw.githubusercontent.com/laurent22/joplin/dev/Assets/WebsiteAssets/images/news/20221216-proxy-support.png" alt=""></p>
+<h2>New PDF viewer<a name="new-pdf-viewer" href="#new-pdf-viewer" class="heading-anchor">🔗</a></h2>
+<p>The desktop application now features a new PDF viewer thanks to the work of Asrient during GSoC.</p>
+<p>The main advantage for now is that this viewer preserves the last PDF page that was read. In the next version, the viewer will also include a way to annotate PDF files.</p>
+<h2>Multi-language spell checking<a name="multi-language-spell-checking" href="#multi-language-spell-checking" class="heading-anchor">🔗</a></h2>
+<p>The desktop app include a multi-language spell checking features, which allows you, for example, to spell-check notes in your native language and in English.</p>
+<h2>New mobile text editor<a name="new-mobile-text-editor" href="#new-mobile-text-editor" class="heading-anchor">🔗</a></h2>
+<p>Writing formatted notes on mobile has always been cumbersome due to the need to enter special format characters like <code>*</code> or <code>[</code>, etc.</p>
+<p>Thanks to the work of Henry Heino during GSoC, writing notes on the go is now easier thanks to an improved Markdown editor.</p>
+<p><img src="https://raw.githubusercontent.com/laurent22/joplin/dev/Assets/WebsiteAssets/images/news/20221216-mobile-beta-editor.png" alt=""></p>
+<p>The most visible feature is the addition of a toolbar, which helps input those special characters, like on desktop.</p>
+<p>Moreover Henry made a lot of subtle but useful improvements to the editor, for example to improve the note appearance, to improve list continuation, etc. Search within a note is now also supported as well as spell-checking.</p>
+<p>At a more technical level, Henry also added many test units to ensure that the editor remains robust and reliable.</p>
+<p>To enable the feature, go to the configuration screen and selected &quot;Opt-in to the editor beta&quot;. It is already very stable so we will probably promote it to be the main editor from the next version.</p>
+<h2>Improved alignment of notebook icons<a name="improved-alignment-of-notebook-icons" href="#improved-alignment-of-notebook-icons" class="heading-anchor">🔗</a></h2>
+<p>Previously, when you would assign an icon to a notebook, it would shift the title to the right, but notebook without an icon would not. It means that notebooks with and without an icon would not be vertically aligned.</p>
+<p>To tidy things up, this new version adds a default icons to notebooks without an explicitly assigned icon. This result in the notebook titles being correctly vertically aligned.</p>
+<p>Note that this feature is only enabled if you use custom icons - otherwise it will simply display the notebook titles without any default icons, as before.</p>
+<p><img src="https://raw.githubusercontent.com/laurent22/joplin/dev/Assets/WebsiteAssets/images/news/20221216-notebook-icons.png" alt=""></p>
+<h2>Improved handling of file attachments<a name="improved-handling-of-file-attachments" href="#improved-handling-of-file-attachments" class="heading-anchor">🔗</a></h2>
+<p>Self Not Found made a number of small but useful improvements to attachment handling, including increasing the maximum size to 200MB, adding support for attaching multiple files, and fixing issues with synchronising attachments via proxy.</p>
+<h2>Fixed filesystem sync on mobile<a name="fixed-filesystem-sync-on-mobile" href="#fixed-filesystem-sync-on-mobile" class="heading-anchor">🔗</a></h2>
+<p>This was a long and complex change due to the need to support new Android APIs but hopefully that should now be working again, thanks to the work of jd1378.</p>
+<p>So you can now sync again your notes with Syncthing and other file-based synchronisation systems.</p>
+<h2>And more...<a name="and-more" href="#and-more" class="heading-anchor">🔗</a></h2>
+<p>In total this new desktop version includes 36 improvements, bug fixes, and security fixes.</p>
+<p>As always, a lot of work went into the Android and iOS app too, which include 37 improvements, bug fixes, and security fixes.</p>
+<p>See here for the changelogs:</p>
+<ul>
+<li><a href="https://joplinapp.org/help/about/changelog/desktop">Desktop app changelog</a></li>
+<li><a href="https://joplinapp.org/help/about/changelog/android/">Android app changelog</a></li>
+</ul>
+<h2>About the Android version<a name="about-the-android-version" href="#about-the-android-version" class="heading-anchor">🔗</a></h2>
+<p>Unfortunately we cannot publish the Android version because it is based on a framework version that Google does not accept. To upgrade the app a lot of changes are needed and another round of pre-releases, and therefore there will not be a 2.9 version for Google Play. You may however download the official APK directly from there: <a href="https://github.com/laurent22/joplin-android/releases/tag/android-v2.9.8">Android 2.9 Official Release</a></p>
+<p>This is the reality of app stores in general - small developers being imposed never ending new requirements by all-powerful companies, and by the time a version is finally ready we can't even publish it because yet more requirements are in place.</p>
+<p>For the record the current 2.9 app works perfectly fine. It targets Android 11, which is only 2 years old and is still supported (and installed on millions of phones). Google requires us to target Android 12 which only came out last year.</p>
+]]></description><link>https://joplinapp.org/news/20221216-release-2-9</link><guid isPermaLink="false">20221216-release-2-9</guid><pubDate>Fri, 16 Dec 2022 00:00:00 GMT</pubDate><twitter-text>What&apos;s new in Joplin 2.9</twitter-text></item></channel></rss>

Dockerfile.transcribe

@@ -1,4 +1,4 @@
-FROM node:24-bullseye
+FROM node:18-bullseye
 
 RUN apt-get update \
     && apt-get install -y \

Joplin_install_and_update.sh

@@ -198,21 +198,12 @@ else
 fi
 
 # Check if it's in the latest version
-if [[ -e "${INSTALL_DIR}/VERSION" ]]; then
-  CURRENT_VERSION=$(< "${INSTALL_DIR}/VERSION")
-  VERSION_COMPARISON=$(compareVersions "$CURRENT_VERSION" "$RELEASE_VERSION")
-
-  if [[ "$VERSION_COMPARISON" == "0" ]]; then
-    print "${COLOR_GREEN}You already have the latest version${COLOR_RESET} ${RELEASE_VERSION} ${COLOR_GREEN}installed.${COLOR_RESET}"
-    ([[ "$FORCE" == true ]] && print "Forcing installation...") || exit 0
-  elif [[ "$VERSION_COMPARISON" == "1" ]]; then
-    print "${COLOR_YELLOW}You have version ${CURRENT_VERSION} installed, which is newer than the latest published version ${RELEASE_VERSION}.${COLOR_RESET}"
-    print "${COLOR_YELLOW}Skipping installation to avoid downgrade.${COLOR_RESET}"
-  else
-    print "The latest version is ${RELEASE_VERSION}, but you have ${CURRENT_VERSION} installed."
-  fi
+if [[ -e "${INSTALL_DIR}/VERSION" ]] && [[ $(< "${INSTALL_DIR}/VERSION") == "${RELEASE_VERSION}" ]]; then
+  print "${COLOR_GREEN}You already have the latest version${COLOR_RESET} ${RELEASE_VERSION} ${COLOR_GREEN}installed.${COLOR_RESET}"
+  ([[ "$FORCE" == true ]] && print "Forcing installation...") || exit 0
 else
-  print "The latest version is ${RELEASE_VERSION}, but you have no version installed."
+  [[ -e "${INSTALL_DIR}/VERSION" ]] && CURRENT_VERSION=$(< "${INSTALL_DIR}/VERSION")
+  print "The latest version is ${RELEASE_VERSION}, but you have ${CURRENT_VERSION:-no version} installed."
 fi
 
 # Check if it's an update or a new install
@@ -284,7 +275,7 @@ if command -v lsb_release &> /dev/null; then
   # without writing the AppImage to a non-user-writable location (without invalidating other security
   # controls). See https://discourse.joplinapp.org/t/possible-future-requirement-for-no-sandbox-flag-for-ubuntu-23-10/.
   HAS_USERNS_RESTRICTIONS=false
-  if [[ "$DISTVER" =~ ^(Ubuntu|Tuxedo) && $DISTMAJOR -ge 23 ]]; then
+  if [[ "$DISTVER" =~ ^Ubuntu && $DISTMAJOR -ge 23 ]]; then
     HAS_USERNS_RESTRICTIONS=true
   fi
 

devbox.json

@@ -9,15 +9,20 @@
     "vips.dev": {
       "platforms": ["aarch64-darwin"],
     },
-    "nodejs":     "24.8.0",
+    "nodejs":     "23.11.0",
     "pkg-config": "latest",
+    "darwin.apple_sdk.frameworks.Foundation": { // satisfies missing CoreText/CoreText.h
+      // https://github.com/NixOS/nixpkgs/blob/master/pkgs/os-specific/darwin/apple-sdk/default.nix
+      "version":   "",
+      "platforms": ["aarch64-darwin", "x86_64-darwin"],
+    },
     "python": "3.13.3",
     "bat":    "latest",
     "electron": {
       "version":            "latest",
       "excluded_platforms": ["aarch64-darwin", "x86_64-darwin"],
     },
-    "git":    "2.50.1",
+    "git":    "2.50.0",
   },
   "shell": {
     "init_hook": [

docker-compose.db-dev.yml

@@ -19,7 +19,7 @@
 services:
 
     postgresql-master:
-        image: 'bitnamilegacy/postgresql:17.6.0'
+        image: 'bitnamilegacy/postgresql:17.5.0'
         ports:
             - '5432:5432'
         environment:
@@ -36,7 +36,7 @@ services:
             - POSTGRESQL_EXTRA_FLAGS=-c work_mem=100000 -c log_statement=all
 
     postgresql-slave:
-        image: 'bitnamilegacy/postgresql:17.6.0'
+        image: 'bitnamilegacy/postgresql:17.5.0'
         ports:
             - '5433:5432'
         depends_on:

jest.config.base.js

@@ -1,6 +0,0 @@
-// This is the base Jest configuration - all
-// jest.config.js files should inherit from it.
-
-module.exports = {
-	watchman: false,
-};

joplin.code-workspace

@@ -16,7 +16,6 @@
 			"./packages/app-cli/**/*.mo": true,
 			"./packages/app-cli/**/build/": true,
 			"./packages/app-cli/**/config.json": true,
-			"**/.watchman-cookie-*": true,
 			"./packages/app-cli/**/linkToLocal.sh": true,
 			"./packages/app-cli/**/node_modules/": true,
 			"./packages/app-cli/**/out.txt": true,

package.json

@@ -81,21 +81,21 @@
     "eslint-plugin-promise": "6.6.0",
     "eslint-plugin-react": "7.37.5",
     "execa": "5.1.1",
-    "fs-extra": "11.3.2",
+    "fs-extra": "11.2.0",
     "glob": "11.0.3",
     "gulp": "4.0.2",
     "husky": "9.1.7",
     "lerna": "3.22.1",
-    "lint-staged": "16.2.6",
+    "lint-staged": "15.5.2",
     "madge": "8.0.0",
-    "npm-package-json-lint": "9.0.0",
+    "npm-package-json-lint": "8.0.0",
     "typescript": "5.8.3"
   },
   "dependencies": {
     "@types/fs-extra": "11.0.4",
     "eslint-plugin-github": "4.10.2",
     "http-server": "14.1.1",
-    "node-gyp": "11.4.2",
+    "node-gyp": "11.2.0",
     "nodemon": "3.1.10"
   },
   "packageManager": "yarn@4.9.2",

packages/app-cli/app/command-keymap.ts

@@ -1,49 +0,0 @@
-import BaseCommand from './base-command';
-import app from './app';
-import { _ } from '@joplin/lib/locale';
-const { cliUtils } = require('./cli-utils.js');
-
-interface Args { }
-
-class Command extends BaseCommand {
-	public override usage() {
-		return 'keymap';
-	}
-
-	public override description() {
-		return _('Displays the configured keyboard shortcuts.');
-	}
-
-	public override compatibleUis() {
-		return ['cli', 'gui'];
-	}
-
-	public override async action(_args: Args) {
-		const keymaps = await app().loadKeymaps();
-
-		this.stdout(_('Configured keyboard shortcuts:'));
-		this.stdout('\n');
-
-		const rows = [];
-		const padding = '  ';
-
-		rows.push([`${padding}${_('KEYS')}`, _('TYPE'), _('COMMAND')]);
-		rows.push([`${padding}----`, '----', '-------']);
-
-		for (const item of keymaps) {
-			const formattedKeys = item.keys
-				.map((k: string) => (k === ' ' ? `(${_('SPACE')})` : k))
-				.join(', ');
-			rows.push([padding + formattedKeys, item.type, item.command]);
-		}
-
-		cliUtils.printArray(this.stdout.bind(this), rows);
-
-		if (app().gui() && !app().gui().isDummy()) {
-			app().gui().showConsole();
-			app().gui().maximizeConsole();
-		}
-	}
-}
-
-module.exports = Command;

packages/app-cli/app/command-testing.ts

@@ -107,7 +107,6 @@ class Command extends BaseCommand {
 				userContentBaseUrl: () => joplinServerAuth.userContentBaseUrl,
 				username: () => joplinServerAuth.email,
 				password: () => joplinServerAuth.password,
-				apiKey: () => '',
 				session: (): Session => null,
 			});
 

packages/app-cli/app/utils/testUtils.ts

@@ -2,7 +2,6 @@ import app from '../app';
 import Folder from '@joplin/lib/models/Folder';
 import BaseCommand from '../base-command';
 import setupCommand from '../setupCommand';
-import Setting from '@joplin/lib/models/Setting';
 
 // eslint-disable-next-line @typescript-eslint/ban-types, @typescript-eslint/no-explicit-any -- Old code before rule was applied, Old code before rule was applied
 export const setupCommandForTesting = (CommandClass: any, stdout: Function = null): BaseCommand => {
@@ -19,9 +18,4 @@ export const setupApplication = async () => {
 
 	// Some tests also need access to the Redux store
 	app().initRedux();
-
-	// Since the settings need to be loaded before the store is created, it will never
-	// receive the SETTING_UPDATE_ALL event, which means state.settings will not be
-	// initialised. So we manually call dispatchUpdateAll() to force an update.
-	Setting.dispatchUpdateAll();
 };

packages/app-cli/jest.config.js

@@ -24,21 +24,9 @@
 // 4. Remove tests one by one to narrow it down to the one with the async
 //    call that's causing problem.
 
-const baseConfig = require('../../jest.config.base.js');
-
 module.exports = {
-	...baseConfig,
 	testMatch: [
-		'**/tests/HtmlToHtml.js',
-		'**/tests/HtmlToMd.js',
-		'**/tests/MarkupToHtml.js',
-		'**/tests/MdToHtml.js',
-		'**/tests/feature_NoteHistory.js',
-		'**/tests/feature_NoteList.js',
-		'**/tests/feature_ShowAllNotes.js',
-		'**/tests/feature_TagList.js',
-
-		'**/tests/services/**/*.js',
+		'**/tests/**/*.js',
 		'**/*.test.js',
 	],
 

packages/app-cli/package.json

@@ -7,7 +7,7 @@
   "scripts": {
     "test": "jest --verbose=false --config=jest.config.js --bail --forceExit",
     "test-one": "jest --verbose=false --config=jest.config.js --bail --forceExit",
-    "test-ci": "jest --config=jest.config.js --forceExit --testPathIgnorePatterns=cli-integration-tests.test",
+    "test-ci": "jest --config=jest.config.js --forceExit",
     "build": "gulp build",
     "start": "gulp build -L && node \"build/main.js\" --stack-trace-enabled --log-level debug --env dev",
     "start-no-build": "node \"build/main.js\" --stack-trace-enabled --log-level debug --env dev",
@@ -35,20 +35,20 @@
     ],
     "owner": "Laurent Cozic"
   },
-  "version": "3.6.0",
+  "version": "3.5.1",
   "bin": "./main.js",
   "engines": {
     "node": ">=10.0.0"
   },
   "dependencies": {
-    "@joplin/lib": "~3.6",
-    "@joplin/renderer": "~3.6",
-    "@joplin/utils": "~3.6",
+    "@joplin/lib": "~3.5",
+    "@joplin/renderer": "~3.5",
+    "@joplin/utils": "~3.5",
     "aws-sdk": "2.1340.0",
     "chalk": "4.1.2",
     "compare-version": "0.1.2",
     "file-type": "16.5.4",
-    "fs-extra": "11.3.2",
+    "fs-extra": "11.2.0",
     "html-entities": "1.4.0",
     "keytar": "7.9.0",
     "md5": "2.3.0",
@@ -57,7 +57,7 @@
     "proper-lockfile": "4.1.2",
     "redux": "4.2.1",
     "server-destroy": "1.0.1",
-    "sharp": "0.34.4",
+    "sharp": "0.34.3",
     "sprintf-js": "1.1.3",
     "sqlite3": "5.1.6",
     "string-padding": "1.0.2",
@@ -70,7 +70,7 @@
     "yargs-parser": "21.1.1"
   },
   "devDependencies": {
-    "@joplin/tools": "~3.6",
+    "@joplin/tools": "~3.5",
     "@types/fs-extra": "11.0.4",
     "@types/jest": "29.5.14",
     "@types/node": "18.19.130",

packages/app-cli/tests/html_to_md/anchor_multiline_title.html

@@ -1,11 +0,0 @@
-<ul>
-	<li><a href="https://example.com/" title="This
-
-is a test title
-testing!
-
-Test...">Test!</a></li>
-	<li><a href="http://example.com" title="
-Test
-">Another test...</a></li>
-</ul>

packages/app-cli/tests/html_to_md/anchor_multiline_title.md

@@ -1,5 +0,0 @@
-- [Test!](https://example.com/ "This
-    is a test title
-    testing!
-    Test...")
-- [Another test...](http://example.com "Test")

packages/app-cli/tests/html_to_md/wikipedia_math_inline.html

@@ -1,74 +0,0 @@
-<!-- From https://en.wikipedia.org/wiki/Collatz_conjecture -->
-<math display="block" xmlns="http://www.w3.org/1998/Math/MathML" alttext="{\displaystyle f(n)={\begin{cases}n/2&amp;{\text{if }}n\equiv 0{\pmod {2}},\\3n+1&amp;{\text{if }}n\equiv 1{\pmod {2}}.\end{cases}}}">
-  <semantics>
-    <mrow class="MJX-TeXAtom-ORD">
-      <mstyle displaystyle="true" scriptlevel="0">
-        <mi>f</mi>
-        <mo stretchy="false">(</mo>
-        <mi>n</mi>
-        <mo stretchy="false">)</mo>
-        <mo>=</mo>
-        <mrow class="MJX-TeXAtom-ORD">
-          <mrow>
-            <mo>{</mo>
-            <mtable columnalign="left left" rowspacing=".2em" columnspacing="1em" displaystyle="false">
-              <mtr>
-                <mtd>
-                  <mi>n</mi>
-                  <mrow class="MJX-TeXAtom-ORD">
-                    <mo>/</mo>
-                  </mrow>
-                  <mn>2</mn>
-                </mtd>
-                <mtd>
-                  <mrow class="MJX-TeXAtom-ORD">
-                    <mtext>if&nbsp;</mtext>
-                  </mrow>
-                  <mi>n</mi>
-                  <mo>\u2261</mo>
-                  <mn>0</mn>
-                  <mrow class="MJX-TeXAtom-ORD">
-                    <mspace width="0.444em"></mspace>
-                    <mo stretchy="false">(</mo>
-                    <mi>mod</mi>
-                    <mspace width="0.333em"></mspace>
-                    <mn>2</mn>
-                    <mo stretchy="false">)</mo>
-                  </mrow>
-                  <mo>,</mo>
-                </mtd>
-              </mtr>
-              <mtr>
-                <mtd>
-                  <mn>3</mn>
-                  <mi>n</mi>
-                  <mo>+</mo>
-                  <mn>1</mn>
-                </mtd>
-                <mtd>
-                  <mrow class="MJX-TeXAtom-ORD">
-                    <mtext>if&nbsp;</mtext>
-                  </mrow>
-                  <mi>n</mi>
-                  <mo>\u2261</mo>
-                  <mn>1</mn>
-                  <mrow class="MJX-TeXAtom-ORD">
-                    <mspace width="0.444em"></mspace>
-                    <mo stretchy="false">(</mo>
-                    <mi>mod</mi>
-                    <mspace width="0.333em"></mspace>
-                    <mn>2</mn>
-                    <mo stretchy="false">)</mo>
-                  </mrow>
-                  <mo>.</mo>
-                </mtd>
-              </mtr>
-            </mtable>
-            <mo fence="true" stretchy="true" symmetric="true"></mo>
-          </mrow>
-        </mrow>
-      </mstyle>
-    </mrow>
-    <annotation encoding="application/x-tex">{\displaystyle f(n)={\begin{cases}n/2&amp;{\text{if }}n\equiv 0{\pmod {2}},\\3n+1&amp;{\text{if }}n\equiv 1{\pmod {2}}.\end{cases}}}</annotation>
-  </semantics>
-</math></span><img src="/some/src/here" class="mwe-math-fallback-image-display mw-invert skin-invert" aria-hidden="true" style="vertical-align: -3.171ex; width:45.735ex; height:7.509ex;"/>

packages/app-cli/tests/html_to_md/wikipedia_math_inline.md

@@ -1 +0,0 @@
-${\displaystyle f(n)={\begin{cases}n/2&{\text{if }}n\equiv 0{\pmod {2}},\\3n+1&{\text{if }}n\equiv 1{\pmod {2}}.\end{cases}}}$

packages/app-cli/tests/md_to_html/abc.html

@@ -1,10 +0,0 @@
-
-				<div class="joplin-editable joplin-abc-notation">
-					<pre class="joplin-source" data-abc-options="{&quot;responsive&quot;:&quot;resize&quot;}" data-joplin-language="abc" data-joplin-source-open="```abc&#10;" data-joplin-source-close="&#10;```&#10;">{responsive:'resize'}
----
-K:F
-!f!(fgag-g2c2)|</pre>
-					<pre class="joplin-rendered joplin-abc-notation-rendered">K:F
-!f!(fgag-g2c2)|</pre>
-				</div>
-			

packages/app-cli/tests/md_to_html/abc.md

@@ -1,6 +0,0 @@
-```abc
-{ responsive: 'resize' }
----
-K:F
-!f!(fgag-g2c2)|
-```

packages/app-cli/tests/md_to_html/external_embed.html

@@ -1,8 +0,0 @@
-
-				<div class="joplin-editable">
-					<span class="joplin-source" data-joplin-source-open="" data-joplin-source-close="">https://www.youtube.com/watch?v=iJqe9pC-z-Y</span>
-					<div class="joplin-youtube-player-rendered">
-						<iframe src="https://www.youtube-nocookie.com/embed/iJqe9pC-z-Y" title="YouTube video player" frameborder="0" allowfullscreen></iframe>
-					</div>
-				</div>
-			

packages/app-cli/tests/md_to_html/external_embed.md

@@ -1 +0,0 @@
-https://www.youtube.com/watch?v=iJqe9pC-z-Y

packages/app-cli/tests/support/test_notes/md/long-url.md

@@ -1,3 +0,0 @@
-# test for joplin import
-
-[https://l.facebook.com/l.php?u=https%3A%2F%2Fix.sk%2FNiBZH%3Futm\_source%3DYouTube%2520Instagram%26utm\_medium%3D2HIqFSGVVB2mFsVTJClrQ7ZnuGJaUt6hu1MNH0vUMjcrgWnUsK%26utm\_campaign%3D%25F0%259F%2598%25A9%25F0%259F%2598%258E%25F0%259F%2598%25BF%25F0%259F%25A4%2594%25F0%259F%2598%25A9%25F0%259F%2599%2583%25F0%259F%25A4%25AF%25F0%259F%25A5%25B0%25F0%259F%2598%25AB%25F0%259F%2598%25BA%26utm\_id%3D%25F0%259F%2598%258B%25F0%259F%2598%25A5%25F0%259F%25A4%25A1%25F0%259F%2598%25A0%25F0%259F%2598%2587%25F0%259F%25A5%25B4%25F0%259F%25A7%2590%25F0%259F%2598%258E%25F0%259F%2598%2582%25F0%259F%2598%259E%26utm\_term%3D%25F0%259F%2598%2584%25F0%259F%25A4%25A9%25F0%259F%2599%2580%25F0%259F%2598%2593%25F0%259F%25A4%25AF%25F0%259F%25A4%25A5%25F0%259F%2591%25BE%25F0%259F%2591%25BF%25F0%259F%2598%25BD%25F0%259F%25A4%25A5%26utm\_content%3D%25F0%259F%2591%25BD%25F0%259F%2598%25AB%25F0%259F%2591%25BF%25F0%259F%2598%25BD%25F0%259F%2598%25A9%25F0%259F%2599%2589%26fbclid%3DIwAR0I3l5DBLypLaTjDTCGPQ1i1MmPB2-pE8iqrxrgUK9Kkvq3OX5Mjejibzw&h=AT3nNxW4G-9nAkhXU1EVN-aVGl1o\_-DzDAaWFx9xbprpN3JRBOh17lCQQHNAlIMv6iE4P2vobBAAivLvdzy00K8xqIqb-CvGj6YnnBX6R9wwtj5Y&\_\_tn\_\_=H-y-R&c[0]=AT0eE6OXx\_t9HzpPmMgTdOWAw2ZRNPRDIHJWf699NZYkYzugbWS6g3rOndhPA8fwrCIgk1zn2D1To7phLW9wXkqfgZU1ayT3887\_dxrfN-x822Pos0lCjTIhoQcxfBl516pTz1XrRG\_MbtPpLzUFAGu4nw5W86UR1EkBCZhustNbgTX4wVReiVSuwAWu7Sp1yiWvUm5JXlo76663333hhsgsu](<https://l.facebook.com/l.php?u=https%3A%2F%2Fix.sk%2FNiBZH%3Futm_source%3DYouTube%2520Instagram%26utm_medium%3D2HIqFSGVVB2mFsVTJClrQ7ZnuGJaUt6hu1MNH0vUMjcrgWnUsK%26utm_campaign%3D%25F0%259F%2598%25A9%25F0%259F%2598%258E%25F0%259F%2598%25BF%25F0%259F%25A4%2594%25F0%259F%2598%25A9%25F0%259F%2599%2583%25F0%259F%25A4%25AF%25F0%259F%25A5%25B0%25F0%259F%2598%25AB%25F0%259F%2598%25BA%26utm_id%3D%25F0%259F%2598%258B%25F0%259F%2598%25A5%25F0%259F%25A4%25A1%25F0%259F%2598%25A0%25F0%259F%2598%2587%25F0%259F%25A5%25B4%25F0%259F%25A7%2590%25F0%259F%2598%258E%25F0%259F%2598%2582%25F0%259F%2598%259E%26utm_term%3D%25F0%259F%2598%2584%25F0%259F%25A4%25A9%25F0%259F%2599%2580%25F0%259F%2598%2593%25F0%259F%25A4%25AF%25F0%259F%25A4%25A5%25F0%259F%2591%25BE%25F0%259F%2591%25BF%25F0%259F%2598%25BD%25F0%259F%25A4%25A5%26utm_content%3D%25F0%259F%2591%25BD%25F0%259F%2598%25AB%25F0%259F%2591%25BF%25F0%259F%2598%25BD%25F0%259F%2598%25A9%25F0%259F%2599%2589%26fbclid%3DIwAR0I3l5DBLypLaTjDTCGPQ1i1MmPB2-pE8iqrxrgUK9Kkvq3OX5Mjejibzw&h=AT3nNxW4G-9nAkhXU1EVN-aVGl1o_-DzDAaWFx9xbprpN3JRBOh17lCQQHNAlIMv6iE4P2vobBAAivLvdzy00K8xqIqb-CvGj6YnnBX6R9wwtj5Y&__tn__=H-y-R&c[0]=AT0eE6OXx_t9HzpPmMgTdOWAw2ZRNPRDIHJWf699NZYkYzugbWS6g3rOndhPA8fwrCIgk1zn2D1To7phLW9wXkqfgZU1ayT3887_dxrfN-x822Pos0lCjTIhoQcxfBl516pTz1XrRG_MbtPpLzUFAGu4nw5W86UR1EkBCZhustNbgTX4wVReiVSuwAWu7Sp1yiWvUm5JXlo>)

packages/app-cli/tests/support/test_notes/yaml/bad_keywords.md

@@ -1,9 +0,0 @@
----
-id:  20250821081408
-date: 2025-08-21
-keywords:
----
-
-# A test file for Joplin importer
-
-Test

packages/app-cli/tests/support/test_notes/yaml/date_bug.md

@@ -1,7 +0,0 @@
----
-title: test
-created: 2025-07-22 17:30:44Z
-updated: 2025-07-22 17:37:48Z
----
-
-test

packages/app-cli/tests/support/test_notes/yaml/notesnook_updated_created.md

@@ -1,7 +1,7 @@
 ---
 title: "Frontmatter test"
 created_at: 01-01-2024 01:23 AM
-updated_at: 01-01-2024 04:56 AM
+updated_at: 02-01-2024 04:56 AM
 ---
 
 # Frontmatter test

packages/app-clipper/content_scripts/index.js

@@ -165,10 +165,6 @@
 				if (a && a.toLowerCase().indexOf('math/tex') >= 0) isVisible = true;
 			}
 
-			if (nodeName === 'annotation') {
-				if (node.getAttribute('encoding') === 'application/x-tex') isVisible = true;
-			}
-
 			if (nodeName === 'source' && nodeParentName === 'picture') {
 				isVisible = false;
 			}

packages/app-clipper/manifest.json

@@ -1,7 +1,7 @@
 {
     "manifest_version": 3,
     "name": "Joplin Web Clipper [DEV]",
-    "version": "3.6.0",
+    "version": "3.5.0",
     "description": "Capture and save web pages and screenshots from your browser to Joplin.",
     "homepage_url": "https://joplinapp.org",
     "content_security_policy": {

packages/app-desktop/ElectronAppWrapper.ts

@@ -260,15 +260,6 @@ export default class ElectronAppWrapper {
 
 		require('@electron/remote/main').enable(this.win_.webContents);
 
-		// Add Referer header for YouTube embeds to fix Error 153
-		this.win_.webContents.session.webRequest.onBeforeSendHeaders(
-			{ urls: ['*://*.youtube.com/*', '*://*.youtube-nocookie.com/*'] },
-			(details, callback) => {
-				details.requestHeaders['Referer'] = 'https://joplinapp.org/';
-				callback({ requestHeaders: details.requestHeaders });
-			},
-		);
-
 		if (!screen.getDisplayMatching(this.win_.getBounds())) {
 			const { width: windowWidth, height: windowHeight } = this.win_.getBounds();
 			const { width: primaryDisplayWidth, height: primaryDisplayHeight } = screen.getPrimaryDisplay().workArea;

packages/app-desktop/InteropServiceHelper.ts

@@ -95,9 +95,6 @@ export default class InteropServiceHelper {
 									// Allows users to override the CSS page size.
 									// See https://github.com/laurent22/joplin/issues/13096
 									preferCSSPageSize: true,
-
-									// Include accessibility information in the output:
-									generateTaggedPDF: true,
 								});
 								resolve(data);
 							} catch (error) {

packages/app-desktop/app.ts

@@ -281,16 +281,14 @@ class Application extends BaseApplication {
 		}
 
 		// As of Joplin 3.5.7, the ABC rendering is part of the app so we automatically disable the plugin
-		if (pluginSettings['org.joplinapp.plugins.AbcSheetMusic']) {
-			pluginSettings = {
-				...pluginSettings,
-				['org.joplinapp.plugins.AbcSheetMusic']: {
-					enabled: false,
-					deleted: false,
-					hasBeenUpdated: false,
-				},
-			};
-		}
+		pluginSettings = {
+			...pluginSettings,
+			['org.joplinapp.plugins.AbcSheetMusic']: {
+				enabled: false,
+				deleted: false,
+				hasBeenUpdated: false,
+			},
+		};
 
 		try {
 			if (await shim.fsDriver().exists(Setting.value('pluginDir'))) {

packages/app-desktop/commands/convertNoteToMarkdown.test.ts

@@ -1,20 +1,18 @@
 import * as convertHtmlToMarkdown from './convertNoteToMarkdown';
-import { defaultState, State } from '../reducer';
-import Note from '../models/Note';
+import { AppState, createAppDefaultState } from '../app.reducer';
+import Note from '@joplin/lib/models/Note';
 import { MarkupLanguage } from '@joplin/renderer';
-import { setupDatabaseAndSynchronizer, switchClient } from '../testing/test-utils';
-import Folder from '../models/Folder';
-import { NoteEntity } from '../services/database/types';
-import shim from '../shim';
+import { setupDatabaseAndSynchronizer, switchClient } from '@joplin/lib/testing/test-utils';
+import Folder from '@joplin/lib/models/Folder';
+import { NoteEntity } from '@joplin/lib/services/database/types';
 
 describe('convertNoteToMarkdown', () => {
-	let state: State = undefined;
+	let state: AppState = undefined;
 
 	beforeEach(async () => {
-		state = defaultState;
+		state = createAppDefaultState({});
 		await setupDatabaseAndSynchronizer(1);
 		await switchClient(1);
-		shim.showToast = jest.fn();
 	});
 
 	it('should set the original note to be trashed', async () => {
@@ -31,6 +29,13 @@ describe('convertNoteToMarkdown', () => {
 	});
 
 	it('should recreate a new note that is a clone of the original', async () => {
+		let noteConvertedToMarkdownId = '';
+		const dispatchFn = jest.fn()
+			.mockImplementationOnce(() => {})
+			.mockImplementationOnce(action => {
+				noteConvertedToMarkdownId = action.id;
+			});
+
 		const folder = await Folder.save({ title: 'test_folder' });
 		const htmlNoteProperties = {
 			title: 'test',
@@ -44,11 +49,10 @@ describe('convertNoteToMarkdown', () => {
 		const htmlNote = await Note.save(htmlNoteProperties);
 		state.selectedNoteIds = [htmlNote.id];
 
-		await convertHtmlToMarkdown.runtime().execute({ state, dispatch: jest.fn() });
+		await convertHtmlToMarkdown.runtime().execute({ state, dispatch: dispatchFn });
 
-		const notes = await Note.previews(folder.id);
-		expect(notes).toHaveLength(1);
-		const noteConvertedToMarkdownId = notes[0].id;
+		expect(dispatchFn).toHaveBeenCalledTimes(2);
+		expect(noteConvertedToMarkdownId).not.toBe('');
 
 		const markdownNote = await Note.load(noteConvertedToMarkdownId);
 
@@ -59,6 +63,15 @@ describe('convertNoteToMarkdown', () => {
 	});
 
 	it('should generate action to trigger notification', async () => {
+		let originalHtmlNoteId = '';
+		let actionType = '';
+		const dispatchFn = jest.fn()
+			.mockImplementationOnce(action => {
+				originalHtmlNoteId = action.value;
+				actionType = action.type;
+			})
+			.mockImplementationOnce(() => {});
+
 		const folder = await Folder.save({ title: 'test_folder' });
 		const htmlNoteProperties = {
 			title: 'test',
@@ -72,9 +85,12 @@ describe('convertNoteToMarkdown', () => {
 		const htmlNote = await Note.save(htmlNoteProperties);
 		state.selectedNoteIds = [htmlNote.id];
 
-		await convertHtmlToMarkdown.runtime().execute({ state, dispatch: jest.fn() });
+		await convertHtmlToMarkdown.runtime().execute({ state, dispatch: dispatchFn });
 
-		expect(shim.showToast).toHaveBeenCalled();
+		expect(dispatchFn).toHaveBeenCalledTimes(2);
+
+		expect(originalHtmlNoteId).toBe(htmlNote.id);
+		expect(actionType).toBe('NOTE_HTML_TO_MARKDOWN_DONE');
 	});
 
 });

packages/app-desktop/commands/convertNoteToMarkdown.ts

@@ -0,0 +1,52 @@
+import { _ } from '@joplin/lib/locale';
+import Note from '@joplin/lib/models/Note';
+import { stateUtils } from '@joplin/lib/reducer';
+import { CommandRuntime, CommandDeclaration, CommandContext } from '@joplin/lib/services/CommandService';
+import { MarkupLanguage } from '@joplin/renderer';
+import { runtime as convertHtmlToMarkdown } from '@joplin/lib/commands/convertHtmlToMarkdown';
+import bridge from '../services/bridge';
+
+export const declaration: CommandDeclaration = {
+	name: 'convertNoteToMarkdown',
+	label: () => _('Convert note to Markdown'),
+};
+
+export const runtime = (): CommandRuntime => {
+	return {
+		execute: async (context: CommandContext, noteId: string = null) => {
+			noteId = noteId || stateUtils.selectedNoteId(context.state);
+
+			const note = await Note.load(noteId);
+
+			if (!note) return;
+
+			try {
+				const markdownBody = await convertHtmlToMarkdown().execute(context, note.body);
+
+				const newNote = await Note.duplicate(note.id);
+
+				newNote.body = markdownBody;
+				newNote.markup_language = MarkupLanguage.Markdown;
+
+				await Note.save(newNote);
+
+				await Note.delete(note.id, { toTrash: true });
+
+				context.dispatch({
+					type: 'NOTE_HTML_TO_MARKDOWN_DONE',
+					value: note.id,
+				});
+
+				context.dispatch({
+					type: 'NOTE_SELECT',
+					id: newNote.id,
+				});
+			} catch (error) {
+				bridge().showErrorMessageBox(_('Could not convert note to Markdown: %s', error.message));
+			}
+
+
+		},
+		enabledCondition: 'oneNoteSelected && noteIsHtml && !noteIsReadOnly',
+	};
+};

packages/app-desktop/commands/index.ts

@@ -1,4 +1,5 @@
 // AUTO-GENERATED using `gulp buildScriptIndexes`
+import * as convertNoteToMarkdown from './convertNoteToMarkdown';
 import * as copyDevCommand from './copyDevCommand';
 import * as copyToClipboard from './copyToClipboard';
 import * as editProfileConfig from './editProfileConfig';
@@ -13,7 +14,6 @@ import * as openProfileDirectory from './openProfileDirectory';
 import * as openSecondaryAppInstance from './openSecondaryAppInstance';
 import * as replaceMisspelling from './replaceMisspelling';
 import * as restoreNoteRevision from './restoreNoteRevision';
-import * as showProfileEditor from './showProfileEditor';
 import * as startExternalEditing from './startExternalEditing';
 import * as stopExternalEditing from './stopExternalEditing';
 import * as switchProfile from './switchProfile';
@@ -25,6 +25,7 @@ import * as toggleSafeMode from './toggleSafeMode';
 import * as toggleTabMovesFocus from './toggleTabMovesFocus';
 
 const index: any[] = [
+	convertNoteToMarkdown,
 	copyDevCommand,
 	copyToClipboard,
 	editProfileConfig,
@@ -39,7 +40,6 @@ const index: any[] = [
 	openSecondaryAppInstance,
 	replaceMisspelling,
 	restoreNoteRevision,
-	showProfileEditor,
 	startExternalEditing,
 	stopExternalEditing,
 	switchProfile,

packages/app-desktop/commands/showProfileEditor.ts

@@ -1,20 +0,0 @@
-import { CommandRuntime, CommandDeclaration, CommandContext } from '@joplin/lib/services/CommandService';
-import { _ } from '@joplin/lib/locale';
-
-export const declaration: CommandDeclaration = {
-	name: 'showProfileEditor',
-	label: () => _('Manage profiles'),
-};
-
-export const runtime = (): CommandRuntime => {
-	return {
-		execute: async (context: CommandContext) => {
-			context.dispatch({
-				type: 'NAV_GO',
-				routeName: 'ProfileEditor',
-			});
-		},
-		enabledCondition: 'hasMultiProfiles',
-	};
-};
-

packages/app-desktop/gui/ConversionNotification/ConversionNotification.tsx

@@ -0,0 +1,28 @@
+import * as React from 'react';
+import { useContext, useEffect } from 'react';
+import { _ } from '@joplin/lib/locale';
+import { Dispatch } from 'redux';
+import { PopupNotificationContext } from '../PopupNotification/PopupNotificationProvider';
+import { NotificationType } from '../PopupNotification/types';
+
+interface Props {
+	noteId: string;
+	dispatch: Dispatch;
+}
+
+export default (props: Props) => {
+	const popupManager = useContext(PopupNotificationContext);
+
+	useEffect(() => {
+		if (!props.noteId || props.noteId === '') return;
+
+		props.dispatch({ type: 'NOTE_HTML_TO_MARKDOWN_DONE', value: '' });
+
+		const notification = popupManager.createPopup(() => (
+			<div>{_('The note has been converted to Markdown and the original note has been moved to the trash')}</div>
+		), { type: NotificationType.Success });
+		notification.scheduleDismiss();
+	}, [props.dispatch, popupManager, props.noteId]);
+
+	return <div style={{ display: 'none' }}/>;
+};

packages/app-desktop/gui/MainScreen.tsx

@@ -38,12 +38,14 @@ import restart from '../services/restart';
 import { connect } from 'react-redux';
 import { NoteListColumns } from '@joplin/lib/services/plugins/api/noteListType';
 import validateColumns from './NoteListHeader/utils/validateColumns';
+import ConversionNotification from './ConversionNotification/ConversionNotification';
 import TrashNotification from './TrashNotification/TrashNotification';
 import UpdateNotification from './UpdateNotification/UpdateNotification';
 import NoteEditor from './NoteEditor/NoteEditor';
 import PluginNotification from './PluginNotification/PluginNotification';
 import { Toast } from '@joplin/lib/services/plugins/api/types';
 import PluginService from '@joplin/lib/services/plugins/PluginService';
+import { Dispatch } from 'redux';
 
 const ipcRenderer = require('electron').ipcRenderer;
 
@@ -84,6 +86,7 @@ interface Props {
 	showInvalidJoplinCloudCredential: boolean;
 	toast: Toast;
 	shouldSwitchToAppleSiliconVersion: boolean;
+	noteHtmlToMarkdownDone: string;
 }
 
 interface ShareFolderDialogOptions {
@@ -797,6 +800,10 @@ class MainScreenComponent extends React.Component<Props, State> {
 
 		return (
 			<div style={style}>
+				<ConversionNotification
+					noteId={this.props.noteHtmlToMarkdownDone}
+					dispatch={this.props.dispatch as Dispatch}
+				/>
 				<TrashNotification
 					lastDeletion={this.props.lastDeletion}
 					lastDeletionNotificationTime={this.props.lastDeletionNotificationTime}
@@ -852,7 +859,8 @@ const mapStateToProps = (state: AppState) => {
 		notesColumns: validateColumns(state.settings['notes.columns']),
 		showInvalidJoplinCloudCredential: state.settings['sync.target'] === 10 && state.mustAuthenticate,
 		toast: state.toast,
-		shouldSwitchToAppleSiliconVersion: shim.isAppleSilicon() && shim.isMac() && process.arch !== 'arm64',
+		shouldSwitchToAppleSiliconVersion: shim.isAppleSilicon() && process.arch !== 'arm64',
+		noteHtmlToMarkdownDone: state.noteHtmlToMarkdownDone,
 	};
 };
 

packages/app-desktop/gui/MenuBar.tsx

@@ -117,7 +117,7 @@ const useSwitchProfileMenuItems = (profileConfig: ProfileConfig, menuItemDic: an
 
 		switchProfileMenuItems.push({ type: 'separator' });
 		switchProfileMenuItems.push(menuItemDic.addProfile);
-		switchProfileMenuItems.push(menuItemDic.showProfileEditor);
+		switchProfileMenuItems.push(menuItemDic.editProfileConfig);
 
 		return switchProfileMenuItems;
 	}, [profileConfig, menuItemDic]);

packages/app-desktop/gui/NoteContentPropertiesDialog.tsx

@@ -31,15 +31,13 @@ function markupToHtml() {
 }
 
 // eslint-disable-next-line @typescript-eslint/ban-types -- Old code before rule was applied
-function countElements(text: string, wordSetter: Function, characterSetter: Function, characterNoSpaceSetter: Function, cjkCharacterSetter: React.Dispatch<React.SetStateAction<number>>, lineSetter: Function) {
+function countElements(text: string, wordSetter: Function, characterSetter: Function, characterNoSpaceSetter: Function, lineSetter: Function) {
 	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 	Countable.count(text, (counter: any) => {
 		wordSetter(counter.words);
 		characterSetter(counter.all);
 		characterNoSpaceSetter(counter.characters);
 	});
-	const cjkMatches = text.match(/[\p{Script=Han}\p{Script=Bopomofo}\p{Script=Hiragana}\p{Script=Katakana}\p{Script=Hangul}]/gu);
-	cjkCharacterSetter(cjkMatches ? cjkMatches.length : 0);
 	lineSetter(text === '' ? 0 : text.split('\n').length);
 }
 
@@ -60,25 +58,23 @@ export default function NoteContentPropertiesDialog(props: NoteContentProperties
 	const [words, setWords] = useState<number>(0);
 	const [characters, setCharacters] = useState<number>(0);
 	const [charactersNoSpace, setCharactersNoSpace] = useState<number>(0);
-	const [cjkCharacters, setCjkCharacters] = useState<number>(0);
 	// For source with Markdown syntax stripped out
 	const [strippedLines, setStrippedLines] = useState<number>(0);
 	const [strippedWords, setStrippedWords] = useState<number>(0);
 	const [strippedCharacters, setStrippedCharacters] = useState<number>(0);
 	const [strippedCharactersNoSpace, setStrippedCharactersNoSpace] = useState<number>(0);
-	const [strippedCjkCharacters, setStrippedCjkCharacters] = useState<number>(0);
 	const [strippedReadTime, setStrippedReadTime] = useState<number>(0);
 	// This amount based on the following paper:
 	// https://www.researchgate.net/publication/332380784_How_many_words_do_we_read_per_minute_A_review_and_meta-analysis_of_reading_rate
 	const wordsPerMinute = 250;
 
 	useEffect(() => {
-		countElements(props.text, setWords, setCharacters, setCharactersNoSpace, setCjkCharacters, setLines);
+		countElements(props.text, setWords, setCharacters, setCharactersNoSpace, setLines);
 	}, [props.text]);
 
 	useEffect(() => {
 		const strippedText: string = markupToHtml().stripMarkup(props.markupLanguage, props.text);
-		countElements(strippedText, setStrippedWords, setStrippedCharacters, setStrippedCharactersNoSpace, setStrippedCjkCharacters, setStrippedLines);
+		countElements(strippedText, setStrippedWords, setStrippedCharacters, setStrippedCharactersNoSpace, setStrippedLines);
 		// eslint-disable-next-line @seiyab/react-hooks/exhaustive-deps -- Old code before rule was applied
 	}, [props.text]);
 
@@ -92,7 +88,6 @@ export default function NoteContentPropertiesDialog(props: NoteContentProperties
 		words: words,
 		characters: characters,
 		charactersNoSpace: charactersNoSpace,
-		cjkCharacters: cjkCharacters,
 	};
 
 	const strippedTextProperties: TextPropertiesMap = {
@@ -104,14 +99,12 @@ export default function NoteContentPropertiesDialog(props: NoteContentProperties
 		words: strippedWords,
 		characters: strippedCharacters,
 		charactersNoSpace: strippedCharactersNoSpace,
-		cjkCharacters: strippedCjkCharacters,
 	};
 
 	const keyToLabel: KeyToLabelMap = {
 		words: _('Words'),
 		characters: _('Characters'),
 		charactersNoSpace: _('Characters excluding spaces'),
-		cjkCharacters: _('Chinese/Japanese/Korean characters'),
 		lines: _('Lines'),
 	};
 
@@ -154,7 +147,6 @@ export default function NoteContentPropertiesDialog(props: NoteContentProperties
 	);
 
 	for (const key in textProperties) {
-		if (key === 'cjkCharacters' && textProperties[key] === 0 && strippedTextProperties[key] === 0) continue;
 		const comp = createTableBodyRow(key, textProperties[key], strippedTextProperties[key]);
 		tableBodyComps.push(comp);
 	}

packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/utils/useContextMenu.ts

@@ -156,10 +156,7 @@ const useContextMenu = (props: ContextMenuProps) => {
 
 		// Prepend the event listener so that it gets called before
 		// the listener that shows the default menu.
-		// Use mainWindow() instead of activeWindow() because activeWindow() can return
-		// the DevTools window when it's focused, causing the listener to be registered
-		// on the wrong webContents.
-		const targetWindow = bridge().mainWindow();
+		const targetWindow = bridge().activeWindow();
 		targetWindow.webContents.prependListener('context-menu', onContextMenu);
 
 		return () => {

packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/CodeMirror.tsx

@@ -366,7 +366,6 @@ const CodeMirror = (props: NoteBodyEditorProps, ref: ForwardedRef<NoteBodyEditor
 			ignoreModifiers: true,
 			spellcheckEnabled: Setting.value('editor.spellcheckBeta'),
 			keymap: keyboardMode,
-			preferMacShortcuts: shim.isMac(),
 			indentWithTabs: true,
 			tabMovesFocus: props.tabMovesFocus,
 			editorLabel: _('Markdown editor'),

packages/app-desktop/gui/NoteEditor/NoteBody/TinyMCE/TinyMCE.tsx

@@ -742,7 +742,7 @@ const TinyMCE = (props: NoteBodyEditorProps, ref: Ref<NoteBodyEditorRef>) => {
 					'media-src \'self\' blob: data: *', // Audio and video players
 
 					// Disallow certain unused features
-					'child-src https://*.youtube.com https://*.youtube-nocookie.com', // Allow YouTube embeds
+					'child-src \'none\'', // Should not contain sub-frames
 					'object-src \'none\'', // Objects can be used for script injection
 					'form-action \'none\'', // No submitting forms
 
@@ -1051,7 +1051,6 @@ const TinyMCE = (props: NoteBodyEditorProps, ref: Ref<NoteBodyEditorRef>) => {
 		editor,
 	});
 
-	const noteChangeTimeRef = useRef(Date.now());
 	const lastNoteIdRef = useRef(props.noteId);
 	useEffect(() => {
 		if (!editor) return () => {};
@@ -1069,9 +1068,6 @@ const TinyMCE = (props: NoteBodyEditorProps, ref: Ref<NoteBodyEditorRef>) => {
 			// Use nextOnChangeEventInfo's noteId -- lastOnChangeEventInfo can be slightly out-of-date.
 			const differentNoteId = lastNoteIdRef.current !== props.noteId;
 			const differentContent = lastOnChangeEventInfo.current.content !== props.content;
-
-			if (differentNoteId) noteChangeTimeRef.current = Date.now();
-
 			if (differentNoteId || differentContent || !resourcesEqual) {
 				const result = await props.markupToHtml(
 					props.contentMarkupLanguage,
@@ -1344,15 +1340,7 @@ const TinyMCE = (props: NoteBodyEditorProps, ref: Ref<NoteBodyEditorRef>) => {
 		// keep it this way for now.
 		// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 		function onKeyUp(event: any) {
-			const timeSinceNoteChange = Date.now() - noteChangeTimeRef.current;
-
-			// A key that is pressed before the editor is opened, and that is released after it is
-			// opened is going to be processed here. For example if the user presses Enter in
-			// GotoAnything to arrive here. But in that case, we don't want the change handler to be
-			// activated, because that would change the note timestamp. So we take into account how
-			// long the note has been loaded before we process the key. Fixes
-			// https://github.com/laurent22/joplin/issues/12367
-			if (['Backspace', 'Delete', 'Enter', 'Tab'].includes(event.key) && timeSinceNoteChange > 200) {
+			if (['Backspace', 'Delete', 'Enter', 'Tab'].includes(event.key)) {
 				onChangeHandler();
 			}
 		}

packages/app-desktop/gui/NoteEditor/NoteBody/TinyMCE/utils/joplinCommandToTinyMceCommands.ts

@@ -22,8 +22,4 @@ export const joplinCommandToTinyMceCommands: JoplinCommandToTinyMceCommands = {
 	'search': { name: 'SearchReplace' },
 	'attachFile': { name: 'joplinAttach' },
 	'insertDateTime': true,
-	'textCopy': true,
-	'textCut': true,
-	'textPaste': true,
-	'textSelectAll': true,
 };

packages/app-desktop/gui/NoteEditor/NoteBody/TinyMCE/utils/useContextMenu.ts

@@ -34,10 +34,7 @@ export default function(editor: Editor, plugins: PluginStates, dispatch: Dispatc
 		if (!editor) return () => {};
 
 		const contextMenuItems = menuItems(dispatch);
-		// Use mainWindow() instead of activeWindow() because activeWindow() can return
-		// the DevTools window when it's focused, causing the listener to be registered
-		// on the wrong webContents.
-		const targetWindow = bridge().mainWindow();
+		const targetWindow = bridge().activeWindow();
 
 		const makeMainMenuItems = (element: Element) => {
 			let itemType: ContextMenuItemType = ContextMenuItemType.None;

packages/app-desktop/gui/NoteEditor/NoteEditor.tsx

@@ -50,7 +50,7 @@ import WarningBanner from './WarningBanner/WarningBanner';
 import UserWebview from '../../services/plugins/UserWebview';
 import Logger from '@joplin/utils/Logger';
 import usePluginEditorView from './utils/usePluginEditorView';
-import { defaultWindowId, stateUtils } from '@joplin/lib/reducer';
+import { stateUtils } from '@joplin/lib/reducer';
 import { WindowIdContext } from '../NewWindowOrIFrame';
 import useResourceUnwatcher from './utils/useResourceUnwatcher';
 import StatusBar from './StatusBar';
@@ -722,8 +722,6 @@ const mapStateToProps = (state: AppState, ownProps: ConnectProps) => {
 		bodyEditor = 'CodeMirror5';
 	}
 
-	const mainWindowState = stateUtils.windowStateById(state, defaultWindowId);
-
 	return {
 		noteId,
 		bodyEditor,
@@ -742,9 +740,7 @@ const mapStateToProps = (state: AppState, ownProps: ConnectProps) => {
 		customCss: state.customViewerCss,
 		noteVisiblePanes: windowState.noteVisiblePanes,
 		watchedResources: windowState.watchedResources,
-		// For now, only the main window has search UI. Show the same search markers in all
-		// windows:
-		highlightedWords: mainWindowState.highlightedWords,
+		highlightedWords: state.highlightedWords,
 		plugins: state.pluginService.plugins,
 		pluginHtmlContents: state.pluginService.pluginHtmlContents,
 		toolbarButtonInfos: toolbarButtonUtils.commandsToToolbarButtons([

packages/app-desktop/gui/NoteEditor/editorCommandDeclarations.test.ts

@@ -17,19 +17,19 @@ describe('editorCommandDeclarations', () => {
 	test.each([
 		[
 			{},
-			{ textBold: true },
+			true,
 		],
 		[
 			{
 				markdownEditorPaneVisible: false,
 			},
-			{ textBold: false },
+			false,
 		],
 		[
 			{
 				noteIsReadOnly: true,
 			},
-			{ textBold: false },
+			false,
 		],
 		[
 			// In the Markdown editor, but only the viewer is visible
@@ -37,7 +37,7 @@ describe('editorCommandDeclarations', () => {
 				markdownEditorPaneVisible: false,
 				richTextEditorVisible: false,
 			},
-			{ textBold: false },
+			false,
 		],
 		[
 			// In the Markdown editor, and the viewer is visible
@@ -45,7 +45,7 @@ describe('editorCommandDeclarations', () => {
 				markdownEditorPaneVisible: true,
 				richTextEditorVisible: false,
 			},
-			{ textBold: true },
+			true,
 		],
 		[
 			// In the RT editor
@@ -53,7 +53,7 @@ describe('editorCommandDeclarations', () => {
 				markdownEditorPaneVisible: false,
 				richTextEditorVisible: true,
 			},
-			{ textBold: true },
+			true,
 		],
 		[
 			// In the Markdown editor, and the command palette is visible
@@ -63,57 +63,14 @@ describe('editorCommandDeclarations', () => {
 				gotoAnythingVisible: true,
 				modalDialogVisible: true,
 			},
-			{ textBold: true },
+			true,
 		],
-		[
-			// In the Markdown editor, and the command palette is visible
-			{
-				markdownEditorPaneVisible: true,
-				richTextEditorVisible: false,
-				gotoAnythingVisible: true,
-				modalDialogVisible: true,
-			},
-			{ textBold: true },
-		],
-		[
-			// Rich Text Editor, HTML note
-			{
-				markdownEditorPaneVisible: false,
-				richTextEditorVisible: true,
-				noteIsMarkdown: false,
-			},
-			{
-				textCopy: true,
-				textPaste: true,
-				textSelectAll: true,
-			},
-		],
-		[
-			// Rich Text Editor, read-only note
-			{
-				markdownEditorPaneVisible: false,
-				richTextEditorVisible: true,
-				noteIsReadOnly: true,
-			},
-			{
-				textBold: false,
-				textPaste: false,
-
-				// TODO: textCopy should be enabled in read-only notes:
-				// textCopy: false,
-			},
-		],
-	])('should correctly determine whether command is enabled (case %#)', (context, expectedStates) => {
-		const actualStates = [];
-		for (const commandName of Object.keys(expectedStates)) {
-			const condition = enabledCondition(commandName);
-			const wc = new WhenClause(condition);
-			const actual = wc.evaluate({ ...baseContext, ...context });
-			actualStates.push([commandName, actual]);
-		}
-
-		const expectedStatesArray = Object.entries(expectedStates);
-		expect(actualStates).toEqual(expectedStatesArray);
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	])('should create the enabledCondition', (context: Record<string, any>, expected: boolean) => {
+		const condition = enabledCondition('textBold');
+		const wc = new WhenClause(condition);
+		const actual = wc.evaluate({ ...baseContext, ...context });
+		expect(actual).toBe(expected);
 	});
 
 });

packages/app-desktop/gui/NoteEditor/editorCommandDeclarations.ts

@@ -4,10 +4,6 @@ import { joplinCommandToTinyMceCommands } from './NoteBody/TinyMCE/utils/joplinC
 
 const workWithHtmlNotes = [
 	'attachFile',
-	'textCopy',
-	'textCut',
-	'textPaste',
-	'textSelectAll',
 ];
 
 export const enabledCondition = (commandName: string) => {

packages/app-desktop/gui/NoteEditor/utils/useWindowCommandHandler.ts

@@ -2,7 +2,7 @@ import { RefObject, Dispatch, SetStateAction, useEffect } from 'react';
 import { WindowCommandDependencies, NoteBodyEditorRef, OnChangeEvent, ScrollOptionTypes } from './types';
 import editorCommandDeclarations, { enabledCondition } from '../editorCommandDeclarations';
 import CommandService, { CommandDeclaration, CommandRuntime, CommandContext, RegisteredRuntime } from '@joplin/lib/services/CommandService';
-import { formatMsToLocal } from '@joplin/utils/time';
+import time from '@joplin/lib/time';
 import { reg } from '@joplin/lib/registry';
 import getWindowCommandPriority from './getWindowCommandPriority';
 
@@ -50,7 +50,7 @@ function editorCommandRuntime(
 			if (declaration.name === 'insertDateTime') {
 				return editorRef.current.execCommand({
 					name: 'insertText',
-					value: formatMsToLocal(Date.now()),
+					value: time.formatMsToLocal(new Date().getTime()),
 				});
 			} else if (declaration.name === 'scrollToHash') {
 				return editorRef.current.scrollTo({

packages/app-desktop/gui/PopupNotification/PopupNotificationProvider.tsx

@@ -1,8 +1,7 @@
 import * as React from 'react';
-import { createContext, useEffect, useMemo, useRef, useState } from 'react';
+import { createContext, useMemo, useRef, useState } from 'react';
 import { NotificationType, PopupHandle, PopupControl as PopupManager } from './types';
 import { Hour, msleep } from '@joplin/utils/time';
-import shim from '@joplin/lib/shim';
 
 export const PopupNotificationContext = createContext<PopupManager|null>(null);
 export const VisibleNotificationsContext = createContext<PopupSpec[]>([]);
@@ -113,18 +112,6 @@ const PopupNotificationProvider: React.FC<Props> = props => {
 		return manager;
 	}, []);
 
-	useEffect(() => {
-		const defaultShowToast = shim.showToast;
-		shim.showToast = async (message: string, options) => {
-			const popup = popupManager.createPopup(() => message, { type: options?.type ?? NotificationType.Info });
-			popup.scheduleDismiss();
-		};
-
-		return () => {
-			shim.showToast = defaultShowToast;
-		};
-	}, [popupManager]);
-
 	return <PopupNotificationContext.Provider value={popupManager}>
 		<VisibleNotificationsContext.Provider value={popupSpecs}>
 			{props.children}

packages/app-desktop/gui/PopupNotification/types.ts

@@ -1,4 +1,3 @@
-import { ToastType } from '@joplin/lib/shim';
 import * as React from 'react';
 
 export type PopupHandle = {
@@ -6,12 +5,13 @@ export type PopupHandle = {
 	scheduleDismiss(delay?: number): void;
 };
 
-export type NotificationContentCallback = ()=> React.ReactNode;
+export enum NotificationType {
+	Info = 'info',
+	Success = 'success',
+	Error = 'error',
+}
 
-// NotificationType is an alias for ToastType
-export type NotificationType = ToastType;
-// eslint-disable-next-line no-redeclare -- export const is necessary for creating an alias, this is not a redeclaration.
-export const NotificationType = ToastType;
+export type NotificationContentCallback = ()=> React.ReactNode;
 
 export interface PopupOptions {
 	type?: NotificationType;

packages/app-desktop/gui/ProfileEditor.scss

@@ -1,47 +0,0 @@
-.profile-management {
-	font-family: var(--joplin-font-family);
-	display: flex;
-	flex-direction: column;
-
-	> .tableContainer {
-		overflow-y: scroll;
-		padding: 20px;
-		box-sizing: border-box;
-		flex: 1 1 0%;
-		color: var(--joplin-color);
-
-		> .notification {
-			margin-bottom: 10px;
-		}
-	}
-}
-
-.profile-table {
-	width: 100%;
-
-	> thead > tr > .headerCell {
-		white-space: nowrap;
-		font-weight: bold;
-		width: 1px;
-	}
-
-	> tbody > tr {
-		> .nameCell {
-			text-overflow: ellipsis;
-			overflow-x: hidden;
-			max-width: 1px;
-			width: 100%;
-			white-space: nowrap;
-		}
-		
-		> .dataCell {
-			white-space: nowrap;
-			width: 1px;
-			color: var(--joplin-color-faded);
-		}
-		
-		> .profileActions > button {
-			margin-right: 10px;
-		}
-	}
-}

packages/app-desktop/gui/ProfileEditor.tsx

@@ -1,193 +0,0 @@
-import * as React from 'react';
-import { useState, useEffect, CSSProperties } from 'react';
-import ButtonBar from './ConfigScreen/ButtonBar';
-import { _ } from '@joplin/lib/locale';
-import { connect } from 'react-redux';
-import { themeStyle } from '@joplin/lib/theme';
-import bridge from '../services/bridge';
-import dialogs from './dialogs';
-import { Profile, ProfileConfig } from '@joplin/lib/services/profileConfig/types';
-import { deleteProfileById, saveProfileConfig } from '@joplin/lib/services/profileConfig';
-import Setting from '@joplin/lib/models/Setting';
-import shim from '@joplin/lib/shim';
-import Logger from '@joplin/utils/Logger';
-import { AppState } from '../app.reducer';
-import { Dispatch } from 'redux';
-
-const logger = Logger.create('ProfileEditor');
-
-interface Props {
-	themeId: number;
-	dispatch: Dispatch;
-	style: CSSProperties;
-	profileConfig: ProfileConfig;
-}
-
-interface ProfileTableProps {
-	profiles: Profile[];
-	currentProfileId: string;
-	onProfileRename: (profile: Profile)=> void;
-	onProfileDelete: (profile: Profile)=> void;
-	themeId: number;
-}
-
-const ProfileTableComp: React.FC<ProfileTableProps> = props => {
-	const theme = themeStyle(props.themeId);
-
-	return (
-		<table className="profile-table">
-			<thead>
-				<tr>
-					<th className="headerCell">{_('Profile name')}</th>
-					<th className="headerCell">{_('ID')}</th>
-					<th className="headerCell">{_('Status')}</th>
-					<th className="headerCell">{_('Actions')}</th>
-				</tr>
-			</thead>
-			<tbody>
-				{props.profiles.map((profile: Profile, index: number) => {
-					const isCurrentProfile = profile.id === props.currentProfileId;
-					return (
-						<tr key={index}>
-							<td id={`name-${profile.id}`} className="nameCell">
-								<span style={{ fontWeight: isCurrentProfile ? 'bold' : 'normal' }}>
-									{profile.name || `(${_('Untitled')})`}
-								</span>
-							</td>
-							<td className="dataCell">{profile.id}</td>
-							<td className="dataCell">
-								{isCurrentProfile ? _('Active') : ''}
-							</td>
-							<td className="dataCell profileActions">
-								<button
-									id={`rename-${profile.id}`}
-									aria-labelledby={`rename-${profile.id} name-${profile.id}`}
-									style={theme.buttonStyle}
-									onClick={() => props.onProfileRename(profile)}
-								>
-									{_('Rename')}
-								</button>
-								{!isCurrentProfile && (
-									<button
-										id={`delete-${profile.id}`}
-										aria-labelledby={`delete-${profile.id} name-${profile.id}`}
-										style={theme.buttonStyle}
-										onClick={() => props.onProfileDelete(profile)}
-									>
-										{_('Delete')}
-									</button>
-								)}
-							</td>
-						</tr>
-					);
-				})}
-			</tbody>
-		</table>
-	);
-};
-
-const ProfileEditorComponent: React.FC<Props> = props => {
-	const { profileConfig, themeId, dispatch } = props;
-	const theme = themeStyle(themeId);
-	const style = props.style;
-	const containerHeight = style.height;
-
-	const [profiles, setProfiles] = useState<Profile[]>(profileConfig.profiles);
-
-	useEffect(() => {
-		setProfiles(profileConfig.profiles);
-	}, [profileConfig]);
-
-	const saveNewProfileConfig = async (makeNewProfileConfig: ()=> ProfileConfig) => {
-		try {
-			const newProfileConfig = makeNewProfileConfig();
-			await saveProfileConfig(`${Setting.value('rootProfileDir')}/profiles.json`, newProfileConfig);
-			dispatch({
-				type: 'PROFILE_CONFIG_SET',
-				value: newProfileConfig,
-			});
-		} catch (error) {
-			logger.error(error);
-			bridge().showErrorMessageBox(error.message);
-		}
-	};
-
-	const onProfileRename = async (profile: Profile) => {
-		const newName = await dialogs.prompt(_('Profile name:'), '', profile.name);
-		if (newName === null || newName === undefined || newName === profile.name) return;
-
-		if (!newName.trim()) {
-			bridge().showErrorMessageBox(_('Profile name cannot be empty'));
-			return;
-		}
-
-		const makeNewProfileConfig = () => {
-			const newProfiles = profileConfig.profiles.map(p =>
-				p.id === profile.id ? { ...p, name: newName.trim() } : p,
-			);
-
-			const newProfileConfig = {
-				...profileConfig,
-				profiles: newProfiles,
-			};
-
-			return newProfileConfig;
-		};
-
-		await saveNewProfileConfig(makeNewProfileConfig);
-	};
-
-	const onProfileDelete = async (profile: Profile) => {
-		const isCurrentProfile = profile.id === profileConfig.currentProfileId;
-		if (isCurrentProfile) {
-			bridge().showErrorMessageBox(_('The active profile cannot be deleted. Switch to a different profile and try again.'));
-			return;
-		}
-
-		const ok = bridge().showConfirmMessageBox(_('Delete profile "%s"?\n\nAll data, including notes, notebooks and tags will be permanently deleted.', profile.name), {
-			buttons: [_('Delete'), _('Cancel')],
-			defaultId: 1,
-		});
-		if (!ok) return;
-
-		const rootDir = Setting.value('rootProfileDir');
-		const profileDir = `${rootDir}/profile-${profile.id}`;
-
-		try {
-			await shim.fsDriver().remove(profileDir);
-			logger.info('Deleted profile directory: ', profileDir);
-		} catch (error) {
-			logger.error('Error deleting profile directory: ', error);
-			bridge().showErrorMessageBox(error.message);
-		}
-
-		await saveNewProfileConfig(() => deleteProfileById(profileConfig, profile.id));
-	};
-
-	return (
-		<div className="profile-management" style={{ ...theme.containerStyle, height: containerHeight }}>
-			<div className="tableContainer">
-				<div className="notification" style={theme.notificationBox}>
-					{_('Manage your profiles. You can rename or delete profiles. The active profile cannot be deleted.')}
-				</div>
-				<ProfileTableComp
-					themeId={themeId}
-					profiles={profiles}
-					currentProfileId={profileConfig.currentProfileId}
-					onProfileRename={onProfileRename}
-					onProfileDelete={onProfileDelete}
-				/>
-			</div>
-			<ButtonBar
-				onCancelClick={() => dispatch({ type: 'NAV_BACK' })}
-			/>
-		</div>
-	);
-};
-
-const mapStateToProps = (state: AppState) => ({
-	themeId: state.settings.theme,
-	profileConfig: state.profileConfig,
-});
-
-export default connect(mapStateToProps)(ProfileEditorComponent);

packages/app-desktop/gui/ResourceScreen.tsx

@@ -84,13 +84,7 @@ const ResourceTableComp = (props: ResourceTable) => {
 	};
 
 	const filteredResources = props.resources.filter(
-		(resource: InnerResource) => {
-			if (props.filter) {
-				const filterLowerCase = props.filter.toLowerCase();
-				return resource.title?.toLowerCase().includes(filterLowerCase) || resource.id.toLowerCase().includes(filterLowerCase);
-			}
-			return true;
-		},
+		(resource: InnerResource) => !props.filter || resource.title?.includes(props.filter) || resource.id.includes(props.filter),
 	);
 
 	const renderSortableHeader = (title: string, order: SortingOrder) => {
@@ -303,7 +297,7 @@ class ResourceScreenComponent extends React.Component<Props, State> {
 					<div style={{ ...theme.notificationBox, marginBottom: 10 }}>{
 						_('This is an advanced tool to show the attachments that are linked to your notes. Please be careful when deleting one of them as they cannot be restored afterwards.')
 					}</div>
-					<p style={{ float: 'left', paddingRight: 10 }}>
+					<div style={{ float: 'right' }}>
 						<input
 							style={theme.inputStyle}
 							type="search"
@@ -311,7 +305,7 @@ class ResourceScreenComponent extends React.Component<Props, State> {
 							onChange={this.onFilterUpdate}
 							placeholder={_('Search...')}
 						/>
-					</p>
+					</div>
 					{this.state.isLoading && <div>{_('Please wait...')}</div>}
 					{!this.state.isLoading && <div>
 						{!this.state.resources && <div>

packages/app-desktop/gui/Root.tsx

@@ -20,7 +20,6 @@ import Dialog from './Dialog';
 import StyleSheetContainer from './StyleSheets/StyleSheetContainer';
 import ImportScreen from './ImportScreen';
 import ResourceScreen from './ResourceScreen';
-import ProfileEditor from './ProfileEditor';
 import Navigator from './Navigator';
 import WelcomeUtils from '@joplin/lib/WelcomeUtils';
 import JoplinCloudLoginScreen from './JoplinCloudLoginScreen';
@@ -166,7 +165,6 @@ class RootComponent extends React.Component<Props, any> {
 			Import: { screen: ImportScreen, title: () => _('Import') },
 			Config: { screen: ConfigScreen, title: () => _('Options') },
 			Resources: { screen: ResourceScreen, title: () => _('Note attachments') },
-			ProfileEditor: { screen: ProfileEditor, title: () => _('Manage profiles') },
 			Status: { screen: StatusScreen, title: () => _('Synchronisation Status') },
 		};
 

packages/app-desktop/gui/ShareNoteDialog.tsx

@@ -3,6 +3,7 @@ import { useState, useEffect, useCallback, useMemo } from 'react';
 import { _, _n } from '@joplin/lib/locale';
 import Note from '@joplin/lib/models/Note';
 import DialogButtonRow from './DialogButtonRow';
+import { themeStyle, buildStyle } from '@joplin/lib/theme';
 import Dialog from './Dialog';
 import DialogTitle from './DialogTitle';
 import ShareService from '@joplin/lib/services/share/ShareService';
@@ -28,6 +29,47 @@ interface Props {
 	syncTargetId: number;
 }
 
+function styles_(props: Props) {
+	return buildStyle('ShareNoteDialog', props.themeId, theme => {
+		return {
+			root: {
+				minWidth: 500,
+			},
+			noteList: {
+				marginBottom: 10,
+			},
+			note: {
+				flex: 1,
+				flexDirection: 'row',
+				display: 'flex',
+				alignItems: 'center',
+				border: '1px solid',
+				borderColor: theme.dividerColor,
+				padding: '0.5em',
+				marginBottom: 5,
+			},
+			noteTitle: {
+				...theme.textStyle,
+				flex: 1,
+				display: 'flex',
+				color: theme.color,
+			},
+			noteRemoveButton: {
+				background: 'none',
+				border: 'none',
+			},
+			noteRemoveButtonIcon: {
+				color: theme.color,
+				fontSize: '1.4em',
+			},
+			copyShareLinkButton: {
+				...theme.buttonStyle,
+				marginBottom: 10,
+			},
+		};
+	});
+}
+
 export function ShareNoteDialog(props: Props) {
 	const [notes, setNotes] = useState<NoteEntity[]>([]);
 	const [recursiveShare, setRecursiveShare] = useState<boolean>(false);
@@ -35,6 +77,8 @@ export function ShareNoteDialog(props: Props) {
 
 	const syncTargetInfo = useMemo(() => SyncTargetRegistry.infoById(props.syncTargetId), [props.syncTargetId]);
 	const noteCount = notes.length;
+	const theme = themeStyle(props.themeId);
+	const styles = styles_(props);
 
 	useEffect(() => {
 		void ShareService.instance().refreshShares();
@@ -73,8 +117,8 @@ export function ShareNoteDialog(props: Props) {
 		);
 
 		return (
-			<div key={note.id} className='shared-note-list-item'>
-				<span className='title'>{note.title}</span>{unshareButton}
+			<div key={note.id} style={styles.note}>
+				<span style={styles.noteTitle}>{note.title}</span>{unshareButton}
 			</div>
 		);
 	};
@@ -84,7 +128,7 @@ export function ShareNoteDialog(props: Props) {
 		for (const note of notes) {
 			noteComps.push(renderNote(note));
 		}
-		return <div className="notes">{noteComps}</div>;
+		return <div style={styles.noteList}>{noteComps}</div>;
 	};
 
 	const statusMessage = useShareStatusMessage({ sharesState, noteCount });
@@ -92,7 +136,7 @@ export function ShareNoteDialog(props: Props) {
 
 	function renderEncryptionWarningMessage() {
 		if (!encryptionWarning) return null;
-		return <div className="message">{encryptionWarning}<hr/></div>;
+		return <div style={theme.textStyle}>{encryptionWarning}<hr/></div>;
 	}
 
 	const onRecursiveShareChange = useCallback(() => {
@@ -111,16 +155,12 @@ export function ShareNoteDialog(props: Props) {
 
 	const renderContent = () => {
 		return (
-			<div className="form share-note-dialog">
+			<div style={styles.root} className="form">
 				<DialogTitle title={_('Publish Notes')}/>
 				{renderNoteList(notes)}
 				{renderRecursiveShareCheckbox()}
-				<button
-					disabled={[SharingStatus.Creating, SharingStatus.Synchronizing].indexOf(sharesState) >= 0}
-					className="share"
-					onClick={shareLinkButton_click}
-				>{_n('Copy Shareable Link', 'Copy Shareable Links', noteCount)}</button>
-				<div className="message">{statusMessage}</div>
+				<button disabled={[SharingStatus.Creating, SharingStatus.Synchronizing].indexOf(sharesState) >= 0} style={styles.copyShareLinkButton} onClick={shareLinkButton_click}>{_n('Copy Shareable Link', 'Copy Shareable Links', noteCount)}</button>
+				<div style={theme.textStyle}>{statusMessage}</div>
 				{renderEncryptionWarningMessage()}
 				<DialogButtonRow
 					themeId={props.themeId}

packages/app-desktop/gui/Sidebar/hooks/useOnSidebarKeyDownHandler.ts

@@ -51,11 +51,9 @@ const getParentOffset = (childIndex: number, listItems: ListItem[]): number|null
 };
 
 const findNextTypeAheadMatch = (selectedIndex: number, query: string, listItems: ListItem[]) => {
-	const normalize = (text: string) => text.trim().toLowerCase();
 	const matches = (item: ListItem) => {
-		return normalize(item.label).startsWith(normalize(query));
+		return item.label.startsWith(query);
 	};
-
 	const indexBefore = listItems.slice(0, selectedIndex).findIndex(matches);
 	// Search in all results **after** the current. This prevents the current item from
 	// always being identified as the next match, if the user repeatedly presses the

packages/app-desktop/gui/ToolbarBase.tsx

@@ -123,8 +123,8 @@ const ToolbarBaseComponent: React.FC<Props> = props => {
 		};
 
 		const tabIndex = indexInFocusable === (selectedIndex % focusableItems.length) ? 0 : -1;
-		const setButtonRefCallback = (button: HTMLButtonElement | null) => {
-			if (button && tabIndex === 0 && containerHasFocus) {
+		const setButtonRefCallback = (button: HTMLButtonElement) => {
+			if (tabIndex === 0 && containerHasFocus) {
 				focus('ToolbarBase', button);
 			}
 		};

packages/app-desktop/gui/WindowCommandsAndDialogs/commands/importFrom.ts

@@ -10,11 +10,8 @@ import Setting from '@joplin/lib/models/Setting';
 import { PackageInfo } from '@joplin/lib/versionInfo';
 import shim from '@joplin/lib/shim';
 import { ImportModule } from '@joplin/lib/services/interop/Module';
-import Logger from '@joplin/utils/Logger';
 const packageInfo: PackageInfo = require('../../../packageInfo.js');
 
-const logger = Logger.create('importFrom');
-
 export const declaration: CommandDeclaration = {
 	name: 'importFrom',
 	label: () => _('Import...'),
@@ -124,7 +121,8 @@ export const runtime = (control: WindowControl): CommandRuntime => {
 
 					void CommandService.instance().execute('showModalMessage', `${modalMessage}\n\n${statusStrings.join('\n')}`);
 				},
-				onError: (error: string|Error) => {
+				// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+				onError: (error: any) => {
 					errors.push(error);
 					console.warn(error);
 				},
@@ -137,7 +135,6 @@ export const runtime = (control: WindowControl): CommandRuntime => {
 				// eslint-disable-next-line no-console
 				console.info('Import result: ', result);
 			} catch (error) {
-				logger.error(error);
 				bridge().showErrorMessageBox(error.message);
 			}
 

packages/app-desktop/gui/menuCommandNames.ts

@@ -73,7 +73,7 @@ export default function() {
 		'commandPalette',
 		'openMasterPasswordDialog',
 		'addProfile',
-		'showProfileEditor',
+		'editProfileConfig',
 		'switchProfile1',
 		'switchProfile2',
 		'switchProfile3',

packages/app-desktop/gui/styles/base-button.scss

@@ -1,16 +0,0 @@
-// Corresponds to theme.buttonStyle
-.base-button {
-	border: 1px solid;
-	min-height: 26px;
-	min-width: 80px;
-	padding-left: 12px;
-	padding-right: 12px;
-	padding-top: 6px;
-	padding-bottom: 6px;
-	border-radius: 4px;
-
-	color: var(--joplin-color4);
-	background-color: var(--joplin-background-color4);
-	border-color: var(--joplin-border-color4);
-	user-select: none;
-}

packages/app-desktop/gui/styles/base-text.scss

@@ -1,8 +0,0 @@
-
-// Corresponds to theme.textStyle
-.base-text {
-	font-family: var(--joplin-font-family);
-	font-size: var(--joplin-font-size);
-	line-height: 1.6em;
-	color: var(--joplin-color);
-}

packages/app-desktop/gui/styles/index.scss

@@ -1,6 +1,4 @@
 
-@use './base-text.scss';
-@use './base-button.scss';
 @use './dialog-modal-layer.scss';
 @use './user-webview-dialog.scss';
 @use './prompt-dialog.scss';
@@ -21,5 +19,3 @@
 @use './popup-notification-list.scss';
 @use './popup-notification-item.scss';
 @use './multi-note-actions.scss';
-@use './share-note-dialog.scss';
-@use './shared-note-list-item.scss';

packages/app-desktop/gui/styles/share-note-dialog.scss

@@ -1,19 +0,0 @@
-@use "./base-button.scss";
-@use "./base-text.scss";
-
-.share-note-dialog {
-	min-width: 500px;
-
-	> .message {
-		@extend .base-text;
-	}
-
-	> .notes {
-		margin-bottom: 10px;
-	}
-
-	> .share {
-		@extend .base-button;
-		margin-bottom: 10px;
-	}
-}

packages/app-desktop/gui/styles/shared-note-list-item.scss

@@ -1,20 +0,0 @@
-@use "./base-text.scss";
-
-.shared-note-list-item {
-	flex: 1;
-	flex-direction: row;
-	display: flex;
-	align-items: center;
-	border: 1px solid;
-	border-color: var(--joplin-divider-color);
-	padding: 0.5em;
-	margin-bottom: 5px;
-
-	> .title {
-		@extend .base-text;
-
-		flex: 1;
-		display: flex;
-		color: var(--joplin-color);
-	}
-}

packages/app-desktop/gui/utils/NoteListUtils.ts

@@ -13,7 +13,6 @@ import Setting from '@joplin/lib/models/Setting';
 const { clipboard } = require('electron');
 import { Dispatch } from 'redux';
 import { NoteEntity } from '@joplin/lib/services/database/types';
-import { MarkupLanguage } from '@joplin/renderer';
 
 const Menu = bridge().Menu;
 const MenuItem = bridge().MenuItem;
@@ -144,16 +143,6 @@ export default class NoteListUtils {
 
 			menu.append(new MenuItem({ type: 'separator' }));
 
-			const includesHtmlNotes = notes.some(n => n.markup_language === MarkupLanguage.Html);
-			if (includesHtmlNotes) {
-				menu.append(
-					new MenuItem(
-						menuUtils.commandToStatefulMenuItem('convertNoteToMarkdown', noteIds),
-					),
-				);
-				menu.append(new MenuItem({ type: 'separator' }));
-			}
-
 			if ([9, 10, 11].includes(Setting.value('sync.target'))) {
 				menu.append(
 					new MenuItem(
@@ -215,6 +204,7 @@ export default class NoteListUtils {
 			);
 		}
 
+
 		const pluginViewInfos = pluginUtils.viewInfosByType(props.plugins, 'menuItem');
 
 		for (const info of pluginViewInfos) {

packages/app-desktop/index.html

@@ -8,7 +8,7 @@
 				default-src 'self' joplin-content://* ;
 				connect-src 'self' * http://* https://* joplin-content://* blob: ;
 				style-src 'unsafe-inline' 'self' blob: joplin-content://* https://* http://* ;
-				child-src 'self' joplin-content://* https://*.youtube.com https://*.youtube-nocookie.com ;
+				child-src 'self' joplin-content://* ;
 				script-src 'self' 'unsafe-inline' joplin-content://* ;
 				media-src 'self' * blob: data: https://* http://* joplin-content://* ;
 				img-src 'self' blob: data: http://* https://* joplin-content://* ;

packages/app-desktop/integration-tests/sidebar.spec.ts

@@ -64,10 +64,6 @@ test.describe('sidebar', () => {
 		await expect(mainWindow.locator(':focus')).toHaveText('Folder b');
 		await mainWindow.keyboard.type('A');
 		await expect(mainWindow.locator(':focus')).toHaveText('All notes');
-
-		// Should be case-insensitive
-		await mainWindow.keyboard.type('f');
-		await expect(mainWindow.locator(':focus')).toHaveText('Folder b');
 	});
 
 	test('left/right arrow keys should expand/collapse notebooks', async ({ electronApp, mainWindow }) => {

packages/app-desktop/jest.config.js

@@ -1,10 +1,7 @@
 // For a detailed explanation regarding each configuration property, visit:
 // https://jestjs.io/docs/en/configuration.html
 
-const baseConfig = require('../../jest.config.base.js');
-
 module.exports = {
-	...baseConfig,
 	// All imported modules in your tests should be mocked automatically
 	// automock: false,
 
@@ -131,9 +128,7 @@ module.exports = {
 	testEnvironment: 'jsdom',
 
 	// Options that will be passed to the testEnvironment
-	testEnvironmentOptions: {
-		customExportConditions: ['node', 'require'],
-	},
+	// testEnvironmentOptions: {},
 
 	// Adds a location field to test results
 	// testLocationInResults: false,

packages/app-desktop/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@joplin/app-desktop",
-  "version": "3.6.2",
+  "version": "3.5.9",
   "description": "Joplin for Desktop",
   "main": "main.bundle.js",
   "private": true,
@@ -92,12 +92,6 @@
             "x64"
           ]
         },
-        {
-          "target": "pkg",
-          "arch": [
-            "x64"
-          ]
-        },
         {
           "target": "zip",
           "arch": [
@@ -145,19 +139,19 @@
     "@electron/rebuild": "3.7.2",
     "@fortawesome/fontawesome-free": "5.15.4",
     "@joeattardi/emoji-button": "4.6.4",
-    "@joplin/default-plugins": "~3.6",
-    "@joplin/editor": "~3.6",
-    "@joplin/lib": "~3.6",
-    "@joplin/renderer": "~3.6",
-    "@joplin/tools": "~3.6",
-    "@joplin/utils": "~3.6",
-    "@playwright/test": "1.55.1",
+    "@joplin/default-plugins": "~3.5",
+    "@joplin/editor": "~3.5",
+    "@joplin/lib": "~3.5",
+    "@joplin/renderer": "~3.5",
+    "@joplin/tools": "~3.5",
+    "@joplin/utils": "~3.5",
+    "@playwright/test": "1.54.2",
     "@sentry/electron": "4.24.0",
     "@testing-library/react-hooks": "8.0.1",
     "@types/jest": "29.5.14",
     "@types/mustache": "4.2.6",
     "@types/node": "18.19.130",
-    "@types/react": "18.3.26",
+    "@types/react": "18.3.23",
     "@types/react-dom": "18.3.7",
     "@types/react-redux": "7.1.33",
     "@types/styled-components": "5.1.32",
@@ -169,7 +163,7 @@
     "debounce": "1.2.1",
     "electron": "39.2.3",
     "electron-builder": "24.13.3",
-    "electron-updater": "6.6.8",
+    "electron-updater": "6.6.2",
     "electron-window-state": "5.0.3",
     "esbuild": "^0.25.3",
     "formatcoords": "1.1.3",
@@ -214,8 +208,8 @@
   },
   "dependencies": {
     "@electron/remote": "2.1.3",
-    "@joplin/onenote-converter": "~3.6",
-    "fs-extra": "11.3.2",
+    "@joplin/onenote-converter": "~3.5",
+    "fs-extra": "11.2.0",
     "keytar": "7.9.0",
     "node-fetch": "2.6.7",
     "sqlite3": "5.1.6"

packages/app-desktop/services/autoUpdater/AutoUpdaterService.ts

@@ -140,10 +140,7 @@ export default class AutoUpdaterService implements AutoUpdaterServiceInterface {
 				// electron's autoUpdater appends automatically the platform's yml file to the link so we should remove it
 				assetUrl = assetUrl.substring(0, assetUrl.lastIndexOf('/'));
 				autoUpdater.setFeedURL({ provider: 'generic', url: assetUrl });
-				const result = await autoUpdater.checkForUpdates();
-
-				// Wait for the installation to finish. By default, .checkForUpdates runs in the background
-				await result.downloadPromise;
+				await autoUpdater.checkForUpdates();
 			} catch (error) {
 				this.logger_.error(`Update download url failed: ${error.message}`);
 				this.isUpdateInProgress = false;

packages/app-desktop/services/plugins/UserWebview.tsx

@@ -29,9 +29,12 @@ export interface Props {
 	borderBottom?: boolean;
 	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 	theme?: any;
-	onSubmit?: ()=> void;
-	onDismiss?: ()=> void;
-	onReady?: ()=> void;
+	// eslint-disable-next-line @typescript-eslint/ban-types -- Old code before rule was applied
+	onSubmit?: Function;
+	// eslint-disable-next-line @typescript-eslint/ban-types -- Old code before rule was applied
+	onDismiss?: Function;
+	// eslint-disable-next-line @typescript-eslint/ban-types -- Old code before rule was applied
+	onReady?: Function;
 }
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied

packages/app-desktop/services/plugins/hooks/useSubmitHandler.ts

@@ -1,14 +1,13 @@
 import { RefObject } from 'react';
 import useMessageHandler from './useMessageHandler';
 
-type OnEvent = ()=> void;
-
-export default function(viewRef: RefObject<HTMLIFrameElement>, onSubmit: OnEvent, onDismiss: OnEvent) {
+// eslint-disable-next-line @typescript-eslint/ban-types, @typescript-eslint/no-explicit-any -- Old code before rule was applied, Old code before rule was applied
+export default function(viewRef: RefObject<HTMLIFrameElement>, onSubmit: Function, onDismiss: Function) {
 	useMessageHandler(viewRef, event => {
 		const message = event.data?.message;
-		if (message === 'form-submit' && onSubmit) {
+		if (message === 'form-submit') {
 			onSubmit();
-		} else if (message === 'dismiss' && onDismiss) {
+		} else if (message === 'dismiss') {
 			onDismiss();
 		}
 	});

packages/app-desktop/style.scss

@@ -13,7 +13,6 @@
 @use 'gui/Sidebar/style.scss' as sidebar-styles;
 @use 'gui/NoteEditor/style.scss' as note-editor-styles;
 @use 'gui/KeymapConfig/style.scss' as keymap-styles;
-@use 'gui/ProfileEditor.scss' as profile-editor;
 @use 'services/plugins/styles/index.scss' as plugins-styles;
 @use 'gui/styles/index.scss' as gui-styles;
 @use 'main.scss' as main;

packages/app-desktop/tools/notarizeFile.js

@@ -1,90 +0,0 @@
-'use strict';
-Object.defineProperty(exports, '__esModule', { value: true });
-exports.default = notarizeFile;
-const fs_1 = require('fs');
-const notarize_1 = require('@electron/notarize');
-const execCommand = require('./execCommand');
-const child_process_1 = require('child_process');
-const util_1 = require('util');
-const execAsync = (0, util_1.promisify)(child_process_1.exec);
-// Same appId in electron-builder.
-const appId = 'net.cozic.joplin-desktop';
-function isDesktopAppTag(tagName) {
-	if (!tagName) { return false; }
-	return tagName[0] === 'v';
-}
-async function notarizeFile(filePath) {
-	if (process.platform !== 'darwin') { return; }
-	console.info(`Checking if notarization should be done on: ${filePath}`);
-	if (!process.env.IS_CONTINUOUS_INTEGRATION || !isDesktopAppTag(process.env.GIT_TAG_NAME)) {
-		console.info(`Either not running in CI or not processing a desktop app tag - skipping notarization. process.env.IS_CONTINUOUS_INTEGRATION = ${process.env.IS_CONTINUOUS_INTEGRATION}; process.env.GIT_TAG_NAME = ${process.env.GIT_TAG_NAME}`);
-		return;
-	}
-	if (!process.env.APPLE_ID || !process.env.APPLE_ID_PASSWORD) {
-		console.warn('Environment variables APPLE_ID and APPLE_ID_PASSWORD not found - notarization will NOT be done.');
-		return;
-	}
-	if (!(0, fs_1.existsSync)(filePath)) {
-		throw new Error(`Cannot find file at: ${filePath}`);
-	}
-	// Every x seconds we print something to stdout, otherwise CI may timeout
-	// the task after 10 minutes, and Apple notarization can take more time.
-	const waitingIntervalId = setInterval(() => {
-		console.info('.');
-	}, 60000);
-	const isPkg = filePath.endsWith('.pkg');
-	console.info(`Notarizing ${filePath}`);
-	try {
-		if (isPkg) {
-			await execAsync(`xcrun notarytool submit "${filePath}" ` +
-                `--apple-id "${process.env.APPLE_ID}" ` +
-                `--password "${process.env.APPLE_ID_PASSWORD}" ` +
-                `--team-id "${process.env.APPLE_ASC_PROVIDER}" ` +
-                '--wait', { maxBuffer: 1024 * 1024 });
-		} else {
-			await (0, notarize_1.notarize)({
-				appBundleId: appId,
-				appPath: filePath,
-				// Apple Developer email address
-				appleId: process.env.APPLE_ID,
-				// App-specific password: https://support.apple.com/en-us/HT204397
-				appleIdPassword: process.env.APPLE_ID_PASSWORD,
-				// When Apple ID is attached to multiple providers (eg if the
-				// account has been used to build multiple apps for different
-				// companies), in that case the provider "Team Short Name" (also
-				// known as "ProviderShortname") must be provided.
-				//
-				// Use this to get it:
-				//
-				// xcrun altool --list-providers -u APPLE_ID -p APPLE_ID_PASSWORD
-				// ascProvider: process.env.APPLE_ASC_PROVIDER,
-				// In our case, the team ID is the same as the legacy ASC_PROVIDER
-				teamId: process.env.APPLE_ASC_PROVIDER,
-				tool: 'notarytool',
-				// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
-			});
-		}
-	} catch (error) {
-		console.error(error);
-		process.exit(1);
-	}
-	clearInterval(waitingIntervalId);
-	// It appears that electron-notarize doesn't staple the app, but without
-	// this we were still getting the malware warning when launching the app.
-	// Stapling the app means attaching the notarization ticket to it, so that
-	// if the user is offline, macOS can still check if the app was notarized.
-	// So it seems to be more or less optional, but at least in our case it
-	// wasn't.
-	console.info('Stapling notarization ticket to the file...');
-	const staplerCmd = `xcrun stapler staple "${filePath}"`;
-	console.info(`> ${staplerCmd}`);
-	console.info(await execCommand(staplerCmd));
-	console.info(`Validating stapled file: ${filePath}`);
-	try {
-		await execAsync(`spctl -a -vv -t install "${filePath}"`);
-	} catch (error) {
-		console.error(`Failed validating stapled file: ${filePath}:`, error);
-	}
-	console.info(`Done notarizing ${filePath}`);
-}
-// # sourceMappingURL=notarizeFile.js.map

packages/app-desktop/utils/customProtocols/handleCustomProtocols.ts

@@ -130,12 +130,6 @@ const makeAccessDeniedResponse = (message: string) => {
 	});
 };
 
-const makeNotFoundResponse = () => {
-	return new Response('not found', {
-		status: 404,
-	});
-};
-
 // Creating a custom protocol allows us to isolate iframes by giving them
 // different domain names from the main Joplin app.
 //
@@ -216,24 +210,10 @@ const handleCustomProtocols = (): CustomProtocolHandler => {
 
 		const rangeHeader = request.headers.get('Range');
 		let response;
-		try {
-			if (!rangeHeader) {
-				response = await net.fetch(asFileUrl);
-			} else {
-				response = await handleRangeRequest(request, pathname);
-			}
-		} catch (error) {
-			if (
-				// Errors from NodeJS fs methods (e.g. fs.stat()
-				error.code === 'ENOENT'
-				// Errors from Electron's net.fetch(). Use error.message since these errors don't
-				// seem to have a specific .code or .name.
-				|| error.message === 'net::ERR_FILE_NOT_FOUND'
-			) {
-				response = makeNotFoundResponse();
-			} else {
-				throw error;
-			}
+		if (!rangeHeader) {
+			response = await net.fetch(asFileUrl);
+		} else {
+			response = await handleRangeRequest(request, pathname);
 		}
 
 		if (mediaOnly) {

packages/app-mobile/android/app/build.gradle

@@ -89,8 +89,8 @@ android {
         applicationId "net.cozic.joplin"
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
-		versionCode 2097788
-		versionName "3.6.0"
+		versionCode 2097781
+		versionName "3.5.1"
         ndk {
             abiFilters "armeabi-v7a", "x86", "arm64-v8a", "x86_64"
         }
@@ -132,17 +132,6 @@ android {
             minifyEnabled enableProguardInReleaseBuilds
             proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
         }
-        profileable {
-            // Release-like build that allows profiling with Android Studio Profiler
-            initWith release
-            signingConfig signingConfigs.debug
-            // Required for Android Studio Profiler to attach
-            debuggable false
-            // Keeps symbols for better stack traces in profiler
-            minifyEnabled false
-            // Use release variants of dependencies that don't have profileable
-            matchingFallbacks = ['release']
-        }
     }
 }
 
@@ -156,3 +145,5 @@ dependencies {
         implementation jscFlavor
     }
 }
+
+apply from: "../../node_modules/react-native-vector-icons/fonts.gradle"