iOS 13.6.2

.coderabbit.yaml

@@ -107,4 +107,3 @@ knowledge_base:
     filePatterns:
       - "readme/dev/coding_style.md"
       - "readme/dev/index.md"
-      - "CLAUDE.md"

.eslintignore

@@ -103,7 +103,6 @@ packages/app-cli/app/command-apidoc.js
 packages/app-cli/app/command-attach.js
 packages/app-cli/app/command-batch.js
 packages/app-cli/app/command-cat.js
-packages/app-cli/app/command-clear.js
 packages/app-cli/app/command-config.js
 packages/app-cli/app/command-cp.js
 packages/app-cli/app/command-done.test.js
@@ -219,8 +218,6 @@ packages/app-desktop/gui/EditFolderDialog/Dialog.js
 packages/app-desktop/gui/EditFolderDialog/IconSelector.js
 packages/app-desktop/gui/EmojiBox.js
 packages/app-desktop/gui/EncryptionConfigScreen/EncryptionConfigScreen.js
-packages/app-desktop/gui/EncryptionConfigScreen/enableFlow.test.js
-packages/app-desktop/gui/EncryptionConfigScreen/enableFlow.js
 packages/app-desktop/gui/ErrorBoundary.js
 packages/app-desktop/gui/ExtensionBadge.js
 packages/app-desktop/gui/FolderIconBox.js
@@ -274,7 +271,6 @@ packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/Editor.js
 packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/useEditorCommands.js
 packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/utils/localisation.js
 packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/utils/useContentScriptRegistration.js
-packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/utils/useEditorSettings.js
 packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/utils/useKeymap.js
 packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/utils/useRefocusOnVisiblePaneChange.js
 packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/utils/useSyncEditorValue.js
@@ -307,7 +303,6 @@ packages/app-desktop/gui/NoteEditor/commands/focusElementNoteTitle.js
 packages/app-desktop/gui/NoteEditor/commands/focusElementNoteViewer.js
 packages/app-desktop/gui/NoteEditor/commands/focusElementToolbar.js
 packages/app-desktop/gui/NoteEditor/commands/index.js
-packages/app-desktop/gui/NoteEditor/commands/pasteAsMarkdown.js
 packages/app-desktop/gui/NoteEditor/commands/pasteAsText.js
 packages/app-desktop/gui/NoteEditor/commands/showLocalSearch.js
 packages/app-desktop/gui/NoteEditor/commands/showRevisions.js
@@ -345,11 +340,9 @@ packages/app-desktop/gui/NoteEditor/utils/useWindowCommandHandler.js
 packages/app-desktop/gui/NoteList/NoteList2.js
 packages/app-desktop/gui/NoteList/commands/focusElementNoteList.js
 packages/app-desktop/gui/NoteList/commands/index.js
-packages/app-desktop/gui/NoteList/utils/UseAutoScroll.test.js
 packages/app-desktop/gui/NoteList/utils/canManuallySortNotes.js
 packages/app-desktop/gui/NoteList/utils/types.js
 packages/app-desktop/gui/NoteList/utils/useActiveDescendantId.js
-packages/app-desktop/gui/NoteList/utils/useAutoScroll.js
 packages/app-desktop/gui/NoteList/utils/useDragAndDrop.js
 packages/app-desktop/gui/NoteList/utils/useFocusNote.js
 packages/app-desktop/gui/NoteList/utils/useFocusVisible.js
@@ -358,8 +351,6 @@ packages/app-desktop/gui/NoteList/utils/useMoveNote.js
 packages/app-desktop/gui/NoteList/utils/useOnKeyDown.js
 packages/app-desktop/gui/NoteList/utils/useOnNoteClick.js
 packages/app-desktop/gui/NoteList/utils/useOnNoteDoubleClick.js
-packages/app-desktop/gui/NoteList/utils/useRefocusOnDeletion.test.js
-packages/app-desktop/gui/NoteList/utils/useRefocusOnDeletion.js
 packages/app-desktop/gui/NoteList/utils/useScroll.js
 packages/app-desktop/gui/NoteList/utils/useVisibleRange.test.js
 packages/app-desktop/gui/NoteList/utils/useVisibleRange.js
@@ -381,8 +372,8 @@ packages/app-desktop/gui/NoteListItem/utils/getNoteTitleHtml.js
 packages/app-desktop/gui/NoteListItem/utils/prepareViewProps.test.js
 packages/app-desktop/gui/NoteListItem/utils/prepareViewProps.js
 packages/app-desktop/gui/NoteListItem/utils/types.js
-packages/app-desktop/gui/NoteListItem/utils/useItemElement.test.js
 packages/app-desktop/gui/NoteListItem/utils/useItemElement.js
+packages/app-desktop/gui/NoteListItem/utils/useItemEventHandlers.js
 packages/app-desktop/gui/NoteListItem/utils/useOnContextMenu.js
 packages/app-desktop/gui/NoteListItem/utils/useRenderedNote.js
 packages/app-desktop/gui/NoteListItem/utils/useRootElement.test.js
@@ -568,7 +559,6 @@ packages/app-desktop/integration-tests/models/NoteEditorScreen.js
 packages/app-desktop/integration-tests/models/NoteList.js
 packages/app-desktop/integration-tests/models/SettingsScreen.js
 packages/app-desktop/integration-tests/models/Sidebar.js
-packages/app-desktop/integration-tests/multiWindow.spec.js
 packages/app-desktop/integration-tests/noteList.spec.js
 packages/app-desktop/integration-tests/pluginApi.spec.js
 packages/app-desktop/integration-tests/resizableLayout.spec.js
@@ -590,7 +580,6 @@ packages/app-desktop/integration-tests/util/setMessageBoxResponse.js
 packages/app-desktop/integration-tests/util/setSettingValue.js
 packages/app-desktop/integration-tests/util/test.js
 packages/app-desktop/integration-tests/util/waitForNextOpenPath.js
-packages/app-desktop/integration-tests/util/waitForNextWindowMatching.js
 packages/app-desktop/integration-tests/wcag.spec.js
 packages/app-desktop/main-html.js
 packages/app-desktop/main.js
@@ -619,6 +608,10 @@ packages/app-desktop/services/plugins/hooks/useViewIsReady.js
 packages/app-desktop/services/plugins/hooks/useWebviewToPluginMessages.js
 packages/app-desktop/services/plugins/types.js
 packages/app-desktop/services/restart.js
+packages/app-desktop/services/sortOrder/PerFolderSortOrderService.test.js
+packages/app-desktop/services/sortOrder/PerFolderSortOrderService.js
+packages/app-desktop/services/sortOrder/notesSortOrderUtils.test.js
+packages/app-desktop/services/sortOrder/notesSortOrderUtils.js
 packages/app-desktop/services/spellChecker/SpellCheckerServiceDriverNative.js
 packages/app-desktop/tools/bundleJs.js
 packages/app-desktop/tools/copy7Zip.js
@@ -654,7 +647,6 @@ packages/app-mobile/commands/newNote.js
 packages/app-mobile/commands/openItem.js
 packages/app-mobile/commands/openNote.js
 packages/app-mobile/commands/scrollToHash.js
-packages/app-mobile/commands/util/goToFolder.js
 packages/app-mobile/commands/util/goToNote.js
 packages/app-mobile/commands/util/showResource.js
 packages/app-mobile/components/BetaChip.js
@@ -872,7 +864,6 @@ packages/app-mobile/components/screens/Notes/NewNoteButton.test.js
 packages/app-mobile/components/screens/Notes/NewNoteButton.js
 packages/app-mobile/components/screens/Notes/Notes.js
 packages/app-mobile/components/screens/Notes/TextWrapCalculator.js
-packages/app-mobile/components/screens/ResourceScreen.js
 packages/app-mobile/components/screens/SearchScreen/SearchBar.js
 packages/app-mobile/components/screens/SearchScreen/SearchResults.test.js
 packages/app-mobile/components/screens/SearchScreen/SearchResults.js
@@ -889,8 +880,6 @@ packages/app-mobile/components/screens/dropbox-login.js
 packages/app-mobile/components/screens/encryption-config.test.js
 packages/app-mobile/components/screens/encryption-config.js
 packages/app-mobile/components/screens/folder.js
-packages/app-mobile/components/screens/resourceScreenUtils.test.js
-packages/app-mobile/components/screens/resourceScreenUtils.js
 packages/app-mobile/components/screens/status.js
 packages/app-mobile/components/screens/tags.js
 packages/app-mobile/components/side-menu-content.js
@@ -913,7 +902,6 @@ packages/app-mobile/contentScripts/markdownEditorBundle/useWebViewSetup.js
 packages/app-mobile/contentScripts/markdownEditorBundle/utils/useCodeMirrorPlugins.js
 packages/app-mobile/contentScripts/rendererBundle/contentScript/Renderer.test.js
 packages/app-mobile/contentScripts/rendererBundle/contentScript/Renderer.js
-packages/app-mobile/contentScripts/rendererBundle/contentScript/index.handleAnchorClick.test.js
 packages/app-mobile/contentScripts/rendererBundle/contentScript/index.js
 packages/app-mobile/contentScripts/rendererBundle/contentScript/types.js
 packages/app-mobile/contentScripts/rendererBundle/contentScript/utils/addPluginAssets.js
@@ -1532,7 +1520,6 @@ packages/lib/services/interop/InteropService_Importer_Md.test.js
 packages/lib/services/interop/InteropService_Importer_Md.js
 packages/lib/services/interop/InteropService_Importer_Md_frontmatter.test.js
 packages/lib/services/interop/InteropService_Importer_Md_frontmatter.js
-packages/lib/services/interop/InteropService_Importer_OneNote.postprocessHtml.test.js
 packages/lib/services/interop/InteropService_Importer_OneNote.test.js
 packages/lib/services/interop/InteropService_Importer_OneNote.js
 packages/lib/services/interop/InteropService_Importer_Raw.test.js
@@ -1588,7 +1575,6 @@ packages/lib/services/plugins/api/JoplinCommands.js
 packages/lib/services/plugins/api/JoplinContentScripts.js
 packages/lib/services/plugins/api/JoplinData.js
 packages/lib/services/plugins/api/JoplinFilters.js
-packages/lib/services/plugins/api/JoplinFs.js
 packages/lib/services/plugins/api/JoplinImaging.js
 packages/lib/services/plugins/api/JoplinInterop.js
 packages/lib/services/plugins/api/JoplinPlugins.js
@@ -1687,10 +1673,6 @@ packages/lib/services/share/ShareService.test.js
 packages/lib/services/share/ShareService.js
 packages/lib/services/share/invitationRespond.js
 packages/lib/services/share/reducer.js
-packages/lib/services/sortOrder/PerFolderSortOrderService.test.js
-packages/lib/services/sortOrder/PerFolderSortOrderService.js
-packages/lib/services/sortOrder/notesSortOrderUtils.test.js
-packages/lib/services/sortOrder/notesSortOrderUtils.js
 packages/lib/services/spellChecker/SpellCheckerService.js
 packages/lib/services/spellChecker/SpellCheckerServiceDriverBase.js
 packages/lib/services/style/cssToTheme.test.js

.github/workflows/build-macos-m1.yml

@@ -1,6 +1,5 @@
 name: Build macOS M1
 on: [push, pull_request]
-
 jobs:
   Main:
     # We always process desktop release tags, because they also publish the release

.github/workflows/check-pr-title.yml

@@ -4,6 +4,6 @@ jobs:
   main:
     runs-on: ubuntu-latest
     steps:
-      - uses: Slashgear/action-check-pr-title@v5.0.1
+      - uses: Slashgear/action-check-pr-title@v4.3.0
         with:
           regexp: "(Desktop|Mobile|All|Cli|Tools|Chore|Clipper|Server|Android|iOS|Plugins|CI|Plugin Repo|Doc): (Fixes|Resolves) #[0-9]+: .+"

.github/workflows/github-actions-main.yml

@@ -1,6 +1,5 @@
 name: Joplin Continuous Integration
 on: [push, pull_request]
-
 jobs:
   Main:
     # We always process server or desktop release tags, because they also publish the release

.github/workflows/ui-tests.yml

@@ -1,6 +1,5 @@
 name: Joplin UI tests
 on: [push, pull_request]
-
 permissions:
   contents: read
 jobs:

.gitignore

@@ -76,7 +76,6 @@ packages/app-cli/app/command-apidoc.js
 packages/app-cli/app/command-attach.js
 packages/app-cli/app/command-batch.js
 packages/app-cli/app/command-cat.js
-packages/app-cli/app/command-clear.js
 packages/app-cli/app/command-config.js
 packages/app-cli/app/command-cp.js
 packages/app-cli/app/command-done.test.js
@@ -192,8 +191,6 @@ packages/app-desktop/gui/EditFolderDialog/Dialog.js
 packages/app-desktop/gui/EditFolderDialog/IconSelector.js
 packages/app-desktop/gui/EmojiBox.js
 packages/app-desktop/gui/EncryptionConfigScreen/EncryptionConfigScreen.js
-packages/app-desktop/gui/EncryptionConfigScreen/enableFlow.test.js
-packages/app-desktop/gui/EncryptionConfigScreen/enableFlow.js
 packages/app-desktop/gui/ErrorBoundary.js
 packages/app-desktop/gui/ExtensionBadge.js
 packages/app-desktop/gui/FolderIconBox.js
@@ -247,7 +244,6 @@ packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/Editor.js
 packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/useEditorCommands.js
 packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/utils/localisation.js
 packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/utils/useContentScriptRegistration.js
-packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/utils/useEditorSettings.js
 packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/utils/useKeymap.js
 packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/utils/useRefocusOnVisiblePaneChange.js
 packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/utils/useSyncEditorValue.js
@@ -280,7 +276,6 @@ packages/app-desktop/gui/NoteEditor/commands/focusElementNoteTitle.js
 packages/app-desktop/gui/NoteEditor/commands/focusElementNoteViewer.js
 packages/app-desktop/gui/NoteEditor/commands/focusElementToolbar.js
 packages/app-desktop/gui/NoteEditor/commands/index.js
-packages/app-desktop/gui/NoteEditor/commands/pasteAsMarkdown.js
 packages/app-desktop/gui/NoteEditor/commands/pasteAsText.js
 packages/app-desktop/gui/NoteEditor/commands/showLocalSearch.js
 packages/app-desktop/gui/NoteEditor/commands/showRevisions.js
@@ -318,11 +313,9 @@ packages/app-desktop/gui/NoteEditor/utils/useWindowCommandHandler.js
 packages/app-desktop/gui/NoteList/NoteList2.js
 packages/app-desktop/gui/NoteList/commands/focusElementNoteList.js
 packages/app-desktop/gui/NoteList/commands/index.js
-packages/app-desktop/gui/NoteList/utils/UseAutoScroll.test.js
 packages/app-desktop/gui/NoteList/utils/canManuallySortNotes.js
 packages/app-desktop/gui/NoteList/utils/types.js
 packages/app-desktop/gui/NoteList/utils/useActiveDescendantId.js
-packages/app-desktop/gui/NoteList/utils/useAutoScroll.js
 packages/app-desktop/gui/NoteList/utils/useDragAndDrop.js
 packages/app-desktop/gui/NoteList/utils/useFocusNote.js
 packages/app-desktop/gui/NoteList/utils/useFocusVisible.js
@@ -331,8 +324,6 @@ packages/app-desktop/gui/NoteList/utils/useMoveNote.js
 packages/app-desktop/gui/NoteList/utils/useOnKeyDown.js
 packages/app-desktop/gui/NoteList/utils/useOnNoteClick.js
 packages/app-desktop/gui/NoteList/utils/useOnNoteDoubleClick.js
-packages/app-desktop/gui/NoteList/utils/useRefocusOnDeletion.test.js
-packages/app-desktop/gui/NoteList/utils/useRefocusOnDeletion.js
 packages/app-desktop/gui/NoteList/utils/useScroll.js
 packages/app-desktop/gui/NoteList/utils/useVisibleRange.test.js
 packages/app-desktop/gui/NoteList/utils/useVisibleRange.js
@@ -354,8 +345,8 @@ packages/app-desktop/gui/NoteListItem/utils/getNoteTitleHtml.js
 packages/app-desktop/gui/NoteListItem/utils/prepareViewProps.test.js
 packages/app-desktop/gui/NoteListItem/utils/prepareViewProps.js
 packages/app-desktop/gui/NoteListItem/utils/types.js
-packages/app-desktop/gui/NoteListItem/utils/useItemElement.test.js
 packages/app-desktop/gui/NoteListItem/utils/useItemElement.js
+packages/app-desktop/gui/NoteListItem/utils/useItemEventHandlers.js
 packages/app-desktop/gui/NoteListItem/utils/useOnContextMenu.js
 packages/app-desktop/gui/NoteListItem/utils/useRenderedNote.js
 packages/app-desktop/gui/NoteListItem/utils/useRootElement.test.js
@@ -541,7 +532,6 @@ packages/app-desktop/integration-tests/models/NoteEditorScreen.js
 packages/app-desktop/integration-tests/models/NoteList.js
 packages/app-desktop/integration-tests/models/SettingsScreen.js
 packages/app-desktop/integration-tests/models/Sidebar.js
-packages/app-desktop/integration-tests/multiWindow.spec.js
 packages/app-desktop/integration-tests/noteList.spec.js
 packages/app-desktop/integration-tests/pluginApi.spec.js
 packages/app-desktop/integration-tests/resizableLayout.spec.js
@@ -563,7 +553,6 @@ packages/app-desktop/integration-tests/util/setMessageBoxResponse.js
 packages/app-desktop/integration-tests/util/setSettingValue.js
 packages/app-desktop/integration-tests/util/test.js
 packages/app-desktop/integration-tests/util/waitForNextOpenPath.js
-packages/app-desktop/integration-tests/util/waitForNextWindowMatching.js
 packages/app-desktop/integration-tests/wcag.spec.js
 packages/app-desktop/main-html.js
 packages/app-desktop/main.js
@@ -592,6 +581,10 @@ packages/app-desktop/services/plugins/hooks/useViewIsReady.js
 packages/app-desktop/services/plugins/hooks/useWebviewToPluginMessages.js
 packages/app-desktop/services/plugins/types.js
 packages/app-desktop/services/restart.js
+packages/app-desktop/services/sortOrder/PerFolderSortOrderService.test.js
+packages/app-desktop/services/sortOrder/PerFolderSortOrderService.js
+packages/app-desktop/services/sortOrder/notesSortOrderUtils.test.js
+packages/app-desktop/services/sortOrder/notesSortOrderUtils.js
 packages/app-desktop/services/spellChecker/SpellCheckerServiceDriverNative.js
 packages/app-desktop/tools/bundleJs.js
 packages/app-desktop/tools/copy7Zip.js
@@ -627,7 +620,6 @@ packages/app-mobile/commands/newNote.js
 packages/app-mobile/commands/openItem.js
 packages/app-mobile/commands/openNote.js
 packages/app-mobile/commands/scrollToHash.js
-packages/app-mobile/commands/util/goToFolder.js
 packages/app-mobile/commands/util/goToNote.js
 packages/app-mobile/commands/util/showResource.js
 packages/app-mobile/components/BetaChip.js
@@ -845,7 +837,6 @@ packages/app-mobile/components/screens/Notes/NewNoteButton.test.js
 packages/app-mobile/components/screens/Notes/NewNoteButton.js
 packages/app-mobile/components/screens/Notes/Notes.js
 packages/app-mobile/components/screens/Notes/TextWrapCalculator.js
-packages/app-mobile/components/screens/ResourceScreen.js
 packages/app-mobile/components/screens/SearchScreen/SearchBar.js
 packages/app-mobile/components/screens/SearchScreen/SearchResults.test.js
 packages/app-mobile/components/screens/SearchScreen/SearchResults.js
@@ -862,8 +853,6 @@ packages/app-mobile/components/screens/dropbox-login.js
 packages/app-mobile/components/screens/encryption-config.test.js
 packages/app-mobile/components/screens/encryption-config.js
 packages/app-mobile/components/screens/folder.js
-packages/app-mobile/components/screens/resourceScreenUtils.test.js
-packages/app-mobile/components/screens/resourceScreenUtils.js
 packages/app-mobile/components/screens/status.js
 packages/app-mobile/components/screens/tags.js
 packages/app-mobile/components/side-menu-content.js
@@ -886,7 +875,6 @@ packages/app-mobile/contentScripts/markdownEditorBundle/useWebViewSetup.js
 packages/app-mobile/contentScripts/markdownEditorBundle/utils/useCodeMirrorPlugins.js
 packages/app-mobile/contentScripts/rendererBundle/contentScript/Renderer.test.js
 packages/app-mobile/contentScripts/rendererBundle/contentScript/Renderer.js
-packages/app-mobile/contentScripts/rendererBundle/contentScript/index.handleAnchorClick.test.js
 packages/app-mobile/contentScripts/rendererBundle/contentScript/index.js
 packages/app-mobile/contentScripts/rendererBundle/contentScript/types.js
 packages/app-mobile/contentScripts/rendererBundle/contentScript/utils/addPluginAssets.js
@@ -1505,7 +1493,6 @@ packages/lib/services/interop/InteropService_Importer_Md.test.js
 packages/lib/services/interop/InteropService_Importer_Md.js
 packages/lib/services/interop/InteropService_Importer_Md_frontmatter.test.js
 packages/lib/services/interop/InteropService_Importer_Md_frontmatter.js
-packages/lib/services/interop/InteropService_Importer_OneNote.postprocessHtml.test.js
 packages/lib/services/interop/InteropService_Importer_OneNote.test.js
 packages/lib/services/interop/InteropService_Importer_OneNote.js
 packages/lib/services/interop/InteropService_Importer_Raw.test.js
@@ -1561,7 +1548,6 @@ packages/lib/services/plugins/api/JoplinCommands.js
 packages/lib/services/plugins/api/JoplinContentScripts.js
 packages/lib/services/plugins/api/JoplinData.js
 packages/lib/services/plugins/api/JoplinFilters.js
-packages/lib/services/plugins/api/JoplinFs.js
 packages/lib/services/plugins/api/JoplinImaging.js
 packages/lib/services/plugins/api/JoplinInterop.js
 packages/lib/services/plugins/api/JoplinPlugins.js
@@ -1660,10 +1646,6 @@ packages/lib/services/share/ShareService.test.js
 packages/lib/services/share/ShareService.js
 packages/lib/services/share/invitationRespond.js
 packages/lib/services/share/reducer.js
-packages/lib/services/sortOrder/PerFolderSortOrderService.test.js
-packages/lib/services/sortOrder/PerFolderSortOrderService.js
-packages/lib/services/sortOrder/notesSortOrderUtils.test.js
-packages/lib/services/sortOrder/notesSortOrderUtils.js
 packages/lib/services/spellChecker/SpellCheckerService.js
 packages/lib/services/spellChecker/SpellCheckerServiceDriverBase.js
 packages/lib/services/style/cssToTheme.test.js
@@ -1966,3 +1948,4 @@ packages/tools/website/utils/types.js
 packages/whisper-voice-typing/src/index.js
 packages/whisper-voice-typing/src/specs/Whisper.nitro.js
 # AUTO-GENERATED - EXCLUDED TYPESCRIPT BUILD
+

Assets/WebsiteAssets/css/site.css

@@ -1351,7 +1351,11 @@ footer .bottom-links-row p {
  ENGLISH VERSION
 *****************************************************************/
 
-:not(:lang(zh-cn)) .top-section-img-cn {
+:lang(en-gb) #made-in-france-section {
+	display: none;
+}
+
+:lang(en-gb) .top-section-img-cn {
 	display: none;
 }
 

Assets/WebsiteAssets/js/script.js

@@ -145,7 +145,7 @@ function setupLocaleRedirect() {
 	if (!isRootPage) return;
 
 	// Check if user has explicitly chosen to stay on current locale
-	const localePreference = (localStorage.getItem('joplin-locale-preference') || '').toLowerCase();
+	const localePreference = localStorage.getItem('joplin-locale-preference');
 	if (localePreference === 'en') return;
 
 	// Get user's preferred language from browser
@@ -160,10 +160,9 @@ function setupLocaleRedirect() {
 	window.location.href = getLocalePath(langCode) + '/';
 }
 
-// Allow users to switch language and remember their preference
-function setLocalePreference(locale, url) {
+// Allow users to switch back to English and remember their preference
+function setLocalePreference(locale) {
 	localStorage.setItem('joplin-locale-preference', locale);
-	window.location.href = url;
 }
 
 // Expose globally for language switcher links

Assets/WebsiteAssets/templates/partials/navbar.mustache

@@ -13,7 +13,6 @@
 			</div>
 			<div class="col-9 text-right d-none d-md-block">
 				{{> twitterLink}}
-				<a href="{{baseUrl}}/plugins/" class="fw500">Plugins</a>
 				<a href="{{baseUrl}}/news/" class="fw500">News</a>
 				<a href="{{baseUrl}}/help/" class="fw500">Help</a>
 				<a href="{{forumUrl}}" class="fw500">Forum</a>
@@ -24,7 +23,7 @@
 					</button>
 					<ul class="dropdown-menu dropdown-menu-end">
 						{{#availableLocales}}
-							<li><a class="dropdown-item {{#isActive}}active{{/isActive}}" href="{{baseUrl}}/{{pathPrefix}}" onclick="setLocalePreference('{{code}}', this.href); return false;">{{name}}</a></li>
+							<li><a class="dropdown-item {{#isActive}}active{{/isActive}}" href="{{baseUrl}}/{{pathPrefix}}" onclick="setLocalePreference('{{code}}')">{{name}}</a></li>
 						{{/availableLocales}}
 					</ul>
 				</div>
@@ -59,7 +58,6 @@
 						</div>
 
 						<div class="text-center menu-mobile-top">
-							<a href="{{baseUrl}}/plugins/" class="fw500 mobile-menu-link">Plugins</a>
 							<a href="{{baseUrl}}/news/" class="fw500 mobile-menu-link">News</a>
 							<a href="{{baseUrl}}/help/" class="fw500 mobile-menu-link">Help</a>
 							<a href="{{forumUrl}}" class="fw500 mobile-menu-link">Forum</a>
@@ -75,7 +73,7 @@
 						<div class="text-center menu-mobile-language">
 							<p class="fw500 mobile-menu-language-label"><i class="fas fa-globe"></i> Language</p>
 							{{#availableLocales}}
-								<a href="{{baseUrl}}/{{pathPrefix}}" class="fw500 mobile-menu-link mobile-language-link {{#isActive}}active{{/isActive}}" onclick="setLocalePreference('{{code}}', this.href); return false;">{{name}}</a>
+								<a href="{{baseUrl}}/{{pathPrefix}}" class="fw500 mobile-menu-link mobile-language-link {{#isActive}}active{{/isActive}}" onclick="setLocalePreference('{{code}}')">{{name}}</a>
 							{{/availableLocales}}
 						</div>
 					</div>

Assets/WebsiteAssets/templates/partials/socialFeeds.mustache

@@ -3,9 +3,9 @@
 		<a class="social-link-bluesky" href="https://bsky.app/profile/joplinapp.bsky.social" title="Joplin Bluesky feed"><i class="fa-brands fa-bluesky"></i></a>
 		<a class="social-link-mastodon" href="https://mastodon.social/@joplinapp" title="Joplin Mastodon feed"><i class="fab fa-mastodon"></i></a>
 		<a class="social-link-patreon" href="https://www.patreon.com/joplin" title="Joplin Patreon"><i class="fab fa-patreon"></i></a>
-		<a class="social-link-youtube" href="https://youtube.com/@joplinapp" title="Joplin YouTube channel"><i class="fab fa-youtube"></i></a>
 		<a class="social-link-discord" href="https://discord.gg/VSj7AFHvpq" title="Joplin Discord chat"><i class="fab fa-discord"></i></a>
 		<a class="social-link-linkedin" href="https://www.linkedin.com/company/joplin" title="Joplin LinkedIn Feed"><i class="fab fa-linkedin"></i></a>
+		<a class="social-link-lemmy" href="https://sopuli.xyz/c/joplinapp" title="Joplin Lemmy Community"><i class="fas fa-otter"></i></a>
 		<a class="social-link-github" href="https://github.com/laurent22/joplin/" title="Joplin GitHub repository"><i class="fab fa-github"></i></a>
 	</div>
 </div>

CLAUDE.md

@@ -8,9 +8,6 @@
 - Comments should be only with `//` and should not contain jsdoc syntax
 - If you duplicate a substantial block of code, add a comment above it noting the duplication and referencing the original location.
 - When creating Jest tests, there should be only one `describe()` statement in the file.
-- Focus on testing essential behaviour and edge cases — avoid adding tests for every minor detail.
-- Avoid duplicating code in tests; when testing the same logic with different inputs, use `test.each` or shared helpers instead of repeating similar test blocks.
-- Do not make white space changes - do not add unnecessary new lines, or spaces to existing code, or wrap existing code.
 
 ## Full Documentation
 

devbox.json

@@ -9,15 +9,15 @@
     "vips.dev": {
       "platforms": ["aarch64-darwin"],
     },
-    "nodejs":     "24.11.1",
+    "nodejs":     "24.10.0",
     "pkg-config": "latest",
-    "python": "3.14.0",
+    "python": "3.13.3",
     "bat":    "latest",
     "electron": {
       "version":            "latest",
       "excluded_platforms": ["aarch64-darwin", "x86_64-darwin"],
     },
-    "git":    "2.51.0",
+    "git":    "2.50.1",
   },
   "shell": {
     "init_hook": [

package.json

@@ -82,8 +82,8 @@
     "eslint-plugin-promise": "6.6.0",
     "eslint-plugin-react": "7.37.5",
     "execa": "5.1.1",
-    "fs-extra": "11.3.3",
-    "glob": "11.1.0",
+    "fs-extra": "11.3.2",
+    "glob": "11.0.3",
     "gulp": "4.0.2",
     "husky": "9.1.7",
     "lerna": "3.22.1",

packages/app-cli/app/app.ts

@@ -1,7 +1,7 @@
 import BaseApplication from '@joplin/lib/BaseApplication';
 import { refreshFolders } from '@joplin/lib/folders-screen-utils.js';
 import ResourceService from '@joplin/lib/services/ResourceService';
-import { ModelType } from '@joplin/lib/BaseModel';
+import BaseModel, { ModelType } from '@joplin/lib/BaseModel';
 import Folder from '@joplin/lib/models/Folder';
 import BaseItem from '@joplin/lib/models/BaseItem';
 import Note from '@joplin/lib/models/Note';
@@ -15,22 +15,20 @@ import RevisionService from '@joplin/lib/services/RevisionService';
 import shim from '@joplin/lib/shim';
 import setupCommand from './setupCommand';
 import { FolderEntity, NoteEntity } from '@joplin/lib/services/database/types';
-
-type FolderOrNoteType = ModelType.Note | ModelType.Folder | 'folderOrNote';
 import initializeCommandService from './utils/initializeCommandService';
 const { cliUtils } = require('./cli-utils.js');
 const Cache = require('@joplin/lib/Cache');
 
 class Application extends BaseApplication {
 
-	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Dynamic command loading system
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 	private commands_: Record<string, any> = {};
-	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Dynamic command metadata
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 	private commandMetadata_: any = null;
-	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Dynamic command type
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 	private activeCommand_: any = null;
 	private allCommandsLoaded_ = false;
-	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Dynamic GUI type with many optional methods
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 	private gui_: any = null;
 	private cache_ = new Cache();
 
@@ -42,16 +40,18 @@ class Application extends BaseApplication {
 		return this.gui().stdoutMaxWidth();
 	}
 
-	public async guessTypeAndLoadItem(pattern: string, options: { parent?: FolderEntity } | null = null) {
-		let type: FolderOrNoteType = ModelType.Note;
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	public async guessTypeAndLoadItem(pattern: string, options: any = null) {
+		let type = BaseModel.TYPE_NOTE;
 		if (pattern.indexOf('/') === 0) {
-			type = ModelType.Folder;
+			type = BaseModel.TYPE_FOLDER;
 			pattern = pattern.substr(1);
 		}
 		return this.loadItem(type, pattern, options);
 	}
 
-	public async loadItem(type: FolderOrNoteType, pattern: string, options: { parent?: FolderEntity } | null = null) {
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	public async loadItem(type: ModelType | 'folderOrNote', pattern: string, options: any = null) {
 		const output = await this.loadItems(type, pattern, options);
 
 		if (output.length > 1) {
@@ -75,36 +75,37 @@ class Application extends BaseApplication {
 		}
 	}
 
-	public async loadItemOrFail(type: FolderOrNoteType, pattern: string) {
+	public async loadItemOrFail(type: ModelType | 'folderOrNote', pattern: string) {
 		const output = await this.loadItem(type, pattern);
 		if (!output) throw new Error(_('Cannot find "%s".', pattern));
 		return output;
 	}
 
-	public async loadItems(type: FolderOrNoteType, pattern: string, options: { parent?: FolderEntity } | null = null): Promise<(FolderEntity | NoteEntity)[]> {
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	public async loadItems(type: ModelType | 'folderOrNote', pattern: string, options: any = null): Promise<(FolderEntity | NoteEntity)[]> {
 		if (type === 'folderOrNote') {
-			const folders: FolderEntity[] = await this.loadItems(ModelType.Folder, pattern, options);
+			const folders: FolderEntity[] = await this.loadItems(BaseModel.TYPE_FOLDER, pattern, options);
 			if (folders.length) return folders;
-			return await this.loadItems(ModelType.Note, pattern, options);
+			return await this.loadItems(BaseModel.TYPE_NOTE, pattern, options);
 		}
 
 		pattern = pattern ? pattern.toString() : '';
 
-		if (type === ModelType.Folder && (pattern === Folder.conflictFolderTitle() || pattern === Folder.conflictFolderId())) return [Folder.conflictFolder()];
+		if (type === BaseModel.TYPE_FOLDER && (pattern === Folder.conflictFolderTitle() || pattern === Folder.conflictFolderId())) return [Folder.conflictFolder()];
 
 		if (!options) options = {};
 
 		const parent = options.parent ? options.parent : app().currentFolder();
 		const ItemClass = BaseItem.itemClass(type);
 
-		if (type === ModelType.Note && pattern.indexOf('*') >= 0) {
+		if (type === BaseModel.TYPE_NOTE && pattern.indexOf('*') >= 0) {
 			// Handle it as pattern
 			if (!parent) throw new Error(_('No notebook selected.'));
 			return await Note.previews(parent.id, { titlePattern: pattern });
 		} else {
 			// Single item
 			let item = null;
-			if (type === ModelType.Note) {
+			if (type === BaseModel.TYPE_NOTE) {
 				if (!parent) throw new Error(_('No notebook has been specified.'));
 				item = await (ItemClass as typeof Note).loadFolderNoteByField(parent.id, 'title', pattern);
 			} else {
@@ -171,7 +172,7 @@ class Application extends BaseApplication {
 		}
 
 		if (uiType !== null) {
-			// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Dynamic command type
+			// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 			const temp: Record<string, any> = {};
 			for (const n in this.commands_) {
 				if (!this.commands_.hasOwnProperty(n)) continue;
@@ -232,7 +233,8 @@ class Application extends BaseApplication {
 			CommandClass = require(`${__dirname}/command-${name}.js`);
 		} catch (error) {
 			if (error.message && error.message.indexOf('Cannot find module') >= 0) {
-				const e: Error & { type?: string } = new Error(_('No such command: %s', name));
+				// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+				const e: any = new Error(_('No such command: %s', name));
 				e.type = 'notFound';
 				throw e;
 			} else {
@@ -251,7 +253,8 @@ class Application extends BaseApplication {
 			isDummy: () => {
 				return true;
 			},
-			prompt: (initialText = '', promptString = '', options: Record<string, unknown> | null = null) => {
+			// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+			prompt: (initialText = '', promptString = '', options: any = null) => {
 				return cliUtils.prompt(initialText, promptString, options);
 			},
 			showConsole: () => {},
@@ -273,7 +276,8 @@ class Application extends BaseApplication {
 		};
 	}
 
-	public async execCommand(argv: string[]): Promise<void> {
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	public async execCommand(argv: string[]): Promise<any> {
 		if (!argv.length) return this.execCommand(['help']);
 		// reg.logger().debug('execCommand()', argv);
 		const commandName = argv[0];
@@ -392,7 +396,8 @@ class Application extends BaseApplication {
 		const keychainEnabled = this.checkIfKeychainEnabled(argv);
 		argv = await super.start(argv, { keychainEnabled });
 
-		cliUtils.setStdout((object: string) => {
+		// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+		cliUtils.setStdout((object: any) => {
 			return this.stdout(object);
 		});
 
@@ -443,7 +448,7 @@ class Application extends BaseApplication {
 			this.gui_.setLogger(this.logger());
 			await this.gui_.start();
 
-			// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Redux dispatch type requires AnyAction
+			// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 			await refreshFolders((action: any) => this.store().dispatch(action), '');
 
 			const tags = await Tag.allWithNotes();

packages/app-cli/app/cli-utils.js

@@ -31,14 +31,9 @@ cliUtils.printArray = function(logFunction, rows) {
 		const line = [];
 		for (let col = 0; col < colWidths.length; col++) {
 			const item = rows[row][col];
-			const isLastCol = col === colWidths.length - 1;
-			if (isLastCol) {
-				line.push(item ? item.toString() : '');
-			} else {
-				const width = colWidths[col];
-				const dir = colAligns[col] === ALIGN_LEFT ? stringPadding.RIGHT : stringPadding.LEFT;
-				line.push(stringPadding(item, width, ' ', dir));
-			}
+			const width = colWidths[col];
+			const dir = colAligns[col] === ALIGN_LEFT ? stringPadding.RIGHT : stringPadding.LEFT;
+			line.push(stringPadding(item, width, ' ', dir));
 		}
 		logFunction(line.join(' '));
 	}

packages/app-cli/app/command-attach.ts

@@ -1,7 +1,7 @@
 import BaseCommand from './base-command';
 import app from './app';
 import { _ } from '@joplin/lib/locale';
-import { ModelType } from '@joplin/lib/BaseModel';
+import BaseModel from '@joplin/lib/BaseModel';
 import shim from '@joplin/lib/shim';
 
 class Command extends BaseCommand {
@@ -17,7 +17,7 @@ class Command extends BaseCommand {
 	public override async action(args: any) {
 		const title = args['note'];
 
-		const note = await app().loadItem(ModelType.Note, title, { parent: app().currentFolder() });
+		const note = await app().loadItem(BaseModel.TYPE_NOTE, title, { parent: app().currentFolder() });
 		this.encryptionCheck(note);
 		if (!note) throw new Error(_('Cannot find "%s".', title));
 

packages/app-cli/app/command-cat.ts

@@ -1,7 +1,7 @@
 import BaseCommand from './base-command';
 import app from './app';
 import { _ } from '@joplin/lib/locale';
-import { ModelType } from '@joplin/lib/BaseModel';
+import BaseModel from '@joplin/lib/BaseModel';
 import BaseItem from '@joplin/lib/models/BaseItem';
 import Note from '@joplin/lib/models/Note';
 
@@ -22,7 +22,7 @@ class Command extends BaseCommand {
 	public override async action(args: any) {
 		const title = args['note'];
 
-		const item = await app().loadItem(ModelType.Note, title, { parent: app().currentFolder() });
+		const item = await app().loadItem(BaseModel.TYPE_NOTE, title, { parent: app().currentFolder() });
 		if (!item) throw new Error(_('Cannot find "%s".', title));
 
 		let content = '';

packages/app-cli/app/command-clear.ts

@@ -1,19 +0,0 @@
-import BaseCommand from './base-command';
-import app from './app';
-import { _ } from '@joplin/lib/locale';
-
-class Command extends BaseCommand {
-	public override usage() {
-		return 'clear';
-	}
-
-	public override description() {
-		return _('Clears the console output.');
-	}
-
-	public override async action() {
-		app().gui().widget('console').clear();
-	}
-}
-
-module.exports = Command;

packages/app-cli/app/command-cp.ts

@@ -1,7 +1,7 @@
 import BaseCommand from './base-command';
 import app from './app';
 import { _ } from '@joplin/lib/locale';
-import { ModelType } from '@joplin/lib/BaseModel';
+import BaseModel from '@joplin/lib/BaseModel';
 import Note from '@joplin/lib/models/Note';
 
 class Command extends BaseCommand {
@@ -17,14 +17,14 @@ class Command extends BaseCommand {
 	public override async action(args: any) {
 		let folder = null;
 		if (args['notebook']) {
-			folder = await app().loadItem(ModelType.Folder, args['notebook']);
+			folder = await app().loadItem(BaseModel.TYPE_FOLDER, args['notebook']);
 		} else {
 			folder = app().currentFolder();
 		}
 
 		if (!folder) throw new Error(_('Cannot find "%s".', args['notebook']));
 
-		const notes = await app().loadItems(ModelType.Note, args['note']);
+		const notes = await app().loadItems(BaseModel.TYPE_NOTE, args['note']);
 		if (!notes.length) throw new Error(_('Cannot find "%s".', args['note']));
 
 		for (let i = 0; i < notes.length; i++) {

packages/app-cli/app/command-done.ts

@@ -1,7 +1,7 @@
 import BaseCommand from './base-command';
 import app from './app';
 import { _ } from '@joplin/lib/locale';
-import { ModelType } from '@joplin/lib/BaseModel';
+import BaseModel from '@joplin/lib/BaseModel';
 import Note from '@joplin/lib/models/Note';
 import time from '@joplin/lib/time';
 import { NoteEntity } from '@joplin/lib/services/database/types';
@@ -17,7 +17,7 @@ class Command extends BaseCommand {
 
 	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 	public static async handleAction(commandInstance: BaseCommand, args: any, isCompleted: boolean) {
-		const note: NoteEntity = await app().loadItem(ModelType.Note, args.note);
+		const note: NoteEntity = await app().loadItem(BaseModel.TYPE_NOTE, args.note);
 		commandInstance.encryptionCheck(note);
 		if (!note) throw new Error(_('Cannot find "%s".', args.note));
 		if (!note.is_todo) throw new Error(_('Note is not a to-do: "%s"', args.note));

packages/app-cli/app/command-edit.ts

@@ -6,7 +6,7 @@ import app from './app';
 import { _ } from '@joplin/lib/locale';
 import Note from '@joplin/lib/models/Note';
 import Setting from '@joplin/lib/models/Setting';
-import { ModelType } from '@joplin/lib/BaseModel';
+import BaseModel from '@joplin/lib/BaseModel';
 
 class Command extends BaseCommand {
 	public override usage() {
@@ -39,7 +39,7 @@ class Command extends BaseCommand {
 			const title = args['note'];
 
 			if (!app().currentFolder()) throw new Error(_('No active notebook.'));
-			let note = await app().loadItem(ModelType.Note, title);
+			let note = await app().loadItem(BaseModel.TYPE_NOTE, title);
 
 			this.encryptionCheck(note);
 

packages/app-cli/app/command-export.ts

@@ -1,6 +1,6 @@
 import BaseCommand from './base-command';
 import InteropService from '@joplin/lib/services/interop/InteropService';
-import { ModelType } from '@joplin/lib/BaseModel';
+import BaseModel from '@joplin/lib/BaseModel';
 import app from './app';
 import { _ } from '@joplin/lib/locale';
 import { ExportOptions } from '@joplin/lib/services/interop/types';
@@ -34,12 +34,12 @@ class Command extends BaseCommand {
 		if (exportOptions.format === 'html') throw new Error('HTML export is not supported. Please use the desktop application.');
 
 		if (args.options.note) {
-			const notes = await app().loadItems(ModelType.Note, args.options.note, { parent: app().currentFolder() });
+			const notes = await app().loadItems(BaseModel.TYPE_NOTE, args.options.note, { parent: app().currentFolder() });
 			if (!notes.length) throw new Error(_('Cannot find "%s".', args.options.note));
 			// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 			exportOptions.sourceNoteIds = notes.map((n: any) => n.id);
 		} else if (args.options.notebook) {
-			const folders = await app().loadItems(ModelType.Folder, args.options.notebook);
+			const folders = await app().loadItems(BaseModel.TYPE_FOLDER, args.options.notebook);
 			if (!folders.length) throw new Error(_('Cannot find "%s".', args.options.notebook));
 			// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 			exportOptions.sourceFolderIds = folders.map((n: any) => n.id);

packages/app-cli/app/command-geoloc.ts

@@ -1,7 +1,7 @@
 import BaseCommand from './base-command';
 import app from './app';
 import { _ } from '@joplin/lib/locale';
-import { ModelType } from '@joplin/lib/BaseModel';
+import BaseModel from '@joplin/lib/BaseModel';
 import Note from '@joplin/lib/models/Note';
 
 class Command extends BaseCommand {
@@ -17,7 +17,7 @@ class Command extends BaseCommand {
 	public override async action(args: any) {
 		const title = args['note'];
 
-		const item = await app().loadItem(ModelType.Note, title, { parent: app().currentFolder() });
+		const item = await app().loadItem(BaseModel.TYPE_NOTE, title, { parent: app().currentFolder() });
 		if (!item) throw new Error(_('Cannot find "%s".', title));
 		const url = Note.geolocationUrl(item);
 		this.stdout(url);

packages/app-cli/app/command-import.ts

@@ -1,6 +1,6 @@
 import BaseCommand from './base-command';
 import InteropService from '@joplin/lib/services/interop/InteropService';
-import { ModelType } from '@joplin/lib/BaseModel';
+import BaseModel from '@joplin/lib/BaseModel';
 const { cliUtils } = require('./cli-utils.js');
 import app from './app';
 import { _ } from '@joplin/lib/locale';
@@ -33,7 +33,7 @@ class Command extends BaseCommand {
 
 	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 	public override async action(args: any) {
-		let destinationFolder = await app().loadItem(ModelType.Folder, args.notebook);
+		let destinationFolder = await app().loadItem(BaseModel.TYPE_FOLDER, args.notebook);
 
 		if (args.notebook && !destinationFolder) throw new Error(_('Cannot find "%s".', args.notebook));
 

packages/app-cli/app/command-mkbook.ts

@@ -1,7 +1,7 @@
 const BaseCommand = require('./base-command').default;
 import app from './app';
 import { _ } from '@joplin/lib/locale';
-import { ModelType } from '@joplin/lib/BaseModel';
+import BaseModel from '@joplin/lib/BaseModel';
 import Folder from '@joplin/lib/models/Folder';
 import { FolderEntity } from '@joplin/lib/services/database/types';
 
@@ -23,7 +23,7 @@ class Command extends BaseCommand {
 	// validDestinationFolder check for presents and ambiguous folders
 	public async validDestinationFolder(targetFolder: string) {
 
-		const destinationFolder = await app().loadItem(ModelType.Folder, targetFolder);
+		const destinationFolder = await app().loadItem(BaseModel.TYPE_FOLDER, targetFolder);
 		if (!destinationFolder) {
 			throw new Error(_('Cannot find: "%s"', targetFolder));
 		}

packages/app-cli/app/command-mv.ts

@@ -1,7 +1,7 @@
 import BaseCommand from './base-command';
 import app from './app';
 import { _ } from '@joplin/lib/locale';
-import { ModelType } from '@joplin/lib/BaseModel';
+import BaseModel from '@joplin/lib/BaseModel';
 import Folder from '@joplin/lib/models/Folder';
 import Note from '@joplin/lib/models/Note';
 
@@ -21,7 +21,7 @@ class Command extends BaseCommand {
 		let folder = null;
 
 		if (destination !== 'root') {
-			folder = await app().loadItem(ModelType.Folder, destination);
+			folder = await app().loadItem(BaseModel.TYPE_FOLDER, destination);
 			if (!folder) throw new Error(_('Cannot find "%s".', destination));
 		}
 
@@ -30,7 +30,7 @@ class Command extends BaseCommand {
 			throw new Error(_('Ambiguous notebook "%s". Please use short notebook id instead - press "ti" to see the short notebook id', destination));
 		}
 
-		const itemFolder = await app().loadItem(ModelType.Folder, pattern);
+		const itemFolder = await app().loadItem(BaseModel.TYPE_FOLDER, pattern);
 		if (itemFolder) {
 			const sourceDuplicates = await Folder.search({ titlePattern: pattern, limit: 2 });
 			if (sourceDuplicates.length > 1) {
@@ -42,7 +42,7 @@ class Command extends BaseCommand {
 				await Folder.moveToFolder(itemFolder.id, folder.id);
 			}
 		} else {
-			const notes = await app().loadItems(ModelType.Note, pattern);
+			const notes = await app().loadItems(BaseModel.TYPE_NOTE, pattern);
 			if (notes.length === 0) throw new Error(_('Cannot find "%s".', pattern));
 			for (let i = 0; i < notes.length; i++) {
 				await Note.moveToFolder(notes[i].id, folder.id);

packages/app-cli/app/command-rmbook.ts

@@ -2,7 +2,7 @@ import BaseCommand from './base-command';
 import app from './app';
 import { _ } from '@joplin/lib/locale';
 import Folder from '@joplin/lib/models/Folder';
-import { ModelType } from '@joplin/lib/BaseModel';
+import BaseModel from '@joplin/lib/BaseModel';
 import { substrWithEllipsis } from '@joplin/lib/string-utils';
 
 class Command extends BaseCommand {
@@ -26,7 +26,7 @@ class Command extends BaseCommand {
 		const pattern = args['notebook'];
 		const force = args.options && args.options.force === true;
 
-		const folder = await app().loadItemOrFail(ModelType.Folder, pattern);
+		const folder = await app().loadItemOrFail(BaseModel.TYPE_FOLDER, pattern);
 
 		const permanent = args.options?.permanent === true || !!folder.deleted_time;
 		const ellipsizedFolderTitle = substrWithEllipsis(folder.title, 0, 32);

packages/app-cli/app/command-rmnote.ts

@@ -2,7 +2,7 @@ import BaseCommand from './base-command';
 import app from './app';
 import { _, _n } from '@joplin/lib/locale';
 import Note from '@joplin/lib/models/Note';
-import { DeleteOptions, ModelType } from '@joplin/lib/BaseModel';
+import BaseModel, { DeleteOptions } from '@joplin/lib/BaseModel';
 import { NoteEntity } from '@joplin/lib/services/database/types';
 
 class Command extends BaseCommand {
@@ -26,7 +26,7 @@ class Command extends BaseCommand {
 		const pattern = args['note-pattern'];
 		const force = args.options && args.options.force === true;
 
-		const notes: NoteEntity[] = await app().loadItems(ModelType.Note, pattern);
+		const notes: NoteEntity[] = await app().loadItems(BaseModel.TYPE_NOTE, pattern);
 		if (!notes.length) throw new Error(_('Cannot find "%s".', pattern));
 
 		let ok = true;

packages/app-cli/app/command-set.ts

@@ -1,7 +1,7 @@
 import BaseCommand from './base-command';
 import app from './app';
 import { _ } from '@joplin/lib/locale';
-import { ModelType } from '@joplin/lib/BaseModel';
+import BaseModel from '@joplin/lib/BaseModel';
 import Database from '@joplin/lib/database';
 import Note from '@joplin/lib/models/Note';
 
@@ -29,7 +29,7 @@ class Command extends BaseCommand {
 		let propValue = args['value'];
 		if (!propValue) propValue = '';
 
-		const notes = await app().loadItems(ModelType.Note, title);
+		const notes = await app().loadItems(BaseModel.TYPE_NOTE, title);
 		if (!notes.length) throw new Error(_('Cannot find "%s".', title));
 
 		for (let i = 0; i < notes.length; i++) {

packages/app-cli/app/command-use.ts

@@ -1,7 +1,7 @@
 import BaseCommand from './base-command';
 import app from './app';
 import { _ } from '@joplin/lib/locale';
-import { ModelType } from '@joplin/lib/BaseModel';
+import BaseModel from '@joplin/lib/BaseModel';
 import Folder from '@joplin/lib/models/Folder';
 
 class Command extends BaseCommand {
@@ -19,7 +19,7 @@ class Command extends BaseCommand {
 
 	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 	public override async action(args: any) {
-		const folder = await app().loadItem(ModelType.Folder, args['notebook']);
+		const folder = await app().loadItem(BaseModel.TYPE_FOLDER, args['notebook']);
 		if (!folder) throw new Error(_('Cannot find "%s".', args['notebook']));
 
 		// Auto-expand parent folders in GUI if present

packages/app-cli/app/gui/ConsoleWidget.js

@@ -34,12 +34,6 @@ class ConsoleWidget extends TextWidget {
 		super.onBlur();
 	}
 
-	clear() {
-		this.lines_ = [];
-		this.updateText_ = true;
-		this.invalidate();
-	}
-
 	render() {
 		if (this.updateText_) {
 			if (this.lines_.length > this.maxLines_) {

packages/app-cli/package.json

@@ -48,7 +48,7 @@
     "chalk": "4.1.2",
     "compare-version": "0.1.2",
     "file-type": "16.5.4",
-    "fs-extra": "11.3.3",
+    "fs-extra": "11.3.2",
     "html-entities": "1.4.0",
     "keytar": "7.9.0",
     "md5": "2.3.0",

packages/app-cli/tests/HtmlToMd.ts

@@ -45,10 +45,6 @@ describe('HtmlToMd', () => {
 				htmlToMdOptions.preserveColorStyles = true;
 			}
 
-			if (htmlFilename.indexOf('table_with') === 0 || htmlFilename.indexOf('table_default') === 0) {
-				htmlToMdOptions.preserveTableStyles = true;
-			}
-
 			const html = await readFile(htmlPath, 'utf8');
 			let expectedMd = await readFile(mdPath, 'utf8');
 
@@ -100,34 +96,4 @@ describe('HtmlToMd', () => {
 		expect(htmlToMd.parse('> 1 _2_ 3.pdf', { disableEscapeContent: false })).toBe('\\> 1 \\_2_ 3.pdf');
 	});
 
-	it('should support tightLists option', async () => {
-		const htmlToMd = new HtmlToMd();
-		const html = '<ul><li><p><strong>Item 1</strong></p></li><li><p><strong>Item 2</strong></p></li><li><p><strong>Item 3</strong></p></li></ul>';
-
-		// Without tightLists, paragraphs inside list items produce extra blank lines
-		const looseResult = htmlToMd.parse(html, { tightLists: false });
-		expect(looseResult).toContain('\n    \n');
-
-		// With tightLists, list items are compact without blank lines
-		const tightResult = htmlToMd.parse(html, { tightLists: true });
-		expect(tightResult).toBe('- **Item 1**\n- **Item 2**\n- **Item 3**');
-	});
-
-	it('should support collapseMultipleBlankLines option', async () => {
-		const htmlToMd = new HtmlToMd();
-		const html = '<p>First</p><br><br><br><p>Second</p>';
-
-		// Without collapseMultipleBlankLines, multiple blank lines are preserved
-		const looseResult = htmlToMd.parse(html, { collapseMultipleBlankLines: false });
-		expect(looseResult).toContain('\n\n  \n');
-
-		// With collapseMultipleBlankLines, multiple blank lines are collapsed into one
-		const collapsedResult = htmlToMd.parse(html, { collapseMultipleBlankLines: true });
-		expect(collapsedResult).not.toContain('\n\n\n');
-		expect(collapsedResult).not.toContain('\n\n  \n');
-
-		// Verify that a single blank line is preserved (not fully removed)
-		expect(collapsedResult).toContain('\n\n');
-	});
-
 });

packages/app-cli/tests/enex_to_md/list_with_br.html

@@ -1,7 +0,0 @@
-<ul>
-	<li>First line<br/>Second line</li>
-	<li>Normal item</li>
-	<li>With sub-list<ul>
-		<li>Sub-list<br/>Paragraph<br/>Also another line</li>
-	</ul></li>
-</ul>

packages/app-cli/tests/enex_to_md/list_with_br.md

@@ -1,8 +0,0 @@
-- First line
-  Second line
-
-- Normal item
-- With sub-list
-    - Sub-list
-      Paragraph
-      Also another line

packages/app-cli/tests/html_to_md/anchor_underlined_fragment.html

@@ -1 +0,0 @@
-<a href="#section" style="text-decoration: underline">Section Link</a>

packages/app-cli/tests/html_to_md/anchor_underlined_fragment.md

@@ -1 +0,0 @@
-[Section Link](#section)

packages/app-cli/tests/html_to_md/table_default_tinymce_styles.html

@@ -1,18 +0,0 @@
-<table style="border-collapse: collapse; width: 100%;">
-<thead>
-<tr>
-<th style="width: 50%;">Name</th>
-<th style="width: 50%;">Value</th>
-</tr>
-</thead>
-<tbody>
-<tr>
-<td style="width: 50%;">Cell A</td>
-<td style="width: 50%;">Cell B</td>
-</tr>
-<tr>
-<td style="width: 50%;">Cell C</td>
-<td style="width: 50%;">Cell D</td>
-</tr>
-</tbody>
-</table>

packages/app-cli/tests/html_to_md/table_default_tinymce_styles.md

@@ -1,4 +0,0 @@
-| Name | Value |
-| --- | --- |
-| Cell A | Cell B |
-| Cell C | Cell D |

packages/app-cli/tests/html_to_md/table_with_custom_attributes.html

@@ -1,18 +0,0 @@
-<table bgcolor="#f0f0f0" cellpadding="8">
-	<thead>
-		<tr>
-			<th>Name</th>
-			<th>Value</th>
-		</tr>
-	</thead>
-	<tbody>
-		<tr>
-			<td>Cell A</td>
-			<td>Cell B</td>
-		</tr>
-		<tr>
-			<td>Cell C</td>
-			<td>Cell D</td>
-		</tr>
-	</tbody>
-</table>

packages/app-cli/tests/html_to_md/table_with_custom_attributes.md

@@ -1 +0,0 @@
-<div class="joplin-table-wrapper"><table bgcolor="#f0f0f0" cellpadding="8"><thead><tr><th>Name</th><th>Value</th></tr></thead><tbody><tr><td>Cell A</td><td>Cell B</td></tr><tr><td>Cell C</td><td>Cell D</td></tr></tbody></table></div>

packages/app-cli/tests/html_to_md/table_with_custom_styles.html

@@ -1,18 +0,0 @@
-<table style="border-collapse: collapse">
-  <thead>
-    <tr>
-      <th>Name</th>
-      <th>Value</th>
-    </tr>
-  </thead>
-  <tbody>
-    <tr>
-      <td style="background-color: #e03e2d">Red cell</td>
-      <td style="padding: 10px 15px">Padded cell</td>
-    </tr>
-    <tr>
-      <td style="border-color: #2dc26b; border-style: solid">Green border</td>
-      <td>Normal cell</td>
-    </tr>
-  </tbody>
-</table>

packages/app-cli/tests/html_to_md/table_with_custom_styles.md

@@ -1 +0,0 @@
-<div class="joplin-table-wrapper"><table style="border-collapse: collapse"><thead><tr><th>Name</th><th>Value</th></tr></thead><tbody><tr><td style="background-color: #e03e2d">Red cell</td><td style="padding: 10px 15px">Padded cell</td></tr><tr><td style="border-color: #2dc26b; border-style: solid">Green border</td><td>Normal cell</td></tr></tbody></table></div>

packages/app-cli/tests/services/plugins/PluginService.ts

@@ -10,7 +10,6 @@ import Folder from '@joplin/lib/models/Folder';
 import { expectNotThrow, setupDatabaseAndSynchronizer, switchClient, expectThrow, createTempDir, supportDir, mockMobilePlatform } from '@joplin/lib/testing/test-utils';
 import { newPluginScript } from '../../testUtils';
 import { join } from 'path';
-import { PluginManifest } from '@joplin/lib/services/plugins/utils/types';
 
 const testPluginDir = `${supportDir}/plugins`;
 
@@ -473,18 +472,4 @@ describe('services_PluginService', () => {
 			await fs.remove(testDir);
 		}
 	});
-
-	it('should report a missing app_min_version field specifically', () => {
-		const service = newPluginService();
-		const manifest = {
-			manifest_version: 1,
-			id: 'test.plugin',
-			name: 'Test Plugin',
-			version: '1.0.0',
-			// Missing app_min_version
-		};
-
-		const error = service.describeIncompatibility(manifest as unknown as PluginManifest);
-		expect(error).toContain('Invalid plugin manifest: Missing required field: app_min_version');
-	});
 });

packages/app-desktop/ElectronAppWrapper.ts

@@ -6,7 +6,7 @@ const shim: typeof ShimType = require('@joplin/lib/shim').default;
 import { isCallbackUrl } from '@joplin/lib/callbackUrlUtils';
 import { FileLocker } from '@joplin/utils/fs';
 import { IpcMessageHandler, IpcServer, Message, newHttpError, sendMessage, SendMessageOptions, startServer, stopServer } from '@joplin/utils/ipc';
-import { BrowserWindow, Tray, WebContents, screen, App, nativeTheme, powerMonitor, Menu } from 'electron';
+import { BrowserWindow, Tray, WebContents, screen, App, nativeTheme } from 'electron';
 import bridge from './bridge';
 import * as url from 'url';
 const path = require('path');
@@ -30,7 +30,8 @@ interface RendererProcessQuitReply {
 }
 
 interface PluginWindows {
-	[key: string]: BrowserWindow;
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	[key: string]: any;
 }
 
 type SecondaryWindowId = string;
@@ -60,7 +61,8 @@ export default class ElectronAppWrapper {
 	private secondaryWindows_: Map<SecondaryWindowId, SecondaryWindowData> = new Map();
 
 	private willQuitApp_ = false;
-	private tray_: Tray = null;
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	private tray_: any = null;
 	private buildDir_: string = null;
 	private rendererProcessQuitReply_: RendererProcessQuitReply = null;
 
@@ -174,10 +176,6 @@ export default class ElectronAppWrapper {
 	public async handleAppFailure(errorMessage: string, canIgnore: boolean, isTesting?: boolean) {
 		await bridge().captureException(new Error(errorMessage));
 
-		if (this.win_ && this.win_.isDestroyed()) {
-			return;
-		}
-
 		const buttons = [];
 		buttons.push(_('Quit'));
 		const exitIndex = 0;
@@ -201,7 +199,7 @@ export default class ElectronAppWrapper {
 			//
 			// Also only run this if not testing (crashing the renderer breaks automated
 			// tests).
-			if (this.win_ && !this.win_.isDestroyed() && !this.win_.webContents.isCrashed() && !isTesting) {
+			if (this.win_ && !this.win_.webContents.isCrashed() && !isTesting) {
 				this.win_.webContents.forcefullyCrashRenderer();
 			}
 		} else if (response === exitIndex) {
@@ -403,15 +401,6 @@ export default class ElectronAppWrapper {
 		};
 		addWindowEventHandlers(this.win_.webContents);
 
-		// BrowserWindow 'focus' fires when the OS gives focus to the application window
-		// (i.e. coming from another app or from the taskbar), not on intra-app focus switches.
-		// We use a dedicated IPC channel so the renderer can trigger an immediate sync on
-		// OS-level focus gain without conflating it with the 'window-focused' channel that
-		// handles Joplin-internal window routing.
-		this.win_.on('focus', () => {
-			this.win_?.webContents.send('main-window-focused');
-		});
-
 		// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 		this.win_.on('close', (event: any) => {
 			// If it's on macOS, the app is completely closed only if the user chooses to close the app (willQuitApp_ will be true)
@@ -555,7 +544,8 @@ export default class ElectronAppWrapper {
 		}
 	}
 
-	public registerPluginWindow(pluginId: string, window: BrowserWindow) {
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	public registerPluginWindow(pluginId: string, window: any) {
 		this.pluginWindows_[pluginId] = window;
 	}
 
@@ -641,7 +631,8 @@ export default class ElectronAppWrapper {
 	}
 
 	// Note: this must be called only after the "ready" event of the app has been dispatched
-	public createTray(contextMenu: Menu) {
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	public createTray(contextMenu: any) {
 		try {
 			this.tray_ = new Tray(`${this.buildDir()}/icons/${this.trayIconFilename_()}`);
 			this.tray_.setToolTip(this.electronApp_.name);
@@ -901,11 +892,6 @@ export default class ElectronAppWrapper {
 			event.preventDefault();
 			void this.openCallbackUrl(url);
 		});
-
-		// When the OS wakes from sleep, notify the renderer so it can trigger an immediate sync.
-		powerMonitor.on('resume', () => {
-			this.win_?.webContents.send('system-resumed');
-		});
 	}
 
 	public async openCallbackUrl(url: string) {

packages/app-desktop/app.reducer.ts

@@ -11,7 +11,8 @@ const logger = Logger.create('app.reducer');
 export interface AppStateRoute {
 	type: string;
 	routeName: string;
-	props: Record<string, unknown>;
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	props: any;
 }
 
 export enum AppStateDialogName {
@@ -21,7 +22,8 @@ export enum AppStateDialogName {
 
 export interface AppStateDialog {
 	name: AppStateDialogName;
-	props: Record<string, unknown>;
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	props: Record<string, any>;
 }
 
 export interface NoteIdToScrollPercent {

packages/app-desktop/app.ts

@@ -43,7 +43,7 @@ const electronContextMenu = require('./services/electron-context-menu');
 // Commands that are not tied to any particular component.
 // The runtime for these commands can be loaded when the app starts.
 
-import PerFolderSortOrderService from '@joplin/lib/services/sortOrder/PerFolderSortOrderService';
+import PerFolderSortOrderService from './services/sortOrder/PerFolderSortOrderService';
 import ShareService from '@joplin/lib/services/share/ShareService';
 import checkForUpdates from './checkForUpdates';
 import { AppState } from './app.reducer';
@@ -78,7 +78,8 @@ type StartupTask = { label: string; task: ()=> void|Promise<void> };
 
 class Application extends BaseApplication {
 
-	private checkAllPluginStartedIID_: ReturnType<typeof setInterval> = null;
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	private checkAllPluginStartedIID_: any = null;
 	private initPluginServiceDone_ = false;
 	private ocrService_: OcrService;
 	private protocolHandler_: CustomContentProtocolHandler;
@@ -639,19 +640,16 @@ class Application extends BaseApplication {
 				void AlarmService.updateAllNotifications();
 				RevisionService.instance().runInBackground();
 			} else {
-				setTimeout(() => {
-					// Schedule sync with a delay of 0 and wrap with the desired timeout, as shim.setTimeout may not fire on first run or after an upgrade
-					// eslint-disable-next-line promise/prefer-await-to-then -- Old code before rule was applied
-					void reg.scheduleSync(0).then(() => {
-						// Wait for the first sync before updating the notifications, since synchronisation
-						// might change the notifications.
-						void AlarmService.updateAllNotifications();
+				// eslint-disable-next-line promise/prefer-await-to-then -- Old code before rule was applied
+				void reg.scheduleSync(1000).then(() => {
+					// Wait for the first sync before updating the notifications, since synchronisation
+					// might change the notifications.
+					void AlarmService.updateAllNotifications();
 
-						void DecryptionWorker.instance().scheduleStart();
+					void DecryptionWorker.instance().scheduleStart();
 
-						RevisionService.instance().runInBackground();
-					});
-				}, 1000);
+					RevisionService.instance().runInBackground();
+				});
 			}
 
 			this.startRotatingLogMaintenance(Setting.value('profileDir'));
@@ -732,23 +730,6 @@ class Application extends BaseApplication {
 					});
 				}
 			});
-
-			// Trigger an immediate sync when the main window gains OS-level focus (i.e. the user
-			// switches back to Joplin from another application) or when the system wakes from sleep.
-			// A 30-second cool-down prevents duplicate syncs during rapid focus-in/focus-out cycles.
-			const minResumeSyncIntervalMs = 30_000;
-			let lastFocusSyncTime = 0;
-
-			const scheduleResumeSync = () => {
-				const now = Date.now();
-				if (now - lastFocusSyncTime > minResumeSyncIntervalMs) {
-					lastFocusSyncTime = now;
-					void reg.scheduleSync(0);
-				}
-			};
-
-			ipcRenderer.on('main-window-focused', scheduleResumeSync);
-			ipcRenderer.on('system-resumed', scheduleResumeSync);
 		});
 
 		addTask('app/initPluginService', () => this.initPluginService());

packages/app-desktop/bridge.ts

@@ -1,7 +1,7 @@
 import ElectronAppWrapper from './ElectronAppWrapper';
 import shim, { MessageBoxType } from '@joplin/lib/shim';
 import { _, setLocale } from '@joplin/lib/locale';
-import { BrowserWindow, nativeTheme, nativeImage, shell, dialog, MessageBoxSyncOptions, safeStorage, Menu, MenuItemConstructorOptions, MenuItem, BrowserWindowConstructorOptions, FileFilter, SaveDialogOptions } from 'electron';
+import { BrowserWindow, nativeTheme, nativeImage, shell, dialog, MessageBoxSyncOptions, safeStorage, Menu, MenuItemConstructorOptions, MenuItem } from 'electron';
 import { dirname, toSystemSlashes } from '@joplin/lib/path-utils';
 import { fileUriToPath } from '@joplin/utils/url';
 import { urlDecode } from '@joplin/lib/string-utils';
@@ -25,7 +25,8 @@ interface OpenDialogOptions {
 	properties?: string[];
 	defaultPath?: string;
 	createDirectory?: boolean;
-	filters?: FileFilter[];
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	filters?: any[];
 }
 
 type OnAllowedExtensionsChange = (newExtensions: string[])=> void;
@@ -207,7 +208,8 @@ export class Bridge {
 		this.onAllowedExtensionsChangeListener_ = listener;
 	}
 
-	public async captureException(error: unknown) {
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	public async captureException(error: any) {
 		Sentry.captureException(error);
 		// We wait to give the "beforeSend" event handler time to process the crash dump and write
 		// it to file.
@@ -333,7 +335,8 @@ export class Bridge {
 		return require('electron').shell.showItemInFolder(toSystemSlashes(fullPath));
 	}
 
-	public newBrowserWindow(options: BrowserWindowConstructorOptions) {
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	public newBrowserWindow(options: any) {
 		return new BrowserWindow(options);
 	}
 
@@ -350,7 +353,8 @@ export class Bridge {
 		return this.activeWindow().webContents.closeDevTools();
 	}
 
-	public async showSaveDialog(options: SaveDialogOptions) {
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	public async showSaveDialog(options: any) {
 		if (!options) options = {};
 		if (!('defaultPath' in options) && this.lastSelectedPaths_.file) options.defaultPath = this.lastSelectedPaths_.file;
 		const { filePath } = await dialog.showSaveDialog(this.activeWindow(), options);
@@ -377,7 +381,8 @@ export class Bridge {
 	}
 
 	// Don't use this directly - call one of the showXxxxxxxMessageBox() instead
-	private showMessageBox_(window: BrowserWindow, options: MessageDialogOptions): number {
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	private showMessageBox_(window: any, options: MessageDialogOptions): number {
 		if (!window) window = this.activeWindow();
 		return dialog.showMessageBoxSync(window, { message: '', ...options });
 	}
@@ -423,7 +428,8 @@ export class Bridge {
 		return result;
 	}
 
-	public showInfoMessageBox(message: string, options: MessageDialogOptions = {}) {
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	public showInfoMessageBox(message: string, options: any = {}) {
 		const result = this.showMessageBox_(this.activeWindow(), { type: 'info',
 			message: message,
 			buttons: [_('OK')], ...options });
@@ -577,11 +583,6 @@ export class Bridge {
 				execPath: process.env.PORTABLE_EXECUTABLE_FILE,
 			};
 			app.relaunch(options);
-		} else if (process.env.APPIMAGE && !this.altInstanceId_) {
-			app.relaunch({
-				execPath: process.env.APPIMAGE,
-				args: ['--appimage-extract-and-run'],
-			});
 		} else if (this.altInstanceId_) {
 			// Couldn't get it to work using relaunch() - it would just "close" the app, but it
 			// would still be open in the tray except unusable. Or maybe it reopens it quickly but

packages/app-desktop/checkForUpdates.ts

@@ -4,7 +4,7 @@ import { _ } from '@joplin/lib/locale';
 import bridge from './services/bridge';
 import KvStore from '@joplin/lib/services/KvStore';
 import * as ArrayUtils from '@joplin/lib/ArrayUtils';
-import { CheckForUpdateOptions, extractVersionInfo, GitHubRelease, handleReleaseResponseError } from './utils/checkForUpdatesUtils';
+import { CheckForUpdateOptions, extractVersionInfo, GitHubRelease } from './utils/checkForUpdatesUtils';
 import { PackageInfo } from '@joplin/lib/versionInfo';
 import { compareVersions } from 'compare-versions';
 const packageInfo: PackageInfo = require('./packageInfo.js');
@@ -29,8 +29,7 @@ async function fetchLatestReleases() {
 
 	if (!response.ok) {
 		const responseText = await response.text();
-		logger.error(`Cannot get latest release info (${response.status}): ${responseText.substr(0, 500)}`);
-		handleReleaseResponseError(response.status, responseText);
+		throw new Error(`Cannot get latest release info: ${responseText.substr(0, 500)}`);
 	}
 
 	return (await response.json()) as GitHubRelease[];
@@ -49,8 +48,8 @@ function truncateText(text: string, length: number) {
 }
 
 async function getSkippedVersions(): Promise<string[]> {
-	const r = await KvStore.instance().value('updateCheck::skippedVersions');
-	return r && typeof r === 'string' ? JSON.parse(r) : [];
+	const r = await KvStore.instance().value<string>('updateCheck::skippedVersions');
+	return r ? JSON.parse(r) : [];
 }
 
 async function isSkippedVersion(v: string): Promise<boolean> {

packages/app-desktop/gui/ConfigScreen/ConfigScreen.tsx

@@ -19,7 +19,7 @@ import shouldShowMissingPasswordWarning from '@joplin/lib/components/shared/conf
 import MacOSMissingPasswordHelpLink from './controls/MissingPasswordHelpLink';
 const { KeymapConfigScreen } = require('../KeymapConfig/KeymapConfigScreen');
 import SettingComponent, { UpdateSettingValueEvent } from './controls/SettingComponent';
-import shim, { MessageBoxType } from '@joplin/lib/shim';
+import shim from '@joplin/lib/shim';
 
 
 interface Font {
@@ -145,16 +145,8 @@ class ConfigScreenComponent extends React.Component<any, any> {
 			screenName = section.name;
 
 			if (this.hasChanges()) {
-				const answer = await shim.showMessageBox(
-					_('This will open a new screen. Save your current changes?'),
-					{
-						type: MessageBoxType.Confirm,
-						buttons: [_('Save changes'), _('Discard changes')],
-						defaultId: 0,
-						cancelId: 1,
-					},
-				);
-				if (answer === 0) {
+				const ok = await shim.showConfirmationDialog(_('This will open a new screen. Save your current changes?'));
+				if (ok) {
 					await shared.saveSettings(this);
 				}
 			}

packages/app-desktop/gui/DialogTitle.tsx

@@ -1,6 +1,7 @@
 import styled from 'styled-components';
 
-const Root = styled.h1<{ justifyContent?: string }>`
+// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+const Root = styled.h1<any>`
 	display: flex;
 	justify-content: ${props => props.justifyContent ? props.justifyContent : 'center'};
 	font-family: ${props => props.theme.fontFamily};

packages/app-desktop/gui/DropboxLoginScreen.tsx

@@ -8,7 +8,7 @@ const { themeStyle } = require('@joplin/lib/theme');
 const Shared = require('@joplin/lib/components/shared/dropbox-login-shared');
 
 interface Props {
-	themeId: number;
+	themeId: string;
 }
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
@@ -63,7 +63,8 @@ class DropboxLoginScreenComponent extends React.Component<any, any> {
 	}
 }
 
-const mapStateToProps = (state: { settings: { theme: number } }) => {
+// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+const mapStateToProps = (state: any) => {
 	return {
 		themeId: state.settings.theme,
 	};

packages/app-desktop/gui/EncryptionConfigScreen/EncryptionConfigScreen.tsx

@@ -10,21 +10,18 @@ import { MasterKeyEntity } from '@joplin/lib/services/e2ee/types';
 import { getEncryptionEnabled, masterKeyEnabled, SyncInfo } from '@joplin/lib/services/synchronizer/syncInfoUtils';
 import { getDefaultMasterKey, getMasterPasswordStatusMessage, masterPasswordIsValid, toggleAndSetupEncryption } from '@joplin/lib/services/e2ee/utils';
 import Button, { ButtonLevel } from '../Button/Button';
-import { useCallback, useEffect, useId, useMemo, useRef, useState } from 'react';
+import { useCallback, useId, useMemo, useState } from 'react';
 import { connect } from 'react-redux';
-import { AppState, AppStateDialogName } from '../../app.reducer';
+import { AppState } from '../../app.reducer';
 import Setting from '@joplin/lib/models/Setting';
 import CommandService from '@joplin/lib/services/CommandService';
 import { PublicPrivateKeyPair } from '@joplin/lib/services/e2ee/ppk/ppk';
 import ToggleAdvancedSettingsButton from '../ConfigScreen/controls/ToggleAdvancedSettingsButton';
 import MacOSMissingPasswordHelpLink from '../ConfigScreen/controls/MissingPasswordHelpLink';
-import { Dispatch } from 'redux';
-import { shouldCancelPendingEnableAfterMasterPasswordDialog, shouldOpenMasterPasswordDialogForEnable, shouldResumeEnableAfterMasterPasswordDialog } from './enableFlow';
 
 interface Props {
 	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 	themeId: any;
-	dispatch: Dispatch;
 	masterKeys: MasterKeyEntity[];
 	passwords: Record<string, string>;
 	notLoadedMasterKeys: string[];
@@ -33,13 +30,10 @@ interface Props {
 	activeMasterKeyId: string;
 	masterPassword: string;
 	ppk: PublicPrivateKeyPair;
-	masterPasswordDialogOpen: boolean;
 }
 
-export const EncryptionConfigScreen = (props: Props) => {
+const EncryptionConfigScreen = (props: Props) => {
 	const { inputPasswords, onInputPasswordChange } = useInputPasswords(props.passwords);
-	const [pendingEnableEncryption, setPendingEnableEncryption] = useState(false);
-	const wasMasterPasswordDialogOpen = useRef(props.masterPasswordDialogOpen);
 
 	const theme = useMemo(() => {
 		return themeStyle(props.themeId);
@@ -50,41 +44,6 @@ export const EncryptionConfigScreen = (props: Props) => {
 	const { showDisabledMasterKeys, toggleShowDisabledMasterKeys } = useToggleShowDisabledMasterKeys();
 	const needMasterPassword = useNeedMasterPassword(passwordChecks, props.masterKeys);
 
-	useEffect(() => {
-		const wasOpen = wasMasterPasswordDialogOpen.current;
-		wasMasterPasswordDialogOpen.current = props.masterPasswordDialogOpen;
-
-		if (shouldCancelPendingEnableAfterMasterPasswordDialog({
-			pendingEnableEncryption,
-			wasMasterPasswordDialogOpen: wasOpen,
-			masterPasswordDialogOpen: props.masterPasswordDialogOpen,
-			masterPassword: props.masterPassword,
-		})) {
-			setPendingEnableEncryption(false);
-			return;
-		}
-
-		if (!shouldResumeEnableAfterMasterPasswordDialog({
-			pendingEnableEncryption,
-			wasMasterPasswordDialogOpen: wasOpen,
-			masterPasswordDialogOpen: props.masterPasswordDialogOpen,
-			masterPassword: props.masterPassword,
-		})) return;
-
-		const masterKey = getDefaultMasterKey();
-
-		void (async () => {
-			try {
-				await toggleAndSetupEncryption(EncryptionService.instance(), true, masterKey, props.masterPassword);
-			} catch (error) {
-				const message = error instanceof Error ? error.message : String(error);
-				await dialogs.alert(message);
-			} finally {
-				setPendingEnableEncryption(false);
-			}
-		})();
-	}, [pendingEnableEncryption, props.masterPasswordDialogOpen, props.masterPassword]);
-
 	const onUpgradeMasterKey = useCallback(async (mk: MasterKeyEntity) => {
 		const password = determineKeyPassword(mk.id, masterPasswordKeys, props.masterPassword, props.passwords);
 		const result = await upgradeMasterKey(mk, password);
@@ -241,18 +200,6 @@ export const EncryptionConfigScreen = (props: Props) => {
 			const answer = await dialogs.confirm(_('Disabling encryption means *all* your notes and attachments are going to be re-synchronised and sent unencrypted to the sync target. Do you wish to continue?'));
 			if (!answer) return;
 		} else {
-			if (shouldOpenMasterPasswordDialogForEnable({
-				hasMasterPassword,
-				masterPasswordDialogOpen: props.masterPasswordDialogOpen,
-			})) {
-				setPendingEnableEncryption(true);
-				props.dispatch({
-					type: 'DIALOG_OPEN',
-					name: AppStateDialogName.MasterPassword,
-				});
-				return;
-			}
-
 			const msg = enableEncryptionConfirmationMessages(masterKey, hasMasterPassword);
 			newPassword = await dialogs.prompt(msg.join('\n\n'), '', '', { type: 'password' });
 		}
@@ -269,7 +216,7 @@ export const EncryptionConfigScreen = (props: Props) => {
 		} catch (error) {
 			await dialogs.alert(error.message);
 		}
-	}, [props.dispatch, props.masterPassword, props.masterPasswordDialogOpen]);
+	}, [props.masterPassword]);
 
 	const renderEncryptionSection = () => {
 		const decryptedItemsInfo = <p>{decryptedStatText(stats)}</p>;
@@ -468,7 +415,6 @@ const mapStateToProps = (state: AppState) => {
 		notLoadedMasterKeys: state.notLoadedMasterKeys,
 		masterPassword: state.settings['encryption.masterPassword'],
 		ppk: syncInfo.ppk,
-		masterPasswordDialogOpen: !!state.dialogs.find(dialog => dialog.name === AppStateDialogName.MasterPassword),
 	};
 };
 

packages/app-desktop/gui/EncryptionConfigScreen/enableFlow.test.ts

@@ -1,51 +0,0 @@
-import { shouldCancelPendingEnableAfterMasterPasswordDialog, shouldOpenMasterPasswordDialogForEnable, shouldResumeEnableAfterMasterPasswordDialog } from './enableFlow';
-
-describe('enableFlow', () => {
-	test('opens the master password dialog when enabling encryption without a stored master password', () => {
-		expect(shouldOpenMasterPasswordDialogForEnable({
-			hasMasterPassword: false,
-			masterPasswordDialogOpen: false,
-		})).toBe(true);
-	});
-
-	test('does not reopen the master password dialog if it is already open', () => {
-		expect(shouldOpenMasterPasswordDialogForEnable({
-			hasMasterPassword: false,
-			masterPasswordDialogOpen: true,
-		})).toBe(false);
-	});
-
-	test('does not open the master password dialog when a master password already exists', () => {
-		expect(shouldOpenMasterPasswordDialogForEnable({
-			hasMasterPassword: true,
-			masterPasswordDialogOpen: false,
-		})).toBe(false);
-	});
-
-	test('resumes enabling encryption after the dialog closes with a saved password', () => {
-		expect(shouldResumeEnableAfterMasterPasswordDialog({
-			pendingEnableEncryption: true,
-			wasMasterPasswordDialogOpen: true,
-			masterPasswordDialogOpen: false,
-			masterPassword: 'new-password',
-		})).toBe(true);
-	});
-
-	test('cancels the pending enable flow if the dialog closes without a password', () => {
-		expect(shouldCancelPendingEnableAfterMasterPasswordDialog({
-			pendingEnableEncryption: true,
-			wasMasterPasswordDialogOpen: true,
-			masterPasswordDialogOpen: false,
-			masterPassword: '',
-		})).toBe(true);
-	});
-
-	test('does not resume while the dialog is still open', () => {
-		expect(shouldResumeEnableAfterMasterPasswordDialog({
-			pendingEnableEncryption: true,
-			wasMasterPasswordDialogOpen: true,
-			masterPasswordDialogOpen: true,
-			masterPassword: 'new-password',
-		})).toBe(false);
-	});
-});

packages/app-desktop/gui/EncryptionConfigScreen/enableFlow.ts

@@ -1,23 +0,0 @@
-interface OpenDialogInput {
-	hasMasterPassword: boolean;
-	masterPasswordDialogOpen: boolean;
-}
-
-interface ResumeEnableInput {
-	pendingEnableEncryption: boolean;
-	wasMasterPasswordDialogOpen: boolean;
-	masterPasswordDialogOpen: boolean;
-	masterPassword: string;
-}
-
-export const shouldOpenMasterPasswordDialogForEnable = ({ hasMasterPassword, masterPasswordDialogOpen }: OpenDialogInput) => {
-	return !hasMasterPassword && !masterPasswordDialogOpen;
-};
-
-export const shouldResumeEnableAfterMasterPasswordDialog = ({ pendingEnableEncryption, wasMasterPasswordDialogOpen, masterPasswordDialogOpen, masterPassword }: ResumeEnableInput) => {
-	return pendingEnableEncryption && wasMasterPasswordDialogOpen && !masterPasswordDialogOpen && !!masterPassword;
-};
-
-export const shouldCancelPendingEnableAfterMasterPasswordDialog = ({ pendingEnableEncryption, wasMasterPasswordDialogOpen, masterPasswordDialogOpen, masterPassword }: ResumeEnableInput) => {
-	return pendingEnableEncryption && wasMasterPasswordDialogOpen && !masterPasswordDialogOpen && !masterPassword;
-};

packages/app-desktop/gui/ErrorBoundary.tsx

@@ -31,7 +31,8 @@ interface State {
 
 interface Props {
 	message?: string;
-	children: React.ReactNode;
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	children: any;
 }
 
 interface BannerProps {

packages/app-desktop/gui/HelpButton.tsx

@@ -6,12 +6,14 @@ import { _ } from '@joplin/lib/locale';
 
 interface Props {
 	tip: string;
-	onClick: ()=> void;
+	// eslint-disable-next-line @typescript-eslint/ban-types -- Old code before rule was applied
+	onClick: Function;
 	themeId: number;
-	style?: React.CSSProperties;
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	style: any;
 
 	'aria-controls'?: string;
-	'aria-expanded'?: boolean;
+	'aria-expanded'?: string;
 }
 
 class HelpButtonComponent extends React.Component<Props> {
@@ -29,7 +31,8 @@ class HelpButtonComponent extends React.Component<Props> {
 		const theme = themeStyle(this.props.themeId);
 		const style = { ...this.props.style, color: theme.color, textDecoration: 'none' };
 		const helpIconStyle = { flex: 0, width: 16, height: 16, marginLeft: 10 };
-		const extraProps: Record<string, string> = {};
+		// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+		const extraProps: any = {};
 		if (this.props.tip) {
 			extraProps['data-tip'] = this.props.tip;
 			extraProps['aria-description'] = this.props.tip;

packages/app-desktop/gui/IconButton.tsx

@@ -3,9 +3,11 @@ import { themeStyle } from '@joplin/lib/theme';
 
 interface Props {
 	themeId: number;
-	style?: React.CSSProperties;
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	style: any;
 	iconName: string;
-	onClick: ()=> void;
+	// eslint-disable-next-line @typescript-eslint/ban-types -- Old code before rule was applied
+	onClick: Function;
 }
 
 class IconButton extends React.Component<Props> {
@@ -18,7 +20,7 @@ class IconButton extends React.Component<Props> {
 		};
 		const icon = <i style={iconStyle} className={`fas ${this.props.iconName}`}></i>;
 
-		const rootStyle: React.CSSProperties = {
+		const rootStyle = {
 			display: 'flex',
 			textDecoration: 'none',
 			padding: 10,

packages/app-desktop/gui/MasterPasswordDialog/Dialog.tsx

@@ -41,7 +41,7 @@ export default function(props: Props) {
 		if (mode === Mode.Reset) return false;
 		return true;
 		// eslint-disable-next-line @seiyab/react-hooks/exhaustive-deps -- Old code before rule was applied
-	}, [status, mode]);
+	}, [status]);
 
 	const onClose = useCallback(() => {
 		props.dispatch({
@@ -90,12 +90,10 @@ export default function(props: Props) {
 		// eslint-disable-next-line @seiyab/react-hooks/exhaustive-deps -- Old code before rule was applied
 	}, [currentPassword, password1, onClose, mode]);
 
-	// Show the "Re-enter password" confirmation field
 	const needToRepeatPassword = useMemo(() => {
 		if (mode === Mode.Reset) return true;
-		if (showCurrentPassword) return true;
 		return !hasMasterPasswordEncryptedData;
-	}, [mode, showCurrentPassword, hasMasterPasswordEncryptedData]);
+	}, [hasMasterPasswordEncryptedData, mode]);
 
 	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 	const onCurrentPasswordChange = useCallback((event: any) => {
@@ -140,7 +138,6 @@ export default function(props: Props) {
 	}, [currentPassword]);
 
 	function renderPasswordForm() {
-		const passwordsMatch = password1 === password2;
 		const renderCurrentPassword = () => {
 			if (!showCurrentPassword) return null;
 
@@ -164,11 +161,11 @@ export default function(props: Props) {
 		const renderResetMasterPasswordLink = () => {
 			if (mode === Mode.Reset) return null;
 			if (status === MasterPasswordStatus.Valid) return null;
-			return <p><a href="#" onClick={onToggleMode}>{_('Reset master password')}</a></p>;
+			return <p><a href="#" onClick={onToggleMode}>Reset master password</a></p>;
 		};
 
 		if (showPasswordForm) {
-			const enterPasswordLabel = [MasterPasswordStatus.Loaded, MasterPasswordStatus.Valid].includes(status) ? _('Enter new password') : _('Enter password');
+			const enterPasswordLabel = [MasterPasswordStatus.Loaded, MasterPasswordStatus.Valid].includes(status) ? 'Enter new password' : 'Enter password';
 
 			return (
 				<div>
@@ -179,32 +176,22 @@ export default function(props: Props) {
 							value={password1}
 							onChange={onPasswordChange1}
 						/>
-
 						{needToRepeatPassword && (
-							<>
-								<LabelledPasswordInput
-									labelText={_('Re-enter password')}
-									value={password2}
-									onChange={onPasswordChange2}
-									valid={password2 ? passwordsMatch : undefined}
-								/>
-
-								{password2 && !passwordsMatch && (
-									<p className="error-message">
-										{_('Passwords do not match')}
-									</p>
-								)}
-							</>
+							<LabelledPasswordInput
+								labelText={_('Re-enter password')}
+								value={password2}
+								onChange={onPasswordChange2}
+							/>
 						)}
 					</div>
-					<p className="bold">{_('Please make sure you remember your password. It cannot be recovered if lost, and any data encrypted with it will become inaccessible.')}</p>
+					<p className="bold">Please make sure you remember your password. For security reasons, it is not possible to recover it if it is lost.</p>
 					{renderResetMasterPasswordLink()}
 				</div>
 			);
 		} else {
 			return (
 				<p>
-					<a onClick={onShowPasswordForm} href="#">{_('Change master password')}</a>
+					<a onClick={onShowPasswordForm} href="#">Change master password</a>
 				</p>
 			);
 		}
@@ -214,16 +201,16 @@ export default function(props: Props) {
 		if (mode === Mode.Reset) {
 			return (
 				<div className="dialog-content">
-					<p>{_('Attention: After resetting your password it will no longer be possible to decrypt any data encrypted with your current password. All encrypted shared notebooks will also be unshared, so please ask the notebook owner to share it again with you.')}</p>
+					<p>Attention: After resetting your password it will no longer be possible to decrypt any data encrypted with your current password. All encrypted shared notebooks will also be unshared, so please ask the notebook owner to share it again with you.</p>
 					{renderPasswordForm()}
 				</div>
 			);
 		} else {
 			return (
 				<div className="dialog-content">
-					<p>{_('Your master password is used to protect sensitive information. In particular, it is used to encrypt your notes when end-to-end encryption (E2EE) is enabled, or to share and encrypt notes with someone who has E2EE enabled.')}</p>
+					<p>Your master password is used to protect sensitive information. In particular, it is used to encrypt your notes when end-to-end encryption (E2EE) is enabled, or to share and encrypt notes with someone who has E2EE enabled.</p>
 					<p>
-						<span>{_('Master password status:')}</span> <span className="bold">{getMasterPasswordStatusMessage(status)}</span>
+						<span>{'Master password status:'}</span> <span className="bold">{getMasterPasswordStatusMessage(status)}</span>
 					</p>
 					{renderPasswordForm()}
 				</div>

packages/app-desktop/gui/MenuBar.tsx

@@ -709,7 +709,6 @@ function useMenu(props: Props) {
 						menuItemDic.textCut,
 						menuItemDic.textPaste,
 						menuItemDic.pasteAsText,
-						menuItemDic.pasteAsMarkdown,
 						menuItemDic.textSelectAll,
 						separator(),
 						menuItemDic.globalUndo,

packages/app-desktop/gui/NoteContentPropertiesDialog.tsx

@@ -22,21 +22,18 @@ interface KeyToLabelMap {
 	[key: string]: string;
 }
 
-let markupToHtml_: ReturnType<typeof markupLanguageUtils.newMarkupToHtml> = null;
+// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+let markupToHtml_: any = null;
 function markupToHtml() {
 	if (markupToHtml_) return markupToHtml_;
 	markupToHtml_ = markupLanguageUtils.newMarkupToHtml();
 	return markupToHtml_;
 }
 
-interface CounterResult {
-	words: number;
-	all: number;
-	characters: number;
-}
-
-function countElements(text: string, wordSetter: React.Dispatch<React.SetStateAction<number>>, characterSetter: React.Dispatch<React.SetStateAction<number>>, characterNoSpaceSetter: React.Dispatch<React.SetStateAction<number>>, cjkCharacterSetter: React.Dispatch<React.SetStateAction<number>>, lineSetter: React.Dispatch<React.SetStateAction<number>>) {
-	Countable.count(text, (counter: CounterResult) => {
+// eslint-disable-next-line @typescript-eslint/ban-types -- Old code before rule was applied
+function countElements(text: string, wordSetter: Function, characterSetter: Function, characterNoSpaceSetter: Function, cjkCharacterSetter: React.Dispatch<React.SetStateAction<number>>, lineSetter: Function) {
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	Countable.count(text, (counter: any) => {
 		wordSetter(counter.words);
 		characterSetter(counter.all);
 		characterNoSpaceSetter(counter.characters);
@@ -56,7 +53,8 @@ function formatReadTime(readTimeMinutes: number) {
 
 export default function NoteContentPropertiesDialog(props: NoteContentPropertiesDialogProps) {
 	const theme = themeStyle(props.themeId);
-	const tableBodyComps: React.JSX.Element[] = [];
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	const tableBodyComps: any[] = [];
 	// For the source Markdown
 	const [lines, setLines] = useState<number>(0);
 	const [words, setWords] = useState<number>(0);

packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/utils/useContextMenu.test.ts

@@ -6,18 +6,12 @@ describe('useContextMenu', () => {
 
 	it('should return type=image when cursor is inside markdown image', () => {
 		const line = `![alt text](:/${resourceId})`;
-		const result = getResourceIdFromMarkup(line, 15);
-		expect(result.resourceId).toBe(resourceId);
-		expect(result.type).toBe('image');
-		expect(line.substring(result.markupStart, result.markupEnd)).toBe(line);
+		expect(getResourceIdFromMarkup(line, 15)).toEqual({ resourceId, type: 'image' });
 	});
 
 	it('should return type=file when cursor is inside markdown link', () => {
 		const line = `[document.pdf](:/${resourceId})`;
-		const result = getResourceIdFromMarkup(line, 15);
-		expect(result.resourceId).toBe(resourceId);
-		expect(result.type).toBe('file');
-		expect(line.substring(result.markupStart, result.markupEnd)).toBe(line);
+		expect(getResourceIdFromMarkup(line, 15)).toEqual({ resourceId, type: 'file' });
 	});
 
 	it('should return null when cursor is outside markup', () => {
@@ -28,13 +22,8 @@ describe('useContextMenu', () => {
 
 	it('should correctly distinguish between image and file on same line', () => {
 		const line = `![image](:/${resourceId}) [file](:/${resourceId2})`;
-		const imageResult = getResourceIdFromMarkup(line, 10);
-		expect(imageResult.resourceId).toBe(resourceId);
-		expect(imageResult.type).toBe('image');
-
-		const fileResult = getResourceIdFromMarkup(line, 48);
-		expect(fileResult.resourceId).toBe(resourceId2);
-		expect(fileResult.type).toBe('file');
+		expect(getResourceIdFromMarkup(line, 10)).toEqual({ resourceId, type: 'image' });
+		expect(getResourceIdFromMarkup(line, 48)).toEqual({ resourceId: resourceId2, type: 'file' });
 	});
 
 	it('should return null for empty line', () => {

packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/utils/useContextMenu.ts

@@ -11,7 +11,7 @@ import type CodeMirrorControl from '@joplin/editor/CodeMirror/CodeMirrorControl'
 import bridge from '../../../../../services/bridge';
 import Setting from '@joplin/lib/models/Setting';
 import Resource from '@joplin/lib/models/Resource';
-import { ContextMenuItemType, ContextMenuOptions, buildMenuItems, handleEditorContextMenuFilter, resolveContextMenuItemType } from '../../../utils/contextMenuUtils';
+import { ContextMenuItemType, ContextMenuOptions, buildMenuItems, handleEditorContextMenuFilter } from '../../../utils/contextMenuUtils';
 import { menuItems } from '../../../utils/contextMenu';
 import isItemId from '@joplin/lib/models/utils/isItemId';
 import { extractResourceUrls } from '@joplin/lib/urlUtils';
@@ -22,8 +22,6 @@ export type ResourceMarkupType = 'image' | 'file';
 export interface ResourceMarkupInfo {
 	resourceId: string;
 	type: ResourceMarkupType;
-	markupStart: number;
-	markupEnd: number;
 }
 
 // Extract resource ID from resource markup (images or file attachments) at a given cursor position within a line.
@@ -76,7 +74,7 @@ export const getResourceIdFromMarkup = (lineContent: string, cursorPosInLine: nu
 			}
 
 			if (markupEnd !== -1 && cursorPosInLine >= markupStart && cursorPosInLine <= markupEnd) {
-				return { resourceId: resourceInfo.itemId, type: markupType, markupStart, markupEnd };
+				return { resourceId: resourceInfo.itemId, type: markupType };
 			}
 		}
 	}
@@ -115,9 +113,6 @@ const useContextMenu = (props: ContextMenuProps) => {
 	// It might be buggy, refer to the below issue
 	// https://github.com/laurent22/joplin/pull/3974#issuecomment-718936703
 	useEffect(() => {
-		const targetWindow = bridge().windowById(windowId);
-		if (!targetWindow) return ()=> {};
-
 		const isAncestorOfCodeMirrorEditor = (elem: Element) => {
 			for (; elem.parentElement; elem = elem.parentElement) {
 				if (elem.classList.contains(props.editorClassName)) {
@@ -166,24 +161,30 @@ const useContextMenu = (props: ContextMenuProps) => {
 			return clickedElement?.closest(`.${imageClassName}`) as HTMLElement | null;
 		};
 
-		const appendEditMenuItems = (menu: typeof Menu.prototype) => {
-			const hasSelectedText = editorRef.current && !!editorRef.current.getSelection();
-			const isReadOnly = editorRef.current?.editor?.state.readOnly ?? false;
-			menu.append(new MenuItem({ label: _('Cut'), enabled: hasSelectedText && !isReadOnly, click: () => props.editorCutText() }));
-			menu.append(new MenuItem({ label: _('Copy'), enabled: hasSelectedText, click: () => props.editorCopyText() }));
-			menu.append(new MenuItem({ label: _('Paste'), enabled: !isReadOnly, click: () => props.editorPaste() }));
-			menu.append(new MenuItem({ label: _('Paste as Markdown'), enabled: !isReadOnly, click: () => CommandService.instance().execute('pasteAsMarkdown') }));
+		// Get resource info from markup at click position (not cursor position)
+		const getResourceInfoAtClickPos = (params: ContextMenuParams): ResourceMarkupInfo | null => {
+			if (!editorRef.current) return null;
+
+			const editor = editorRef.current.editor;
+			if (!editor) return null;
+
+			const zoom = Setting.value('windowContentZoomFactor');
+			const x = convertFromScreenCoordinates(zoom, params.x);
+			const y = convertFromScreenCoordinates(zoom, params.y);
+
+			const clickPos = editor.posAtCoords({ x, y });
+			if (clickPos === null) return null;
+
+			const line = editor.state.doc.lineAt(clickPos);
+			return getResourceIdFromMarkup(line.text, clickPos - line.from);
 		};
 
+		const targetWindow = bridge().windowById(windowId);
+
 		const showResourceContextMenu = async (resourceId: string, type: ResourceMarkupType) => {
 			const menu = new Menu();
-
-			// Add resource-specific options first
-			const baseType = type === 'image' ? ContextMenuItemType.Image : ContextMenuItemType.Resource;
-			const itemType = await resolveContextMenuItemType(baseType, resourceId);
-			const isReadOnly = editorRef.current?.editor?.state.readOnly ?? false;
 			const contextMenuOptions: ContextMenuOptions = {
-				itemType,
+				itemType: type === 'image' ? ContextMenuItemType.Image : ContextMenuItemType.Resource,
 				resourceId,
 				filename: null,
 				mime: null,
@@ -191,34 +192,18 @@ const useContextMenu = (props: ContextMenuProps) => {
 				linkToOpen: null,
 				textToCopy: null,
 				htmlToCopy: null,
-				insertContent: () => { editorRef.current?.insertText(''); },
-				isReadOnly,
+				insertContent: () => {},
+				isReadOnly: true,
 				fireEditorEvent: () => {},
 				htmlToMd: null,
 				mdToHtml: null,
 			};
 
-			const resourceMenuItems = await buildMenuItems(menuItems(props.dispatch), contextMenuOptions, { excludeEditItems: true, excludePluginItems: true });
+			const resourceMenuItems = await buildMenuItems(menuItems(props.dispatch), contextMenuOptions);
 			for (const item of resourceMenuItems) {
 				menu.append(item);
 			}
 
-			// Add edit items
-			menu.append(new MenuItem({ type: 'separator' }));
-			appendEditMenuItems(menu);
-
-			// Add plugin items last
-			const extraItems = await handleEditorContextMenuFilter({
-				resourceId,
-				itemType,
-			});
-			if (extraItems.length) {
-				menu.append(new MenuItem({ type: 'separator' }));
-				for (const item of extraItems) {
-					menu.append(item);
-				}
-			}
-
 			menu.popup({ window: targetWindow });
 		};
 
@@ -240,25 +225,7 @@ const useContextMenu = (props: ContextMenuProps) => {
 			});
 		};
 
-		interface ResourceContextInfo {
-			resourceId: string;
-			type: ResourceMarkupType;
-		}
-
-		const getResourceInfoAtPos = (docPos: number): ResourceContextInfo | null => {
-			const editor = editorRef.current?.editor;
-			if (!editor) return null;
-
-			const line = editor.state.doc.lineAt(docPos);
-			const info = getResourceIdFromMarkup(line.text, docPos - line.from);
-			if (!info) return null;
-
-			return { resourceId: info.resourceId, type: info.type };
-		};
-
 		const onContextMenu = async (event: Event, params: ContextMenuParams) => {
-			let resourceInfo: ResourceContextInfo | null = null;
-
 			// Check if right-clicking on a rendered image first (images may not be "editable")
 			const imageContainer = getClickedImageContainer(params);
 			if (imageContainer && pointerInsideEditor(params, true)) {
@@ -266,40 +233,19 @@ const useContextMenu = (props: ContextMenuProps) => {
 				if (imgElement) {
 					const resourceId = pathToId(imgElement.src);
 					if (resourceId) {
+						event.preventDefault();
 						moveCursorToImageLine(imageContainer);
-						const sourceFrom = imageContainer.dataset.sourceFrom;
-						if (sourceFrom !== undefined) {
-							const editor = editorRef.current?.editor;
-							if (editor) {
-								const pos = Math.min(Number(sourceFrom), editor.state.doc.length);
-								resourceInfo = getResourceInfoAtPos(pos);
-							}
-						}
-						// Fallback if we couldn't get markup info
-						if (!resourceInfo) {
-							resourceInfo = { resourceId, type: 'image' };
-						}
+						await showResourceContextMenu(resourceId, 'image');
+						return;
 					}
 				}
 			}
 
 			// Check if right-clicking on resource markup text (images or file attachments)
-			if (!resourceInfo && pointerInsideEditor(params)) {
-				const editor = editorRef.current?.editor;
-				if (editor) {
-					const zoom = Setting.value('windowContentZoomFactor');
-					const x = convertFromScreenCoordinates(zoom, params.x);
-					const y = convertFromScreenCoordinates(zoom, params.y);
-					const clickPos = editor.posAtCoords({ x, y });
-					if (clickPos !== null) {
-						resourceInfo = getResourceInfoAtPos(clickPos);
-					}
-				}
-			}
-
-			if (resourceInfo) {
+			const markupResourceInfo = getResourceInfoAtClickPos(params);
+			if (markupResourceInfo && pointerInsideEditor(params)) {
 				event.preventDefault();
-				await showResourceContextMenu(resourceInfo.resourceId, resourceInfo.type);
+				await showResourceContextMenu(markupResourceInfo.resourceId, markupResourceInfo.type);
 				return;
 			}
 
@@ -310,7 +256,38 @@ const useContextMenu = (props: ContextMenuProps) => {
 			event.preventDefault();
 
 			const menu = new Menu();
-			appendEditMenuItems(menu);
+
+			const hasSelectedText = editorRef.current && !!editorRef.current.getSelection() ;
+
+			menu.append(
+				new MenuItem({
+					label: _('Cut'),
+					enabled: hasSelectedText,
+					click: async () => {
+						props.editorCutText();
+					},
+				}),
+			);
+
+			menu.append(
+				new MenuItem({
+					label: _('Copy'),
+					enabled: hasSelectedText,
+					click: async () => {
+						props.editorCopyText();
+					},
+				}),
+			);
+
+			menu.append(
+				new MenuItem({
+					label: _('Paste'),
+					enabled: true,
+					click: async () => {
+						props.editorPaste();
+					},
+				}),
+			);
 
 			const spellCheckerMenuItems = SpellCheckerService.instance().contextMenuItems(params.misspelledWord, params.dictionarySuggestions);
 

packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/utils/useScrollHandler.ts

@@ -221,14 +221,7 @@ const translateLE_ = (codeMirror: any, percent: number, l2e: boolean) => {
 		linInterp = percent * lineCount - lineU;
 		result = ePercentU + (ePercentL - ePercentU) * linInterp;
 	} else {
-		const rawLinInterp = (percent - ePercentU) / (ePercentL - ePercentU);
-		if (ePercentL === ePercentU) {
-			// Prevents the Viewer from jumping to the bottom of
-			// the document when there is division by zero.
-			linInterp = percent;
-		} else {
-			linInterp = Math.max(0, Math.min(1, rawLinInterp)) || 0;
-		}
+		linInterp = Math.max(0, Math.min(1, (percent - ePercentU) / (ePercentL - ePercentU))) || 0;
 		result = (lineU + linInterp) / lineCount;
 	}
 	return Math.max(0, Math.min(1, result));

packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v5/CodeMirror.tsx

@@ -338,7 +338,7 @@ function CodeMirror(props: NoteBodyEditorProps, ref: ForwardedRef<NoteBodyEditor
 	}, [editorPasteText, onEditorPaste]);
 
 	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
-	const loadScript = async (script: any, document: Document) => {
+	const loadScript = async (script: any) => {
 		return new Promise((resolve) => {
 			// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 			let element: any = document.createElement('script');
@@ -367,7 +367,6 @@ function CodeMirror(props: NoteBodyEditorProps, ref: ForwardedRef<NoteBodyEditor
 	};
 
 	useEffect(() => {
-		if (!editorRoot) return () => { };
 		let cancelled = false;
 
 		async function loadScripts() {
@@ -394,14 +393,13 @@ function CodeMirror(props: NoteBodyEditorProps, ref: ForwardedRef<NoteBodyEditor
 				});
 			}
 
-			const ownerDoc = editorRoot.ownerDocument;
 			for (const s of scriptsToLoad) {
-				if (ownerDoc.getElementById(s.id)) {
+				if (document.getElementById(s.id)) {
 					s.loaded = true;
 					continue;
 				}
 
-				await loadScript(s, ownerDoc);
+				await loadScript(s);
 				if (cancelled) return;
 
 				s.loaded = true;
@@ -413,7 +411,7 @@ function CodeMirror(props: NoteBodyEditorProps, ref: ForwardedRef<NoteBodyEditor
 		return () => {
 			cancelled = true;
 		};
-	}, [styles.editor.codeMirrorTheme, editorRoot]);
+	}, [styles.editor.codeMirrorTheme]);
 
 	useEffect(() => {
 		if (!editorRoot) return () => {};

packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/CodeMirror.tsx

@@ -1,5 +1,5 @@
 import * as React from 'react';
-import { useState, useEffect, useRef, forwardRef, useCallback, useImperativeHandle, ForwardedRef, useContext } from 'react';
+import { useState, useEffect, useRef, forwardRef, useCallback, useImperativeHandle, useMemo, ForwardedRef, useContext } from 'react';
 
 import { EditorCommand, MarkupToHtmlOptions, NoteBodyEditorProps, NoteBodyEditorRef, OnChangeEvent } from '../../../utils/types';
 import { getResourcesFromPasteEvent } from '../../../utils/resourceHandling';
@@ -12,10 +12,11 @@ import Note from '@joplin/lib/models/Note';
 import { _ } from '@joplin/lib/locale';
 import bridge from '../../../../../services/bridge';
 import shim from '@joplin/lib/shim';
+import { MarkupToHtml } from '@joplin/renderer';
 import { clipboard } from 'electron';
 import { reg } from '@joplin/lib/registry';
 import ErrorBoundary from '../../../../ErrorBoundary';
-import { SearchState, UserEventSource } from '@joplin/editor/types';
+import { EditorKeymap, EditorLanguageType, EditorSettings, SearchState, UserEventSource } from '@joplin/editor/types';
 import useStyles from '../utils/useStyles';
 import { EditorEvent, EditorEventType } from '@joplin/editor/events';
 import useScrollHandler from '../utils/useScrollHandler';
@@ -32,7 +33,6 @@ import { WindowIdContext } from '../../../../NewWindowOrIFrame';
 import eventManager, { EventName, ResourceChangeEvent } from '@joplin/lib/eventManager';
 import useSyncEditorValue from './utils/useSyncEditorValue';
 import { getGlobalSettings } from '@joplin/renderer/types';
-import useEditorSettings from './utils/useEditorSettings';
 
 const logger = Logger.create('CodeMirror6');
 const logDebug = (message: string) => logger.debug(message);
@@ -338,6 +338,46 @@ const CodeMirror = (props: NoteBodyEditorProps, ref: ForwardedRef<NoteBodyEditor
 		void CommandService.instance().execute('focusElement', 'noteTitle');
 	}, []);
 
+	const editorSettings = useMemo((): EditorSettings => {
+		const isHTMLNote = props.contentMarkupLanguage === MarkupToHtml.MARKUP_LANGUAGE_HTML;
+
+		let keyboardMode = EditorKeymap.Default;
+		if (props.keyboardMode === 'vim') {
+			keyboardMode = EditorKeymap.Vim;
+		} else if (props.keyboardMode === 'emacs') {
+			keyboardMode = EditorKeymap.Emacs;
+		}
+
+		return {
+			language: isHTMLNote ? EditorLanguageType.Html : EditorLanguageType.Markdown,
+			readOnly: props.disabled,
+			markdownMarkEnabled: Setting.value('markdown.plugin.mark'),
+			katexEnabled: Setting.value('markdown.plugin.katex'),
+			inlineRenderingEnabled: Setting.value('editor.inlineRendering'),
+			imageRenderingEnabled: Setting.value('editor.imageRendering'),
+			highlightActiveLine: Setting.value('editor.highlightActiveLine'),
+			themeData: {
+				...styles.globalTheme,
+				marginLeft: 0,
+				marginRight: 0,
+				monospaceFont: Setting.value('style.editor.monospaceFontFamily'),
+			},
+			automatchBraces: Setting.value('editor.autoMatchingBraces'),
+			autocompleteMarkup: Setting.value('editor.autocompleteMarkup'),
+			useExternalSearch: false,
+			ignoreModifiers: true,
+			spellcheckEnabled: Setting.value('editor.spellcheckBeta'),
+			keymap: keyboardMode,
+			preferMacShortcuts: shim.isMac(),
+			indentWithTabs: true,
+			tabMovesFocus: props.tabMovesFocus,
+			editorLabel: _('Markdown editor'),
+		};
+	}, [
+		props.contentMarkupLanguage, props.disabled, props.keyboardMode, styles.globalTheme,
+		props.tabMovesFocus,
+	]);
+
 	const initialCursorLocationRef = useRef(0);
 	initialCursorLocationRef.current = props.initialCursorLocation.markdown ?? 0;
 
@@ -350,14 +390,6 @@ const CodeMirror = (props: NoteBodyEditorProps, ref: ForwardedRef<NoteBodyEditor
 		initialCursorLocationRef,
 	});
 
-	const settings = useEditorSettings({
-		baseTheme: styles.globalTheme,
-		contentMarkupLanguage: props.contentMarkupLanguage,
-		disabled: props.disabled,
-		keyboardMode: props.keyboardMode,
-		tabMovesFocus: props.tabMovesFocus,
-	});
-
 	const renderEditor = () => {
 		return (
 			<div className='editor'>
@@ -367,7 +399,7 @@ const CodeMirror = (props: NoteBodyEditorProps, ref: ForwardedRef<NoteBodyEditor
 					initialSelectionRef={initialCursorLocationRef}
 					initialNoteId={props.noteId}
 					ref={editorRef}
-					settings={settings}
+					settings={editorSettings}
 					pluginStates={props.plugins}
 					onPasteFile={null}
 					onEvent={onEditorEvent}

packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/Editor.tsx

@@ -45,8 +45,8 @@ const Editor = (props: Props, ref: ForwardedRef<CodeMirrorControl>) => {
 			return () => {};
 		}
 
-		const pasteEventHandler = (_editor: unknown, ...args: unknown[]) => {
-			const event = args[0] as Event;
+		// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+		const pasteEventHandler = (_editor: any, event: Event) => {
 			props.onEditorPaste(event);
 		};
 

packages/app-desktop/gui/NoteEditor/NoteBody/CodeMirror/v6/utils/useEditorSettings.ts

@@ -1,76 +0,0 @@
-import { EditorKeymap, EditorLanguageType, EditorSettings, EditorTheme } from '@joplin/editor/types';
-import shim from '@joplin/lib/shim';
-import { MarkupLanguage, MarkupToHtml } from '@joplin/renderer';
-import { useMemo } from 'react';
-import { useSelector } from 'react-redux';
-import { AppState } from '../../../../../../app.reducer';
-import { _ } from '@joplin/lib/locale';
-import { isDeepStrictEqual } from 'node:util';
-
-interface EditorSettingsProps {
-	contentMarkupLanguage: MarkupLanguage;
-	keyboardMode: string;
-	disabled: boolean;
-	tabMovesFocus: boolean;
-	baseTheme: EditorTheme;
-}
-
-const useEditorSettings = (props: EditorSettingsProps) => {
-	const stateToSettings = (state: AppState) => ({
-		markdownMark: state.settings['markdown.plugin.mark'],
-		markdownInsert: state.settings['markdown.plugin.insert'],
-		katex: state.settings['markdown.plugin.katex'],
-		inlineRendering: state.settings['editor.inlineRendering'],
-		imageRendering: state.settings['editor.imageRendering'],
-		highlightActiveLine: state.settings['editor.highlightActiveLine'],
-		monospaceFont: state.settings['style.editor.monospaceFontFamily'],
-		automatchBraces: state.settings['editor.autoMatchingBraces'],
-		autocompleteMarkup: state.settings['editor.autocompleteMarkup'],
-		spellcheckEnabled: state.settings['editor.spellcheckBeta'],
-	});
-	type SelectedSettings = ReturnType<typeof stateToSettings>;
-	const settings = useSelector<AppState, SelectedSettings>(stateToSettings, isDeepStrictEqual);
-
-	return useMemo((): EditorSettings => {
-		const isHTMLNote = props.contentMarkupLanguage === MarkupToHtml.MARKUP_LANGUAGE_HTML;
-
-		let keyboardMode = EditorKeymap.Default;
-		if (props.keyboardMode === 'vim') {
-			keyboardMode = EditorKeymap.Vim;
-		} else if (props.keyboardMode === 'emacs') {
-			keyboardMode = EditorKeymap.Emacs;
-		}
-
-		return {
-			language: isHTMLNote ? EditorLanguageType.Html : EditorLanguageType.Markdown,
-			readOnly: props.disabled,
-			markdownMarkEnabled: settings.markdownMark,
-			markdownInsertEnabled: settings.markdownInsert,
-			katexEnabled: settings.katex,
-			inlineRenderingEnabled: settings.inlineRendering,
-			imageRenderingEnabled: settings.imageRendering,
-			highlightActiveLine: settings.highlightActiveLine,
-			themeData: {
-				...props.baseTheme,
-				marginLeft: 0,
-				marginRight: 0,
-				monospaceFont: settings.monospaceFont,
-			},
-			automatchBraces: settings.automatchBraces,
-			autocompleteMarkup: settings.autocompleteMarkup,
-			useExternalSearch: false,
-			ignoreModifiers: true,
-			spellcheckEnabled: settings.spellcheckEnabled,
-			keymap: keyboardMode,
-			preferMacShortcuts: shim.isMac(),
-			indentWithTabs: true,
-			tabMovesFocus: props.tabMovesFocus,
-			editorLabel: _('Markdown editor'),
-		};
-	}, [
-		props.contentMarkupLanguage, props.disabled, props.keyboardMode, props.baseTheme,
-		props.tabMovesFocus, settings,
-	]);
-};
-
-export default useEditorSettings;

packages/app-desktop/gui/NoteEditor/NoteBody/TinyMCE/TinyMCE.tsx

@@ -705,15 +705,6 @@ const TinyMCE = (props: NoteBodyEditorProps, ref: Ref<NoteBodyEditorRef>) => {
 
 			// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 			const containerWindow = editorContainerDom.defaultView as any;
-			const isDefaultEnglishLocale = ['en_US', 'en_GB'].includes(language);
-
-			if (!isDefaultEnglishLocale) {
-				await loadScript({
-					id: `tinyMceLang_${language}`,
-					src: `${bridge().vendorDir()}/lib/tinymce/langs/${language}.js`,
-				}, editorContainerDom);
-			}
-
 			const editors = await containerWindow.tinymce.init({
 				selector: `#${editorContainer.id}`,
 
@@ -744,7 +735,7 @@ const TinyMCE = (props: NoteBodyEditorProps, ref: Ref<NoteBodyEditorRef>) => {
 				// Handle the first table row as table header.
 				// https://www.tiny.cloud/docs/plugins/table/#table_header_type
 				table_header_type: 'sectionCells',
-				language: isDefaultEnglishLocale ? undefined : language,
+				language_url: ['en_US', 'en_GB'].includes(language) ? undefined : `${bridge().vendorDir()}/lib/tinymce/langs/${language}`,
 				toolbar: toolbar.join(' '),
 				localization_function: _,
 				// See https://www.tiny.cloud/docs/tinymce/latest/tinymce-and-csp/#content_security_policy
@@ -896,30 +887,6 @@ const TinyMCE = (props: NoteBodyEditorProps, ref: Ref<NoteBodyEditorRef>) => {
 					editor.addShortcut('Meta+Shift+8', '', () => editor.execCommand('InsertUnorderedList'));
 					editor.addShortcut('Meta+Shift+9', '', () => editor.execCommand('InsertJoplinChecklist'));
 
-					// Override ScrollIntoView to scroll to the cursor's character position
-					// instead of the start of the paragraph.
-					// See: https://github.com/laurent22/joplin/issues/14143
-					editor.on('ScrollIntoView', (event) => {
-						const sel = editor.getDoc().getSelection();
-						if (!sel || sel.rangeCount === 0) return;
-
-						const rect = sel.getRangeAt(0).getBoundingClientRect();
-						const win = editor.getWin();
-						const viewHeight = win.innerHeight;
-
-						if (rect.top < 0) {
-							win.scrollBy(0, rect.top);
-						} else if (rect.bottom > viewHeight) {
-							win.scrollBy(0, rect.bottom - viewHeight);
-						} else if (rect.top === 0 && rect.height === 0) {
-							// Handles edge case where rect is not rendered
-							// See: https://stackoverflow.com/a/14384220/5757550
-							return;
-						}
-						event.preventDefault();
-						return;
-					});
-
 					// TODO: remove event on unmount?
 					editor.on('drop', (event) => {
 						// Prevent the message "Dropped file type is not supported" from showing up.
@@ -1359,35 +1326,13 @@ const TinyMCE = (props: NoteBodyEditorProps, ref: Ref<NoteBodyEditorRef>) => {
 
 		// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 		const onSetAttrib = (event: EditorEvent<any>) => {
-			// Dispatch onChange when a link or table-related formatting is edited
+			// Dispatch onChange when a link is edited
 			const target = Array.isArray(event.attrElm) ? event.attrElm[0] : event.attrElm;
-			if (!target) return;
-
 			if (target.nodeName === 'A') {
 				if (event.attrName === 'title' || event.attrName === 'href' || event.attrName === 'rel') {
 					onChangeHandler();
 				}
 			}
-
-			if (['TABLE', 'TR', 'TD', 'TH'].includes(target.nodeName)) {
-				const attributeName = (event.attrName ?? '').toLowerCase();
-				if (
-					attributeName === 'style' ||
-					attributeName === 'class' ||
-					attributeName === 'bgcolor' ||
-					attributeName === 'bordercolor' ||
-					attributeName === 'background' ||
-					attributeName === 'cellpadding' ||
-					attributeName === 'cellspacing'
-				) {
-					onChangeHandler();
-				}
-			}
-		};
-
-		// Table plugin fires this on structure/style changes from dialogs.
-		const onTableModified = () => {
-			onChangeHandler();
 		};
 
 		// Keypress means that a printable key (letter, digit, etc.) has been
@@ -1536,7 +1481,6 @@ const TinyMCE = (props: NoteBodyEditorProps, ref: Ref<NoteBodyEditorRef>) => {
 		editor.on(TinyMceEditorEvents.Redo, onChangeHandler);
 		editor.on(TinyMceEditorEvents.ExecCommand, onExecCommand);
 		editor.on(TinyMceEditorEvents.SetAttrib, onSetAttrib);
-		editor.on('TableModified', onTableModified);
 
 		return () => {
 			try {
@@ -1553,7 +1497,6 @@ const TinyMCE = (props: NoteBodyEditorProps, ref: Ref<NoteBodyEditorRef>) => {
 				editor.off(TinyMceEditorEvents.Redo, onChangeHandler);
 				editor.off(TinyMceEditorEvents.ExecCommand, onExecCommand);
 				editor.off(TinyMceEditorEvents.SetAttrib, onSetAttrib);
-				editor.off('TableModified', onTableModified);
 			} catch (error) {
 				console.warn('Error removing events', error);
 			}

packages/app-desktop/gui/NoteEditor/NoteBody/TinyMCE/utils/useContextMenu.ts

@@ -35,10 +35,8 @@ export default function(editor: Editor, plugins: PluginStates, dispatch: Dispatc
 	useEffect(() => {
 		if (!editor) return () => {};
 
-		const targetWindow = bridge().windowById(windowId);
-		if (!targetWindow) return () => {};
-
 		const contextMenuItems = menuItems(dispatch);
+		const targetWindow = bridge().windowById(windowId);
 
 		const makeMainMenuItems = async (element: Element) => {
 			let itemType: ContextMenuItemType = ContextMenuItemType.None;

packages/app-desktop/gui/NoteEditor/commands/focusElementNoteTitle.ts

@@ -1,7 +1,6 @@
 import { CommandRuntime, CommandDeclaration } from '@joplin/lib/services/CommandService';
 import { _ } from '@joplin/lib/locale';
 import { focus } from '@joplin/lib/utils/focusHandler';
-import { RefObject } from 'react';
 
 export const declaration: CommandDeclaration = {
 	name: 'focusElementNoteTitle',
@@ -9,7 +8,8 @@ export const declaration: CommandDeclaration = {
 	parentLabel: () => _('Focus'),
 };
 
-export const runtime = (comp: { titleInputRef: RefObject<HTMLInputElement> }): CommandRuntime => {
+// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+export const runtime = (comp: any): CommandRuntime => {
 	return {
 		execute: async () => {
 			if (!comp.titleInputRef.current) return;

packages/app-desktop/gui/NoteEditor/commands/index.ts

@@ -3,7 +3,6 @@ import * as focusElementNoteBody from './focusElementNoteBody';
 import * as focusElementNoteTitle from './focusElementNoteTitle';
 import * as focusElementNoteViewer from './focusElementNoteViewer';
 import * as focusElementToolbar from './focusElementToolbar';
-import * as pasteAsMarkdown from './pasteAsMarkdown';
 import * as pasteAsText from './pasteAsText';
 import * as showLocalSearch from './showLocalSearch';
 import * as showRevisions from './showRevisions';
@@ -13,7 +12,6 @@ const index: any[] = [
 	focusElementNoteTitle,
 	focusElementNoteViewer,
 	focusElementToolbar,
-	pasteAsMarkdown,
 	pasteAsText,
 	showLocalSearch,
 	showRevisions,

packages/app-desktop/gui/NoteEditor/commands/pasteAsMarkdown.ts

@@ -1,42 +0,0 @@
-import { CommandRuntime, CommandDeclaration } from '@joplin/lib/services/CommandService';
-import { _ } from '@joplin/lib/locale';
-import HtmlToMd from '@joplin/lib/HtmlToMd';
-import { processImagesInPastedHtml } from '../utils/resourceHandling';
-
-const { clipboard } = require('electron');
-
-export const declaration: CommandDeclaration = {
-	name: 'pasteAsMarkdown',
-	label: () => _('Paste as Markdown'),
-};
-
-let htmlToMd_: HtmlToMd | null = null;
-
-const htmlToMd = () => {
-	if (!htmlToMd_) {
-		htmlToMd_ = new HtmlToMd();
-	}
-	return htmlToMd_;
-};
-
-// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Props passed from NoteEditor component
-export const runtime = (comp: any): CommandRuntime => {
-	return {
-		execute: async () => {
-			let html = clipboard.readHTML();
-			if (html) {
-				// Download images and convert them to Joplin resources
-				html = await processImagesInPastedHtml(html, { useInternalUrls: true });
-				const markdown = htmlToMd().parse(html, { tightLists: true, collapseMultipleBlankLines: true });
-				comp.editorRef.current.execCommand({ name: 'insertText', value: markdown });
-			} else {
-				// Fall back to plain text if no HTML is available
-				const text = clipboard.readText();
-				if (text) {
-					comp.editorRef.current.execCommand({ name: 'insertText', value: text });
-				}
-			}
-		},
-		enabledCondition: 'oneNoteSelected && markdownEditorVisible',
-	};
-};

packages/app-desktop/gui/NoteEditor/utils/contextMenu.ts

@@ -103,17 +103,10 @@ export function menuItems(dispatch: Function): ContextMenuItems {
 				}
 			},
 			isActive: (itemType: ContextMenuItemType, options: ContextMenuOptions) => (
-				(!options.textToCopy && (itemType === ContextMenuItemType.Image || itemType === ContextMenuItemType.Resource || itemType === ContextMenuItemType.NoteLink))
+				(!options.textToCopy && (itemType === ContextMenuItemType.Image || itemType === ContextMenuItemType.Resource))
 				|| (!!options.linkToOpen && itemType === ContextMenuItemType.Link)
 			),
 		},
-		openNoteInNewWindow: {
-			label: _('Open in new window'),
-			onAction: async (options: ContextMenuOptions) => {
-				await CommandService.instance().execute('openNoteInNewWindow', options.resourceId);
-			},
-			isActive: (itemType: ContextMenuItemType) => itemType === ContextMenuItemType.NoteLink,
-		},
 		saveAs: {
 			label: _('Save as...'),
 			onAction: async (options: ContextMenuOptions) => {

packages/app-desktop/gui/NoteEditor/utils/contextMenuUtils.ts

@@ -6,8 +6,6 @@ import { ContextMenuItemType, EditContextMenuFilterObject } from '@joplin/lib/se
 import eventManager from '@joplin/lib/eventManager';
 import CommandService from '@joplin/lib/services/CommandService';
 import { type MenuItem as MenuItemType } from 'electron';
-import BaseItem from '@joplin/lib/models/BaseItem';
-import { ModelType } from '@joplin/lib/BaseModel';
 
 const MenuItem = bridge().MenuItem;
 const logger = Logger.create('contextMenuUtils');
@@ -15,19 +13,6 @@ const logger = Logger.create('contextMenuUtils');
 // Re-export for backward compatibility
 export { ContextMenuItemType };
 
-// Resolves whether a resource-type item is actually a note link.
-// Falls back to Resource on error or if the item is not found.
-export const resolveContextMenuItemType = async (itemType: ContextMenuItemType, resourceId: string): Promise<ContextMenuItemType> => {
-	if (itemType !== ContextMenuItemType.Resource || !resourceId) return itemType;
-	try {
-		const item = await BaseItem.loadItemById(resourceId);
-		if (item?.type_ === ModelType.Note) return ContextMenuItemType.NoteLink;
-	} catch (error) {
-		logger.warn('resolveContextMenuItemType: failed to load item, defaulting to Resource', error);
-	}
-	return ContextMenuItemType.Resource;
-};
-
 export interface ContextMenuOptions {
 	itemType: ContextMenuItemType;
 	resourceId: string;
@@ -197,48 +182,39 @@ export const handleEditorContextMenuFilter = async (context?: EditorContextMenuF
 	return output;
 };
 
-export interface BuildMenuItemsOptions {
-	excludeEditItems?: boolean;
-	excludePluginItems?: boolean;
-}
-
-export const buildMenuItems = async (items: ContextMenuItems, options: ContextMenuOptions, buildOptions?: BuildMenuItemsOptions) => {
-	const editItemKeys = ['cut', 'copy', 'paste', 'pasteAsText', 'separator4'];
+export const buildMenuItems = async (items: ContextMenuItems, options: ContextMenuOptions) => {
 	const activeItems: ContextMenuItem[] = [];
 	for (const itemKey in items) {
-		if (buildOptions?.excludeEditItems && editItemKeys.includes(itemKey)) continue;
 		const item = items[itemKey];
 		if (item.isActive(options.itemType, options)) {
 			activeItems.push(item);
 		}
 	}
 
-	if (!buildOptions?.excludePluginItems) {
-		const extraItems = await handleEditorContextMenuFilter({
-			resourceId: options.resourceId,
-			itemType: options.itemType,
-			textToCopy: options.textToCopy,
+	const extraItems = await handleEditorContextMenuFilter({
+		resourceId: options.resourceId,
+		itemType: options.itemType,
+		textToCopy: options.textToCopy,
+	});
+
+	if (extraItems.length) {
+		activeItems.push({
+			isActive: () => true,
+			label: '',
+			onAction: () => {},
+			isSeparator: true,
 		});
+	}
 
-		if (extraItems.length) {
-			activeItems.push({
-				isActive: () => true,
-				label: '',
-				onAction: () => {},
-				isSeparator: true,
-			});
-		}
-
-		for (const [, extraItem] of extraItems.entries()) {
-			activeItems.push({
-				isActive: () => true,
-				label: extraItem.label,
-				onAction: () => {
-					extraItem.click();
-				},
-				isSeparator: extraItem.type === 'separator',
-			});
-		}
+	for (const [, extraItem] of extraItems.entries()) {
+		activeItems.push({
+			isActive: () => true,
+			label: extraItem.label,
+			onAction: () => {
+				extraItem.click();
+			},
+			isSeparator: extraItem.type === 'separator',
+		});
 	}
 
 	const filteredItems = filterSeparators(activeItems, item => item.isSeparator);

packages/app-desktop/gui/NoteEditor/utils/index.ts

@@ -13,7 +13,6 @@ export async function htmlToMarkdown(markupLanguage: number, html: string, origi
 		newBody = htmlToMd.parse(html, {
 			preserveImageTagsWithSize: true,
 			preserveNestedTables: true,
-			preserveTableStyles: true,
 			preserveColorStyles: true,
 			...parseOptions,
 		});

packages/app-desktop/gui/NoteEditor/utils/resourceHandling.test.ts

@@ -1,23 +1,8 @@
 import Setting from '@joplin/lib/models/Setting';
-import { processImagesInPastedHtml, processPastedHtml, getResourcesFromPasteEvent } from './resourceHandling';
+import { processPastedHtml } from './resourceHandling';
 import markupLanguageUtils from '@joplin/lib/markupLanguageUtils';
 import HtmlToMd from '@joplin/lib/HtmlToMd';
 import { HtmlToMarkdownHandler, MarkupToHtmlHandler } from './types';
-import { setupDatabaseAndSynchronizer, switchClient } from '@joplin/lib/testing/test-utils';
-
-jest.mock('electron', () => ({
-	clipboard: {
-		has: jest.fn(),
-		readBuffer: jest.fn(),
-	},
-}));
-
-interface ClipboardMock {
-	has: jest.Mock;
-	readBuffer: jest.Mock;
-}
-
-const mockClipboard = (require('electron') as { clipboard: ClipboardMock }).clipboard;
 
 const createTestMarkupConverters = () => {
 	const markupToHtml: MarkupToHtmlHandler = async (markupLanguage, markup, options) => {
@@ -37,11 +22,6 @@ const createTestMarkupConverters = () => {
 };
 
 describe('resourceHandling', () => {
-	afterEach(() => {
-		mockClipboard.has.mockReset();
-		mockClipboard.readBuffer.mockReset();
-	});
-
 	it('should sanitize pasted HTML', async () => {
 		Setting.setConstant('resourceDir', '/home/.config/joplin/resources');
 
@@ -83,104 +63,4 @@ describe('resourceHandling', () => {
 		const html = `<img src="file://${encodeURI(Setting.value('resourceDir'))}/resource.png" alt="test"/>`;
 		expect(await processPastedHtml(html, htmlToMd, markupToHtml)).toBe(html);
 	});
-
-	it('should normalize HTML-encoded newlines in image alt attributes', async () => {
-		// Word encodes newlines in alt text as &#10; HTML entities. These must be
-		// normalized to spaces before Turndown processes the HTML, otherwise
-		// node.outerHTML (returned verbatim for images with width/height) embeds
-		// literal newlines that break Markdown raw HTML block parsing.
-		const resourceSrc = `file://${encodeURI(Setting.value('resourceDir'))}/resource.png`;
-		const testCases: [string, string][] = [
-			// HTML entity newlines (Word clipboard format: &#10; = LF)
-			[
-				`<img src="${resourceSrc}" alt="A screenshot&#10;&#10;AI-generated content."/>`,
-				`<img src="${resourceSrc}" alt="A screenshot AI-generated content."/>`,
-			],
-			// Literal newlines in the raw HTML attribute value
-			[
-				`<img src="${resourceSrc}" alt="hello\nworld"/>`,
-				`<img src="${resourceSrc}" alt="hello world"/>`,
-			],
-		];
-
-		for (const [html, expected] of testCases) {
-			expect(await processPastedHtml(html, null, null)).toBe(expected);
-		}
-	});
-
-	it('should render Word-pasted images with newlines in alt as img elements, not broken text', async () => {
-		// When Word pastes an image with width/height attributes and &#10; in the alt,
-		// Turndown returns node.outerHTML verbatim (preserveImageTagsWithSize=true).
-		// Without normalization, literal newlines inside the Markdown raw HTML block
-		// would terminate the block early, causing the <img> to render as plain text.
-		const { markupToHtml, htmlToMd } = createTestMarkupConverters();
-		const resourceSrc = `file://${encodeURI(Setting.value('resourceDir'))}/resource.png`;
-
-		const testCases = [
-			// Word-style: width/height present, alt has &#10; entities
-			`<img width="625" height="284" src="${resourceSrc}" alt="A screenshot&#10;&#10;AI-generated content."/>`,
-			// Multiple consecutive newline entities collapsed to single space
-			`<img width="100" height="100" src="${resourceSrc}" alt="line1&#10;&#13;&#10;line2"/>`,
-		];
-
-		for (const html of testCases) {
-			const result = await processPastedHtml(html, htmlToMd, markupToHtml);
-			// The image must be rendered as an <img> element, not as escaped/broken text
-			expect(result).toContain('<img');
-			// The alt text after normalization must not contain literal newlines
-			expect(result).not.toMatch(/alt="[^"]*\n/);
-		}
-	});
-
-	// Regression test: base64 branch was hardcoding file:// and ignoring useInternalUrls
-	// 1x1 transparent PNG — smallest valid base64-encoded image for testing
-	const minimalPng = 'iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mNk+M9QDwADhgGAWjR9awAAAABJRU5ErkJggg==';
-
-	test.each([
-		{ useInternalUrls: true, expectMatch: /src=":\/[a-f0-9]+"/, expectAbsent: 'file://' },
-		{ useInternalUrls: false, expectMatch: /src="file:\/\//, expectAbsent: 'data:' },
-	])('should convert base64 image using resourceUrl (useInternalUrls=$useInternalUrls)', async ({ useInternalUrls, expectMatch, expectAbsent }) => {
-		await setupDatabaseAndSynchronizer(1);
-		await switchClient(1);
-		const html = `<img src="data:image/png;base64,${minimalPng}"/>`;
-		const result = await processImagesInPastedHtml(html, { useInternalUrls });
-		expect(result).toMatch(expectMatch);
-		expect(result).not.toContain(expectAbsent);
-		expect(result).not.toContain('data:');
-	});
-
-	// Tests for getResourcesFromPasteEvent - clipboard image paste (issue #14613)
-	// The test environment (non-Electron, no sharp) skips image validation and
-	// just copies the file, so any non-empty buffer works as test data.
-	const testImageBuffer = Buffer.from(minimalPng, 'base64');
-
-	test.each([
-		{ format: 'image/jpeg', description: 'JPEG (bug #14613)' },
-		{ format: 'image/jpg', description: 'JPG alias' },
-		{ format: 'image/png', description: 'PNG (regression check)' },
-	])('should paste $description image from clipboard via getResourcesFromPasteEvent', async ({ format }) => {
-		await setupDatabaseAndSynchronizer(1);
-		await switchClient(1);
-		mockClipboard.has.mockImplementation((f: string) => f === format);
-		mockClipboard.readBuffer.mockImplementation((f: string) => {
-			return f === format ? testImageBuffer : Buffer.alloc(0);
-		});
-		const mockEvent = { preventDefault: jest.fn() };
-		const result = await getResourcesFromPasteEvent(mockEvent);
-		expect(result.length).toBe(1);
-		expect(result[0]).toContain('](:/');
-		expect(mockEvent.preventDefault).toHaveBeenCalledTimes(1);
-	});
-
-	test.each([
-		{ description: 'clipboard has no image', hasResult: false },
-		{ description: 'buffer is empty despite has() returning true', hasResult: true },
-	])('should return empty when $description', async ({ hasResult }) => {
-		mockClipboard.has.mockReturnValue(hasResult);
-		mockClipboard.readBuffer.mockReturnValue(Buffer.alloc(0));
-		const mockEvent = { preventDefault: jest.fn() };
-		const result = await getResourcesFromPasteEvent(mockEvent);
-		expect(result).toEqual([]);
-		expect(mockEvent.preventDefault).not.toHaveBeenCalled();
-	});
 });

packages/app-desktop/gui/NoteEditor/utils/resourceHandling.ts

@@ -2,7 +2,6 @@ import shim from '@joplin/lib/shim';
 import Setting from '@joplin/lib/models/Setting';
 import Note from '@joplin/lib/models/Note';
 import Resource from '@joplin/lib/models/Resource';
-import { ResourceEntity } from '@joplin/lib/services/database/types';
 import ResourceFetcher from '@joplin/lib/services/ResourceFetcher';
 import htmlUtils from '@joplin/lib/htmlUtils';
 import rendererHtmlUtils, { extractHtmlBody, removeWrappingParagraphAndTrailingEmptyElements } from '@joplin/renderer/htmlUtils';
@@ -93,59 +92,38 @@ export function resourcesStatus(resourceInfos: any) {
 // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
 export async function getResourcesFromPasteEvent(event: any) {
 	const output = [];
+	const formats = clipboard.availableFormats();
+	for (let i = 0; i < formats.length; i++) {
+		const format = formats[i].toLowerCase();
+		const formatType = format.split('/')[0];
 
-	// clipboard.has() and readBuffer() are used instead of availableFormats() and
-	// readImage(), which don't work for JPEG on Linux.
-	// https://github.com/laurent22/joplin/issues/14613
-	const supportedFormats = ['image/png', 'image/jpeg', 'image/jpg'];
-
-	for (const format of supportedFormats) {
-		if (!clipboard.has(format)) continue;
-
-		const data = clipboard.readBuffer(format);
-		if (!data || data.length === 0) continue;
-
-		if (event) event.preventDefault();
-
-		const fileExt = mimeUtils.toFileExtension(format);
-		const filePath = `${Setting.value('tempDir')}/${md5(Date.now() + Math.random())}.${fileExt}`;
-
-		let md = null;
-		try {
-			await shim.fsDriver().writeFile(filePath, data, 'buffer');
-			md = await commandAttachFileToBody('', [filePath]);
-		} finally {
-			try {
-				await shim.fsDriver().remove(filePath);
-			} catch (cleanupError) {
-				logger.warn('getResourcesFromPasteEvent: Failed to remove temporary file.', cleanupError);
+		if (formatType === 'image') {
+			// writeImageToFile can process only image/jpeg, image/jpg or image/png mime types
+			if (['image/png', 'image/jpg', 'image/jpeg'].indexOf(format) < 0) {
+				continue;
 			}
-		}
+			if (event) event.preventDefault();
 
-		if (md) {
-			output.push(md);
-			break;
+			const image = clipboard.readImage();
+
+			const fileExt = mimeUtils.toFileExtension(format);
+			const filePath = `${Setting.value('tempDir')}/${md5(Date.now())}.${fileExt}`;
+
+			await shim.writeImageToFile(image, format, filePath);
+			const md = await commandAttachFileToBody('', [filePath]);
+			await shim.fsDriver().remove(filePath);
+
+			if (md) output.push(md);
 		}
 	}
 	return output;
 }
 
 
-export interface ProcessImagesOptions {
-	// When true, returns Joplin internal URLs (:/resourceId) instead of file:// URLs
-	useInternalUrls?: boolean;
-}
-
-export const processImagesInPastedHtml = async (html: string, options: ProcessImagesOptions = {}) => {
+const processImagesInPastedHtml = async (html: string) => {
 	const allImageUrls: string[] = [];
 	const mappedResources: Record<string, string> = {};
 
-	const resourceUrl = (resource: ResourceEntity) => {
-		return options.useInternalUrls
-			? Resource.internalUrl(resource)
-			: `file://${encodeURI(Resource.fullPath(resource))}`;
-	};
-
 	htmlUtils.replaceImageUrls(html, (src: string) => {
 		allImageUrls.push(src);
 	});
@@ -160,7 +138,7 @@ export const processImagesInPastedHtml = async (html: string, options: ProcessIm
 			await shim.fetchBlob(imageSrc, { path: filePath });
 			const createdResource = await shim.createResourceFromPath(filePath);
 			await shim.fsDriver().remove(filePath);
-			mappedResources[imageSrc] = resourceUrl(createdResource);
+			mappedResources[imageSrc] = `file://${encodeURI(Resource.fullPath(createdResource))}`;
 		} catch (error) {
 			logger.warn(`Error creating a resource for ${imageSrc}.`, error);
 			mappedResources[imageSrc] = imageSrc;
@@ -177,49 +155,14 @@ export const processImagesInPastedHtml = async (html: string, options: ProcessIm
 					const imageFilePath = path.normalize(fileUriToPath(imageSrc));
 					const resourceDirPath = path.normalize(Setting.value('resourceDir'));
 
-					// Use path.relative for robust containment check - startsWith can falsely match sibling paths
-					const rel = path.relative(resourceDirPath, imageFilePath);
-					const isInsideResourceDir = rel && !rel.startsWith('..') && !path.isAbsolute(rel);
-					if (isInsideResourceDir) {
-						if (options.useInternalUrls) {
-							const resourceId = Resource.pathToId(imageFilePath);
-							mappedResources[imageSrc] = `:/${resourceId}`;
-						} else {
-							mappedResources[imageSrc] = imageSrc;
-						}
+					if (imageFilePath.startsWith(resourceDirPath)) {
+						mappedResources[imageSrc] = imageSrc;
 					} else {
 						const createdResource = await shim.createResourceFromPath(imageFilePath);
-						mappedResources[imageSrc] = resourceUrl(createdResource);
+						mappedResources[imageSrc] = `file://${encodeURI(Resource.fullPath(createdResource))}`;
 					}
 				} else if (imageSrc.startsWith('data:')) {
-					// Word encodes base64 with MIME line breaks every ~76 chars.
-					// Strip whitespace before decoding, then save as a Joplin resource
-					// so Turndown's outerHTML (used for images with width/height) gets
-					// a short URL instead of 200KB of base64.
-					const cleanSrc = imageSrc.replace(/\s/g, '');
-					const dataUrlMatch = cleanSrc.match(/^data:((?!image\/svg\+xml)[^;]+);base64,(.+)$/);
-					if (dataUrlMatch) {
-						const mimeType = dataUrlMatch[1];
-						const base64Data = dataUrlMatch[2];
-						const fileExt = mimeUtils.toFileExtension(mimeType) || 'bin';
-						const filePath = `${Setting.value('tempDir')}/${md5(Date.now() + Math.random())}.${fileExt}`;
-						try {
-							await shim.fsDriver().writeFile(filePath, base64Data, 'base64');
-							const createdResource = await shim.createResourceFromPath(filePath);
-							mappedResources[imageSrc] = resourceUrl(createdResource);
-						} catch (writeError) {
-							writeError.message = `processPastedHtml: Failed to write or create resource from pasted image: ${writeError.message}`;
-							throw writeError;
-						} finally {
-							try {
-								await shim.fsDriver().remove(filePath);
-							} catch (cleanupError) {
-								logger.warn('processPastedHtml: Error removing temporary file.', cleanupError);
-							}
-						}
-					} else {
-						mappedResources[imageSrc] = imageSrc;
-					}
+					mappedResources[imageSrc] = imageSrc;
 				} else {
 					downloadImages.push(downloadImage(imageSrc));
 				}
@@ -245,27 +188,6 @@ export async function processPastedHtml(html: string, htmlToMd: HtmlToMarkdownHa
 
 	html = await processImagesInPastedHtml(html);
 
-	// Word encodes newlines in alt attributes as HTML entities (&#10; &#13; &#xA; etc.).
-	// These get decoded to literal newline characters by JSDOM when Turndown processes
-	// the HTML. With preserveImageTagsWithSize=true, Turndown returns node.outerHTML
-	// verbatim — embedding literal newlines inside an HTML attribute value, which
-	// breaks the Markdown raw HTML block (a blank line ends the block, making the
-	// parser treat the <img> as plain text). Normalize them to spaces here.
-	html = html.replace(
-		/(\balt\s*=\s*)(["'])([\s\S]*?)\2/gi,
-		(_m, prefix, quote, altText) => {
-			// Replace HTML-encoded newlines/control chars and literal ones with a space
-			const normalized = altText
-				.replace(/&#(?:10|13);|&#x(?:0*[aAdD]);/gi, ' ')
-				// biome-ignore lint/suspicious/noControlCharactersInRegex: intentional sanitisation of control chars
-				// eslint-disable-next-line no-control-regex
-				.replace(/[\r\n\x00-\x08\x0B\x0C\x0E-\x1F\x7F]/g, ' ')
-				.replace(/ {2,}/g, ' ')
-				.trim();
-			return `${prefix}${quote}${normalized}${quote}`;
-		},
-	);
-
 	// TinyMCE can accept any type of HTML, including HTML that may not be preserved once saved as
 	// Markdown. For example the content may have a dark background which would be supported by
 	// TinyMCE, but lost once the note is saved. So here we convert the HTML to Markdown then back

packages/app-desktop/gui/NoteEditor/utils/useMessageHandler.ts

@@ -6,7 +6,6 @@ import PostMessageService from '@joplin/lib/services/PostMessageService';
 import ResourceFetcher from '@joplin/lib/services/ResourceFetcher';
 import { reg } from '@joplin/lib/registry';
 import bridge from '../../../services/bridge';
-import { resolveContextMenuItemType } from './contextMenuUtils';
 
 export default function useMessageHandler(
 	scrollWhenReadyRef: RefObject<ScrollOptions|null>,
@@ -47,11 +46,9 @@ export default function useMessageHandler(
 			if (s.length < 2) throw new Error(`Invalid message: ${msg}`);
 			void ResourceFetcher.instance().markForDownload(s[1]);
 		} else if (msg === 'contextMenu') {
-			const resourceId = arg0.resourceId;
-			const itemType = await resolveContextMenuItemType(arg0 && arg0.type, resourceId);
 			const menu = await contextMenu({
-				itemType,
-				resourceId: resourceId,
+				itemType: arg0 && arg0.type,
+				resourceId: arg0.resourceId,
 				filename: arg0.filename,
 				mime: arg0.mime,
 				linkToOpen: null,

packages/app-desktop/gui/NoteEditor/utils/useWindowCommandHandler.ts

@@ -13,7 +13,6 @@ const commandsWithDependencies = [
 	require('../commands/focusElementNoteViewer'),
 	require('../commands/focusElementToolbar'),
 	require('../commands/pasteAsText'),
-	require('../commands/pasteAsMarkdown'),
 ];
 
 type OnBodyChange = (event: OnChangeEvent)=> void;

packages/app-desktop/gui/NoteList/NoteList2.tsx

@@ -30,8 +30,6 @@ import useFocusVisible from './utils/useFocusVisible';
 import { stateUtils } from '@joplin/lib/reducer';
 import { connect } from 'react-redux';
 import useOnNoteDoubleClick from './utils/useOnNoteDoubleClick';
-import useAutoScroll from './utils/useAutoScroll';
-import useRefocusOnDeletion from './utils/useRefocusOnDeletion';
 
 const commands = {
 	focusElementNoteList,
@@ -75,7 +73,6 @@ const NoteList = (props: Props) => {
 
 	const { activeNoteId, setActiveNoteId } = useActiveDescendantId(props.selectedFolderId, props.selectedNoteIds);
 	const focusNote = useFocusNote(listRef, props.notes, makeItemIndexVisible, setActiveNoteId);
-	useRefocusOnDeletion(props.notes.length, props.selectedNoteIds, props.focusedField, props.selectedFolderId, focusNote);
 
 	const moveNote = useMoveNote(
 		props.notesParentType,
@@ -134,10 +131,6 @@ const NoteList = (props: Props) => {
 		};
 	}, [focusNote]);
 
-	const selectedNoteId = props.selectedNoteIds.length === 1 ? props.selectedNoteIds[0] : '';
-	const targetIndex = props.notes.findIndex(note => note.id === selectedNoteId);
-	useAutoScroll(selectedNoteId, props.selectedFolderId, targetIndex, makeItemIndexVisible);
-
 	const onItemContextMenu = useOnContextMenu(
 		props.selectedNoteIds,
 		props.selectedFolderId,

packages/app-desktop/gui/NoteList/utils/UseAutoScroll.test.ts

@@ -1,106 +0,0 @@
-import useAutoScroll from './useAutoScroll';
-import { renderHook } from '@testing-library/react';
-
-type Props = {
-	selectedNoteId: string;
-	selectedFolderId: string;
-	targetIndex: number;
-	makeItemIndexVisible: (index: number)=> void;
-};
-
-describe('useAutoScroll', () => {
-
-	test('scrolls to the note when a new note is selected', () => {
-		const makeItemIndexVisible = jest.fn();
-
-		renderHook(() => useAutoScroll('note-1', 'folder-1', 5, makeItemIndexVisible));
-
-		expect(makeItemIndexVisible).toHaveBeenCalledTimes(1);
-		expect(makeItemIndexVisible).toHaveBeenCalledWith(5);
-	});
-
-	test('does not scroll when the same note is already selected', () => {
-		const makeItemIndexVisible = jest.fn();
-
-		const { rerender } = renderHook(() =>
-			useAutoScroll('note-1', 'folder-1', 5, makeItemIndexVisible),
-		);
-
-		makeItemIndexVisible.mockClear();
-		rerender();
-
-		expect(makeItemIndexVisible).not.toHaveBeenCalled();
-	});
-
-	test('does not scroll for multi-selection or no selection', () => {
-		const makeItemIndexVisible = jest.fn();
-
-		renderHook(() => useAutoScroll('', 'folder-1', -1, makeItemIndexVisible));
-
-		expect(makeItemIndexVisible).not.toHaveBeenCalled();
-	});
-
-	test('defers scroll until notes load after folder change', () => {
-		const makeItemIndexVisible = jest.fn();
-
-		const { rerender } = renderHook(
-			(props: Props) => useAutoScroll(
-				props.selectedNoteId,
-				props.selectedFolderId,
-				props.targetIndex,
-				props.makeItemIndexVisible,
-			),
-			{ initialProps: { selectedNoteId: 'note-1', selectedFolderId: 'folder-2', targetIndex: -1, makeItemIndexVisible } },
-		);
-
-		expect(makeItemIndexVisible).not.toHaveBeenCalled();
-
-		rerender({ selectedNoteId: 'note-1', selectedFolderId: 'folder-2', targetIndex: 3, makeItemIndexVisible });
-
-		expect(makeItemIndexVisible).toHaveBeenCalledTimes(1);
-		expect(makeItemIndexVisible).toHaveBeenCalledWith(3);
-	});
-
-	test('scrolls again when the folder changes even if note ID is the same', () => {
-		const makeItemIndexVisible = jest.fn();
-
-		const { rerender } = renderHook(
-			(props: Props) => useAutoScroll(
-				props.selectedNoteId,
-				props.selectedFolderId,
-				props.targetIndex,
-				props.makeItemIndexVisible,
-			),
-			{ initialProps: { selectedNoteId: 'note-1', selectedFolderId: 'folder-1', targetIndex: 2, makeItemIndexVisible } },
-		);
-
-		expect(makeItemIndexVisible).toHaveBeenCalledTimes(1);
-
-		rerender({ selectedNoteId: 'note-1', selectedFolderId: 'folder-2', targetIndex: 2, makeItemIndexVisible });
-
-		expect(makeItemIndexVisible).toHaveBeenCalledTimes(2);
-	});
-
-	test('does not scroll again when targetIndex changes after the pending flag is cleared', () => {
-		// Covers the case where a sort or filter changes targetIndex without a new selection.
-		// Without this guard, arrow-key navigation would trigger a spurious second scroll.
-		const makeItemIndexVisible = jest.fn();
-
-		const { rerender } = renderHook(
-			(props: Props) => useAutoScroll(
-				props.selectedNoteId,
-				props.selectedFolderId,
-				props.targetIndex,
-				props.makeItemIndexVisible,
-			),
-			{ initialProps: { selectedNoteId: 'note-1', selectedFolderId: 'folder-1', targetIndex: 5, makeItemIndexVisible } },
-		);
-
-		expect(makeItemIndexVisible).toHaveBeenCalledTimes(1);
-
-		rerender({ selectedNoteId: 'note-1', selectedFolderId: 'folder-1', targetIndex: 7, makeItemIndexVisible });
-
-		expect(makeItemIndexVisible).toHaveBeenCalledTimes(1);
-	});
-
-});

packages/app-desktop/gui/NoteList/utils/useAutoScroll.ts

@@ -1,43 +0,0 @@
-import { useRef, useEffect } from 'react';
-
-// Auto-scrolls the note list to the selected note when selection changes. Uses a pending flag
-// to handle cross-folder navigation where notes may not be loaded on the first render.
-const useAutoScroll = (
-	selectedNoteId: string,
-	selectedFolderId: string,
-	targetIndex: number,
-	makeItemIndexVisible: (index: number)=> void,
-) => {
-	const lastNoteIdRef = useRef('');
-	const lastFolderIdRef = useRef('');
-	const scrollPendingRef = useRef(false); // true when scroll requested but notes not yet loaded
-
-	useEffect(() => {
-		// No selection or multi-selection — reset tracking state.
-		if (!selectedNoteId) {
-			lastNoteIdRef.current = '';
-			lastFolderIdRef.current = selectedFolderId;
-			scrollPendingRef.current = false;
-			return;
-		}
-
-		const isNewNote = selectedNoteId !== lastNoteIdRef.current;
-		const isFolderChange = selectedFolderId !== lastFolderIdRef.current;
-
-		if (isNewNote || isFolderChange) {
-			lastNoteIdRef.current = selectedNoteId;
-			lastFolderIdRef.current = selectedFolderId;
-			scrollPendingRef.current = true;
-		}
-
-		// targetIndex is -1 until the new folder's notes load — re-runs automatically when they do.
-		if (!scrollPendingRef.current || targetIndex === -1) return;
-
-		// makeItemIndexVisible has its own visibility guard and is a no-op when the note is
-		// already visible — this covers arrow-key and click navigation without double-scrolling.
-		makeItemIndexVisible(targetIndex);
-		scrollPendingRef.current = false;
-	}, [selectedNoteId, selectedFolderId, targetIndex, makeItemIndexVisible]);
-};
-
-export default useAutoScroll;

packages/app-desktop/gui/NoteList/utils/useRefocusOnDeletion.test.ts

@@ -1,41 +0,0 @@
-import { renderHook } from '@testing-library/react';
-import useRefocusOnDeletion from './useRefocusOnDeletion';
-
-describe('useRefocusOnDeletion', () => {
-	it('should refocus when a note is deleted in the same folder', () => {
-		const focusNote = jest.fn();
-		const { rerender } = renderHook(
-			({ noteCount }: { noteCount: number }) =>
-				useRefocusOnDeletion(noteCount, ['note-1'], '', 'folder-1', focusNote),
-			{ initialProps: { noteCount: 3 } },
-		);
-		rerender({ noteCount: 2 });
-		expect(focusNote).toHaveBeenCalledWith('note-1');
-	});
-
-	test.each([
-		['note count increases', 2, 3, '', ['note-1']],
-		['another field has focus', 3, 2, 'editor', ['note-1']],
-		['multiple notes are selected', 3, 2, '', ['note-1', 'note-2']],
-	])('should not refocus when %s', (_label, initialCount, newCount, focusedField, noteIds) => {
-		const focusNote = jest.fn();
-		const { rerender } = renderHook(
-			({ noteCount }: { noteCount: number }) =>
-				useRefocusOnDeletion(noteCount, noteIds, focusedField, 'folder-1', focusNote),
-			{ initialProps: { noteCount: initialCount } },
-		);
-		rerender({ noteCount: newCount });
-		expect(focusNote).not.toHaveBeenCalled();
-	});
-
-	it('should not refocus when switching to a folder with fewer notes', () => {
-		const focusNote = jest.fn();
-		const { rerender } = renderHook(
-			({ noteCount, folderId }: { noteCount: number; folderId: string }) =>
-				useRefocusOnDeletion(noteCount, ['note-1'], '', folderId, focusNote),
-			{ initialProps: { noteCount: 3, folderId: 'folder-1' } },
-		);
-		rerender({ noteCount: 2, folderId: 'folder-2' });
-		expect(focusNote).not.toHaveBeenCalled();
-	});
-});

packages/app-desktop/gui/NoteList/utils/useRefocusOnDeletion.ts

@@ -1,20 +0,0 @@
-import { useEffect } from 'react';
-import usePrevious from '@joplin/lib/hooks/usePrevious';
-const useRefocusOnDeletion = (
-	noteCount: number,
-	selectedNoteIds: string[],
-	focusedField: string,
-	selectedFolderId: string,
-	focusNote: (noteId: string)=> void,
-) => {
-	const previousNoteCount = usePrevious(noteCount, 0);
-	const previousFolderId = usePrevious(selectedFolderId, '');
-	useEffect(() => {
-		const noteWasRemoved = noteCount < previousNoteCount;
-		const folderDidNotChange = selectedFolderId === previousFolderId;
-		if (noteWasRemoved && folderDidNotChange && selectedNoteIds.length === 1 && !focusedField) {
-			focusNote(selectedNoteIds[0]);
-		}
-	}, [noteCount, previousNoteCount, selectedNoteIds, focusedField, selectedFolderId, previousFolderId, focusNote]);
-};
-export default useRefocusOnDeletion;

packages/app-desktop/gui/NoteListControls/NoteListControls.tsx

@@ -6,7 +6,7 @@ import Button, { ButtonLevel, ButtonSize, buttonSizePx } from '../Button/Button'
 import CommandService from '@joplin/lib/services/CommandService';
 import { runtime as focusSearchRuntime } from './commands/focusSearch';
 import Note from '@joplin/lib/models/Note';
-import { notesSortOrderNextField } from '@joplin/lib/services/sortOrder/notesSortOrderUtils';
+import { notesSortOrderNextField } from '../../services/sortOrder/notesSortOrderUtils';
 import { _ } from '@joplin/lib/locale';
 import { connect } from 'react-redux';
 import styled from 'styled-components';
@@ -284,11 +284,9 @@ interface ConnectProps {
 const mapStateToProps = (state: AppState, ownProps: ConnectProps) => {
 	const whenClauseContext = stateToWhenClauseContext(state, { windowId: ownProps.windowId });
 	const windowState = stateUtils.windowStateById(state, ownProps.windowId);
-	const hasFolderForNewNotes = whenClauseContext.selectedFolderIsValid
-		&& windowState.selectedFolderId !== getTrashFolderId();
 
 	return {
-		showNewNoteButtons: hasFolderForNewNotes,
+		showNewNoteButtons: windowState.selectedFolderId !== getTrashFolderId(),
 		newNoteButtonEnabled: CommandService.instance().isEnabled('newNote', whenClauseContext),
 		newTodoButtonEnabled: CommandService.instance().isEnabled('newTodo', whenClauseContext),
 		sortOrderButtonsVisible: state.settings['notes.sortOrder.buttonsVisible'],

packages/app-desktop/gui/NoteListHeader/NoteListHeaderItem.tsx

@@ -54,16 +54,7 @@ export default (props: Props) => {
 			classes.push(props.isReverse ? 'fa-chevron-down' : 'fa-chevron-up');
 			chevron = <i className={classes.join(' ')}></i>;
 		}
-		const title = getColumnTitle(column.name);
-		let titleElement: React.ReactNode = title;
-
-		if (column.name === 'note.checkboxes') {
-			titleElement = <i className="fas fa-adjust" aria-label={title} title={title}></i>;
-		} else if (column.name === 'note.is_todo') {
-			titleElement = <i className="fas fa-check" aria-label={title} title={title}></i>;
-		}
-
-		return <span className="titlewrapper">{titleElement}{chevron}</span>;
+		return <span className="titlewrapper">{getColumnTitle(column.name, true)}{chevron}</span>;
 	};
 
 	const renderResizer = () => {
@@ -86,7 +77,6 @@ export default (props: Props) => {
 			draggable={true}
 			className={classes.join(' ')}
 			style={style}
-			title={getColumnTitle(column.name)}
 			onClick={onClick}
 			onDragStart={props.onDragStart}
 			onDragOver={props.onDragOver}

packages/app-desktop/gui/NoteListHeader/utils/getColumnTitle.ts

@@ -16,6 +16,14 @@ const titles: Record<ColumnName, ()=> string> = {
 	'note.user_updated_time': () => _('Updated'),
 };
 
-export default (name: ColumnName) => {
-	return titles[name]();
+const titlesForHeader: Partial<Record<ColumnName, ()=> string>> = {
+	'note.checkboxes': () => '◐',
+	'note.is_todo': () => '✓',
+};
+
+export default (name: ColumnName, forHeader = false) => {
+	let fn: ()=> string = null;
+	if (forHeader) fn = titlesForHeader[name];
+	if (!fn) fn = titles[name];
+	return fn ? fn() : name;
 };

packages/app-desktop/gui/NoteListItem/NoteListItem.tsx

@@ -4,7 +4,8 @@ import { ItemFlow, ListRenderer, NoteListColumns, OnChangeEvent, OnChangeHandler
 import { Size } from '@joplin/utils/types';
 import useRootElement from './utils/useRootElement';
 import useItemElement from './utils/useItemElement';
-import { ItemEventHandlers, OnInputChange } from './utils/types';
+import useItemEventHandlers from './utils/useItemEventHandlers';
+import { OnInputChange } from './utils/types';
 import Note from '@joplin/lib/models/Note';
 import { NoteEntity } from '@joplin/lib/services/database/types';
 import useRenderedNote from './utils/useRenderedNote';
@@ -71,9 +72,7 @@ const NoteListItem = (props: NoteItemProps, ref: LegacyRef<HTMLDivElement>) => {
 
 	const renderedNote = useRenderedNote(props.note, props.isSelected, props.isWatched, props.listRenderer, props.highlightedWords, props.index, props.columns);
 
-	const itemEventHandlers = useMemo((): ItemEventHandlers => ({ onInputChange, onClick: null }), [onInputChange]);
-
-	useItemElement(
+	const itemElement = useItemElement(
 		rootElement,
 		noteId,
 		renderedNote ? renderedNote.html : '',
@@ -83,9 +82,9 @@ const NoteListItem = (props: NoteItemProps, ref: LegacyRef<HTMLDivElement>) => {
 		props.onClick,
 		props.onDoubleClick,
 		props.flow,
-		itemEventHandlers,
 	);
 
+	useItemEventHandlers(rootElement, itemElement, onInputChange, null);
 
 	const className = useMemo(() => {
 		return [

packages/app-desktop/gui/NoteListItem/utils/types.ts

@@ -2,8 +2,3 @@ import * as React from 'react';
 
 export type OnInputChange = (event: React.ChangeEvent<HTMLInputElement>)=> void;
 export type OnClick = (event: React.MouseEvent<HTMLElement>)=> void;
-
-export type ItemEventHandlers = {
-	onInputChange: OnInputChange;
-	onClick: OnClick | null;
-};

packages/app-desktop/gui/NoteListItem/utils/useItemElement.test.ts

@@ -1,67 +0,0 @@
-import { act, renderHook } from '@testing-library/react';
-import { ItemFlow } from '@joplin/lib/services/plugins/api/noteListType';
-import useItemElement from './useItemElement';
-import * as React from 'react';
-
-const defaultProps = {
-	noteId: 'note-1',
-	noteHtml: '<span>Test content</span>',
-	focusVisible: false,
-	style: { height: '24px' } as React.CSSProperties,
-	itemSize: { width: 200, height: 24 },
-	onClick: jest.fn(),
-	onDoubleClick: jest.fn(),
-	flow: ItemFlow.TopToBottom,
-};
-
-const defaultItemEventHandlers = { onInputChange: jest.fn(), onClick: null as import('./types').OnClick | null };
-
-describe('useItemElement', () => {
-	let rootElement: HTMLDivElement;
-
-	beforeEach(() => {
-		rootElement = document.createElement('div');
-		document.body.appendChild(rootElement);
-		defaultProps.onClick.mockClear();
-		defaultProps.onDoubleClick.mockClear();
-	});
-
-	afterEach(() => {
-		rootElement.remove();
-	});
-
-	test('returns a ref (no setState, avoids "Maximum update depth exceeded")', () => {
-		const { result } = renderHook(
-			() => useItemElement(rootElement, defaultProps.noteId, defaultProps.noteHtml, defaultProps.focusVisible, defaultProps.style, defaultProps.itemSize, defaultProps.onClick, defaultProps.onDoubleClick, defaultProps.flow, defaultItemEventHandlers),
-		);
-
-		expect(result.current).toHaveProperty('current');
-	});
-
-	test('assigns created element to ref.current and cleanup nulls ref and removes element', () => {
-		const { result, unmount } = renderHook(
-			() => useItemElement(rootElement, defaultProps.noteId, defaultProps.noteHtml, false, defaultProps.style, defaultProps.itemSize, defaultProps.onClick, defaultProps.onDoubleClick, defaultProps.flow, defaultItemEventHandlers),
-		);
-
-		act(() => {});
-
-		const el = result.current.current;
-		expect(el).toBeInstanceOf(HTMLDivElement);
-		expect(rootElement.contains(el)).toBe(true);
-
-		unmount();
-
-		expect(result.current.current).toBeNull();
-		expect(rootElement.contains(el as Node)).toBe(false);
-	});
-
-	test('does nothing when rootElement is null', () => {
-		const { result } = renderHook(
-			() => useItemElement(null, defaultProps.noteId, defaultProps.noteHtml, false, defaultProps.style, defaultProps.itemSize, defaultProps.onClick, defaultProps.onDoubleClick, defaultProps.flow, defaultItemEventHandlers),
-		);
-
-		act(() => {});
-
-		expect(result.current.current).toBeNull();
-	});
-});

packages/app-desktop/gui/NoteListItem/utils/useItemElement.ts

@@ -1,65 +1,12 @@
 import * as React from 'react';
 import { Size } from '@joplin/utils/types';
-import { useEffect, useRef } from 'react';
+import { useEffect, useState } from 'react';
 import { ItemFlow } from '@joplin/lib/services/plugins/api/noteListType';
-import { ItemEventHandlers } from './types';
-
-const addItemEventListeners = (
-	element: HTMLElement,
-	listeners: ItemEventHandlers,
-	onClick: React.MouseEventHandler<HTMLDivElement>,
-	onDoubleClick: React.MouseEventHandler<HTMLDivElement>,
-): { cleanup: ()=> void } => {
-	const processedInputs: HTMLInputElement[] = [];
-	const processedButtons: HTMLButtonElement[] = [];
-
-	const inputs = element.getElementsByTagName('input');
-	for (const input of inputs) {
-		if (input.type === 'checkbox' || input.type === 'text') {
-			// eslint-disable-next-line @typescript-eslint/no-explicit-any -- we're mixing React synthetic events with DOM events which ideally should not be done but it is fine in this particular case
-			input.addEventListener('change', listeners.onInputChange as any);
-			processedInputs.push(input);
-		}
-	}
-
-	const buttons = element.getElementsByTagName('button');
-	if (listeners.onClick) {
-		for (const button of buttons) {
-			// eslint-disable-next-line @typescript-eslint/no-explicit-any -- we're mixing React synthetic events with DOM events which ideally should not be done but it is fine in this particular case
-			button.addEventListener('click', listeners.onClick as any);
-			processedButtons.push(button);
-		}
-	}
-
-	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- we're mixing React synthetic events with DOM events which ideally should not be done but it is fine in this particular case
-	const clickHandler = (e: MouseEvent) => onClick(e as any);
-	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- we're mixing React synthetic events with DOM events which ideally should not be done but it is fine in this particular case
-	const dblclickHandler = (e: MouseEvent) => onDoubleClick(e as any);
-	element.addEventListener('click', clickHandler);
-	element.addEventListener('dblclick', dblclickHandler);
-
-	return {
-		cleanup: () => {
-			for (const input of processedInputs) {
-				// eslint-disable-next-line @typescript-eslint/no-explicit-any -- we're mixing React synthetic events with DOM events which ideally should not be done but it is fine in this particular case
-				input.removeEventListener('change', listeners.onInputChange as any);
-			}
-			if (listeners.onClick) {
-				for (const button of processedButtons) {
-					// eslint-disable-next-line @typescript-eslint/no-explicit-any -- we're mixing React synthetic events with DOM events which ideally should not be done but it is fine in this particular case
-					button.removeEventListener('click', listeners.onClick as any);
-				}
-			}
-			element.removeEventListener('click', clickHandler);
-			element.removeEventListener('dblclick', dblclickHandler);
-		},
-	};
-};
 
 const useItemElement = (
-	rootElement: HTMLDivElement | null, noteId: string, noteHtml: string, focusVisible: boolean, style: React.CSSProperties, itemSize: Size, onClick: React.MouseEventHandler<HTMLDivElement>, onDoubleClick: React.MouseEventHandler<HTMLDivElement>, flow: ItemFlow, itemEventHandlers: ItemEventHandlers,
+	rootElement: HTMLDivElement, noteId: string, noteHtml: string, focusVisible: boolean, style: React.CSSProperties, itemSize: Size, onClick: React.MouseEventHandler<HTMLDivElement>, onDoubleClick: React.MouseEventHandler<HTMLDivElement>, flow: ItemFlow,
 ) => {
-	const itemElement = useRef<HTMLDivElement>(null);
+	const [itemElement, setItemElement] = useState<HTMLDivElement>(null);
 
 	useEffect(() => {
 		if (!rootElement) return () => {};
@@ -74,28 +21,29 @@ const useItemElement = (
 		if (flow === ItemFlow.LeftToRight) element.style.width = `${itemSize.width}px`;
 		element.style.height = `${itemSize.height}px`;
 		element.innerHTML = noteHtml;
-
-		const { cleanup } = addItemEventListeners(element, itemEventHandlers, onClick, onDoubleClick);
+		// eslint-disable-next-line @typescript-eslint/no-explicit-any -- we're mixing React synthetic events with DOM events which ideally should not be done but it is fine in this particular case
+		element.addEventListener('click', onClick as any);
+		// eslint-disable-next-line @typescript-eslint/no-explicit-any -- we're mixing React synthetic events with DOM events which ideally should not be done but it is fine in this particular case
+		element.addEventListener('dblclick', onDoubleClick as any);
 
 		rootElement.appendChild(element);
-		itemElement.current = element;
+
+		setItemElement(element);
 
 		return () => {
-			cleanup();
-			itemElement.current = null;
 			element.remove();
 		};
-	}, [rootElement, itemSize, noteHtml, noteId, flow, style, onClick, onDoubleClick, itemEventHandlers]);
+	}, [rootElement, itemSize, noteHtml, noteId, style, onClick, onDoubleClick, flow]);
 
 	useEffect(() => {
-		const element = itemElement.current;
-		if (!element) return;
+		if (!itemElement) return;
+
 		if (focusVisible) {
-			element.classList.add('-focus-visible');
+			itemElement.classList.add('-focus-visible');
 		} else {
-			element.classList.remove('-focus-visible');
+			itemElement.classList.remove('-focus-visible');
 		}
-	}, [focusVisible]);
+	}, [focusVisible, itemElement]);
 
 	return itemElement;
 };

packages/app-desktop/gui/NoteListItem/utils/useItemEventHandlers.ts

@@ -0,0 +1,57 @@
+import { OnClick, OnInputChange } from './types';
+import { useEffect } from 'react';
+
+const useItemEventHandlers = (rootElement: HTMLDivElement, itemElement: HTMLDivElement, onInputChange: OnInputChange, onClick: OnClick) => {
+	useEffect(() => {
+		if (!itemElement) return () => {};
+
+		const inputs = itemElement.getElementsByTagName('input');
+
+		const processedCheckboxes: HTMLInputElement[] = [];
+		const processedTextInputs: HTMLInputElement[] = [];
+
+		for (const input of inputs) {
+			if (input.type === 'checkbox') {
+				// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+				input.addEventListener('change', onInputChange as any);
+				processedCheckboxes.push(input);
+			}
+
+			if (input.type === 'text') {
+				// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+				input.addEventListener('change', onInputChange as any);
+				processedTextInputs.push(input);
+			}
+		}
+
+		const buttons = itemElement.getElementsByTagName('button');
+		const processedButtons: HTMLButtonElement[] = [];
+
+		if (onClick) {
+			for (const button of buttons) {
+				// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+				button.addEventListener('click', onClick as any);
+				processedButtons.push(button);
+			}
+		}
+
+		return () => {
+			for (const input of processedCheckboxes) {
+				// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+				input.removeEventListener('change', onInputChange as any);
+			}
+
+			for (const input of processedTextInputs) {
+				// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+				input.removeEventListener('change', onInputChange as any);
+			}
+
+			for (const button of processedButtons) {
+				// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+				button.removeEventListener('click', onClick as any);
+			}
+		};
+	}, [itemElement, rootElement, onInputChange, onClick]);
+};
+
+export default useItemEventHandlers;

packages/app-desktop/gui/NoteListItem/utils/useRenderedNote.ts

@@ -18,7 +18,8 @@ interface RenderedNote {
 	html: string;
 }
 
-const hashContent = (content: unknown) => {
+// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+const hashContent = (content: any) => {
 	return createHash('sha1').update(JSON.stringify(content)).digest('hex');
 };
 

packages/app-desktop/gui/NoteListWrapper/NoteListWrapper.tsx

@@ -60,7 +60,7 @@ const useNoteListControlsBreakpoints = (width: number, newNoteButtonElement: Ele
 	const [dynamicBreakpoints, setDynamicBreakpoints] = useState<Breakpoints>({ Sm: BaseBreakpoint.Sm, Md: BaseBreakpoint.Md, Lg: BaseBreakpoint.Lg, Xl: BaseBreakpoint.Xl });
 	const previousWidth = usePrevious(width);
 	const widthHasChanged = width !== previousWidth;
-	const showNewNoteButton = !!selectedFolderId && selectedFolderId !== getTrashFolderId();
+	const showNewNoteButton = selectedFolderId !== getTrashFolderId();
 
 	// Initialize language-specific breakpoints
 	useEffect(() => {

packages/app-desktop/gui/NotePropertiesDialog.tsx

@@ -45,7 +45,7 @@ interface State {
 const uniqueId = (key: string) => `note-properties-dialog-${key}`;
 
 const isPropertyDatetimeRelated = (key: string) => {
-	return key === 'user_created_time' || key === 'user_updated_time' || key === 'deleted_time' || key === 'todo_completed';
+	return key === 'user_created_time' || key === 'user_updated_time' || key === 'deleted_time';
 };
 
 class NotePropertiesDialog extends React.Component<Props, State> {
@@ -317,7 +317,7 @@ class NotePropertiesDialog extends React.Component<Props, State> {
 		const styles = this.styles(this.props.themeId);
 		const theme = themeStyle(this.props.themeId);
 		const labelText = this.formatLabel(key);
-		const labelComp = <label htmlFor={uniqueId(key)} style={{ ...theme.textStyle, ...theme.controlBoxLabel }}>{labelText}</label>;
+		const labelComp = <label htmlFor={uniqueId(key)} role='rowheader' style={{ ...theme.textStyle, ...theme.controlBoxLabel }}>{labelText}</label>;
 		let controlComp = null;
 		let editComp = null;
 		let editCompHandler = null;
@@ -422,11 +422,11 @@ class NotePropertiesDialog extends React.Component<Props, State> {
 					textOverflow: 'ellipsis',
 					display: 'inline-block',
 				};
-				controlComp = displayedValue ? (
+				controlComp = (
 					<a href="#" onClick={() => bridge().openExternal(url)} style={urlStyle}>
 						{displayedValue}
 					</a>
-				) : null;
+				);
 			} else if (key === 'revisionsLink') {
 				controlComp = (
 					<a href="#" onClick={this.revisionsLink_click} style={theme.urlStyle}>
@@ -468,10 +468,10 @@ class NotePropertiesDialog extends React.Component<Props, State> {
 		}
 
 		return (
-			<tr key={key} style={theme.controlBox} className="note-property-box">
-				<th>{labelComp}</th>
-				<td>{controlComp} {editComp}</td>
-			</tr>
+			<div role='row' key={key} style={theme.controlBox} className="note-property-box">
+				{labelComp}
+				<span role='cell'>{controlComp} {editComp}</span>
+			</div>
 		);
 	}
 
@@ -497,12 +497,10 @@ class NotePropertiesDialog extends React.Component<Props, State> {
 
 		return (
 			<Dialog onCancel={this.props.onClose}>
-				<h1 style={theme.dialogTitle} id='note-properties-dialog-title'>{_('Note properties')}</h1>
-				<table aria-labelledby='note-properties-dialog-title'>
-					<tbody>
-						{noteComps}
-					</tbody>
-				</table>
+				<div style={theme.dialogTitle} id='note-properties-dialog-title'>{_('Note properties')}</div>
+				<div role='table' aria-labelledby='note-properties-dialog-title'>
+					{noteComps}
+				</div>
 				<DialogButtonRow
 					themeId={this.props.themeId}
 					okButtonShow={!this.isReadOnly()}

packages/app-desktop/gui/NoteRevisionViewer.tsx

@@ -157,10 +157,7 @@ const NoteRevisionViewerComponent: React.FC<Props> = ({ themeId, noteId, onBack,
 		// if (msg !== 'percentScroll') console.info(`Got ipc-message: ${msg}`, args);
 
 		try {
-			if (msg.indexOf('checkboxclick:') === 0) {
-				// Revision previews are read-only. Ignore checkbox toggle IPC messages so they
-				// don't fall through to URL handling (`checkboxclick:` looks like a protocol).
-			} else if (msg.indexOf('joplin://') === 0) {
+			if (msg.indexOf('joplin://') === 0) {
 				throw new Error(_('Unsupported link or message: %s', msg));
 			} else if (urlUtils.urlProtocol(msg)) {
 				await bridge().openExternal(msg);

packages/app-desktop/gui/NoteSearchBar.tsx

@@ -5,22 +5,28 @@ import { focus } from '@joplin/lib/utils/focusHandler';
 
 interface Props {
 	themeId: number;
-	onNext: ()=> void;
-	onPrevious: ()=> void;
-	onClose: ()=> void;
-	onChange: (query: string)=> void;
+	// eslint-disable-next-line @typescript-eslint/ban-types -- Old code before rule was applied
+	onNext: Function;
+	// eslint-disable-next-line @typescript-eslint/ban-types -- Old code before rule was applied
+	onPrevious: Function;
+	// eslint-disable-next-line @typescript-eslint/ban-types -- Old code before rule was applied
+	onClose: Function;
+	// eslint-disable-next-line @typescript-eslint/ban-types -- Old code before rule was applied
+	onChange: Function;
 	query: string;
 	searching: boolean;
 	resultCount: number;
 	selectedIndex: number;
 	visiblePanes: string[];
 	editorType: string;
-	style: React.CSSProperties;
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	style: any;
 }
 
 class NoteSearchBar extends React.Component<Props> {
 
-	private backgroundColor: string;
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	private backgroundColor: any;
 	private searchInputRef: React.RefObject<HTMLInputElement>;
 
 	public constructor(props: Props) {
@@ -50,7 +56,8 @@ class NoteSearchBar extends React.Component<Props> {
 		return style;
 	}
 
-	public buttonIconComponent(iconName: string, clickHandler: ()=> void, isEnabled: boolean) {
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	public buttonIconComponent(iconName: string, clickHandler: any, isEnabled: boolean) {
 		const theme = themeStyle(this.props.themeId);
 
 		const searchButton = {
@@ -78,12 +85,14 @@ class NoteSearchBar extends React.Component<Props> {
 		);
 	}
 
-	private searchInput_change(event: React.ChangeEvent<HTMLInputElement>) {
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	private searchInput_change(event: any) {
 		const query = event.currentTarget.value;
 		this.triggerOnChange(query);
 	}
 
-	private searchInput_keyDown(event: React.KeyboardEvent<HTMLInputElement>) {
+	// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Old code before rule was applied
+	private searchInput_keyDown(event: any) {
 		if (event.keyCode === 13) {
 			// ENTER
 			event.preventDefault();
@@ -105,7 +114,7 @@ class NoteSearchBar extends React.Component<Props> {
 		if (event.keyCode === 70) {
 			// F key
 			if (event.ctrlKey) {
-				event.currentTarget.select();
+				event.target.select();
 			}
 		}
 	}