self-hosted/oncall
1
0
Fork 0
mirror of https://github.com/linkedin/oncall.git synced 2025-11-29 23:38:17 +02:00
Code Issues Releases Activity

Group schedule events by role as well as chronologically (#218)

Browse Source 
Break ties based on roles
This commit is contained in:
Daniel Wang
2018-10-04 10:53:00 -07:00
committed by Joe Gillotti
parent c98962d7b6
commit c05869581d
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/oncall/scheduler/default.py
View File

@@ -326,8 +326,8 @@ class Scheduler(object):
self.set_last_epoch(schedule['id'], last_epoch, cursor)
# Create events in the db, associating a user to them
# Iterate through events in order of start time to properly assign users
for schedule, epoch in sorted(events, key=lambda x: min(ev['start'] for ev in x[1])):
# Iterate through events in order of (start time, role) to properly assign users
for schedule, epoch in sorted(events, key=lambda x: (min(ev['start'] for ev in x[1]), x[0]['role_id'])):
user_id = self.find_next_user_id(schedule, epoch, cursor)
if not user_id:
logger.info('Failed to find available user')