virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-01-13 21:28:01 +02:00
Code Issues Releases Activity

avfilter/palettegen: use AV_QSORT()

Browse Source 
This makes the sorting of the colors along an axis (r, g or b)
predictible, and thus testable under FATE. The performance is not really
an issue here since the function is called only once at the end and will
need to sort very small number of entries, so an alternative would be to
make the sorting functions (see DECLARE_CMP_FUNC()) fallback on another
axis in case of equality. This approach was actually simpler.

I don't know if there is any advantage in using a multidimensional sort,
but it will affect the final palette one way or another.
This commit is contained in:
Clément Bœsch 2015-02-25 16:06:34 +01:00
parent 30f4e9d3d9
commit 321de03492
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libavfilter/vf_palettegen.c
View File

@ -25,6 +25,7 @@
#include "libavutil/avassert.h"
#include "libavutil/opt.h"
#include "libavutil/qsort.h"
#include "avfilter.h"
#include "internal.h"
@ -352,7 +353,8 @@ static AVFrame *get_palette_frame(AVFilterContext *ctx)
/* sort the range by its longest axis if it's not already sorted */
if (box->sorted_by != longest) {
qsort(&s->refs[box->start], box->len, sizeof(*s->refs), cmp_funcs[longest]);
cmp_func cmpf = cmp_funcs[longest];
AV_QSORT(&s->refs[box->start], box->len, const struct color_ref *, cmpf);
box->sorted_by = longest;
}