You've already forked FFmpeg
							
							
				mirror of
				https://github.com/FFmpeg/FFmpeg.git
				synced 2025-10-30 23:18:11 +02:00 
			
		
		
		
	pcx: round up in bits->bytes conversion in a buffer size check
Fixes invalid reads. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind CC:libav-stable@libav.org
This commit is contained in:
		| @@ -109,7 +109,7 @@ static int pcx_decode_frame(AVCodecContext *avctx, void *data, int *got_frame, | ||||
|     nplanes            = buf[65]; | ||||
|     bytes_per_scanline = nplanes * bytes_per_line; | ||||
|  | ||||
|     if (bytes_per_scanline < w * bits_per_pixel * nplanes / 8 || | ||||
|     if (bytes_per_scanline < (w * bits_per_pixel * nplanes + 7) / 8 || | ||||
|         (!compressed && bytes_per_scanline > buf_size / h)) { | ||||
|         av_log(avctx, AV_LOG_ERROR, "PCX data is corrupted\n"); | ||||
|         return AVERROR_INVALIDDATA; | ||||
|   | ||||
		Reference in New Issue
	
	Block a user