forgejo: make aarch64 asm linter part of pre-commit

Needed some minor semantical changes to the shell wrapper, since
pre-commit expects it to exit with an error when applying fixes.

.forgejo/pre-commit/config.yaml

@@ -18,6 +18,14 @@ repos:
     - id: fix-byte-order-marker
     - id: mixed-line-ending
     - id: trailing-whitespace
+- repo: local
+  hooks:
+    - id: aarch64-asm-indent
+      name: fix aarch64 assembly indentation
+      files: ^.*/aarch64/.*\.S$
+      language: script
+      entry: ./tools/check_arm_indent.sh --apply
+      pass_filenames: false
 - repo: https://github.com/codespell-project/codespell
   rev: v2.4.1
   hooks:

.forgejo/workflows/lint.yml

@@ -24,5 +24,3 @@ jobs:
           key: pre-commit-${{ steps.install.outputs.envhash }}
       - name: Run pre-commit CI
         run: ~/pre-commit/bin/pre-commit run -c .forgejo/pre-commit/config.yaml --show-diff-on-failure --color=always --all-files
-      - name: Check aarch64 assembly indentation
-        run: ./tools/check_arm_indent.sh

tools/check_arm_indent.sh

@@ -39,12 +39,13 @@ for i in */aarch64/*.S */aarch64/*/*.S; do
         # Skip files with known (and tolerated) deviations from the tool.
         continue
     esac
-    cat $i | ./tools/indent_arm_assembly.pl > tmp.S
-    if [ -n "$apply" ]; then
-        mv tmp.S $i
-        continue
-    fi
-    if ! PAGER=cat git diff --no-index $i tmp.S; then
+    ./tools/indent_arm_assembly.pl < "$i" > tmp.S || ret=$?
+    if ! git diff --quiet --no-index "$i" tmp.S; then
+        if [ -n "$apply" ]; then
+            mv tmp.S "$i"
+        else
+            git --no-pager diff --no-index "$i" tmp.S
+        fi
         ret=1
     fi
 done