virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2024-11-21 10:55:51 +02:00
Code Issues Releases Activity

avcodec/aptx: Use AVCodecContext.frame_size according to the API

Browse Source 
Currently the APTX (HD) codecs set frame_size if unset and check
whether it is divisible by block_size (corresponding to block_align
as used by other codecs). But this is based upon a misunderstanding
of the API: frame_size is not in bytes, but in samples.

Said value is also not intended to be set by the user at all,
but set by encoders and (possibly) decoders if the number of channels
in a frame is constant. The latter condition is not fulfilled here,
so only set it for encoders. Given that the encoder can handle any
number of samples as long as it is divisible by four and given that
it worked to set a custom frame size before, the encoders accept
any multiple of four; otherwise the value is set to the value
that it already had for APTX: 1024 samples (per channel).

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
This commit is contained in:
Andreas Rheinhardt 2021-08-29 20:25:18 +02:00
parent 6f22d1965e
commit c0d483cecb
2 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libavcodec/aptx.c
View File

@ -516,15 +516,6 @@ av_cold int ff_aptx_init(AVCodecContext *avctx)
s->hd = avctx->codec->id == AV_CODEC_ID_APTX_HD;
s->block_size = s->hd ? 6 : 4;
if (avctx->frame_size == 0)
avctx->frame_size = 256 * s->block_size;
if (avctx->frame_size % s->block_size) {
av_log(avctx, AV_LOG_ERROR,
"Frame size must be a multiple of %d samples\n", s->block_size);
return AVERROR(EINVAL);
}
for (chan = 0; chan < NB_CHANNELS; chan++) {
Channel *channel = &s->channels[chan];
for (subband = 0; subband < NB_SUBBANDS; subband++) {

3
libavcodec/aptxenc.c
View File

@ -257,6 +257,9 @@ static av_cold int aptx_encode_init(AVCodecContext *avctx)
ff_af_queue_init(avctx, &s->afq);
if (!avctx->frame_size || avctx->frame_size % 4)
avctx->frame_size = 1024;
return ff_aptx_init(avctx);
}