mirror of
https://github.com/FFmpeg/FFmpeg.git
synced 2024-11-26 19:01:44 +02:00
avcodec/h264_refs: set last_pic_for_ec only if it has not been set previously
This ensures we do not loose the frame in case or multiple clears Fixes out of array read Fixes: asan_heap-oob_2fa47ea_2100_cov_1278768963_ff_add_pixels_clamped_mmx.m2ts Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
This commit is contained in:
parent
7dad2f7bb9
commit
e09ad5bd0d
@ -493,9 +493,10 @@ void ff_h264_remove_all_refs(H264Context *h)
|
||||
}
|
||||
assert(h->long_ref_count == 0);
|
||||
|
||||
ff_h264_unref_picture(h, &h->last_pic_for_ec);
|
||||
if (h->short_ref_count)
|
||||
if (h->short_ref_count && !h->last_pic_for_ec.f.data[0]) {
|
||||
ff_h264_unref_picture(h, &h->last_pic_for_ec);
|
||||
ff_h264_ref_picture(h, &h->last_pic_for_ec, h->short_ref[0]);
|
||||
}
|
||||
|
||||
for (i = 0; i < h->short_ref_count; i++) {
|
||||
unreference_pic(h, h->short_ref[i], 0);
|
||||
|
Loading…
Reference in New Issue
Block a user