Commit Graph
8 Commits
Author SHA1 Message Date
Stefan Huehner 119e48d960 Make some functions which aren't used outside their declaring source file
and have no prototype in a header file static.
patch by Stefan Huehner, stefan huehner org

Originally committed as revision 8686 to svn://svn.ffmpeg.org/ffmpeg/trunk
2007-04-08 20:21:11 +00:00
Stefan Huehner 2b100ab2bf changes some function declarations from () to (void) as per ansi c.
Patch by Stefan Huehner % stefan A huehner P org %

Originally committed as revision 8625 to svn://svn.ffmpeg.org/ffmpeg/trunk
2007-04-04 11:51:08 +00:00
Stefan Huehner 62a05b5b00 Mark some read-only datastructures as const.
patch by Stefan Huehner, stefan & at & huehner & dot & org

Originally committed as revision 5639 to svn://svn.ffmpeg.org/ffmpeg/trunk
2006-07-06 13:53:07 +00:00
Stefan Huehner 109d2de108 Mark read-only data as const. Patch by stefan huehner org.
Originally committed as revision 5615 to svn://svn.ffmpeg.org/ffmpeg/trunk
2006-07-04 19:15:47 +00:00
Stefan Huehner ea138e978a Remove unused variable, patch by Stefan Huehner stefan__at__huehner__dot__org.
Originally committed as revision 5506 to svn://svn.ffmpeg.org/ffmpeg/trunk
2006-06-20 22:19:11 +00:00
Stefan Huehner 7b49ce2e34 Add const to (mostly) char* and make some functions static, which aren't used
outside their declaring source file and which have no corresponding prototype.
patch by Stefan Huehner stefan^^@^^huehner^^.^^org

Originally committed as revision 5497 to svn://svn.ffmpeg.org/ffmpeg/trunk
2006-06-18 11:33:14 +00:00
Stefan Huehner a97c1e93aa Add (mostly) const to variable and parameter declaration, where a char* was
used and 'const char*' should be, plus make some function declarations
static if they aren't used outside their declaring source file.
patch by Stefan Huehner stefan%%at%%huehner%%dot%%org

Originally committed as revision 5492 to svn://svn.ffmpeg.org/ffmpeg/trunk
2006-06-17 15:53:23 +00:00
Stefan Huehner 9b2283cc33 Patch by Stefan Huehner / stefan % huehner ! org \
patch replaces '()' for the correct '(void)' in function
declarations/prototypes which have no parameters. The '()' syntax tell
thats there is a variable list of arguments, so that the compiler cannot
check this. The extra CFLAG '-Wstrict-declarations' shows those cases.

Comments about a similar patch applied to ffmpeg:

That in C++ these mean the same, but in ANSI C the semantics are
different; function() is an (obsolete) K&R C style forward declaration,
it basically means that the function can have any number and any types
of parameters, effectively completely preventing the compiler from doing
any sort of type checking. -- Erik Slagter

Defining functions with unspecified arguments is allowed but bad.
With arguments unspecified the compiler can't report an error/warning
if the function is called with incorrect arguments. -- Måns Rullgård

Originally committed as revision 17567 to svn://svn.mplayerhq.hu/mplayer/trunk/postproc
2006-02-09 14:08:03 +00:00