virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2026-06-19 19:03:00 +02:00
Code Issues Releases Activity
112,856 Commits 39 Branches 425 Tags
ac8ac10e3331ebd7188b2df905ad39103da8ee0e
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Michael Niedermayer ac8ac10e33 avfilter/af_afir: Assert format 
Maybe helps: CID1516805 Uninitialized scalar variable

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit a5c815f937)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:32 +02:00
Michael Niedermayer 40b801870d avfilter/af_afftdn: Assert format 
Maybe helps: CID1515514 Uninitialized scalar variable
Maybe helps: CID1515517 Uninitialized scalar variable

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 8f9a6c4ea8)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:32 +02:00
Michael Niedermayer c773ce8435 avfilter/af_pan: check nb_output_channels before use 
Fixes: CID1500281 Out-of-bounds write
Fixes: CID1500331 Out-of-bounds write

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 5fe8bf4aa5)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:31 +02:00
Michael Niedermayer bdd1a93e4b avfilter/af_mcompand: compute half frequency in double 
Fixes: CID1422217 Result is not floating-point

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 2d0d502ff1)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:31 +02:00
Michael Niedermayer 4d7d183ccb avfilter/af_channelsplit: Assert that av_channel_layout_channel_from_index() succeeds 
Maybe Helps: CID1503077 Bad bit shift operation

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit cef720ab42)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:30 +02:00
Michael Niedermayer bea691ffc1 avfilter/af_aresample: Cleanup on av_channel_layout_copy() failure 
Fixes: CID1503078 Resource leak

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 7a0ea15c7a)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:30 +02:00
Michael Niedermayer 252464c49b tools/coverity: Phase 1 study of anti-halicogenic for coverity av_rescale() 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 380a8213b1)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:30 +02:00
Michael Niedermayer 3666a36472 avfilter/vf_avgblur: Check plane instead of AVFrame 
Fixes: CID1551694 Use after free (false positive based on assuming that out == in and one is freed and one used)

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit c296d4fdec)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:29 +02:00
Michael Niedermayer 371c42dd81 avfilter/drawutils: Fix depthb computation 
Fixes: CID1496940 Logically dead code

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 34f821e448)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:29 +02:00
Michael Niedermayer 96a63346ee avfilter/avf_showcwt: Check av_parse_video_rate() for failure 
Fixes: CID1539147 Unused value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit aab0c344c5)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:29 +02:00
Michael Niedermayer 807b53c191 avformat/rdt: Check pkt_len 
Fixes: CID1473553 Untrusted loop bound

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 0d0373de3b)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:28 +02:00
Michael Niedermayer 9c52069b83 avformat/mpeg: Check len in mpegps_probe() 
Fixes: CID1473590 Untrusted loop bound

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit ca237a841e)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:28 +02:00
Michael Niedermayer 002c1b4ddb avformat/mxfenc: resurrects the error print 
Fixes: CID1524681 Logically dead code

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit a469e48b6d)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:28 +02:00
Michael Niedermayer b736844c5f avdevice/dshow: Check ICaptureGraphBuilder2_SetFiltergraph() for failure 
Fixes: CID1591939 Logically dead code

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 4c285bb278)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:27 +02:00
Michael Niedermayer adc6730d51 avcodec/mfenc: check IMFSample_ConvertToContiguousBuffer() for failure 
Fixes: CID1591911 Logically dead code

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 86cd7c68bc)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:27 +02:00
Michael Niedermayer 74bacfc00b avcodec/vc1_loopfilter: Factor duplicate code in vc1_b_h_intfi_loop_filter() 
Fixes: CID1435168

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 63ecce9ba8)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:27 +02:00
Michael Niedermayer 3e02fd22a3 avformat/img2dec: assert no pipe on ts_from_file 
Help coverity with CID1500302 Uninitialized scalar variable

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 4824156fa0)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:26 +02:00
Michael Niedermayer 29852104f5 avcodec/cbs_jpeg: Try to move the read entity to one side in a test 
The checked entity should be alone on one side of the check, this avoids
complex considerations of overflows.
This fixes a issue of bad style in our code and a coverity issue.

Fixes: CID1439654 Untrusted pointer read

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 385784a148)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:26 +02:00
Michael Niedermayer b4d190ca32 fftools/ffmpeg_enc: Initialize fd 
Fixes: CID1520677 Uninitialized pointer read

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 462bd44b03)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:26 +02:00
Michael Niedermayer 2334e8e2d2 fftools/ffmpeg_enc: simplify opaque_ref check 
Found-while-revieweing: CID1520670 Dereference after null check

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 97b2ab15de)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:25 +02:00
Michael Niedermayer dad619078e avformat/mov: Check edit list for overflow 
Fixes: 67492/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5778297231310848
Fixes: signed integer overflow: 2314885530818453536 + 7782220156096217088 cannot be represented in type 'long'

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 2882d30e3a)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:25 +02:00
Michael Niedermayer a9c838f6f7 fftools/ffmpeg: Check read() for failure 
Fixes: CID1591932 Ignoring number of bytes read

Sponsored-by: Sovereign Tech Fund
Reviewed-by: Anton Khirnov <anton@khirnov.net>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 34fd247c3b)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:25 +02:00
Michael Niedermayer de3331843c MAINTAINERS: Add Timo Rothenpieler to server admins 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit ca4ff242d8)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:24 +02:00
Michael Niedermayer aeb81a7fdc swscale/output: Avoid undefined overflow in yuv2rgb_write_full() 
Fixes: signed integer overflow: -140140 * 16525 cannot be represented in type 'int'
Fixes: 68859/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-4516387130245120

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit c221c7422f)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:24 +02:00
Michael Niedermayer 60af592bdd swscale/output: alpha can become negative after scaling, use multiply 
Fixes: left shift of negative value -3245
Fixes: 69047/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-6571511551950848

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 9e6c5b6e86)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:24 +02:00
Michael Niedermayer cc8f0276b5 avcodec/targaenc: Allocate space for the palette 
Fixes: out of array access
Fixes: 68927/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TARGA_fuzzer-5105665067515904

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 4a7220bd5c)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:23 +02:00
Michael Niedermayer ac9045e993 avcodec/r210enc: Use av_rescale for bitrate 
Fixes: signed integer overflow: 281612954574848 * 65344 cannot be represented in type 'long'
Fixes: 68956/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_R210_fuzzer-6459074458746880

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit d34d4b6a7c)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:23 +02:00
Michael Niedermayer 11ae269072 avcodec/jfdctint_template: Fewer integer anomalies 
Fixes: signed integer overflow: 105788 * -20995 cannot be represented in type 'int'
Fixes: signed integer overflow: 923211729 + 2073948236 cannot be represented in type 'int'
Fixes: signed integer overflow: 1281179284 + 2073948236 cannot be represented in type 'int'
Fixes: 68975/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PRORES_fuzzer-6266769177116672
Fixes: 68997/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PRORES_KS_fuzzer-6284237161431040

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 228f255b5d)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:23 +02:00
Michael Niedermayer c9d1d0f0d7 avcodec/snowenc: MV limits due to mv_penalty table size 
Fixes: out of array read
Fixes: 69673/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SNOW_fuzzer-5476592894148608

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 3a9292aff3)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:22 +02:00
Michael Niedermayer a9e55f409f tools/target_dec_fuzzer: Adjust threshold for MV30 
Fixes: 60867/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MV30_fuzzer-6381933108527104
Fixes: Timeout

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit f81602fb3a)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:22 +02:00
Michael Niedermayer a412dd1863 tools/target_dec_fuzzer: Adjust threshold for jpeg2000 
Fixes: Timeout
Fixes: 57385/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5394334324490240

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 749994194c)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:22 +02:00
Michael Niedermayer 4c004c350c avformat/mxfdec: Check container_ul->desc before use 
Fixes: CID1592939 Dereference after null check

Sponsored-by: Sovereign Tech Fund
Reviewed-by: Tomas Härdin <git@haerdin.se>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 4cab028bd0)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:21 +02:00
Michael Niedermayer 4d05988497 avcodec/libvpxenc: Cleanup on error 
This or fifo needs to be freed on errors explicitly

Fixes: memleak
Fixes: 68937/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBVPX_VP8_fuzzer-4830831016214528

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: James Zern <jzern@google.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 2b2ced61eb)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:21 +02:00
Michael Niedermayer ed9b67a149 MAINTAINERS: Update the entries for the release maintainer for FFmpeg 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 97ecfb5a19)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:21 +02:00
Michael Niedermayer 8cef0f2673 doc/developer: Provide information about git send-email and gmail 
The 2 links are the clearest i found.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 959cb2e2e3)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:20 +02:00
Michael Niedermayer 7e634b9731 avfilter/vf_rotate: Check ff_draw_init2() return value 
Fixes: NULL pointer dereference
Fixes: 3_343

Found-by: De3mond
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 9c9f095e30)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:20 +02:00
Michael Niedermayer 2b8c96074b avformat/mov: Use int64_t in intermediate for corrected_dts 
Fixes: CID1500312 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 034054b370)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:19 +02:00
Michael Niedermayer 0df8b97e09 avformat/mov: Use 64bit in intermediate for current_dts 
Fixes: CID1500304 Unintentional integer overflow
Fixes: CID1500318 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 0c977d37aa)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:19 +02:00
Michael Niedermayer d081214a70 avformat/matroskadec: Assert that num_levels is non negative 
Maybe Closes: CID1452496 Uninitialized scalar variable

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 019fce18bb)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:19 +02:00
Michael Niedermayer bde8a67e92 avformat/libzmq: Check av_strstart() 
Fixes: CID1453457 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 0263b6a48c)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:18 +02:00
Michael Niedermayer d06f35f285 avformat/img2dec: Little JFIF / Exif cleanup 
This changes the behavior and makes it behave how it probably was intended.
Either way this is unlikely to result in any user visible change

Fixes: CID1494637 Missing break in switch

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 5712f36dd0)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:18 +02:00
Michael Niedermayer ba5343eefb avformat/img2dec: Move DQT after unrelated if() 
Fixes: CID1494636 Missing break in switch

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 7d04c6016b)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:18 +02:00
Michael Niedermayer ae964c5851 avformat/imfdec: Simplify get_next_track_with_minimum_timestamp() 
This also makes the code more robust

Fixes: CID1512414 Uninitialized pointer read

Sponsored-by: Sovereign Tech Fund
Reviewed-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit f10493f6fc)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:17 +02:00
Michael Niedermayer 42d9464f6f avdevice/xcbgrab: Check sscanf() return 
Alot more input checking can be performed, this is only checking the obvious missing case

Fixes: CID1598562 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 78d6d13bab)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:17 +02:00
Michael Niedermayer dcf26aa3a2 fftools/cmdutils: Add protective () to FLAGS 
issue found while reviewing CID1452612 Free of array-typed value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit d9b9fc4be2)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:17 +02:00
Michael Niedermayer 6b4165643d avformat/sdp: Check before appending "," 
Found by reviewing code related to CID1500301 String not null terminated

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 5b82852519)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:16 +02:00
Michael Niedermayer 22d2a4eb34 avcodec/ilbcdec: Remove dead code 
Yes the same dead code is in "iLBC Speech Coder ANSI-C Source Code"

Fixes: CID1509370 Logically dead code

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 8a64a003b5)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:16 +02:00
Michael Niedermayer 18b0e31390 avcodec/vp8: Check cond init 
Fixes: CID1598563 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 9b76e49061)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:16 +02:00
Michael Niedermayer 79f7917939 avcodec/vp8: Check mutex init 
Fixes: CID1598556 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 4ac7405aaf)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:15 +02:00
Michael Niedermayer ad636886ca avcodec/proresenc_anatoliy: Assert that AV_PROFILE_UNKNOWN is replaced 
If its not replaced we would have a negative index used in an array potentially

Helps: CID1440385 Negative array index read

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 6106177ad6)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:15 +02:00
Michael Niedermayer e04470d816 avcodec/pcm-dvdenc: 64bit pkt-size 
It seems nothing prevents such overflow even though odd

Fixes: CID1441934 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 160b81ce2a)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:15 +02:00
Michael Niedermayer 537a893560 avcodec/notchlc: Check init_get_bits8() for failure 
Fixes: CID1500300 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 19db9636c5)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:14 +02:00
Michael Niedermayer 11e8eeca4d avcodec/tests/dct: Use 64bit in intermediate for error computation 
Fixes: CID1500284 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 161d0aa2a8)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:14 +02:00
Michael Niedermayer 6696741957 avcodec/scpr3: Check add_dec() for failure 
Fixes: CID1441459 Improper use of negative value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit d741638042)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:14 +02:00
Michael Niedermayer 8d348dc635 avcodec/rv34: assert that size is not 0 in rv34_gen_vlc_ext() 
Helps: CID1548380 Uninitialized scalar variable

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit e5098589b0)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:13 +02:00
Michael Niedermayer c630e08d41 avcodec/wavpackenc: Use unsigned for potential 31bit shift 
Fixes: CID1465481 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 6f976db251)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:13 +02:00
Michael Niedermayer 846d2f7d71 avcodec/tests/jpeg2000dwt: Use 64bit in comparission 
Found while reviewing: CID1500309 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 12391b732f)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:12 +02:00
Michael Niedermayer 729c68f86f avcodec/tests/jpeg2000dwt: Use 64bit in err2 computation 
This issue cannot happen with the current function parameters

Fixes: CID1500309 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 847a53f264)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:12 +02:00
Michael Niedermayer 5477c6dc66 avformat/fwse: Remove always false expression 
Fixes: CID1460758 Operands don't affect result

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 348c3a7ffe)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:12 +02:00
Michael Niedermayer 8255f469bf avcodec/sga: Make it clear that the return is intentionally not checked 
Related: CID1473496 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 00d029d5c0)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:11 +02:00
Michael Niedermayer 980d1e530e avformat/asfdec_f: Use 64bit for preroll computation 
Fixes: CID1500342 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 70b4994762)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:11 +02:00
Michael Niedermayer c00fd50092 avformat/argo_asf: Use 64bit in offset intermediate 
Fixes: CID1467435 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit d9d1f65308)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:11 +02:00
Michael Niedermayer d0092f4ef2 avformat/ape: Use 64bit for final frame size 
Fixes: CID1505963 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit a2b8d03347)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:10 +02:00
Michael Niedermayer 18193cfadb avformat/ac4dec: Check remaining space in ac4_probe() 
Fixes: CID1538298 Untrusted loop bound
Fixes: undefined behavior

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 2f04cb673c)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:10 +02:00
Michael Niedermayer 2e632394dd avdevice/pulse_audio_enc: Use av_rescale() to avoid integer overflow 
Fixes: CID1503075 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 6f52b64bcc)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:10 +02:00
Michael Niedermayer 47fd81fda3 avcodec/vlc: Cleanup on multi table alloc failure in ff_vlc_init_multi_from_lengths() 
Fixes: CID1544630 Resource leak

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 62d7106c36)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:09 +02:00
Michael Niedermayer 0241e87624 avcodec/tiff: Assert init_get_bits8() success in unpack_gray() 
Helps: CID1441939 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit a287f17db2)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:09 +02:00
Michael Niedermayer c8907643fb avcodec/tiff: Assert init_get_bits8() success in horizontal_fill() 
Helps: CID1441167 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 8814cedb07)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:09 +02:00
Michael Niedermayer 6b89f87fd9 tools/decode_simple: Check avcodec_send_packet() for errors on flushing 
This will not error but the API allows errors so we should check it
Fixes: CID1489999 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 6df8bd64ff)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:08 +02:00
Michael Niedermayer 188ffc18ef swscale/yuv2rgb: Use 64bit for brightness computation 
This will not overflow for normal values
Fixes: CID1500280 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit bfc22f364d)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:08 +02:00
Michael Niedermayer cb2f3ec5cb swscale/x86/swscale: use a clearer name for INPUT_PLANER_RGB_A_FUNC_CASE 
related: CID1497114 Missing break in switch

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 3f9daf1c18)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:08 +02:00
Michael Niedermayer f1de1a9d80 avutil/tests/opt: Check av_set_options_string() for failure 
This is test code after all so it should test things

Fixes: CID1518990 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit e3481730ed)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:07 +02:00
Michael Niedermayer 3edd95e79e avutil/tests/dict: Check av_dict_set() before get for failure 
Failure is possible due to strdup()

Fixes: CID1516764 Dereference null return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit e8a1e1899d)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:07 +02:00
Michael Niedermayer 1b67de255f avdevice/dshow: fix badly indented line 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit c4004605b2)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:07 +02:00
Michael Niedermayer 6feea4ada8 avformat/demux: resurrect dead stores 
Fixes: CID1473512 Unused value
Fixes: CID1529228 Unused value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 33da5f4e27)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:06 +02:00
Michael Niedermayer 66a140c0c0 avcodec/tests/bitstream_template: Assert bits_init8() return 
Helps: CID1518967 Unchecked return value
Helps: CID1518968 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit e7775973f0)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:06 +02:00
Michael Niedermayer 59029c2b16 tools/enc_recon_frame_test: Assert that av_image_get_linesize() succeeds 
Helps: CID1524598 Improper use of negative value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit b6fa2ed77e)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-07-24 16:52:06 +02:00
Michael NiedermayerandTimo Rothenpieler e3711d18f3 qsv: Initialize impl_value 
Fixes: The warnings from CID1598553 Uninitialized scalar variable

Passing partly initialized structs is ugly and asking for hard to rieproduce bugs,
The uninitialized fields where not used

Reviewed-by: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit c841cb45e8)
 2024-06-24 00:14:04 +02:00
Michael Niedermayer 4e53ea496c avcodec/mscc & mwsc: Check loop counts before use 
This could cause timeouts

Fixes: CID1439568 Untrusted loop bound

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit e35fe3d8b9)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:21 +02:00
Michael Niedermayer 7cc79bfda9 avcodec/mpegvideo_enc: Fix potential overflow in RD 
Fixes: CID1500285 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit b6b2b01025)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:21 +02:00
Michael Niedermayer 8174b4206d avcodec/mpeg4videodec: assert impossible wrap points 
Helps: CID1473517 Uninitialized scalar variable
Helps: CID1473497 Uninitialized scalar variable

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 8fc649b931)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:21 +02:00
Michael Niedermayer 94849755fb avcodec/mpeg12dec: Use 64bit in bit computation 
I dont think this can actually overflow but 64bit seems reasonable to use

Fixes: CID1521983 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 4c725df059)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:20 +02:00
Michael Niedermayer d54198256e avcodec/vqcdec: Check init_get_bits8() for failure 
Fixes: CID1516090 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Reviewed-by: Peter Ross <pross@xvid.org>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 6a9302739f)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:20 +02:00
Michael Niedermayer cc78679c84 avcodec/vble: Check av_image_get_buffer_size() for failure 
Fixes: CID1461482 Improper use of negative value

Sponsored-by: Sovereign Tech Fund
Reviewed-.by: "Xiang, Haihao" <haihao.xiang@intel.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit dd5379db5d)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:20 +02:00
Michael Niedermayer 1b9de6ff28 avcodec/vp3: Replace check by assert 
Fixes: CID1452425 Logically dead code

Sponsored-by: Sovereign Tech Fund
Reviewed-by: Peter Ross <pross@xvid.org>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 1b991e77b9)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:19 +02:00
Michael Niedermayer 6db10d3be0 avcodec/vp8: Forward return of ff_vpx_init_range_decoder() 
Fixes: CID1507483 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Reviewed-by: "Ronald S. Bultje" <rsbultje@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 63feed1519)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:19 +02:00
Michael Niedermayer 236001ce0b avcodec/jpeg2000dec: remove ST=3 case 
Fixes: CID1460979 Logically dead code

Sponsored-by: Sovereign Tech Fund
Reviewed-by: Tomas Härdin <git@haerdin.se>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 4ed4f9a6c0)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:19 +02:00
Michael Niedermayer 28eb4663d6 avcodec/qsvdec: Check av_image_get_buffer_size() for failure 
Fixes: CID1477406 Improper use of negative value

Sponsored-by: Sovereign Tech Fund
Reviewed-by: "Xiang, Haihao" <haihao.xiang@intel.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 8789c550fa)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:18 +02:00
Michael Niedermayer c10b416087 avcodec/exr: Fix preview overflow 
Fixes: CID1515456 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 36126e4c14)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:18 +02:00
Michael Niedermayer 3ee5567c54 avcodec/decode: decode_simple_internal() only implements audio and video 
Fixes: CID1538861 Uninitialized scalar variable

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit e9bb586543)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:18 +02:00
Michael Niedermayer 41550b0ebb avcodec/fmvc: remove dead assignment 
Fixes: CID1529220 Unused value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 96c1162545)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:17 +02:00
Michael Niedermayer b586ff2768 avcodec/h2645_sei: Remove dead checks 
Fixes: CID1596534 Dereference after null check

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit fdaa6ae2b6)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:17 +02:00
Michael Niedermayer 61f5019a51 avcodec/h264_slice: Remove dead sps check 
Fixes: CID1439574 Dereference after null check

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit a68aa951b2)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:17 +02:00
Michael Niedermayer 2de1f26366 avcodec/lpc: copy levenson coeffs only when they have been computed 
Fixes: CID1473514 Uninitialized scalar variable

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit c2d897f356)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:16 +02:00
Michael Niedermayer 21efa2af53 avutil/tests/base64: Check with too short output array 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit c304784a86)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:16 +02:00
Michael Niedermayer f3931154bb libavutil/base64: Try not to write over the array end 
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 2d216566f2)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:16 +02:00
Michael Niedermayer bc08dfdf5d avcodec/cbs_av1: Avoid shift overflow 
Fixes: CID1465488 Unintentional integer overflow

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit d7924a4f60)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:15 +02:00
Michael Niedermayer cc773eba6b fftools/ffplay: Check return of swr_alloc_set_opts2() 
This probably makes no difference but its more correct

Fixes: CID1503080 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit f44f441555)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:15 +02:00
Michael Niedermayer b91b594dbd tools/opt_common: Check for malloc failure 
Fixes: CID1539100 Negative loop bound

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit ba7038043a)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:15 +02:00
Michael Niedermayer 36713f42ab doc/examples/demux_decode: Simplify loop 
Fixes: CID1463550 Logically dead code

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 91d27f7e02)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
 2024-05-25 00:31:14 +02:00