1
0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2024-12-02 03:06:28 +02:00
Go to file
Stefan Schoenefeld 39a5c0ac06 avcodec/h263dec: fix hwaccel decoding
Recently we encountered an issue when decoding a h.263 file:

FFmpeg will freeze when decoding h.263 video with NVDEC. Turns out this is not directly related to NVDEC but is a problem that shows with several other HW decoders like VDPAU, though the exact kind of error is different (either error messages or freezing[1]). The root cause is that ff_thread_finish_setup() is called twice per frame from ff_h263_decode_frame(). This is not supported by ff_thread_finish_setup() and specifically checked for and warned against in the functions code. The issue is also specific to hw accelerated decoding only as the second call to ff_thread_finish_setup() is only issued when hw acceleration is on. The fix is simple: add a check that the first call is only send when hw acceleration is off, and the second call only when hw acceleration is on (see attached patch). This works fine as far as I was able to test with vdpau and nvdec/nvcuvid hw decoding. The patch also adds NVDEC to the hw config list if available.

I also noticed a secondary issue when browsing through the code which is that, according to documentation, ff_thread_finish_setup() should only be called if the codec implements update_thread_context(), which h263dec does not. The patch does not address this and I'm not sure any action needs to be taken here at all.

[1] This is depending on whether or not the hw decoder sets the  HWACCEL_CAPS_ASYNC_SAFE flag

Signed-off-by: Timo Rothenpieler <timo@rothenpieler.org>
2019-08-04 16:11:53 +02:00
compat compat/cuda/ptx2c: don't drop final newline 2019-05-24 19:23:39 +02:00
doc lavu/tx: add support for double precision FFT and MDCT 2019-08-02 01:19:52 +01:00
ffbuild Merge commit '7e5bde93a1e7641e1622814dafac0be3f413d79b' 2019-03-10 19:31:13 -03:00
fftools ffmpeg_opt: Respect default disposition when select audio/video 2019-07-03 10:33:44 +08:00
libavcodec avcodec/h263dec: fix hwaccel decoding 2019-08-04 16:11:53 +02:00
libavdevice lavd/v4l2: produce a 0 byte packet when a dequeued buffer's size is unexpected 2019-07-30 12:05:52 +02:00
libavfilter lavfi/zmq: Avoid mem copy past the end of input buffer 2019-08-01 19:10:05 +02:00
libavformat avformat/vividas: Check that value from ffio_read_varlen() does not overflow 2019-08-03 17:44:23 +02:00
libavresample
libavutil avutil/mips: Avoid instruction exception caused by gssqc1/gslqc1. 2019-08-02 19:01:51 +02:00
libpostproc Bump minor versions again on master to keep 4.2 versions separate from master 2019-07-21 18:36:31 +02:00
libswresample Bump minor versions again on master to keep 4.2 versions separate from master 2019-07-21 18:36:31 +02:00
libswscale Bump minor versions again on master to keep 4.2 versions separate from master 2019-07-21 18:36:31 +02:00
presets
tests FATE: add hls single file mode test case 2019-08-01 19:25:29 +08:00
tools tools/target_dec_fuzzer: fix memleak of extradata 2019-07-31 20:35:07 +02:00
.gitattributes
.gitignore tools/python: add script to convert TensorFlow model (.pb) to native model (.model) 2019-07-01 10:23:47 -03:00
.travis.yml Merge commit '899ee03088d55152a48830df0899887f055da1de' 2019-03-14 15:53:16 -03:00
Changelog Changelog: Add 4.2 cut marker 2019-07-21 18:25:21 +02:00
configure avutil/mips: optimize UNPCK&SAD macros with MSA2.0 instruction. 2019-07-10 12:54:57 +02:00
CONTRIBUTING.md
COPYING.GPLv2
COPYING.GPLv3
COPYING.LGPLv2.1
COPYING.LGPLv3
CREDITS
INSTALL.md
LICENSE.md LICENSE: Clarify --enable-nonfree. 2019-05-10 01:18:58 +02:00
MAINTAINERS MAINTAINERS: remove myself as mailing list maintainer 2019-03-21 11:34:13 -08:00
Makefile tools: Add fuzzer for demuxers 2019-05-31 22:44:30 +02:00
README.md
RELEASE RELEASE: Update value for post 4.2 branch 2019-07-21 18:37:32 +02:00

FFmpeg README

FFmpeg is a collection of libraries and tools to process multimedia content such as audio, video, subtitles and related metadata.

Libraries

  • libavcodec provides implementation of a wider range of codecs.
  • libavformat implements streaming protocols, container formats and basic I/O access.
  • libavutil includes hashers, decompressors and miscellaneous utility functions.
  • libavfilter provides a mean to alter decoded Audio and Video through chain of filters.
  • libavdevice provides an abstraction to access capture and playback devices.
  • libswresample implements audio mixing and resampling routines.
  • libswscale implements color conversion and scaling routines.

Tools

  • ffmpeg is a command line toolbox to manipulate, convert and stream multimedia content.
  • ffplay is a minimalistic multimedia player.
  • ffprobe is a simple analysis tool to inspect multimedia content.
  • Additional small tools such as aviocat, ismindex and qt-faststart.

Documentation

The offline documentation is available in the doc/ directory.

The online documentation is available in the main website and in the wiki.

Examples

Coding examples are available in the doc/examples directory.

License

FFmpeg codebase is mainly LGPL-licensed with optional components licensed under GPL. Please refer to the LICENSE file for detailed information.

Contributing

Patches should be submitted to the ffmpeg-devel mailing list using git format-patch or git send-email. Github pull requests should be avoided because they are not part of our review process and will be ignored.