1
0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2024-11-26 19:01:44 +02:00
Go to file
Andreas Rheinhardt c4fcfa47df avcodec/h264_slice: Fix decoding undamaged input with slices
ff_er_frame_start() initializes ERContext.error_count
to three times the number of macroblocks to decode.
Later ff_er_add_slice() reduces this number by the amount
of macroblocks whose AC resp. DC resp. MV have been finished
(so every correctly decoded MB counts three times).
So the frame has been decoded correctly if error_count is zero
at the end.

The H.264 decoder uses multiple ERContexts when using
slice threading and therefore combines these error counts:
The first slice's ERContext is intended to be initialized
by ff_er_frame_start(), error_count of all the other
slice contexts is intended to be zeroed initially and
all afterwards all the error_counts are summed.

Yet commit 43b434210e
(probably unintentionally) changed the code to set
the first slice's error_count to zero as well.
This leads to bogus error messages in case one decodes
an input video using multiple slices with slice threading
with error concealment enabled (which is not the default)
("concealing 0 DC, 0 AC, 0 MV errors in [IPB] frame");
furthermore the returned frame is marked as corrupt as well
(ffmpeg reports "corrupt decoded frame in stream %d" for this).

This can be fixed easily given that only the first ERContext
is really used since 7be2d2a70c:
Don't reset the error_count; and don't sum the error counts as well.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2022-03-25 19:07:13 +01:00
compat Replace all occurences of av_mallocz_array() by av_calloc() 2021-09-20 01:03:52 +02:00
doc doc/utils: add missing 22.2 layout entry 2022-03-25 09:26:45 -03:00
ffbuild Fix libversion.sh for split version headers, to unbreak shared library builds 2022-03-17 11:11:17 +02:00
fftools fftools/opt_cmdutils: fix printing known channel layouts 2022-03-25 08:42:45 -03:00
libavcodec avcodec/h264_slice: Fix decoding undamaged input with slices 2022-03-25 19:07:13 +01:00
libavdevice Keep including the full version.h when headers are included externally 2022-03-19 00:01:57 +02:00
libavfilter avfilter/vsrc_life: set outlink frame_rate 2022-03-25 18:20:01 +01:00
libavformat avformat: Remove unnecessary inclusions from libavcodec 2022-03-23 23:45:39 +01:00
libavutil avutil/tests/channel_layout: test av_channel_layout_check() 2022-03-25 12:09:21 -03:00
libpostproc Keep including the full version.h when headers are included externally 2022-03-19 00:01:57 +02:00
libswresample Keep including the full version.h when headers are included externally 2022-03-19 00:01:57 +02:00
libswscale Keep including the full version.h when headers are included externally 2022-03-19 00:01:57 +02:00
presets
tests fate: add crystalizer test 2022-03-25 18:18:44 +01:00
tools avcodec/codec_internal: Add FFCodec, hide internal part of AVCodec 2022-03-21 01:33:09 +01:00
.gitattributes
.gitignore gitignore: add config_components.h 2022-03-17 18:35:41 -03:00
.mailmap mailmap: add entry for myself 2021-03-09 02:09:55 +00:00
.travis.yml
Changelog avformat: add DFPWM raw format 2022-03-10 14:11:12 +01:00
configure avcodec/bsf: Add FFBitStreamFilter, hide internals of BSFs 2022-03-23 23:45:45 +01:00
CONTRIBUTING.md
COPYING.GPLv2
COPYING.GPLv3
COPYING.LGPLv2.1
COPYING.LGPLv3
CREDITS
INSTALL.md
LICENSE.md avfilter/vf_geq: Relicense to LGPL 2019-12-28 11:20:48 +01:00
MAINTAINERS avformat: add DFPWM raw format 2022-03-10 14:11:12 +01:00
Makefile Makefile: check config_components.h when comparing timestamps in component list files 2022-03-17 18:35:41 -03:00
README.md README: fix typo and description of libavfilter 2021-10-08 09:44:34 +05:30
RELEASE Bump Versions before release/4.4 branch 2021-03-20 01:01:12 +01:00

FFmpeg README

FFmpeg is a collection of libraries and tools to process multimedia content such as audio, video, subtitles and related metadata.

Libraries

  • libavcodec provides implementation of a wider range of codecs.
  • libavformat implements streaming protocols, container formats and basic I/O access.
  • libavutil includes hashers, decompressors and miscellaneous utility functions.
  • libavfilter provides means to alter decoded audio and video through a directed graph of connected filters.
  • libavdevice provides an abstraction to access capture and playback devices.
  • libswresample implements audio mixing and resampling routines.
  • libswscale implements color conversion and scaling routines.

Tools

  • ffmpeg is a command line toolbox to manipulate, convert and stream multimedia content.
  • ffplay is a minimalistic multimedia player.
  • ffprobe is a simple analysis tool to inspect multimedia content.
  • Additional small tools such as aviocat, ismindex and qt-faststart.

Documentation

The offline documentation is available in the doc/ directory.

The online documentation is available in the main website and in the wiki.

Examples

Coding examples are available in the doc/examples directory.

License

FFmpeg codebase is mainly LGPL-licensed with optional components licensed under GPL. Please refer to the LICENSE file for detailed information.

Contributing

Patches should be submitted to the ffmpeg-devel mailing list using git format-patch or git send-email. Github pull requests should be avoided because they are not part of our review process and will be ignored.