mirror of
https://github.com/FFmpeg/FFmpeg.git
synced 2024-12-28 20:53:54 +02:00
aa28df74ab
When compiling FFmpeg with GCC-9, some very random segfaults were
observed in code which had previously called down into the SBC encoder
NEON assembly routines. This was caused by these functions clobbering
some of the vfp callee saved registers (d8 - d15 aka q4 - q7). GCC was
using these registers to save local variables, but after these
functions returned, they would contain garbage.
Fix by reallocating the registers in the two affected functions in
the following way:
ff_sbc_analyze_4_neon: q2-q5 => q8-q11, then q1-q4 => q8-q11
ff_sbc_analyze_8_neon: q2-q9 => q8-q15
The reason for using these replacements is to keep closely related
sets of registers consecutively numbered which hopefully makes the
code more easy to follow. Since this commit only reallocates
registers, it should have no performance impact.
Signed-off-by: James Cowgill <jcowgill@debian.org>
Signed-off-by: Martin Storsjö <martin@martin.st>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| aac.h | ||
| aacpsdsp_init_arm.c | ||
| aacpsdsp_neon.S | ||
| ac3dsp_arm.S | ||
| ac3dsp_armv6.S | ||
| ac3dsp_init_arm.c | ||
| ac3dsp_neon.S | ||
| asm-offsets.h | ||
| audiodsp_arm.h | ||
| audiodsp_init_arm.c | ||
| audiodsp_init_neon.c | ||
| audiodsp_neon.S | ||
| blockdsp_arm.h | ||
| blockdsp_init_arm.c | ||
| blockdsp_init_neon.c | ||
| blockdsp_neon.S | ||
| cabac.h | ||
| dca.h | ||
| fft_init_arm.c | ||
| fft_neon.S | ||
| fft_vfp.S | ||
| flacdsp_arm.S | ||
| flacdsp_init_arm.c | ||
| fmtconvert_init_arm.c | ||
| fmtconvert_neon.S | ||
| fmtconvert_vfp.S | ||
| g722dsp_init_arm.c | ||
| g722dsp_neon.S | ||
| h264chroma_init_arm.c | ||
| h264cmc_neon.S | ||
| h264dsp_init_arm.c | ||
| h264dsp_neon.S | ||
| h264idct_neon.S | ||
| h264pred_init_arm.c | ||
| h264pred_neon.S | ||
| h264qpel_init_arm.c | ||
| h264qpel_neon.S | ||
| hevcdsp_arm.h | ||
| hevcdsp_deblock_neon.S | ||
| hevcdsp_idct_neon.S | ||
| hevcdsp_init_arm.c | ||
| hevcdsp_init_neon.c | ||
| hevcdsp_qpel_neon.S | ||
| hevcdsp_sao_neon.S | ||
| hpeldsp_arm.h | ||
| hpeldsp_arm.S | ||
| hpeldsp_armv6.S | ||
| hpeldsp_init_arm.c | ||
| hpeldsp_init_armv6.c | ||
| hpeldsp_init_neon.c | ||
| hpeldsp_neon.S | ||
| idct.h | ||
| idctdsp_arm.h | ||
| idctdsp_arm.S | ||
| idctdsp_armv6.S | ||
| idctdsp_init_arm.c | ||
| idctdsp_init_armv5te.c | ||
| idctdsp_init_armv6.c | ||
| idctdsp_init_neon.c | ||
| idctdsp_neon.S | ||
| int_neon.S | ||
| jrevdct_arm.S | ||
| lossless_audiodsp_init_arm.c | ||
| lossless_audiodsp_neon.S | ||
| Makefile | ||
| mathops.h | ||
| mdct_neon.S | ||
| mdct_vfp.S | ||
| me_cmp_armv6.S | ||
| me_cmp_init_arm.c | ||
| mlpdsp_armv5te.S | ||
| mlpdsp_armv6.S | ||
| mlpdsp_init_arm.c | ||
| mpegaudiodsp_fixed_armv6.S | ||
| mpegaudiodsp_init_arm.c | ||
| mpegvideo_arm.c | ||
| mpegvideo_arm.h | ||
| mpegvideo_armv5te_s.S | ||
| mpegvideo_armv5te.c | ||
| mpegvideo_neon.S | ||
| mpegvideoencdsp_armv6.S | ||
| mpegvideoencdsp_init_arm.c | ||
| neon.S | ||
| neontest.c | ||
| pixblockdsp_armv6.S | ||
| pixblockdsp_init_arm.c | ||
| pixblockdsp_neon.S | ||
| rdft_init_arm.c | ||
| rdft_neon.S | ||
| rv34dsp_init_arm.c | ||
| rv34dsp_neon.S | ||
| rv40dsp_init_arm.c | ||
| rv40dsp_neon.S | ||
| sbcdsp_armv6.S | ||
| sbcdsp_init_arm.c | ||
| sbcdsp_neon.S | ||
| sbrdsp_init_arm.c | ||
| sbrdsp_neon.S | ||
| simple_idct_arm.S | ||
| simple_idct_armv5te.S | ||
| simple_idct_armv6.S | ||
| simple_idct_neon.S | ||
| startcode_armv6.S | ||
| startcode.h | ||
| synth_filter_init_arm.c | ||
| synth_filter_neon.S | ||
| synth_filter_vfp.S | ||
| vc1dsp_init_arm.c | ||
| vc1dsp_init_neon.c | ||
| vc1dsp_neon.S | ||
| vc1dsp.h | ||
| videodsp_arm.h | ||
| videodsp_armv5te.S | ||
| videodsp_init_arm.c | ||
| videodsp_init_armv5te.c | ||
| vorbisdsp_init_arm.c | ||
| vorbisdsp_neon.S | ||
| vp3dsp_init_arm.c | ||
| vp3dsp_neon.S | ||
| vp6dsp_init_arm.c | ||
| vp6dsp_neon.S | ||
| vp8_armv6.S | ||
| vp8.h | ||
| vp8dsp_armv6.S | ||
| vp8dsp_init_arm.c | ||
| vp8dsp_init_armv6.c | ||
| vp8dsp_init_neon.c | ||
| vp8dsp_neon.S | ||
| vp8dsp.h | ||
| vp9dsp_init_10bpp_arm.c | ||
| vp9dsp_init_12bpp_arm.c | ||
| vp9dsp_init_16bpp_arm_template.c | ||
| vp9dsp_init_arm.c | ||
| vp9dsp_init.h | ||
| vp9itxfm_16bpp_neon.S | ||
| vp9itxfm_neon.S | ||
| vp9lpf_16bpp_neon.S | ||
| vp9lpf_neon.S | ||
| vp9mc_16bpp_neon.S | ||
| vp9mc_neon.S | ||
| vp56_arith.h | ||