1
0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-01-24 13:56:33 +02:00
FFmpeg/libavfilter
Muhammad Faiz fc3a03fcf9 avfilter: take_samples: do not directly return frame when samples are skipped
Modifying data pointer when skipping samples may make it unaligned.
Workaround for Ticket6349.

This should fix the crash of ticket's testcase and a crash/regression
with avxsynth (reported by Michael Niedermayer).

Also change frame->nb_samples < max to frame->nb_samples <= max.
This improves performance. Benchmark:
./ffmpeg -filter_complex "aevalsrc=0:n=1166,firequalizer=fixed=on" -f null null
old:
  25767 decicycles in take_samples,    1023 runs,      1 skips
  25422 decicycles in take_samples,    2047 runs,      1 skips
  25181 decicycles in take_samples,    4095 runs,      1 skips
  24904 decicycles in take_samples,    8191 runs,      1 skips

new:
    550 decicycles in take_samples,    1024 runs,      0 skips
    548 decicycles in take_samples,    2048 runs,      0 skips
    545 decicycles in take_samples,    4096 runs,      0 skips
    544 decicycles in take_samples,    8192 runs,      0 skips

Reviewed-by: Nicolas George <george@nsup.org>
Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Muhammad Faiz <mfcc64@gmail.com>
2017-05-20 23:19:46 +07:00
..
2017-05-12 10:48:13 +02:00
2016-12-01 09:53:38 +01:00
2017-04-23 14:40:30 +07:00
2015-10-26 20:56:17 +01:00
2017-01-12 15:07:18 +01:00
2016-03-13 10:06:21 +01:00
2017-04-23 14:40:30 +07:00
2017-04-23 14:40:30 +07:00
2017-01-12 10:22:52 +01:00
2016-01-28 19:49:48 -08:00
2014-08-13 01:00:38 +02:00
2017-05-17 20:18:39 +02:00
2016-01-31 15:44:11 -08:00
2016-01-28 19:49:48 -08:00
2017-04-23 14:40:30 +07:00
2016-01-31 15:44:11 -08:00
2015-01-05 01:45:49 +01:00
2017-05-17 20:18:39 +02:00
2017-04-10 16:53:17 +02:00
2016-02-27 21:35:20 +01:00
2016-02-17 09:42:46 +01:00
2017-04-23 14:40:30 +07:00
2017-04-24 20:37:30 +02:00
2017-04-23 14:40:30 +07:00
2015-01-09 17:26:31 +01:00
2017-01-30 18:44:08 +01:00
2017-04-22 13:18:59 +02:00