mirror of
https://github.com/videojs/video.js.git
synced 2024-12-21 01:39:04 +02:00
Fix several typos in docs and comments (#8110)
This commit is contained in:
parent
af33e39da9
commit
423f7ebd67
2
.github/workflows/release.yml
vendored
2
.github/workflows/release.yml
vendored
@ -14,7 +14,7 @@ jobs:
|
||||
steps:
|
||||
- name: Checkout
|
||||
uses: actions/checkout@v2
|
||||
# We neeed to fetch the entire history as conventional-changelog needs
|
||||
# We need to fetch the entire history as conventional-changelog needs
|
||||
# access to any number of git commits to build the changelog.
|
||||
with:
|
||||
fetch-depth: 0
|
||||
|
32
CHANGELOG.md
32
CHANGELOG.md
@ -332,7 +332,7 @@
|
||||
### Features
|
||||
|
||||
* make negative sign on remaining time optional ([#7571](https://github.com/videojs/video.js/issues/7571)) ([67e6ed6](https://github.com/videojs/video.js/commit/67e6ed6)), closes [#7565](https://github.com/videojs/video.js/issues/7565)
|
||||
* udpate to [@videojs](https://github.com/videojs)/http-streaming[@2](https://github.com/2).13.1 ([#7573](https://github.com/videojs/video.js/issues/7573)) ([9aaf67a](https://github.com/videojs/video.js/commit/9aaf67a))
|
||||
* update to [@videojs](https://github.com/videojs)/http-streaming[@2](https://github.com/2).13.1 ([#7573](https://github.com/videojs/video.js/issues/7573)) ([9aaf67a](https://github.com/videojs/video.js/commit/9aaf67a))
|
||||
|
||||
<a name="7.17.3"></a>
|
||||
## [7.17.3](https://github.com/videojs/video.js/compare/v7.17.2...v7.17.3) (2021-12-10)
|
||||
@ -478,7 +478,7 @@
|
||||
* **lang:** add Hindi Language translation ([#7327](https://github.com/videojs/video.js/issues/7327)) ([e90ae32](https://github.com/videojs/video.js/commit/e90ae32))
|
||||
* **lang:** add Romanian language and update translations doc. ([#7300](https://github.com/videojs/video.js/issues/7300)) ([5c2a45b](https://github.com/videojs/video.js/commit/5c2a45b))
|
||||
* **package:** update to [@videojs](https://github.com/videojs)/xhr[@2](https://github.com/2).6 to add httpHandler helper ([#7348](https://github.com/videojs/video.js/issues/7348)) ([c699140](https://github.com/videojs/video.js/commit/c699140))
|
||||
* **time-ranges:** make TimeRanges iteratable if Symbol.iterator exists ([#7330](https://github.com/videojs/video.js/issues/7330)) ([ad9546c](https://github.com/videojs/video.js/commit/ad9546c))
|
||||
* **time-ranges:** make TimeRanges iterable if Symbol.iterator exists ([#7330](https://github.com/videojs/video.js/issues/7330)) ([ad9546c](https://github.com/videojs/video.js/commit/ad9546c))
|
||||
|
||||
### Bug Fixes
|
||||
|
||||
@ -1428,7 +1428,7 @@
|
||||
|
||||
* add correct cursor pointer for the play toggle ([#5463](https://github.com/videojs/video.js/issues/5463)) ([aed337a](https://github.com/videojs/video.js/commit/aed337a))
|
||||
* default subtitles not enabled ([#5608](https://github.com/videojs/video.js/issues/5608)) ([8329e64](https://github.com/videojs/video.js/commit/8329e64))
|
||||
* **tracks:** don't select tracks based on user pref if no langauge is set ([#5556](https://github.com/videojs/video.js/issues/5556)) ([c1cbce3](https://github.com/videojs/video.js/commit/c1cbce3)), closes [#5553](https://github.com/videojs/video.js/issues/5553)
|
||||
* **tracks:** don't select tracks based on user pref if no language is set ([#5556](https://github.com/videojs/video.js/issues/5556)) ([c1cbce3](https://github.com/videojs/video.js/commit/c1cbce3)), closes [#5553](https://github.com/videojs/video.js/issues/5553)
|
||||
* Don't remove vjs-waiting until time changes ([#5533](https://github.com/videojs/video.js/issues/5533)) ([0060747](https://github.com/videojs/video.js/commit/0060747))
|
||||
* **lang:** add is loading ru translation ([#5630](https://github.com/videojs/video.js/issues/5630)) ([0090b75](https://github.com/videojs/video.js/commit/0090b75))
|
||||
* **lang:** Occitan: harmonisation plural/singular ([#5602](https://github.com/videojs/video.js/issues/5602)) ([4842201](https://github.com/videojs/video.js/commit/4842201))
|
||||
@ -2012,7 +2012,7 @@
|
||||
### Bug Fixes
|
||||
|
||||
* **package:** update videojs-font to version 2.1.0 ([#4812](https://github.com/videojs/video.js/issues/4812)) ([1117587](https://github.com/videojs/video.js/commit/1117587))
|
||||
* modify debug log tests to accomodate old IE stringification ([#4824](https://github.com/videojs/video.js/issues/4824)) ([5f89570](https://github.com/videojs/video.js/commit/5f89570))
|
||||
* modify debug log tests to accommodate old IE stringification ([#4824](https://github.com/videojs/video.js/issues/4824)) ([5f89570](https://github.com/videojs/video.js/commit/5f89570))
|
||||
|
||||
### Chores
|
||||
|
||||
@ -2117,7 +2117,7 @@
|
||||
* Don't enable player controls if they where disabled when ModalDialog closes. ([#4690](https://github.com/videojs/video.js/issues/4690)) ([afea980](https://github.com/videojs/video.js/commit/afea980))
|
||||
* don't throttle duration change updates ([#4635](https://github.com/videojs/video.js/issues/4635)) ([9cf9800](https://github.com/videojs/video.js/commit/9cf9800))
|
||||
* Events#off threw if Object.prototype had extra enumerable properties, don't remove all events if off receives a falsey value ([#4669](https://github.com/videojs/video.js/issues/4669)) ([7963913](https://github.com/videojs/video.js/commit/7963913))
|
||||
* make parseUrl helper always have a protocl ([#4673](https://github.com/videojs/video.js/issues/4673)) ([bebca9c](https://github.com/videojs/video.js/commit/bebca9c)), closes [#3100](https://github.com/videojs/video.js/issues/3100)
|
||||
* make parseUrl helper always have a protocol ([#4673](https://github.com/videojs/video.js/issues/4673)) ([bebca9c](https://github.com/videojs/video.js/commit/bebca9c)), closes [#3100](https://github.com/videojs/video.js/issues/3100)
|
||||
* Make sure we remove vjs-ended from the play toggle in all appropriate cases. ([#4661](https://github.com/videojs/video.js/issues/4661)) ([0287f6e](https://github.com/videojs/video.js/commit/0287f6e))
|
||||
* player.src() should return empty string if no source is set ([#4711](https://github.com/videojs/video.js/issues/4711)) ([9acbcd8](https://github.com/videojs/video.js/commit/9acbcd8))
|
||||
|
||||
@ -2834,7 +2834,7 @@
|
||||
### Code Refactoring
|
||||
|
||||
* **texttracksettings:** DRYer code and remove massive HTML blob ([#3679](https://github.com/videojs/video.js/issues/3679)) ([fb74c71](https://github.com/videojs/video.js/commit/fb74c71))
|
||||
* remove un-needed contructor and function overrides ([#3721](https://github.com/videojs/video.js/issues/3721)) ([6889e92](https://github.com/videojs/video.js/commit/6889e92))
|
||||
* remove un-needed constructor and function overrides ([#3721](https://github.com/videojs/video.js/issues/3721)) ([6889e92](https://github.com/videojs/video.js/commit/6889e92))
|
||||
|
||||
### Documentation
|
||||
|
||||
@ -2934,7 +2934,7 @@
|
||||
* @misteroneill, @BrandonOCasey, and @pagarwal123 updates all the code to pass the linter ([view](https://github.com/videojs/video.js/pull/3459))
|
||||
* @misteroneill added ghooks to run linter on git push ([view](https://github.com/videojs/video.js/pull/3459))
|
||||
* @BrandonOCasey removed unused base-styles.js file ([view](https://github.com/videojs/video.js/pull/3486))
|
||||
* @erikyuzwa, @gkatsev updated CSS build to inlcude the IE8-specific CSS from a separate file instead of it being inside of sass ([view](https://github.com/videojs/video.js/pull/3380)) ([view2](https://github.com/erikyuzwa/video.js/pull/1))
|
||||
* @erikyuzwa, @gkatsev updated CSS build to include the IE8-specific CSS from a separate file instead of it being inside of sass ([view](https://github.com/videojs/video.js/pull/3380)) ([view2](https://github.com/erikyuzwa/video.js/pull/1))
|
||||
* @gkatsev added null checks around navigator.userAgent ([view](https://github.com/videojs/video.js/pull/3502))
|
||||
* greenkeeper updated karma dependencies ([view](https://github.com/videojs/video.js/pull/3523))
|
||||
* @BrandonOCasey updated language docs to link to IANA language registry ([view](https://github.com/videojs/video.js/pull/3493))
|
||||
@ -3237,7 +3237,7 @@ _(none)_
|
||||
* @gkatsev made initListeners more general and added Tech.isTech. Fixes #2767 ([view](https://github.com/videojs/video.js/pull/2773))
|
||||
* @dmlap updated swf to 5.0.1 ([view](https://github.com/videojs/video.js/pull/2795))
|
||||
* @gkatsev added a tech registry. Fixes #2772 ([view](https://github.com/videojs/video.js/pull/2782))
|
||||
* @Lillemanden impoved logic for dividing RTMP paths ([view](https://github.com/videojs/video.js/pull/2787))
|
||||
* @Lillemanden improved logic for dividing RTMP paths ([view](https://github.com/videojs/video.js/pull/2787))
|
||||
* @bdeitte added a test for improved RTMP path dividing logic ([view](https://github.com/videojs/video.js/pull/2794))
|
||||
* @paladox updated grunt-cli dependency ([view](https://github.com/videojs/video.js/pull/2555))
|
||||
* @paladox updated grunt-contrib-jshint ([view](https://github.com/videojs/video.js/pull/2554))
|
||||
@ -3436,7 +3436,7 @@ _(none)_
|
||||
* @dmlap update to videojs-swf v4.7.3 ([view](https://github.com/videojs/video.js/pull/2457))
|
||||
|
||||
## 4.12.12 (2015-07-23)
|
||||
* @imbcmdth updated source handlers to use bracket notation so they wont break when using minified videojs ([view](https://github.com/videojs/video.js/pull/2348))
|
||||
* @imbcmdth updated source handlers to use bracket notation so they won't break when using minified videojs ([view](https://github.com/videojs/video.js/pull/2348))
|
||||
* @imbcmdth fix potential triggerReady infinite loop ([view](https://github.com/videojs/video.js/pull/2398))
|
||||
|
||||
## 4.12.11 (2015-07-09)
|
||||
@ -3551,14 +3551,14 @@ _(none)_
|
||||
@heff removed his own stupid error [view](https://github.com/videojs/video.js/commit/a12dd770572a7f16e436e2332eba7ffbb1f1b9b9)
|
||||
|
||||
## 4.10.0 (2014-10-28)
|
||||
* @aptx4869 fixed an issue where the native JSON parser wasn't used ([view](https://github.com/videojs/video.js/pull/1565))
|
||||
* @aptx4869 fixed an issue where the native JSON parser wasn't used ([view](https://github.com/videojs/video.js/pull/1565))
|
||||
* @andekande improved the German translation ([view](https://github.com/videojs/video.js/pull/1555))
|
||||
* @OlehTsvirko added a Ukrainian translation ([view](https://github.com/videojs/video.js/pull/1562))
|
||||
* @OlehTsvirko added a Russian translation ([view](https://github.com/videojs/video.js/pull/1563))
|
||||
* @thijstriemstra added a Dutch translation ([view](https://github.com/videojs/video.js/pull/1566))
|
||||
* @heff updated the poster to use CSS styles to display; fixed the poster not showing if not originally set ([view](https://github.com/videojs/video.js/pull/1568))
|
||||
* @mmcc fixed an issue where errors on source tags could get missed ([view](https://github.com/videojs/video.js/pull/1575))
|
||||
* @heff enhanced the event listener API to allow for auto-cleanup of listeners on other componenets and elements ([view](https://github.com/videojs/video.js/pull/1588))
|
||||
* @heff enhanced the event listener API to allow for auto-cleanup of listeners on other components and elements ([view](https://github.com/videojs/video.js/pull/1588))
|
||||
* @mmcc fixed an issue with the VolumeButton assuming it was vertical by default ([view](https://github.com/videojs/video.js/pull/1592))
|
||||
* @DevGavin added a Simplified Chinese translation ([view](https://github.com/videojs/video.js/pull/1593))
|
||||
* @heff Added the ability to set options for child components directly in the parent options ([view](https://github.com/videojs/video.js/pull/1599))
|
||||
@ -3581,7 +3581,7 @@ _(none)_
|
||||
* @philipgiuliani added an Italian translation ([view](https://github.com/videojs/video.js/pull/1550))
|
||||
* @twentyrogersc fixed the return value when setting the poster source ([view](https://github.com/videojs/video.js/pull/1552))
|
||||
* @heff updated to swf v4.5.0 to fix event issues ([view](https://github.com/videojs/video.js/pull/1554))
|
||||
* @rpless made the VolumeMenuButton volume more accesible via tab navigation ([view](https://github.com/videojs/video.js/pull/1519))
|
||||
* @rpless made the VolumeMenuButton volume more accessible via tab navigation ([view](https://github.com/videojs/video.js/pull/1519))
|
||||
* @mmcc added support for audio tags (html5 audio only) ([view](https://github.com/videojs/video.js/pull/1540))
|
||||
|
||||
## 4.8.5 (2014-09-25)
|
||||
@ -3640,7 +3640,7 @@ _(none)_
|
||||
* Fixed Component trigger function arguments and docs ([view](https://github.com/videojs/video.js/pull/1310))
|
||||
* Now copying all attributes from the original video tag to the generated video element ([view](https://github.com/videojs/video.js/pull/1321))
|
||||
* Added files to be ignored in the bower.json ([view](https://github.com/videojs/video.js/pull/1337))
|
||||
* Fixed an error that could happen if Flash was diposed before the ready callback was fired ([view](https://github.com/videojs/video.js/pull/1340))
|
||||
* Fixed an error that could happen if Flash was disposed before the ready callback was fired ([view](https://github.com/videojs/video.js/pull/1340))
|
||||
* The up and down arrows can now be used to control sliders in addition to left and right ([view](https://github.com/videojs/video.js/pull/1345))
|
||||
* Added a player.currentType() function to get the MIME type of the current source ([view](https://github.com/videojs/video.js/pull/1320))
|
||||
* Fixed a potential conflict with other event listener shims ([view](https://github.com/videojs/video.js/pull/1363))
|
||||
@ -3661,7 +3661,7 @@ _(none)_
|
||||
* Fixed an issue with the firstplay event not firing when autoplaying ([view](https://github.com/videojs/video.js/pull/1271))
|
||||
|
||||
## 4.6.1 (2014-05-20)
|
||||
* Udpated playbackRate menu to work in minified version ([view](https://github.com/videojs/video.js/pull/1223))
|
||||
* Updated playbackRate menu to work in minified version ([view](https://github.com/videojs/video.js/pull/1223))
|
||||
|
||||
## 4.6.0 (2014-05-20)
|
||||
* Updated the UI to support live video ([view](https://github.com/videojs/video.js/pull/1121))
|
||||
@ -3679,7 +3679,7 @@ _(none)_
|
||||
* Fixed the default flag for captions/subtitles tracks [[view](https://github.com/videojs/video.js/pull/1153)]
|
||||
* Fixed compilation failures with LESS v1.7.0 and GRUNT v0.4.4 [[view](https://github.com/videojs/video.js/pull/1180)]
|
||||
* Added better error handling across the library [[view](https://github.com/videojs/video.js/pull/1197)]
|
||||
* Updated captions/subtiles file fetching to support cross-origin requests in older IE browsers [[view](https://github.com/videojs/video.js/pull/1095)]
|
||||
* Updated captions/subtitles file fetching to support cross-origin requests in older IE browsers [[view](https://github.com/videojs/video.js/pull/1095)]
|
||||
* Added support for playback rate switching [[view](https://github.com/videojs/video.js/pull/1132)]
|
||||
* Fixed an issue with the loadstart event order that caused the big play button to not hide [[view](https://github.com/videojs/video.js/pull/1209)]
|
||||
* Modernized the fullscreen API and added support for IE11 [[view](https://github.com/videojs/video.js/pull/1205)]
|
||||
@ -3726,7 +3726,7 @@ _(none)_
|
||||
* Fixed a test for touch detection ([view](https://github.com/videojs/video.js/pull/962))
|
||||
* Updated the src file list for karma tests ([view](https://github.com/videojs/video.js/pull/948))
|
||||
* Added more tests for API properties after minification ([view](https://github.com/videojs/video.js/pull/906))
|
||||
* Updated projet to use npm version of videojs-swf ([view](https://github.com/videojs/video.js/pull/930))
|
||||
* Updated project to use npm version of videojs-swf ([view](https://github.com/videojs/video.js/pull/930))
|
||||
* Added support for dist zipping on windows ([view](https://github.com/videojs/video.js/pull/944))
|
||||
* Fixed iOS fullscreen issue ([view](https://github.com/videojs/video.js/pull/977))
|
||||
* Fixed touch event bubbling ([view](https://github.com/videojs/video.js/pull/992))
|
||||
|
@ -70,7 +70,7 @@ Bug fixes require a test case that fails beforehand and succeeds after. All code
|
||||
|
||||
### Involving the TSC
|
||||
|
||||
A change or issue can be elevated to the TSC by assing the `tsc-agent` label. This should be done in the following scenarios:
|
||||
A change or issue can be elevated to the TSC by assigning the `tsc-agent` label. This should be done in the following scenarios:
|
||||
|
||||
* There will be a major impact on the codebase or project
|
||||
* The change is inherently controversial
|
||||
@ -235,7 +235,7 @@ fixup 433c582 Update TOC
|
||||
edit 259dee6 Add grunt and doctoc npm scripts
|
||||
```
|
||||
|
||||
When you get to the edit commits, git will give more information, but you'd want to run ammend the current commit while following our commit guidelines
|
||||
When you get to the edit commits, git will give more information, but you'd want to run amend the current commit while following our commit guidelines
|
||||
|
||||
```sh
|
||||
git commit --amend
|
||||
|
@ -69,7 +69,7 @@ A good bug report should be as detailed as possible, so that others won't have t
|
||||
|
||||
1. [Check the plugin list](https://videojs.com/plugins/) for any plugins that may already support the feature.
|
||||
1. [Search the issues](https://github.com/videojs/video.js/issues) for any previous requests for the same feature, and give a thumbs up or +1 on existing requests.
|
||||
1. If no previous requests exist, create a new issue. Please be as clear as possible about why the feautre is needed and the intended use case.
|
||||
1. If no previous requests exist, create a new issue. Please be as clear as possible about why the feature is needed and the intended use case.
|
||||
1. Once again, be as details as possible and follow the [issue template][]
|
||||
|
||||
**[Request a feature](https://github.com/videojs/video.js/issues/new)**
|
||||
@ -87,11 +87,11 @@ There are a few labels that might be added to your issue or PR by a maintainer.
|
||||
| first-timers-only | Issue | Marked as a good bug or enhancement to be done by a newcomer to open source |
|
||||
| minor, patch, major | PR | Marks PR with the expected [semver](https://semver.org/) classification of the change |
|
||||
| needs: more info | Issue | Marked by a maintainer as needing more information from the issue reporter. Please update your issue with more information to help us reproduce the bug. |
|
||||
| needs: reduced test case | Issue | Marked by a maintainer as needing a reduced test case from the issue reporter. Please create a test page that we can inspect to help us indentify a bug. |
|
||||
| needs: reduced test case | Issue | Marked by a maintainer as needing a reduced test case from the issue reporter. Please create a test page that we can inspect to help us identify a bug. |
|
||||
|
||||
## Contributing code
|
||||
|
||||
To contibute code you'll need to be able to build a copy of Video.js and run tests locally. There are a few requirements before getting started.
|
||||
To contribute code you'll need to be able to build a copy of Video.js and run tests locally. There are a few requirements before getting started.
|
||||
|
||||
* Node.js
|
||||
Video.js uses Node for build and test automation. Node is available for Windows, Mac OS X, Linux, and SunOS, as well as source code if that doesn't scare you. [Download and install Node.js](http://nodejs.org/download/)
|
||||
|
@ -33,7 +33,7 @@ const watch = {
|
||||
};
|
||||
|
||||
const onwarn = (warning) => {
|
||||
// ignore unknow option for --no-progress
|
||||
// ignore unknown option for --no-progress
|
||||
if (warning.code === 'UNKNOWN_OPTION' && warning.message.indexOf('progress') !== -1) {
|
||||
return;
|
||||
}
|
||||
|
@ -46,7 +46,7 @@ class Component {
|
||||
* The key/value store of component options.
|
||||
*
|
||||
* @param {Object[]} [options.children]
|
||||
* An array of children objects to intialize this component with. Children objects have
|
||||
* An array of children objects to initialize this component with. Children objects have
|
||||
* a name property that will be used if more than one component of the same type needs to be
|
||||
* added.
|
||||
*
|
||||
@ -420,7 +420,7 @@ class Component {
|
||||
}
|
||||
|
||||
/**
|
||||
* Handles language change for the player in components. Should be overriden by sub-components.
|
||||
* Handles language change for the player in components. Should be overridden by sub-components.
|
||||
*
|
||||
* @abstract
|
||||
*/
|
||||
@ -754,7 +754,7 @@ class Component {
|
||||
})
|
||||
.filter((child) => {
|
||||
// we have to make sure that child.name isn't in the techOrder since
|
||||
// techs are registerd as Components but can't aren't compatible
|
||||
// techs are registered as Components but can't aren't compatible
|
||||
// See https://github.com/videojs/video.js/issues/2772
|
||||
const c = Component.getComponent(child.opts.componentClass ||
|
||||
toTitleCase(child.name));
|
||||
@ -766,7 +766,7 @@ class Component {
|
||||
}
|
||||
|
||||
/**
|
||||
* Builds the default DOM class name. Should be overriden by sub-components.
|
||||
* Builds the default DOM class name. Should be overridden by sub-components.
|
||||
*
|
||||
* @return {string}
|
||||
* The DOM class name for this object.
|
||||
@ -980,7 +980,7 @@ class Component {
|
||||
* - The value of the attribute that was asked for.
|
||||
* - Can be an empty string on some browsers if the attribute does not exist
|
||||
* or has no value
|
||||
* - Most browsers will return null if the attibute does not exist or has
|
||||
* - Most browsers will return null if the attribute does not exist or has
|
||||
* no value.
|
||||
*
|
||||
* @see [DOM API]{@link https://developer.mozilla.org/en-US/docs/Web/API/Element/getAttribute}
|
||||
@ -1545,7 +1545,7 @@ class Component {
|
||||
|
||||
/**
|
||||
* Clears an interval that gets created via `window.setInterval` or
|
||||
* {@link Component#setInterval}. If you set an inteval via {@link Component#setInterval}
|
||||
* {@link Component#setInterval}. If you set an interval via {@link Component#setInterval}
|
||||
* use this function instead of `window.clearInterval`. If you don't your dispose
|
||||
* listener will not get cleaned up until {@link Component#dispose}!
|
||||
*
|
||||
|
@ -41,7 +41,7 @@ class RemainingTimeDisplay extends TimeDisplay {
|
||||
}
|
||||
|
||||
/**
|
||||
* Create the `Component`'s DOM element with the "minus" characted prepend to the time
|
||||
* Create the `Component`'s DOM element with the "minus" character prepend to the time
|
||||
*
|
||||
* @return {Element}
|
||||
* The element that was created.
|
||||
|
@ -38,7 +38,7 @@ class LiveTracker extends Component {
|
||||
* Number of seconds behind live that we have to be
|
||||
* before we will be considered non-live. Note that this will only
|
||||
* be used when playing at the live edge. This allows large seekable end
|
||||
* changes to not effect wether we are live or not.
|
||||
* changes to not effect whether we are live or not.
|
||||
*/
|
||||
constructor(player, options) {
|
||||
// LiveTracker does not need an element
|
||||
@ -293,7 +293,7 @@ class LiveTracker extends Component {
|
||||
* is tracking live playback or not
|
||||
*
|
||||
* @return {boolean}
|
||||
* Wether liveTracker is tracking
|
||||
* Whether liveTracker is tracking
|
||||
*/
|
||||
isLive() {
|
||||
return this.isTracking();
|
||||
@ -304,7 +304,7 @@ class LiveTracker extends Component {
|
||||
* on each seekableendchange
|
||||
*
|
||||
* @return {boolean}
|
||||
* Wether playback is at the live edge
|
||||
* Whether playback is at the live edge
|
||||
*/
|
||||
atLiveEdge() {
|
||||
return !this.behindLiveEdge();
|
||||
@ -321,7 +321,7 @@ class LiveTracker extends Component {
|
||||
}
|
||||
|
||||
/**
|
||||
* The number of seconds that have occured after seekable end
|
||||
* The number of seconds that have occurred after seekable end
|
||||
* changed. This will be reset to 0 once seekable end changes.
|
||||
*
|
||||
* @return {number}
|
||||
@ -349,7 +349,7 @@ class LiveTracker extends Component {
|
||||
}
|
||||
|
||||
/**
|
||||
* Wether live tracker is currently tracking or not.
|
||||
* Whether live tracker is currently tracking or not.
|
||||
*/
|
||||
isTracking() {
|
||||
return typeof this.trackingInterval_ === 'number';
|
||||
|
@ -361,7 +361,7 @@ class MenuButton extends Component {
|
||||
} else {
|
||||
// NOTE: This is a special case where we don't pass unhandled
|
||||
// keydown events up to the Component handler, because it is
|
||||
// just entending the keydown handling of the `MenuItem`
|
||||
// just intending the keydown handling of the `MenuItem`
|
||||
// in the `Menu` which already passes unused keys up.
|
||||
}
|
||||
}
|
||||
|
@ -315,7 +315,7 @@ const EventedMixin = {
|
||||
} else {
|
||||
// TODO: This wrapper is incorrect! It should only
|
||||
// remove the wrapper for the event type that called it.
|
||||
// Instead all listners are removed on the first trigger!
|
||||
// Instead all listeners are removed on the first trigger!
|
||||
// see https://github.com/videojs/video.js/issues/5962
|
||||
const wrapper = (...largs) => {
|
||||
this.off(target, type, wrapper);
|
||||
|
@ -759,7 +759,7 @@ class Player extends Component {
|
||||
this.addClass('vjs-paused');
|
||||
|
||||
// Add a style element in the player that we'll use to set the width/height
|
||||
// of the player in a way that's still overrideable by CSS, just like the
|
||||
// of the player in a way that's still overridable by CSS, just like the
|
||||
// video element
|
||||
if (window.VIDEOJS_NO_DYNAMIC_STYLE !== true) {
|
||||
this.styleEl_ = stylesheet.createStyleElement('vjs-styles-dimensions');
|
||||
@ -873,7 +873,7 @@ class Player extends Component {
|
||||
* To get the current height use `currentheight()`.
|
||||
*
|
||||
* @param {number} [value]
|
||||
* The value to set the `Player`'s heigth to.
|
||||
* The value to set the `Player`'s height to.
|
||||
*
|
||||
* @return {number}
|
||||
* The current height of the `Player` when getting.
|
||||
@ -1074,7 +1074,7 @@ class Player extends Component {
|
||||
// Use any width that's been specifically set
|
||||
width = this.width_;
|
||||
} else if (this.height_ !== undefined) {
|
||||
// Or calulate the width from the aspect ratio if a height has been set
|
||||
// Or calculate the width from the aspect ratio if a height has been set
|
||||
width = this.height_ / ratioMultiplier;
|
||||
} else {
|
||||
// Or use the video's metadata, or use the video el's default of 300
|
||||
@ -2364,7 +2364,7 @@ class Player extends Component {
|
||||
/**
|
||||
* These functions will be run when if play is terminated. If play
|
||||
* runPlayCallbacks_ is run these function will not be run. This allows us
|
||||
* to differenciate between a terminated play and an actual call to play.
|
||||
* to differentiate between a terminated play and an actual call to play.
|
||||
*/
|
||||
runPlayTerminatedQueue_() {
|
||||
const queue = this.playTerminatedQueue_.slice(0);
|
||||
@ -2484,7 +2484,7 @@ class Player extends Component {
|
||||
// cache last currentTime and return. default to 0 seconds
|
||||
//
|
||||
// Caching the currentTime is meant to prevent a massive amount of reads on the tech's
|
||||
// currentTime when scrubbing, but may not provide much performance benefit afterall.
|
||||
// currentTime when scrubbing, but may not provide much performance benefit after all.
|
||||
// Should be tested. Also something has to read the actual current time or the cache will
|
||||
// never get updated.
|
||||
this.cache_.currentTime = (this.techGet_('currentTime') || 0);
|
||||
@ -2563,7 +2563,7 @@ class Player extends Component {
|
||||
}
|
||||
|
||||
/**
|
||||
* A remaining time function that is intented to be used when
|
||||
* A remaining time function that is intended to be used when
|
||||
* the time is to be displayed directly to the user.
|
||||
*
|
||||
* @return {number}
|
||||
@ -4547,7 +4547,7 @@ class Player extends Component {
|
||||
}
|
||||
|
||||
/**
|
||||
* returns a JavaScript object reperesenting the current track
|
||||
* returns a JavaScript object representing the current track
|
||||
* information. **DOES not return it as JSON**
|
||||
*
|
||||
* @return {Object}
|
||||
|
@ -162,7 +162,7 @@ class Slider extends Component {
|
||||
}
|
||||
// Do not call preventDefault() on touchstart in Chrome
|
||||
// to avoid console warnings. Use a 'touch-action: none' style
|
||||
// instead to prevent unintented scrolling.
|
||||
// instead to prevent unintended scrolling.
|
||||
// https://developers.google.com/web/updates/2017/01/scrolling-intervention
|
||||
if (event.type === 'touchstart' && !IS_CHROME) {
|
||||
event.preventDefault();
|
||||
@ -303,7 +303,7 @@ class Slider extends Component {
|
||||
}
|
||||
|
||||
/**
|
||||
* Handle a `keydown` event on the `Slider`. Watches for left, rigth, up, and down
|
||||
* Handle a `keydown` event on the `Slider`. Watches for left, right, up, and down
|
||||
* arrow keys. This function will only be called when the slider has focus. See
|
||||
* {@link Slider#handleFocus} and {@link Slider#handleBlur}.
|
||||
*
|
||||
|
@ -640,7 +640,7 @@ class Html5 extends Tech {
|
||||
|
||||
const endFn = function() {
|
||||
this.trigger('fullscreenchange', { isFullscreen: false });
|
||||
// Safari will sometimes set contols on the videoelement when existing fullscreen.
|
||||
// Safari will sometimes set controls on the videoelement when existing fullscreen.
|
||||
if (this.el_.controls && !this.options_.nativeControlsForTouch && this.controls()) {
|
||||
this.el_.controls = false;
|
||||
}
|
||||
|
@ -1382,7 +1382,7 @@ Tech.withSourceHandlers = function(_Tech) {
|
||||
let sh = _Tech.selectSourceHandler(source, this.options_);
|
||||
|
||||
if (!sh) {
|
||||
// Fall back to a native source hander when unsupported sources are
|
||||
// Fall back to a native source handler when unsupported sources are
|
||||
// deliberately set
|
||||
if (_Tech.nativeSourceHandler) {
|
||||
sh = _Tech.nativeSourceHandler;
|
||||
|
@ -67,7 +67,7 @@ export let IS_CHROMIUM = false;
|
||||
* This will also be `true` for Chrome on iOS, which will have different support
|
||||
* as it is actually Safari under the hood.
|
||||
*
|
||||
* Depreacted, as the behaviour to not match Edge was to prevent Legacy Edge's UA matching.
|
||||
* Deprecated, as the behaviour to not match Edge was to prevent Legacy Edge's UA matching.
|
||||
* IS_CHROMIUM should be used instead.
|
||||
* "Chromium but not Edge" could be explicitly tested with IS_CHROMIUM && !IS_EDGE
|
||||
*
|
||||
@ -88,7 +88,7 @@ export let CHROMIUM_VERSION = null;
|
||||
/**
|
||||
* The detected Google Chrome version - or `null`.
|
||||
* This has always been the _Chromium_ version, i.e. would return on Chromium Edge.
|
||||
* Depreacted, use CHROMIUM_VERSION instead.
|
||||
* Deprecated, use CHROMIUM_VERSION instead.
|
||||
*
|
||||
* @static
|
||||
* @deprecated
|
||||
@ -167,7 +167,7 @@ if (UAD) {
|
||||
IS_WINDOWS = UAD.platform === 'Windows';
|
||||
}
|
||||
|
||||
// If the broser is not Chromium, either userAgentData is not present which could be an old Chromium browser,
|
||||
// If the browser is not Chromium, either userAgentData is not present which could be an old Chromium browser,
|
||||
// or it's a browser that has added userAgentData since that we don't have tests for yet. In either case,
|
||||
// the checks need to be made agiainst the regular userAgent string.
|
||||
if (!IS_CHROMIUM) {
|
||||
|
@ -10,7 +10,7 @@ const hooks_ = {};
|
||||
* Get a list of hooks for a specific lifecycle
|
||||
*
|
||||
* @param {string} type
|
||||
* the lifecyle to get hooks from
|
||||
* the lifecycle to get hooks from
|
||||
*
|
||||
* @param {Function|Function[]} [fn]
|
||||
* Optionally add a hook (or hooks) to the lifecycle that your are getting.
|
||||
|
@ -5,7 +5,7 @@
|
||||
import document from 'global/document';
|
||||
|
||||
/**
|
||||
* Create a DOM syle element given a className for it.
|
||||
* Create a DOM style element given a className for it.
|
||||
*
|
||||
* @param {string} className
|
||||
* The className to add to the created style element.
|
||||
|
@ -900,7 +900,7 @@ QUnit.test('should emit a tap event', function(assert) {
|
||||
]});
|
||||
comp.trigger('touchend');
|
||||
|
||||
// A touchmove with a lot of movement by modifying the exisiting touch object
|
||||
// A touchmove with a lot of movement by modifying the existing touch object
|
||||
// should not trigger a tap
|
||||
singleTouch = { pageX: 0, pageY: 0 };
|
||||
Events.trigger(comp.el(), {type: 'touchstart', touches: [singleTouch]});
|
||||
@ -909,7 +909,7 @@ QUnit.test('should emit a tap event', function(assert) {
|
||||
Events.trigger(comp.el(), {type: 'touchmove', touches: [singleTouch]});
|
||||
comp.trigger('touchend');
|
||||
|
||||
// A touchmove with not much movement by modifying the exisiting touch object
|
||||
// A touchmove with not much movement by modifying the existing touch object
|
||||
// should still allow a tap
|
||||
singleTouch = { pageX: 0, pageY: 0 };
|
||||
Events.trigger(comp.el(), {type: 'touchstart', touches: [singleTouch]});
|
||||
@ -918,7 +918,7 @@ QUnit.test('should emit a tap event', function(assert) {
|
||||
Events.trigger(comp.el(), {type: 'touchmove', touches: [singleTouch]});
|
||||
comp.trigger('touchend');
|
||||
|
||||
// Reset to orignial value
|
||||
// Reset to original value
|
||||
browser.stub_TOUCH_ENABLED(origTouch);
|
||||
comp.dispose();
|
||||
});
|
||||
|
@ -333,7 +333,7 @@ QUnit.test('one() can add a listener to one event type on a different target obj
|
||||
});
|
||||
|
||||
// TODO: This test is incorrect! this listener should be called twice,
|
||||
// but instead all listners are removed on the first trigger!
|
||||
// but instead all listeners are removed on the first trigger!
|
||||
// see https://github.com/videojs/video.js/issues/5962
|
||||
QUnit.test('one() can add a listener to an array of event types on a different target object', function(assert) {
|
||||
const a = this.targets.a = evented({});
|
||||
|
@ -124,7 +124,7 @@ const mainModule = function(playReturnValue, middlewareTermination, subhooks) {
|
||||
QUnit.test('Player#play() resolves correctly with dom sources and async tech ready', function(assert) {
|
||||
// turn of mediaLoader to prevent setting a tech right away
|
||||
// similar to settings sources in the DOM
|
||||
// turn off autoReady to prevent syncronous ready from the tech
|
||||
// turn off autoReady to prevent synchronous ready from the tech
|
||||
this.player = TestHelpers.makePlayer({mediaLoader: false, techFaker: {autoReady: false}});
|
||||
|
||||
this.playTest('before anything is ready');
|
||||
|
@ -2450,7 +2450,7 @@ QUnit.test('player.duration() returns NaN if player.cache_.duration is undefined
|
||||
const player = TestHelpers.makePlayer();
|
||||
|
||||
player.cache_.duration = undefined;
|
||||
assert.ok(Number.isNaN(player.duration()), 'returned NaN for unkown duration');
|
||||
assert.ok(Number.isNaN(player.duration()), 'returned NaN for unknown duration');
|
||||
});
|
||||
|
||||
QUnit.test('player.duration() returns player.cache_.duration if it is defined', function(assert) {
|
||||
@ -3086,4 +3086,3 @@ QUnit.test('turning on audioPosterMode when audioOnlyMode is already on will tur
|
||||
assert.notOk(player.audioOnlyMode(), 'audioOnlyMode is false');
|
||||
});
|
||||
});
|
||||
|
||||
|
@ -146,7 +146,7 @@ QUnit.test('test defaultPlaybackRate', function(assert) {
|
||||
assert.strictEqual(tech.defaultPlaybackRate(), 0.75, 'can be changed from the API');
|
||||
});
|
||||
|
||||
QUnit.test('blacklist playbackRate support on older verisons of Chrome on Android', function(assert) {
|
||||
QUnit.test('blacklist playbackRate support on older versions of Chrome on Android', function(assert) {
|
||||
if (!Html5.canControlPlaybackRate()) {
|
||||
assert.ok(true, 'playbackRate is not supported');
|
||||
return;
|
||||
|
@ -72,7 +72,7 @@ QUnit.test('middleware get iterates through the middleware array in the right or
|
||||
const foo = middleware.get(mws, tech, 'foo');
|
||||
|
||||
const assertion = (actual, expected, actualArr, expectedArr, type) => {
|
||||
assert.equal(actual, expected, `our middleware chain return currectly for ${type}`);
|
||||
assert.equal(actual, expected, `our middleware chain return correctly for ${type}`);
|
||||
assert.deepEqual(actualArr, expectedArr, `we got called in the correct order for ${type}`);
|
||||
};
|
||||
|
||||
@ -135,7 +135,7 @@ QUnit.test('middleware set iterates through the middleware array in the right or
|
||||
const foo = middleware.set(mws, tech, 'foo', 10);
|
||||
|
||||
const assertion = (actual, expected, actualArr, expectedArr, type) => {
|
||||
assert.equal(actual, expected, `our middleware chain return currectly for ${type}`);
|
||||
assert.equal(actual, expected, `our middleware chain return correctly for ${type}`);
|
||||
assert.deepEqual(actualArr, expectedArr, `we got called in the correct order for ${type}`);
|
||||
};
|
||||
|
||||
|
@ -488,7 +488,7 @@ QUnit.test('should add the source handler interface to a tech', function(assert)
|
||||
);
|
||||
assert.equal(tech.remoteTextTracks().length, 2, 'should have two remote text tracks');
|
||||
|
||||
// Check that the handler dipose method works
|
||||
// Check that the handler dispose method works
|
||||
assert.ok(disposeCalled, 'dispose has been called for the handler yet');
|
||||
disposeCalled = false;
|
||||
tech.dispose();
|
||||
|
@ -13,7 +13,7 @@ TrackBaseline(AudioTrack, {
|
||||
kind: 'main'
|
||||
});
|
||||
|
||||
QUnit.test('can create an enabled propert on an AudioTrack', function(assert) {
|
||||
QUnit.test('can create an enabled property on an AudioTrack', function(assert) {
|
||||
const enabled = true;
|
||||
const track = new AudioTrack({
|
||||
enabled
|
||||
|
@ -223,7 +223,7 @@ if (!Html5.supportsNativeTextTracks()) {
|
||||
player.dispose();
|
||||
});
|
||||
|
||||
QUnit.test("don't select user langauge if it is an empty string", function(assert) {
|
||||
QUnit.test("don't select user language if it is an empty string", function(assert) {
|
||||
const player = TestHelpers.makePlayer();
|
||||
const track1 = {
|
||||
kind: 'captions',
|
||||
@ -396,7 +396,7 @@ if (!Html5.supportsNativeTextTracks()) {
|
||||
const englishTrack = player.addRemoteTextTrack(track1, true).track;
|
||||
// Keep track of menu items
|
||||
const enCaptionMenuItem = getMenuItemByLanguage(captionsButton.items, 'en');
|
||||
// we know the postition of the OffTextTrackMenuItem
|
||||
// we know the position of the OffTextTrackMenuItem
|
||||
const offMenuItem = captionsButton.items[1];
|
||||
|
||||
// Select English initially
|
||||
|
@ -254,7 +254,7 @@ QUnit.test('can only remove one cue at a time', function(assert) {
|
||||
});
|
||||
|
||||
QUnit.test('does not include past cues in activeCues', function(assert) {
|
||||
// Testing for the absense of a previous behaviour, which considered cues with equal
|
||||
// Testing for the absence of a previous behaviour, which considered cues with equal
|
||||
// start and end times as active 0.5s after ending
|
||||
const player = TestHelpers.makePlayer();
|
||||
const tt = new TextTrack({
|
||||
|
@ -164,7 +164,7 @@ QUnit.test('update texttrack buttons on removetrack or addtrack', function(asser
|
||||
}
|
||||
events[type].push(handler);
|
||||
},
|
||||
// Requrired in player.dispose()
|
||||
// Required in player.dispose()
|
||||
removeEventListener() {}
|
||||
};
|
||||
};
|
||||
|
@ -85,7 +85,7 @@ QUnit.test(
|
||||
);
|
||||
|
||||
QUnit.test(
|
||||
'should log about already initalized players if options already passed',
|
||||
'should log about already initialized players if options already passed',
|
||||
function(assert) {
|
||||
const origWarnLog = log.warn;
|
||||
const fixture = document.getElementById('qunit-fixture');
|
||||
@ -469,7 +469,7 @@ QUnit.test('should add video-js class to video-js embed if missing', function(as
|
||||
});
|
||||
|
||||
QUnit.test(
|
||||
'should log about already initalized players if options already passed',
|
||||
'should log about already initialized players if options already passed',
|
||||
function(assert) {
|
||||
const origWarnLog = log.warn;
|
||||
const fixture = document.getElementById('qunit-fixture');
|
||||
|
@ -206,7 +206,7 @@ QUnit.test('beforesetup returns dont break videojs options', function(assert) {
|
||||
|
||||
const player = videojs(vid, vjsOptions);
|
||||
|
||||
assert.ok(player.options_, 'beforesetup should not destory options');
|
||||
assert.ok(player.options_, 'beforesetup should not destroy options');
|
||||
assert.equal(player.options_.techOrder, vjsOptions.techOrder, 'options set by user should exist');
|
||||
|
||||
log.error = oldLogError;
|
||||
@ -229,7 +229,7 @@ QUnit.test('beforesetup options override videojs options', function(assert) {
|
||||
|
||||
const player = videojs(vid, vjsOptions);
|
||||
|
||||
assert.ok(player.options_, 'beforesetup should not destory options');
|
||||
assert.ok(player.options_, 'beforesetup should not destroy options');
|
||||
assert.equal(player.options_.techOrder, vjsOptions.techOrder, 'options set by user should exist');
|
||||
assert.equal(player.options_.autoplay, true, 'autoplay should be set to true now');
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user