web/video.js
1
0
Fork 0
mirror of https://github.com/videojs/video.js.git synced 2024-12-25 02:42:10 +02:00
Code Releases Activity

fix: remove unnecessary handling of invalid cues (#7956)

Browse Source
This commit is contained in:
mister-ben 2023-02-01 18:08:30 +01:00 committed by GitHub
parent 33b476d7cc
commit db882cd49d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 37 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/js/tracks/text-track.js
View File

@ -326,10 +326,6 @@ class TextTrack extends Track {
if (cue.startTime <= ct && cue.endTime >= ct) {
active.push(cue);
} else if (cue.startTime === cue.endTime &&
cue.startTime <= ct &&
cue.startTime + 0.5 >= ct) {
active.push(cue);
}
}

37
test/unit/tracks/text-track.test.js
View File

@ -253,6 +253,43 @@ QUnit.test('can only remove one cue at a time', function(assert) {
assert.equal(tt.cues.length, 0, 'we have removed the other instance of cue1');
});
QUnit.test('does not include past cues in activeCues', function(assert) {
// Testing for the absense of a previous behaviour, which considered cues with equal
// start and end times as active 0.5s after ending
const player = TestHelpers.makePlayer();
const tt = new TextTrack({
tech: player.tech_,
mode: 'showing'
});
const expectedCue = {
id: '2',
startTime: 2.555,
endTime: 3
};
player.tech_.currentTime = function() {
return 2.556;
};
tt.addCue({
id: '1',
startTime: 1,
endTime: 2.555
});
tt.addCue({
id: '2',
startTime: 2.555,
endTime: 2.555
});
// start 2.55
tt.addCue(expectedCue);
player.tech_.trigger('playing');
assert.equal(tt.activeCues_.length, 1, 'only one cue is present');
assert.equal(tt.activeCues_[0].originalCue_, expectedCue, 'correct active cue is present');
});
QUnit.test('does not fire cuechange before Tech is ready', function(assert) {
const done = assert.async();
const clock = sinon.useFakeTimers();