1
0
mirror of https://github.com/videojs/video.js.git synced 2024-11-24 08:42:25 +02:00
Video.js - open source HTML5 video player
Go to file
mister-ben 0a836e1006
fix: ensure transient button event listeners are removed on dispose (#8796)
## Description
Transient button sets an event listener on the player directly instead
of on itself, which doesn't get cleaned up when disposed.
Fixes #8795

## Specific Changes proposed
Call `on` on the component with player as the first arg, instead of
calling `on` on the player directly.

## Requirements Checklist
- [x] Feature implemented / Bug fixed
- [ ] If necessary, more likely in a feature request than a bug fix
- [x] Change has been verified in an actual browser (Chrome, Firefox,
IE)
  - [ ] Unit Tests updated or fixed
  - [ ] Docs/guides updated
- [ ] Example created ([starter template on
JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
- [x] Has no DOM changes which impact accessiblilty or trigger warnings
(e.g. Chrome issues tab)
  - [x] Has no changes to JSDoc which cause `npm run docs:api` to error
- [ ] Reviewed by Two Core Contributors
2024-07-14 18:15:38 +02:00
.github chore: Update PR template (#8750) 2024-05-28 19:44:56 +02:00
build fix(docs): Add workaround for ErrorMetadata typedef (#8737) 2024-05-23 19:04:25 +02:00
docs Added missing Arabic translation, but forgot to remove that from this file (#8725) 2024-05-30 12:15:33 -07:00
lang fix(lang): Arabic translation grammar, spelling and vocabulary errors (#8724) 2024-05-30 12:15:54 -07:00
sandbox fix(middleware): cache grows even if no middleware created (#8674) 2024-07-06 07:44:37 +01:00
src fix: ensure transient button event listeners are removed on dispose (#8796) 2024-07-14 18:15:38 +02:00
test feat: Adds a transient button component (#8629) 2024-07-06 07:40:31 +01:00
.babelrc chore(package): Update VHS version (#8447) 2023-09-25 15:09:36 -04:00
.browserslistrc chore(package): Update VHS version (#8447) 2023-09-25 15:09:36 -04:00
.editorconfig Added .editorconfig and travis CI badge 2012-12-11 14:33:42 -08:00
.gitignore docs: Update jsdoc template for better usability on mobile (#8048) 2023-03-22 20:15:17 +01:00
.jsdoc.js fix(docs): Add workaround for ErrorMetadata typedef (#8737) 2024-05-23 19:04:25 +02:00
.npmignore feat: add core ES module. (#6287) 2019-11-15 13:44:11 -05:00
.nvmrc chore: update node/nvmrc and various dependencies (#7221) 2021-05-04 11:45:59 -04:00
.remarkignore chore(docs): Documentation Linting and TOC generation (#3841) 2016-12-20 16:55:59 -05:00
.remarkrc.js chore(docs): Documentation Linting and TOC generation (#3841) 2016-12-20 16:55:59 -05:00
CHANGELOG.md 8.17.0 2024-07-10 11:43:18 +02:00
CODE_OF_CONDUCT.md docs(coc): introduce CODE_OF_CONDUCT.md (#4160) 2017-03-23 16:39:17 -04:00
COLLABORATOR_GUIDE.md Fix several typos in docs and comments (#8110) 2023-03-22 15:00:01 +01:00
composer.json docs: Remove Flash (#6994) 2020-12-22 14:10:53 -05:00
CONTRIBUTING.md chore: Fixed an incomplete sentence in contributing guide (#8471) 2023-10-24 09:56:03 +02:00
index.html feat: Adds a transient button component (#8629) 2024-07-06 07:40:31 +01:00
LICENSE More build and testing cleanup. Also some reorganization. 2015-04-02 11:33:51 -07:00
package-lock.json 8.17.0 2024-07-10 11:43:18 +02:00
package.json 8.17.0 2024-07-10 11:43:18 +02:00
postcss.config.js chore(css): fix typo in postcss-config browserslist and update list (#8578) 2024-05-06 09:58:15 -07:00
README.md feat: Add useSVGIcons option (#8260) 2023-06-12 13:31:06 -05:00
rollup.config.js chore(package): Update VHS version (#8447) 2023-09-25 15:09:36 -04:00
tsconfig.json fix(types): improves quality of typescript definitions (#8218) 2023-09-27 10:00:49 +02:00

Video.js logo

Video.js - HTML5 Video Player

Build Status Coverage Status Greenkeeper badge Slack Status

NPM

Video.js is a web video player built from the ground up for an HTML5 world. It supports HTML5 video and Media Source Extensions, as well as other playback techs like YouTube and Vimeo (through plugins). It supports video playback on desktops and mobile devices. This project was started mid 2010, and the player is now used on over 50,000 100,000 200,000 400,000 700,000 websites.

Table of Contents

Quick Start

Thanks to the awesome folks over at Fastly, there's a free, CDN hosted version of Video.js that anyone can use. Add these tags to your document's <head>:

<link href="//vjs.zencdn.net/8.3.0/video-js.min.css" rel="stylesheet">
<script src="//vjs.zencdn.net/8.3.0/video.min.js"></script>

For the latest version of video.js and URLs to use, check out the Getting Started page on our website.

Video.js version 7 (and newer) CDN builds do not send any data to Google Analytics.

In older versions of Video.js (6 and earlier), in the vjs.zencdn.net CDN-hosted versions we include a stripped down Google Analytics pixel that tracks a random sampling (currently 1%) of players loaded from the CDN. This allows us to see (roughly) what browsers are in use in the wild, along with other useful metrics such as OS and device. If you'd like to disable analytics, you can simply include the following global before including Video.js via the free CDN:

<script>window.HELP_IMPROVE_VIDEOJS = false;</script>

Alternatively, you can include Video.js by getting it from npm, downloading from GitHub releases or by including it via unpkg or another JavaScript CDN like CDNjs. These releases do not include Google Analytics tracking at all.

<!-- unpkg : use the latest version of Video.js -->
<link href="https://unpkg.com/video.js/dist/video-js.min.css" rel="stylesheet">
<script src="https://unpkg.com/video.js/dist/video.min.js"></script>

<!-- unpkg : use a specific version of Video.js (change the version numbers as necessary) -->
<link href="https://unpkg.com/video.js@8.3.0/dist/video-js.min.css" rel="stylesheet">
<script src="https://unpkg.com/video.js@8.3.0/dist/video.min.js"></script>

<!-- cdnjs : use a specific version of Video.js (change the version numbers as necessary) -->
<link href="https://cdnjs.cloudflare.com/ajax/libs/video.js/8.3.0/video-js.min.css" rel="stylesheet">
<script src="https://cdnjs.cloudflare.com/ajax/libs/video.js/8.3.0/video.min.js"></script>

Next, using Video.js is as simple as creating a <video> element, but with an additional data-setup attribute. At a minimum, this attribute must have a value of '{}', but it can include any Video.js options - just make sure it contains valid JSON!

<video
    id="my-player"
    class="video-js"
    controls
    preload="auto"
    poster="//vjs.zencdn.net/v/oceans.png"
    data-setup='{}'>
  <source src="//vjs.zencdn.net/v/oceans.mp4" type="video/mp4"></source>
  <source src="//vjs.zencdn.net/v/oceans.webm" type="video/webm"></source>
  <source src="//vjs.zencdn.net/v/oceans.ogv" type="video/ogg"></source>
  <p class="vjs-no-js">
    To view this video please enable JavaScript, and consider upgrading to a
    web browser that
    <a href="https://videojs.com/html5-video-support/" target="_blank">
      supports HTML5 video
    </a>
  </p>
</video>

When the page loads, Video.js will find this element and automatically setup a player in its place.

If you don't want to use automatic setup, you can leave off the data-setup attribute and initialize a <video> element manually using the videojs function:

var player = videojs('my-player');

The videojs function also accepts an options object and a callback to be invoked when the player is ready:

var options = {};

var player = videojs('my-player', options, function onPlayerReady() {
  videojs.log('Your player is ready!');

  // In this context, `this` is the player that was created by Video.js.
  this.play();

  // How about an event listener?
  this.on('ended', function() {
    videojs.log('Awww...over so soon?!');
  });
});

If you're ready to dive in, the Getting Started page and documentation are the best places to go for more information. If you get stuck, head over to our Slack channel!

Contributing

Video.js is a free and open source library, and we appreciate any help you're willing to give - whether it's fixing bugs, improving documentation, or suggesting new features. Check out the contributing guide for more!

Video.js uses BrowserStack for compatibility testing.

Code of Conduct

Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms.

License

Video.js is licensed under the Apache License, Version 2.0.